René's URL Explorer Experiment


Title: Do not inherit @pure-unless-* tags into a method marked @phpstan-pure or @phpstan-impure by zonuexe · Pull Request #6669 · phpstan/phpstan-src · GitHub

Open Graph Title: Do not inherit @pure-unless-* tags into a method marked @phpstan-pure or @phpstan-impure by zonuexe · Pull Request #6669 · phpstan/phpstan-src

X Title: Do not inherit @pure-unless-* tags into a method marked @phpstan-pure or @phpstan-impure by zonuexe · Pull Request #6669 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Do not inherit @pure-unless-* tags into a method marked @phpstan-pure or @phpstan-impure by zonuexe · Pull Request #6669 · phpstan/phpstan-src

Open Graph Description: A method that declares its own @phpstan-pure or @phpstan-impure inherited the parent's @pure-unless-callable-is-impure / @pure-unless-parameter-passed tags through ResolvedPhpDocBlock::merge(),...

X Description: A method that declares its own @phpstan-pure or @phpstan-impure inherited the parent's @pure-unless-callable-is-impure / @pure-unless-parameter-passed tags through ResolvedPhpDocBlock::merg...

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/6669

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c78389ff-fec0-20f3-04c9-6b5c1c0b62e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2C2:1D8AA1:CB6621:10D589B:6B00F1F6
html-safe-noncebb4a0ed5469339fa795d420e7471cb54c9d24b483272e815dcb0af0116c34aa9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkMyOjFEOEFBMTpDQjY2MjE6MTBENTg5Qjo2QjAwRjFGNiIsInZpc2l0b3JfaWQiOiIzMzU4MTgwMjU1NjAzOTQ1OTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac16a531f8222152548a1c875bca6d55c5ff67c916a586fa56a77f2d7ac4121708
hovercard-subject-tagpull_request:4729052222
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/6669/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d17b45c693e6b4bc163bcd320acaf3cadbd7f9952a6d4caa235f5d833f2eaae3/phpstan/phpstan-src/pull/6669
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d17b45c693e6b4bc163bcd320acaf3cadbd7f9952a6d4caa235f5d833f2eaae3/phpstan/phpstan-src/pull/6669
og:image:altA method that declares its own @phpstan-pure or @phpstan-impure inherited the parent's @pure-unless-callable-is-impure / @pure-unless-parameter-passed tags through ResolvedPhpDocBlock::merge(),...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezonuexe
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/6669#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6669
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6669
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/6669
Reloadhttps://github.com/phpstan/phpstan-src/pull/6669
Reloadhttps://github.com/phpstan/phpstan-src/pull/6669
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests186 (186)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
zonuexehttps://github.com/zonuexe
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
zonuexe:feature/impure-override-skips-conditional-body-checkhttps://github.com/zonuexe/phpstan-src/tree/feature/impure-override-skips-conditional-body-check
Conversationhttps://github.com/phpstan/phpstan-src/pull/6669
Commits3 (3)https://github.com/phpstan/phpstan-src/pull/6669/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/6669/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/6669/files
Do not inherit @pure-unless-* tags into a method marked @phpstan-pure or @phpstan-impurehttps://github.com/phpstan/phpstan-src/pull/6669#top
zonuexehttps://github.com/zonuexe
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
zonuexe:feature/impure-override-skips-conditional-body-checkhttps://github.com/zonuexe/phpstan-src/tree/feature/impure-override-skips-conditional-body-check
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 3, 2026https://github.com/phpstan/phpstan-src/pull/6669#issue-5692743017
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6669
#6667https://github.com/phpstan/phpstan-src/pull/6667
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6669
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Oct 3, 2026 https://github.com/phpstan/phpstan-src/pull/6669#pullrequestreview-5402370952
View reviewed changes https://github.com/phpstan/phpstan-src/pull/6669/files
VincentLanglethttps://github.com/VincentLanglet
https://github.com/phpstan/phpstan-src/pull/6669#pullrequestreview-5402370952
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6669
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 4, 2026https://github.com/phpstan/phpstan-src/pull/6669#event-32430075710
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 4, 2026https://github.com/phpstan/phpstan-src/pull/6669#issuecomment-5977041869
@VincentLanglethttps://github.com/VincentLanglet
#6666https://github.com/phpstan/phpstan-src/pull/6666
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6669
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 4, 2026 https://github.com/phpstan/phpstan-src/pull/6669#ref-pullrequest-5696822998
Report a docblock that combines a purity tag with a @pure-unless-* tag #6670 https://github.com/phpstan/phpstan-src/pull/6670
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Oct 4, 2026 https://github.com/phpstan/phpstan-src/pull/6669#ref-pullrequest-5692262706
Let @pure-unless-* tags take precedence over the class-level purity tags #6667 https://github.com/phpstan/phpstan-src/pull/6667
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 5, 2026 https://github.com/phpstan/phpstan-src/pull/6669#ref-issue-5717727082
Purity tags on overriding methods: which combinations should PHPStan report? phpstan/phpstan#15381 https://github.com/phpstan/phpstan/issues/15381
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
force-pushedhttps://github.com/phpstan/phpstan-src/compare/2e55ded0ab2a0508c4903f7c1ba4685c8386ad62..66e638d562e91c77f5ac8ff0308e726abfddaeb8
2e55dedhttps://github.com/phpstan/phpstan-src/commit/2e55ded0ab2a0508c4903f7c1ba4685c8386ad62
66e638dhttps://github.com/phpstan/phpstan-src/commit/66e638d562e91c77f5ac8ff0308e726abfddaeb8
Compare https://github.com/phpstan/phpstan-src/compare/2e55ded0ab2a0508c4903f7c1ba4685c8386ad62..66e638d562e91c77f5ac8ff0308e726abfddaeb8
October 5, 2026 19:40https://github.com/phpstan/phpstan-src/pull/6669#event-32540020380
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
October 27, 2026 17:40https://github.com/phpstan/phpstan-src/pull/6669#event-34395104599
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
force-pushedhttps://github.com/phpstan/phpstan-src/compare/66e638d562e91c77f5ac8ff0308e726abfddaeb8..fcac56b723de1ad03bd881f6d0f7ce094fa3ac39
66e638dhttps://github.com/phpstan/phpstan-src/commit/66e638d562e91c77f5ac8ff0308e726abfddaeb8
fcac56bhttps://github.com/phpstan/phpstan-src/commit/fcac56b723de1ad03bd881f6d0f7ce094fa3ac39
Compare https://github.com/phpstan/phpstan-src/compare/66e638d562e91c77f5ac8ff0308e726abfddaeb8..fcac56b723de1ad03bd881f6d0f7ce094fa3ac39
October 27, 2026 17:54https://github.com/phpstan/phpstan-src/pull/6669#event-34396327489
zonuexehttps://github.com/zonuexe
October 28, 2026 03:35https://github.com/phpstan/phpstan-src/pull/6669#commits-pushed-0d728a6
https://github.com/zonuexe
Do not check the body of an impure method against an inherited @pure-…https://github.com/phpstan/phpstan-src/pull/6669/commits/0d728a6419305d2e8eb13311a38a7f48633b2bd9
0d728a6https://github.com/phpstan/phpstan-src/pull/6669/commits/0d728a6419305d2e8eb13311a38a7f48633b2bd9
https://github.com/zonuexe
Do not inherit @pure-unless-* tags into a method marked @phpstan-pure…https://github.com/phpstan/phpstan-src/pull/6669/commits/7c1a06a3114030a9f8c7682a96e19dfc1f5743f6
7c1a06ahttps://github.com/phpstan/phpstan-src/pull/6669/commits/7c1a06a3114030a9f8c7682a96e19dfc1f5743f6
https://github.com/zonuexe
Keep prose lines of the fixture from parsing as PHPDoc tagshttps://github.com/phpstan/phpstan-src/pull/6669/commits/493904666d128b02cbe893f22540aa1aae1b3f94
4939046https://github.com/phpstan/phpstan-src/pull/6669/commits/493904666d128b02cbe893f22540aa1aae1b3f94
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
force-pushedhttps://github.com/phpstan/phpstan-src/compare/fcac56b723de1ad03bd881f6d0f7ce094fa3ac39..493904666d128b02cbe893f22540aa1aae1b3f94
fcac56bhttps://github.com/phpstan/phpstan-src/commit/fcac56b723de1ad03bd881f6d0f7ce094fa3ac39
4939046https://github.com/phpstan/phpstan-src/commit/493904666d128b02cbe893f22540aa1aae1b3f94
Compare https://github.com/phpstan/phpstan-src/compare/fcac56b723de1ad03bd881f6d0f7ce094fa3ac39..493904666d128b02cbe893f22540aa1aae1b3f94
October 27, 2026 18:39https://github.com/phpstan/phpstan-src/pull/6669#event-34400300377
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6669
https://github.com/VincentLanglet
VincentLanglet https://github.com/VincentLanglet
https://github.com/phpstan/phpstan-src/pull/6669/files/8176381681e0030d245812db1eb5a59feb139851
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6669
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6669
https://github.com/zonuexe
https://github.com/VincentLanglet
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.