| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ccd36d12-1975-74ed-9278-8b2c605d1cd8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE66:3E4205:96CE95:CB63C3:6B00E9BB |
| html-safe-nonce | 259d3aec8c1b3c292cb62025cb5c114c64501dfab6380ffe534a59948205ead9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTY2OjNFNDIwNTo5NkNFOTU6Q0I2M0MzOjZCMDBFOUJCIiwidmlzaXRvcl9pZCI6IjYzMTQ2MDI4MjYwOTM4ODE3ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a0b768a103840fde9cc7695c4056b4afb74be3c175c858b85b40f7ecb96e7d62 |
| hovercard-subject-tag | pull_request:4728663782 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/6667/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fd07de1529d1e3484a5fca09069517cfa3e6fa5fbcb85df970b3722f8a5bbf69/phpstan/phpstan-src/pull/6667 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fd07de1529d1e3484a5fca09069517cfa3e6fa5fbcb85df970b3722f8a5bbf69/phpstan/phpstan-src/pull/6667 |
| og:image:alt | Follow-up to #6666 (comment). In a class marked @phpstan-all-methods-pure, the class-level tag overrode a method's own @pure-unless-parameter-passed or @pure-unless-callable-is-impure and made ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zonuexe |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 219334214 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 219334214 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/phpstan/phpstan-src/pull/6667#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6667 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6667 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src |
| Reload | https://github.com/phpstan/phpstan-src/pull/6667 |
| Reload | https://github.com/phpstan/phpstan-src/pull/6667 |
| Reload | https://github.com/phpstan/phpstan-src/pull/6667 |
| phpstan | https://github.com/phpstan |
| phpstan-src | https://github.com/phpstan/phpstan-src |
| Code | https://github.com/phpstan/phpstan-src |
| Pull requests186 (186) | https://github.com/phpstan/phpstan-src/pulls |
| Actions | https://github.com/phpstan/phpstan-src/actions |
| Security and quality | https://github.com/phpstan/phpstan-src/security |
| Insights | https://github.com/phpstan/phpstan-src/insights |
| https://github.com/phpstan/phpstan-src |
| zonuexe | https://github.com/zonuexe |
| phpstan:2.3.x | https://github.com/phpstan/phpstan-src/tree/2.3.x |
| zonuexe:feature/all-methods-pure-respects-pure-unless | https://github.com/zonuexe/phpstan-src/tree/feature/all-methods-pure-respects-pure-unless |
| Conversation | https://github.com/phpstan/phpstan-src/pull/6667 |
| Commits3 (3) | https://github.com/phpstan/phpstan-src/pull/6667/commits |
| Checks | https://github.com/phpstan/phpstan-src/pull/6667/checks |
| Files changed | https://github.com/phpstan/phpstan-src/pull/6667/files |
| Let @pure-unless-* tags take precedence over the class-level purity tags | https://github.com/phpstan/phpstan-src/pull/6667#top |
| zonuexe | https://github.com/zonuexe |
| phpstan:2.3.x | https://github.com/phpstan/phpstan-src/tree/2.3.x |
| zonuexe:feature/all-methods-pure-respects-pure-unless | https://github.com/zonuexe/phpstan-src/tree/feature/all-methods-pure-respects-pure-unless |
|
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Oct 3, 2026 | https://github.com/phpstan/phpstan-src/pull/6667#issue-5692262706 |
| #6666 (comment) | https://github.com/phpstan/phpstan-src/pull/6666#issuecomment-5971832273 |
| #6666 | https://github.com/phpstan/phpstan-src/pull/6666 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| VincentLanglet | https://github.com/VincentLanglet |
| October 3, 2026 18:28 | https://github.com/phpstan/phpstan-src/pull/6667#event-32409284592 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
|
Oct 3, 2026
| https://github.com/phpstan/phpstan-src/pull/6667#pullrequestreview-5402294251 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/6667/files |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| staabm | https://github.com/staabm |
| October 3, 2026 18:59 | https://github.com/phpstan/phpstan-src/pull/6667#event-32410406848 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
|
Oct 3, 2026
| https://github.com/phpstan/phpstan-src/pull/6667#ref-pullrequest-5692743017 |
|
Do not inherit @pure-unless-* tags into a method marked @phpstan-pure or @phpstan-impure
#6669
| https://github.com/phpstan/phpstan-src/pull/6669 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Oct 4, 2026
| https://github.com/phpstan/phpstan-src/pull/6667#pullrequestreview-5404411741 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/6667/files |
| tests/PHPStan/Rules/Methods/MethodSignatureRuleTest.php | https://github.com/phpstan/phpstan-src/pull/6667/files#diff-5293fcee1af12e2579c787fccc9d7a18fc6419b3aa9c755672655f4125c25d21 |
| staabm | https://github.com/staabm |
| Oct 4, 2026 | https://github.com/phpstan/phpstan-src/pull/6667#discussion_r4176218904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Oct 4, 2026 | https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-5976893734 |
| #3482 | https://github.com/phpstan/phpstan-src/pull/3482 |
| #6666 | https://github.com/phpstan/phpstan-src/pull/6666 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| stale review | https://github.com/phpstan/phpstan-src/pull/6667#pullrequestreview-5402294251 |
| October 4, 2026 07:35 | https://github.com/phpstan/phpstan-src/pull/6667#event-32433090751 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| Oct 4, 2026 | https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-5977808964 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| @staabm | https://github.com/staabm |
| @zonuexe | https://github.com/zonuexe |
| #6669 | https://github.com/phpstan/phpstan-src/pull/6669 |
| https://phpstan.org/r/948a3b08-566b-499c-bef0-1f7a7dc1f027 | https://phpstan.org/r/948a3b08-566b-499c-bef0-1f7a7dc1f027 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Oct 4, 2026 | https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-5978001448 |
| Check the purity declarations of methods without a body #6668 | https://github.com/phpstan/phpstan-src/pull/6668 |
| #6667 | https://github.com/phpstan/phpstan-src/pull/6667 |
| #6669 | https://github.com/phpstan/phpstan-src/pull/6669 |
| #6667 | https://github.com/phpstan/phpstan-src/pull/6667 |
| #6669 | https://github.com/phpstan/phpstan-src/pull/6669 |
| #6669 | https://github.com/phpstan/phpstan-src/pull/6669 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
|
Oct 5, 2026
| https://github.com/phpstan/phpstan-src/pull/6667#ref-issue-5717727082 |
|
Purity tags on overriding methods: which combinations should PHPStan report?
phpstan/phpstan#15381
| https://github.com/phpstan/phpstan/issues/15381 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/86eceaf61de6d108e45b16cd885a0b724c5192b1..7361cfb0dc38ec4bbedb80850030763cab876838 |
| 86eceaf | https://github.com/phpstan/phpstan-src/commit/86eceaf61de6d108e45b16cd885a0b724c5192b1 |
| 7361cfb | https://github.com/phpstan/phpstan-src/commit/7361cfb0dc38ec4bbedb80850030763cab876838 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/86eceaf61de6d108e45b16cd885a0b724c5192b1..7361cfb0dc38ec4bbedb80850030763cab876838 |
| October 5, 2026 19:40 | https://github.com/phpstan/phpstan-src/pull/6667#event-32540022193 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| October 27, 2026 17:41 | https://github.com/phpstan/phpstan-src/pull/6667#event-34395182893 |
| zonuexe | https://github.com/zonuexe |
| October 28, 2026 02:43 | https://github.com/phpstan/phpstan-src/pull/6667#commits-pushed-3dd6562 |
|
| https://github.com/zonuexe |
| Let @pure-unless-* tags take precedence over the class-level purity tags | https://github.com/phpstan/phpstan-src/pull/6667/commits/3dd656274d743045acb79286caa7e5140eb04051 |
| 3dd6562 | https://github.com/phpstan/phpstan-src/pull/6667/commits/3dd656274d743045acb79286caa7e5140eb04051 |
|
| https://github.com/zonuexe |
| Cover a pure override of a @pure-unless-callable-is-impure method | https://github.com/phpstan/phpstan-src/pull/6667/commits/27ebd5f8c5de97311d51ec7d8e78a0d7a1b7ba69 |
| 27ebd5f | https://github.com/phpstan/phpstan-src/pull/6667/commits/27ebd5f8c5de97311d51ec7d8e78a0d7a1b7ba69 |
|
| https://github.com/zonuexe |
| Keep a prose line of the turbo fixture from parsing as a PHPDoc tag | https://github.com/phpstan/phpstan-src/pull/6667/commits/cc802f57aaceb48235cb2807aae24a5de9a2dfb6 |
| cc802f5 | https://github.com/phpstan/phpstan-src/pull/6667/commits/cc802f57aaceb48235cb2807aae24a5de9a2dfb6 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/7361cfb0dc38ec4bbedb80850030763cab876838..cc802f57aaceb48235cb2807aae24a5de9a2dfb6 |
| 7361cfb | https://github.com/phpstan/phpstan-src/commit/7361cfb0dc38ec4bbedb80850030763cab876838 |
| cc802f5 | https://github.com/phpstan/phpstan-src/commit/cc802f57aaceb48235cb2807aae24a5de9a2dfb6 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/7361cfb0dc38ec4bbedb80850030763cab876838..cc802f57aaceb48235cb2807aae24a5de9a2dfb6 |
| October 27, 2026 17:54 | https://github.com/phpstan/phpstan-src/pull/6667#event-34396332100 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| October 27, 2026 18:31 | https://github.com/phpstan/phpstan-src/pull/6667#event-34399630426 |
| https://github.com/phpstan-bot |
| phpstan-bot | https://github.com/phpstan-bot |
| Oct 27, 2026 | https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-6450399855 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6667 |
|
| https://github.com/staabm |
|
staabm
| https://github.com/staabm |
|
| https://github.com/phpstan/phpstan-src/pull/6667/files/5e9882477b2c17f9052f8bc083cdf4536d8ffa9e |
|
| https://github.com/VincentLanglet |
|
VincentLanglet
| https://github.com/VincentLanglet |
|
| https://github.com/phpstan/phpstan-src/pull/6667/files/5e9882477b2c17f9052f8bc083cdf4536d8ffa9e |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/6667 |
|
| https://github.com/zonuexe |
|
| https://github.com/VincentLanglet |
|
| https://github.com/phpstan-bot |
|
| https://github.com/staabm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |