René's URL Explorer Experiment


Title: Let @pure-unless-* tags take precedence over the class-level purity tags by zonuexe · Pull Request #6667 · phpstan/phpstan-src · GitHub

Open Graph Title: Let @pure-unless-* tags take precedence over the class-level purity tags by zonuexe · Pull Request #6667 · phpstan/phpstan-src

X Title: Let @pure-unless-* tags take precedence over the class-level purity tags by zonuexe · Pull Request #6667 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Let @pure-unless-* tags take precedence over the class-level purity tags by zonuexe · Pull Request #6667 · phpstan/phpstan-src

Open Graph Description: Follow-up to #6666 (comment). In a class marked @phpstan-all-methods-pure, the class-level tag overrode a method's own @pure-unless-parameter-passed or @pure-unless-callable-is-impure and made ...

X Description: Follow-up to #6666 (comment). In a class marked @phpstan-all-methods-pure, the class-level tag overrode a method's own @pure-unless-parameter-passed or @pure-unless-callable-is-impure and m...

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/6667

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ccd36d12-1975-74ed-9278-8b2c605d1cd8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE66:3E4205:96CE95:CB63C3:6B00E9BB
html-safe-nonce259d3aec8c1b3c292cb62025cb5c114c64501dfab6380ffe534a59948205ead9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTY2OjNFNDIwNTo5NkNFOTU6Q0I2M0MzOjZCMDBFOUJCIiwidmlzaXRvcl9pZCI6IjYzMTQ2MDI4MjYwOTM4ODE3ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca0b768a103840fde9cc7695c4056b4afb74be3c175c858b85b40f7ecb96e7d62
hovercard-subject-tagpull_request:4728663782
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/6667/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fd07de1529d1e3484a5fca09069517cfa3e6fa5fbcb85df970b3722f8a5bbf69/phpstan/phpstan-src/pull/6667
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fd07de1529d1e3484a5fca09069517cfa3e6fa5fbcb85df970b3722f8a5bbf69/phpstan/phpstan-src/pull/6667
og:image:altFollow-up to #6666 (comment). In a class marked @phpstan-all-methods-pure, the class-level tag overrode a method's own @pure-unless-parameter-passed or @pure-unless-callable-is-impure and made ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezonuexe
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/6667#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6667
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6667
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/6667
Reloadhttps://github.com/phpstan/phpstan-src/pull/6667
Reloadhttps://github.com/phpstan/phpstan-src/pull/6667
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests186 (186)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
zonuexehttps://github.com/zonuexe
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
zonuexe:feature/all-methods-pure-respects-pure-unlesshttps://github.com/zonuexe/phpstan-src/tree/feature/all-methods-pure-respects-pure-unless
Conversationhttps://github.com/phpstan/phpstan-src/pull/6667
Commits3 (3)https://github.com/phpstan/phpstan-src/pull/6667/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/6667/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/6667/files
Let @pure-unless-* tags take precedence over the class-level purity tagshttps://github.com/phpstan/phpstan-src/pull/6667#top
zonuexehttps://github.com/zonuexe
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
zonuexe:feature/all-methods-pure-respects-pure-unlesshttps://github.com/zonuexe/phpstan-src/tree/feature/all-methods-pure-respects-pure-unless
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 3, 2026https://github.com/phpstan/phpstan-src/pull/6667#issue-5692262706
#6666 (comment)https://github.com/phpstan/phpstan-src/pull/6666#issuecomment-5971832273
#6666https://github.com/phpstan/phpstan-src/pull/6666
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
https://github.com/staabm
staabmhttps://github.com/staabm
VincentLanglethttps://github.com/VincentLanglet
October 3, 2026 18:28https://github.com/phpstan/phpstan-src/pull/6667#event-32409284592
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Oct 3, 2026 https://github.com/phpstan/phpstan-src/pull/6667#pullrequestreview-5402294251
View reviewed changes https://github.com/phpstan/phpstan-src/pull/6667/files
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
staabmhttps://github.com/staabm
October 3, 2026 18:59https://github.com/phpstan/phpstan-src/pull/6667#event-32410406848
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 3, 2026 https://github.com/phpstan/phpstan-src/pull/6667#ref-pullrequest-5692743017
Do not inherit @pure-unless-* tags into a method marked @phpstan-pure or @phpstan-impure #6669 https://github.com/phpstan/phpstan-src/pull/6669
https://github.com/staabm
staabmhttps://github.com/staabm
Oct 4, 2026 https://github.com/phpstan/phpstan-src/pull/6667#pullrequestreview-5404411741
View reviewed changes https://github.com/phpstan/phpstan-src/pull/6667/files
tests/PHPStan/Rules/Methods/MethodSignatureRuleTest.phphttps://github.com/phpstan/phpstan-src/pull/6667/files#diff-5293fcee1af12e2579c787fccc9d7a18fc6419b3aa9c755672655f4125c25d21
staabmhttps://github.com/staabm
Oct 4, 2026https://github.com/phpstan/phpstan-src/pull/6667#discussion_r4176218904
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 4, 2026https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-5976893734
#3482https://github.com/phpstan/phpstan-src/pull/3482
#6666https://github.com/phpstan/phpstan-src/pull/6666
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
stale reviewhttps://github.com/phpstan/phpstan-src/pull/6667#pullrequestreview-5402294251
October 4, 2026 07:35https://github.com/phpstan/phpstan-src/pull/6667#event-32433090751
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Oct 4, 2026https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-5977808964
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
@staabmhttps://github.com/staabm
@zonuexehttps://github.com/zonuexe
#6669https://github.com/phpstan/phpstan-src/pull/6669
https://phpstan.org/r/948a3b08-566b-499c-bef0-1f7a7dc1f027https://phpstan.org/r/948a3b08-566b-499c-bef0-1f7a7dc1f027
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 4, 2026https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-5978001448
Check the purity declarations of methods without a body #6668https://github.com/phpstan/phpstan-src/pull/6668
#6667https://github.com/phpstan/phpstan-src/pull/6667
#6669https://github.com/phpstan/phpstan-src/pull/6669
#6667https://github.com/phpstan/phpstan-src/pull/6667
#6669https://github.com/phpstan/phpstan-src/pull/6669
#6669https://github.com/phpstan/phpstan-src/pull/6669
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Oct 5, 2026 https://github.com/phpstan/phpstan-src/pull/6667#ref-issue-5717727082
Purity tags on overriding methods: which combinations should PHPStan report? phpstan/phpstan#15381 https://github.com/phpstan/phpstan/issues/15381
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
force-pushedhttps://github.com/phpstan/phpstan-src/compare/86eceaf61de6d108e45b16cd885a0b724c5192b1..7361cfb0dc38ec4bbedb80850030763cab876838
86eceafhttps://github.com/phpstan/phpstan-src/commit/86eceaf61de6d108e45b16cd885a0b724c5192b1
7361cfbhttps://github.com/phpstan/phpstan-src/commit/7361cfb0dc38ec4bbedb80850030763cab876838
Compare https://github.com/phpstan/phpstan-src/compare/86eceaf61de6d108e45b16cd885a0b724c5192b1..7361cfb0dc38ec4bbedb80850030763cab876838
October 5, 2026 19:40https://github.com/phpstan/phpstan-src/pull/6667#event-32540022193
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
October 27, 2026 17:41https://github.com/phpstan/phpstan-src/pull/6667#event-34395182893
zonuexehttps://github.com/zonuexe
October 28, 2026 02:43https://github.com/phpstan/phpstan-src/pull/6667#commits-pushed-3dd6562
https://github.com/zonuexe
Let @pure-unless-* tags take precedence over the class-level purity tagshttps://github.com/phpstan/phpstan-src/pull/6667/commits/3dd656274d743045acb79286caa7e5140eb04051
3dd6562https://github.com/phpstan/phpstan-src/pull/6667/commits/3dd656274d743045acb79286caa7e5140eb04051
https://github.com/zonuexe
Cover a pure override of a @pure-unless-callable-is-impure methodhttps://github.com/phpstan/phpstan-src/pull/6667/commits/27ebd5f8c5de97311d51ec7d8e78a0d7a1b7ba69
27ebd5fhttps://github.com/phpstan/phpstan-src/pull/6667/commits/27ebd5f8c5de97311d51ec7d8e78a0d7a1b7ba69
https://github.com/zonuexe
Keep a prose line of the turbo fixture from parsing as a PHPDoc taghttps://github.com/phpstan/phpstan-src/pull/6667/commits/cc802f57aaceb48235cb2807aae24a5de9a2dfb6
cc802f5https://github.com/phpstan/phpstan-src/pull/6667/commits/cc802f57aaceb48235cb2807aae24a5de9a2dfb6
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
force-pushedhttps://github.com/phpstan/phpstan-src/compare/7361cfb0dc38ec4bbedb80850030763cab876838..cc802f57aaceb48235cb2807aae24a5de9a2dfb6
7361cfbhttps://github.com/phpstan/phpstan-src/commit/7361cfb0dc38ec4bbedb80850030763cab876838
cc802f5https://github.com/phpstan/phpstan-src/commit/cc802f57aaceb48235cb2807aae24a5de9a2dfb6
Compare https://github.com/phpstan/phpstan-src/compare/7361cfb0dc38ec4bbedb80850030763cab876838..cc802f57aaceb48235cb2807aae24a5de9a2dfb6
October 27, 2026 17:54https://github.com/phpstan/phpstan-src/pull/6667#event-34396332100
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
October 27, 2026 18:31https://github.com/phpstan/phpstan-src/pull/6667#event-34399630426
https://github.com/phpstan-bot
phpstan-bothttps://github.com/phpstan-bot
Oct 27, 2026https://github.com/phpstan/phpstan-src/pull/6667#issuecomment-6450399855
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6667
https://github.com/staabm
staabm https://github.com/staabm
https://github.com/phpstan/phpstan-src/pull/6667/files/5e9882477b2c17f9052f8bc083cdf4536d8ffa9e
https://github.com/VincentLanglet
VincentLanglet https://github.com/VincentLanglet
https://github.com/phpstan/phpstan-src/pull/6667/files/5e9882477b2c17f9052f8bc083cdf4536d8ffa9e
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6667
https://github.com/zonuexe
https://github.com/VincentLanglet
https://github.com/phpstan-bot
https://github.com/staabm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.