| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:714765b1-9575-a83b-bc89-6e8568105c8b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A2E4:34CAB:96298B:C0BC50:6B00F185 |
| html-safe-nonce | db56806654adbb7baa576a6938d3f47094484e782d18842d174b48c0fb3c4683 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkU0OjM0Q0FCOjk2Mjk4QjpDMEJDNTA6NkIwMEYxODUiLCJ2aXNpdG9yX2lkIjoiNDUzOTA2NzcwMDAwMTQ2ODIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f5ca8ffa77d1d7ed018698d629b71899f752fb907e2cfe7eb9a1b7144c676373 |
| hovercard-subject-tag | pull_request:716655222 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/633/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4b273c8933dec7c1f39a4aca4b1255d4fa61ceabcee89b2723e99a0c06528557/phpstan/phpstan-src/pull/633 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4b273c8933dec7c1f39a4aca4b1255d4fa61ceabcee89b2723e99a0c06528557/phpstan/phpstan-src/pull/633 |
| og:image:alt | https://3v4l.org/TNDjR
inspired by vimeo/psalm#6324 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | staabm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 219334214 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 219334214 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/phpstan/phpstan-src/pull/633#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F633 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F633 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src |
| Reload | https://github.com/phpstan/phpstan-src/pull/633 |
| Reload | https://github.com/phpstan/phpstan-src/pull/633 |
| Reload | https://github.com/phpstan/phpstan-src/pull/633 |
| phpstan | https://github.com/phpstan |
| phpstan-src | https://github.com/phpstan/phpstan-src |
| Code | https://github.com/phpstan/phpstan-src |
| Pull requests186 (186) | https://github.com/phpstan/phpstan-src/pulls |
| Actions | https://github.com/phpstan/phpstan-src/actions |
| Security and quality | https://github.com/phpstan/phpstan-src/security |
| Insights | https://github.com/phpstan/phpstan-src/insights |
| https://github.com/phpstan/phpstan-src |
| ondrejmirtes | https://github.com/ondrejmirtes |
| phpstan:master | https://github.com/phpstan/phpstan-src/tree/master |
| staabm:str-split | https://github.com/staabm/phpstan-src/tree/str-split |
| Conversation | https://github.com/phpstan/phpstan-src/pull/633 |
| Commits6 (6) | https://github.com/phpstan/phpstan-src/pull/633/commits |
| Checks | https://github.com/phpstan/phpstan-src/pull/633/checks |
| Files changed | https://github.com/phpstan/phpstan-src/pull/633/files |
| mb_str_split() / str_split() always returns non-empty-array | https://github.com/phpstan/phpstan-src/pull/633#top |
| ondrejmirtes | https://github.com/ondrejmirtes |
| phpstan:master | https://github.com/phpstan/phpstan-src/tree/master |
| staabm:str-split | https://github.com/staabm/phpstan-src/tree/str-split |
|
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Aug 20, 2021 | https://github.com/phpstan/phpstan-src/pull/633#issue-975515728 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| https://3v4l.org/TNDjR | https://3v4l.org/TNDjR |
| vimeo/psalm#6324 | https://github.com/vimeo/psalm/pull/6324 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Aug 20, 2021
| https://github.com/phpstan/phpstan-src/pull/633#ref-pullrequest-975481437 |
|
str_split() length parameter is always positive
#631
| https://github.com/phpstan/phpstan-src/pull/631 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Aug 20, 2021 | https://github.com/phpstan/phpstan-src/pull/633#event-5186262311 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Aug 20, 2021
| https://github.com/phpstan/phpstan-src/pull/633#pullrequestreview-734935897 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/633/files |
| tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php | https://github.com/phpstan/phpstan-src/pull/633/files#diff-52d2cce81a3daff27b7d6d8ba619b045420ab9a9acffc57c1c379af4eba0b127 |
| staabm | https://github.com/staabm |
| Aug 20, 2021 | https://github.com/phpstan/phpstan-src/pull/633#discussion_r692874646 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| ondrejmirtes | https://github.com/ondrejmirtes |
| Aug 20, 2021 | https://github.com/phpstan/phpstan-src/pull/633#discussion_r692879006 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| phpstan-src/src/Type/UnionType.php | https://github.com/phpstan/phpstan-src/blob/119facc64db3acd77b8024fafa8bb3228e90cb25/src/Type/UnionType.php#L150-L168 |
| 119facc | https://github.com/phpstan/phpstan-src/commit/119facc64db3acd77b8024fafa8bb3228e90cb25 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/4c0266f852bc1ec6b10a52e78e9043d33cb00988..703459d66a3f2fae1bee00921246509447cf6915 |
| 4c0266f | https://github.com/phpstan/phpstan-src/commit/4c0266f852bc1ec6b10a52e78e9043d33cb00988 |
| 703459d | https://github.com/phpstan/phpstan-src/commit/703459d66a3f2fae1bee00921246509447cf6915 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/4c0266f852bc1ec6b10a52e78e9043d33cb00988..703459d66a3f2fae1bee00921246509447cf6915 |
| August 20, 2021 11:34 | https://github.com/phpstan/phpstan-src/pull/633#event-5186329384 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Aug 20, 2021
| https://github.com/phpstan/phpstan-src/pull/633#pullrequestreview-734938601 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/633/files |
| src/Type/Php/StrSplitFunctionReturnTypeExtension.php | https://github.com/phpstan/phpstan-src/pull/633/files#diff-969d66407a5d708b6cc7be1d6781fba2e8ab8adff4c0d5f2acd177c9b2c2cf87 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| staabm | https://github.com/staabm |
| August 20, 2021 13:42 | https://github.com/phpstan/phpstan-src/pull/633#commits-pushed-6bbca56 |
|
| https://github.com/staabm |
| (mb_)?str_split() always returns non-empty-array | https://github.com/phpstan/phpstan-src/pull/633/commits/6bbca56b8067637dbb90c70e6d75ef1f8731a323 |
| 6bbca56 | https://github.com/phpstan/phpstan-src/pull/633/commits/6bbca56b8067637dbb90c70e6d75ef1f8731a323 |
|
| https://github.com/staabm |
| fix tests | https://github.com/phpstan/phpstan-src/pull/633/commits/7fefa4ea8b2db2965747bac544e5defd7ac44ce3 |
| 7fefa4e | https://github.com/phpstan/phpstan-src/pull/633/commits/7fefa4ea8b2db2965747bac544e5defd7ac44ce3 |
|
| https://github.com/staabm |
| remove dead code | https://github.com/phpstan/phpstan-src/pull/633/commits/dbfc9f7d4ed065618fe26fb6fe16d6d0fa28f06d |
| dbfc9f7 | https://github.com/phpstan/phpstan-src/pull/633/commits/dbfc9f7d4ed065618fe26fb6fe16d6d0fa28f06d |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/703459d66a3f2fae1bee00921246509447cf6915..dbfc9f7d4ed065618fe26fb6fe16d6d0fa28f06d |
| 703459d | https://github.com/phpstan/phpstan-src/commit/703459d66a3f2fae1bee00921246509447cf6915 |
| dbfc9f7 | https://github.com/phpstan/phpstan-src/commit/dbfc9f7d4ed065618fe26fb6fe16d6d0fa28f06d |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/703459d66a3f2fae1bee00921246509447cf6915..dbfc9f7d4ed065618fe26fb6fe16d6d0fa28f06d |
| August 20, 2021 11:42 | https://github.com/phpstan/phpstan-src/pull/633#event-5186361998 |
| staabm | https://github.com/staabm |
| August 20, 2021 13:46 | https://github.com/phpstan/phpstan-src/pull/633#commits-pushed-bc3c64f |
|
| https://github.com/staabm |
| adjust test expectations | https://github.com/phpstan/phpstan-src/pull/633/commits/bc3c64f762c8d9305a8a6b9f956ea8d060d8b800 |
| bc3c64f | https://github.com/phpstan/phpstan-src/pull/633/commits/bc3c64f762c8d9305a8a6b9f956ea8d060d8b800 |
|
| https://github.com/staabm |
| adjusted should-not-happen condition | https://github.com/phpstan/phpstan-src/pull/633/commits/4a526b160e166ddae40e83d8a0c8973eb6168690 |
| 4a526b1 | https://github.com/phpstan/phpstan-src/pull/633/commits/4a526b160e166ddae40e83d8a0c8973eb6168690 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Aug 20, 2021
| https://github.com/phpstan/phpstan-src/pull/633#pullrequestreview-734956343 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/633/files/4a526b160e166ddae40e83d8a0c8973eb6168690 |
| src/Type/Php/StrSplitFunctionReturnTypeExtension.php | https://github.com/phpstan/phpstan-src/pull/633/files/4a526b160e166ddae40e83d8a0c8973eb6168690#diff-969d66407a5d708b6cc7be1d6781fba2e8ab8adff4c0d5f2acd177c9b2c2cf87 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
|
| https://github.com/clxmstaab |
| fix php8 baseline | https://github.com/phpstan/phpstan-src/pull/633/commits/7036765c2b1c5369f388588f81be4d8f629884ab |
| 7036765 | https://github.com/phpstan/phpstan-src/pull/633/commits/7036765c2b1c5369f388588f81be4d8f629884ab |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Aug 23, 2021 | https://github.com/phpstan/phpstan-src/pull/633#event-5194944603 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Aug 23, 2021 | https://github.com/phpstan/phpstan-src/pull/633#issuecomment-903840873 |
| @ondrejmirtes | https://github.com/ondrejmirtes |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
| 8bf2fe0 | https://github.com/phpstan/phpstan-src/commit/8bf2fe0683e21da1735c65545a3567925e27a71c |
| Aug 23, 2021 | https://github.com/phpstan/phpstan-src/pull/633#event-5196746778 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
| Aug 23, 2021 | https://github.com/phpstan/phpstan-src/pull/633#issuecomment-904104316 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| August 27, 2021 11:56 | https://github.com/phpstan/phpstan-src/pull/633#event-5218232665 |
| https://github.com/herndlm |
| herndlm | https://github.com/herndlm |
|
Jul 6, 2022
| https://github.com/phpstan/phpstan-src/pull/633#ref-pullrequest-1295480111 |
|
Fix handling of str_split / mb_str_split string arg compound types + default return type for mb_str_split
#1496
| https://github.com/phpstan/phpstan-src/pull/1496 |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F633 |
|
| https://github.com/ondrejmirtes |
|
ondrejmirtes
| https://github.com/ondrejmirtes |
|
| https://github.com/phpstan/phpstan-src/pull/633/files/4a526b160e166ddae40e83d8a0c8973eb6168690 |
|
| https://github.com/voku |
|
voku
| https://github.com/voku |
|
| https://github.com/phpstan/phpstan-src/pull/633/files/4a526b160e166ddae40e83d8a0c8973eb6168690 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/633 |
|
| https://github.com/staabm |
|
| https://github.com/ondrejmirtes |
|
| https://github.com/voku |
|
| https://github.com/clxmstaab |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |