René's URL Explorer Experiment


Title: Declare Memcached methods as impure by VincentLanglet · Pull Request #5536 · phpstan/phpstan-src · GitHub

Open Graph Title: Declare Memcached methods as impure by VincentLanglet · Pull Request #5536 · phpstan/phpstan-src

X Title: Declare Memcached methods as impure by VincentLanglet · Pull Request #5536 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Declare Memcached methods as impure by VincentLanglet · Pull Request #5536 · phpstan/phpstan-src

Open Graph Description: Closes phpstan/phpstan#13444 Closes #4344 Closes phpstan/phpstan#14534

X Description: Closes phpstan/phpstan#13444 Closes #4344 Closes phpstan/phpstan#14534

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/5536

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d08faedd-295d-474b-9278-fa81d854ccb2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A50:21149E:AE91ED:EF518C:6B00A8E0
html-safe-nonceeba29a81cbe0fedc02aa9d127f7cdefbb0e74d75631a012ac4602cdfd07ee80f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTUwOjIxMTQ5RTpBRTkxRUQ6RUY1MThDOjZCMDBBOEUwIiwidmlzaXRvcl9pZCI6Ijg3NTgzMjcyOTQ5NjUwOTg3MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4fcdb08785f20a26addc12f018021235ad9cd177e128406137786a319415af29
hovercard-subject-tagpull_request:3585239462
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/5536/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/268e574dcf495ac2fb18aa81a51875f8b4de5260560f300128150120c2f4eb2a/phpstan/phpstan-src/pull/5536
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/268e574dcf495ac2fb18aa81a51875f8b4de5260560f300128150120c2f4eb2a/phpstan/phpstan-src/pull/5536
og:image:altCloses phpstan/phpstan#13444 Closes #4344 Closes phpstan/phpstan#14534
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameVincentLanglet
hostnamegithub.com
expected-hostnamegithub.com
None455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2f575159976167242d488c0b062eb355c4e198b7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/5536#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F5536
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F5536
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/5536
Reloadhttps://github.com/phpstan/phpstan-src/pull/5536
Reloadhttps://github.com/phpstan/phpstan-src/pull/5536
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests185 (185)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
VincentLanglethttps://github.com/VincentLanglet
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
VincentLanglet:bug13444https://github.com/VincentLanglet/phpstan-src/tree/bug13444
Conversationhttps://github.com/phpstan/phpstan-src/pull/5536
Commits7 (7)https://github.com/phpstan/phpstan-src/pull/5536/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/5536/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/5536/files
Declare Memcached methods as impurehttps://github.com/phpstan/phpstan-src/pull/5536#top
VincentLanglethttps://github.com/VincentLanglet
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
VincentLanglet:bug13444https://github.com/VincentLanglet/phpstan-src/tree/bug13444
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Apr 26, 2026https://github.com/phpstan/phpstan-src/pull/5536#issue-4330364183
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
phpstan/phpstan#13444https://github.com/phpstan/phpstan/issues/13444
#4344https://github.com/phpstan/phpstan-src/pull/4344
phpstan/phpstan#14534https://github.com/phpstan/phpstan/issues/14534
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/phpstan-bot
phpstan-bothttps://github.com/phpstan-bot
Apr 26, 2026https://github.com/phpstan/phpstan-src/pull/5536#issuecomment-4321576938
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
April 26, 2026 08:00https://github.com/phpstan/phpstan-src/pull/5536#event-24877038534
https://github.com/VincentLanglet
Declare Memcached as impurehttps://github.com/phpstan/phpstan-src/pull/5536/commits/673b3c79cf98f3368b2db7e84b8146c2f2964db2
673b3c7https://github.com/phpstan/phpstan-src/pull/5536/commits/673b3c79cf98f3368b2db7e84b8146c2f2964db2
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
force-pushedhttps://github.com/phpstan/phpstan-src/compare/c49e2894f02bd1b31f454251e647ba104a6264a9..673b3c79cf98f3368b2db7e84b8146c2f2964db2
c49e289https://github.com/phpstan/phpstan-src/commit/c49e2894f02bd1b31f454251e647ba104a6264a9
673b3c7https://github.com/phpstan/phpstan-src/commit/673b3c79cf98f3368b2db7e84b8146c2f2964db2
Compare https://github.com/phpstan/phpstan-src/compare/c49e2894f02bd1b31f454251e647ba104a6264a9..673b3c79cf98f3368b2db7e84b8146c2f2964db2
April 26, 2026 08:02https://github.com/phpstan/phpstan-src/pull/5536#event-24877059445
VincentLanglethttps://github.com/VincentLanglet
April 26, 2026 13:49https://github.com/phpstan/phpstan-src/pull/5536#commits-pushed-315cbb8
https://github.com/VincentLanglet
Fixhttps://github.com/phpstan/phpstan-src/pull/5536/commits/315cbb8eb236f55e8541a58736b4321a27603306
315cbb8https://github.com/phpstan/phpstan-src/pull/5536/commits/315cbb8eb236f55e8541a58736b4321a27603306
https://github.com/VincentLanglet
Add testhttps://github.com/phpstan/phpstan-src/pull/5536/commits/96be53f7d46abd0c6ee18df2b15b069ccb945849
96be53fhttps://github.com/phpstan/phpstan-src/pull/5536/commits/96be53f7d46abd0c6ee18df2b15b069ccb945849
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Apr 26, 2026 https://github.com/phpstan/phpstan-src/pull/5536#ref-pullrequest-4330533465
Respect @phpstan-all-methods-impure, @phpstan-all-methods-pure, and method-level purity annotations on built-in classes #5539 https://github.com/phpstan/phpstan-src/pull/5539
https://github.com/VincentLanglet
Fixhttps://github.com/phpstan/phpstan-src/pull/5536/commits/2edcb5ef18064fe3fdf8faf9afd401930ee4786c
2edcb5ehttps://github.com/phpstan/phpstan-src/pull/5536/commits/2edcb5ef18064fe3fdf8faf9afd401930ee4786c
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
April 26, 2026 12:15https://github.com/phpstan/phpstan-src/pull/5536#event-24879216304
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
staabmhttps://github.com/staabm
April 26, 2026 12:15https://github.com/phpstan/phpstan-src/pull/5536#event-24879217265
https://github.com/phpstan-bot
phpstan-bothttps://github.com/phpstan-bot
Apr 26, 2026https://github.com/phpstan/phpstan-src/pull/5536#issuecomment-4321999822
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/staabm
staabmhttps://github.com/staabm
Apr 27, 2026 https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4178320598
View reviewed changes https://github.com/phpstan/phpstan-src/pull/5536/files/2edcb5ef18064fe3fdf8faf9afd401930ee4786c
stubs/Memcached.stubhttps://github.com/phpstan/phpstan-src/pull/5536/files/2edcb5ef18064fe3fdf8faf9afd401930ee4786c#diff-bf47c885872c03812b6ccdb8350a5c1303773b9b48a03f6857218ccafe58660e
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/staabm
staabmhttps://github.com/staabm
Apr 27, 2026 https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4178325243
View reviewed changes https://github.com/phpstan/phpstan-src/pull/5536/files/2edcb5ef18064fe3fdf8faf9afd401930ee4786c
staabmhttps://github.com/staabm
https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4178325243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#4344 (comment)https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-3384454257
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
VincentLanglethttps://github.com/VincentLanglet
April 27, 2026 10:00https://github.com/phpstan/phpstan-src/pull/5536#commits-pushed-199c942
https://github.com/VincentLanglet
Add MemcachePoolhttps://github.com/phpstan/phpstan-src/pull/5536/commits/199c9429abe2f162015c24735bc8e13ee20758e2
199c942https://github.com/phpstan/phpstan-src/pull/5536/commits/199c9429abe2f162015c24735bc8e13ee20758e2
https://github.com/VincentLanglet
Add Memcachehttps://github.com/phpstan/phpstan-src/pull/5536/commits/347eca496d5c10d13f95552ed38e7ab27282dbe2
347eca4https://github.com/phpstan/phpstan-src/pull/5536/commits/347eca496d5c10d13f95552ed38e7ab27282dbe2
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Apr 27, 2026https://github.com/phpstan/phpstan-src/pull/5536#issuecomment-4325253152
#4344 (comment)https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-3384454257
#4422https://github.com/phpstan/phpstan-src/pull/4422
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
staabmhttps://github.com/staabm
April 27, 2026 08:05https://github.com/phpstan/phpstan-src/pull/5536#event-24896100451
https://github.com/staabm
staabmhttps://github.com/staabm
Apr 27, 2026 https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4179157237
View reviewed changes https://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2
tests/PHPStan/Rules/Comparison/data/bug-14534.stubhttps://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2#diff-da9fd47148d14a3a686d02b34d7d4c981987e0209f11c9cca62516ba6df2074d
staabmhttps://github.com/staabm
Apr 27, 2026https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145745787
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
VincentLanglethttps://github.com/VincentLanglet
Apr 27, 2026https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145766648
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#5539 (comment)https://github.com/phpstan/phpstan-src/pull/5539#issuecomment-4321836621
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
staabmhttps://github.com/staabm
Apr 27, 2026https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145795063
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
VincentLanglethttps://github.com/VincentLanglet
Apr 27, 2026https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145852856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/staabm
staabmhttps://github.com/staabm
Apr 27, 2026 https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4179163921
View reviewed changes https://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2
tests/PHPStan/Rules/Comparison/data/bug-14534.phphttps://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2#diff-701119ec488a4e46a2bdf1ff063af3fa0da62bfc71514a458c9ff67efbc97d03
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/VincentLanglet
Add testhttps://github.com/phpstan/phpstan-src/pull/5536/commits/45f069f55e4a616b497528089fb44c08d03e2cd4
45f069fhttps://github.com/phpstan/phpstan-src/pull/5536/commits/45f069f55e4a616b497528089fb44c08d03e2cd4
https://github.com/staabm
staabmhttps://github.com/staabm
Apr 27, 2026 https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4179212546
View reviewed changes https://github.com/phpstan/phpstan-src/pull/5536/files/45f069f55e4a616b497528089fb44c08d03e2cd4
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
fe750c5https://github.com/phpstan/phpstan-src/commit/fe750c5587a75b175150feeade5894c89918134f
Apr 27, 2026https://github.com/phpstan/phpstan-src/pull/5536#event-24896796640
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
Recognize the \Memcached::cas() can change the \Memcached::getResultCode() phpstan/phpstan#13444 https://github.com/phpstan/phpstan/issues/13444
phpstan-all-method-impure seems to be ignored for native class phpstan/phpstan#14534 https://github.com/phpstan/phpstan/issues/14534
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F5536
https://github.com/staabm
staabm https://github.com/staabm
https://github.com/phpstan/phpstan-src/pull/5536/files/45f069f55e4a616b497528089fb44c08d03e2cd4
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
Recognize the \Memcached::cas() can change the \Memcached::getResultCode() https://github.com/phpstan/phpstan/issues/13444
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/5536
https://github.com/VincentLanglet
https://github.com/phpstan-bot
https://github.com/staabm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.