| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d08faedd-295d-474b-9278-fa81d854ccb2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A50:21149E:AE91ED:EF518C:6B00A8E0 |
| html-safe-nonce | eba29a81cbe0fedc02aa9d127f7cdefbb0e74d75631a012ac4602cdfd07ee80f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTUwOjIxMTQ5RTpBRTkxRUQ6RUY1MThDOjZCMDBBOEUwIiwidmlzaXRvcl9pZCI6Ijg3NTgzMjcyOTQ5NjUwOTg3MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4fcdb08785f20a26addc12f018021235ad9cd177e128406137786a319415af29 |
| hovercard-subject-tag | pull_request:3585239462 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/5536/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/268e574dcf495ac2fb18aa81a51875f8b4de5260560f300128150120c2f4eb2a/phpstan/phpstan-src/pull/5536 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/268e574dcf495ac2fb18aa81a51875f8b4de5260560f300128150120c2f4eb2a/phpstan/phpstan-src/pull/5536 |
| og:image:alt | Closes phpstan/phpstan#13444
Closes #4344
Closes phpstan/phpstan#14534 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | VincentLanglet |
| hostname | github.com |
| expected-hostname | github.com |
| None | 455b493e3402a3a3a06beac5d20bb7db3da060808b220aa48d6a7eca7c59863a |
| turbo-cache-control | no-cache |
| go-import | github.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 219334214 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 219334214 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2f575159976167242d488c0b062eb355c4e198b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/phpstan/phpstan-src/pull/5536#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F5536 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F5536 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src |
| Reload | https://github.com/phpstan/phpstan-src/pull/5536 |
| Reload | https://github.com/phpstan/phpstan-src/pull/5536 |
| Reload | https://github.com/phpstan/phpstan-src/pull/5536 |
| phpstan | https://github.com/phpstan |
| phpstan-src | https://github.com/phpstan/phpstan-src |
| Code | https://github.com/phpstan/phpstan-src |
| Pull requests185 (185) | https://github.com/phpstan/phpstan-src/pulls |
| Actions | https://github.com/phpstan/phpstan-src/actions |
| Security and quality | https://github.com/phpstan/phpstan-src/security |
| Insights | https://github.com/phpstan/phpstan-src/insights |
| https://github.com/phpstan/phpstan-src |
| VincentLanglet | https://github.com/VincentLanglet |
| phpstan:2.1.x | https://github.com/phpstan/phpstan-src/tree/2.1.x |
| VincentLanglet:bug13444 | https://github.com/VincentLanglet/phpstan-src/tree/bug13444 |
| Conversation | https://github.com/phpstan/phpstan-src/pull/5536 |
| Commits7 (7) | https://github.com/phpstan/phpstan-src/pull/5536/commits |
| Checks | https://github.com/phpstan/phpstan-src/pull/5536/checks |
| Files changed | https://github.com/phpstan/phpstan-src/pull/5536/files |
| Declare Memcached methods as impure | https://github.com/phpstan/phpstan-src/pull/5536#top |
| VincentLanglet | https://github.com/VincentLanglet |
| phpstan:2.1.x | https://github.com/phpstan/phpstan-src/tree/2.1.x |
| VincentLanglet:bug13444 | https://github.com/VincentLanglet/phpstan-src/tree/bug13444 |
|
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| Apr 26, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#issue-4330364183 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| phpstan/phpstan#13444 | https://github.com/phpstan/phpstan/issues/13444 |
| #4344 | https://github.com/phpstan/phpstan-src/pull/4344 |
| phpstan/phpstan#14534 | https://github.com/phpstan/phpstan/issues/14534 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| https://github.com/phpstan-bot |
| phpstan-bot | https://github.com/phpstan-bot |
| Apr 26, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#issuecomment-4321576938 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| April 26, 2026 08:00 | https://github.com/phpstan/phpstan-src/pull/5536#event-24877038534 |
|
| https://github.com/VincentLanglet |
| Declare Memcached as impure | https://github.com/phpstan/phpstan-src/pull/5536/commits/673b3c79cf98f3368b2db7e84b8146c2f2964db2 |
| 673b3c7 | https://github.com/phpstan/phpstan-src/pull/5536/commits/673b3c79cf98f3368b2db7e84b8146c2f2964db2 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/c49e2894f02bd1b31f454251e647ba104a6264a9..673b3c79cf98f3368b2db7e84b8146c2f2964db2 |
| c49e289 | https://github.com/phpstan/phpstan-src/commit/c49e2894f02bd1b31f454251e647ba104a6264a9 |
| 673b3c7 | https://github.com/phpstan/phpstan-src/commit/673b3c79cf98f3368b2db7e84b8146c2f2964db2 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/c49e2894f02bd1b31f454251e647ba104a6264a9..673b3c79cf98f3368b2db7e84b8146c2f2964db2 |
| April 26, 2026 08:02 | https://github.com/phpstan/phpstan-src/pull/5536#event-24877059445 |
| VincentLanglet | https://github.com/VincentLanglet |
| April 26, 2026 13:49 | https://github.com/phpstan/phpstan-src/pull/5536#commits-pushed-315cbb8 |
|
| https://github.com/VincentLanglet |
| Fix | https://github.com/phpstan/phpstan-src/pull/5536/commits/315cbb8eb236f55e8541a58736b4321a27603306 |
| 315cbb8 | https://github.com/phpstan/phpstan-src/pull/5536/commits/315cbb8eb236f55e8541a58736b4321a27603306 |
|
| https://github.com/VincentLanglet |
| Add test | https://github.com/phpstan/phpstan-src/pull/5536/commits/96be53f7d46abd0c6ee18df2b15b069ccb945849 |
| 96be53f | https://github.com/phpstan/phpstan-src/pull/5536/commits/96be53f7d46abd0c6ee18df2b15b069ccb945849 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
|
Apr 26, 2026
| https://github.com/phpstan/phpstan-src/pull/5536#ref-pullrequest-4330533465 |
|
Respect @phpstan-all-methods-impure, @phpstan-all-methods-pure, and method-level purity annotations on built-in classes
#5539
| https://github.com/phpstan/phpstan-src/pull/5539 |
|
| https://github.com/VincentLanglet |
| Fix | https://github.com/phpstan/phpstan-src/pull/5536/commits/2edcb5ef18064fe3fdf8faf9afd401930ee4786c |
| 2edcb5e | https://github.com/phpstan/phpstan-src/pull/5536/commits/2edcb5ef18064fe3fdf8faf9afd401930ee4786c |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| April 26, 2026 12:15 | https://github.com/phpstan/phpstan-src/pull/5536#event-24879216304 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| staabm | https://github.com/staabm |
| April 26, 2026 12:15 | https://github.com/phpstan/phpstan-src/pull/5536#event-24879217265 |
| https://github.com/phpstan-bot |
| phpstan-bot | https://github.com/phpstan-bot |
| Apr 26, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#issuecomment-4321999822 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Apr 27, 2026
| https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4178320598 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/5536/files/2edcb5ef18064fe3fdf8faf9afd401930ee4786c |
| stubs/Memcached.stub | https://github.com/phpstan/phpstan-src/pull/5536/files/2edcb5ef18064fe3fdf8faf9afd401930ee4786c#diff-bf47c885872c03812b6ccdb8350a5c1303773b9b48a03f6857218ccafe58660e |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Apr 27, 2026
| https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4178325243 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/5536/files/2edcb5ef18064fe3fdf8faf9afd401930ee4786c |
| staabm | https://github.com/staabm |
| https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4178325243 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4344 (comment) | https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-3384454257 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| VincentLanglet | https://github.com/VincentLanglet |
| April 27, 2026 10:00 | https://github.com/phpstan/phpstan-src/pull/5536#commits-pushed-199c942 |
|
| https://github.com/VincentLanglet |
| Add MemcachePool | https://github.com/phpstan/phpstan-src/pull/5536/commits/199c9429abe2f162015c24735bc8e13ee20758e2 |
| 199c942 | https://github.com/phpstan/phpstan-src/pull/5536/commits/199c9429abe2f162015c24735bc8e13ee20758e2 |
|
| https://github.com/VincentLanglet |
| Add Memcache | https://github.com/phpstan/phpstan-src/pull/5536/commits/347eca496d5c10d13f95552ed38e7ab27282dbe2 |
| 347eca4 | https://github.com/phpstan/phpstan-src/pull/5536/commits/347eca496d5c10d13f95552ed38e7ab27282dbe2 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| Apr 27, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#issuecomment-4325253152 |
| #4344 (comment) | https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-3384454257 |
| #4422 | https://github.com/phpstan/phpstan-src/pull/4422 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| staabm | https://github.com/staabm |
| April 27, 2026 08:05 | https://github.com/phpstan/phpstan-src/pull/5536#event-24896100451 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Apr 27, 2026
| https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4179157237 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2 |
| tests/PHPStan/Rules/Comparison/data/bug-14534.stub | https://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2#diff-da9fd47148d14a3a686d02b34d7d4c981987e0209f11c9cca62516ba6df2074d |
| staabm | https://github.com/staabm |
| Apr 27, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145745787 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| VincentLanglet | https://github.com/VincentLanglet |
| Apr 27, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145766648 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #5539 (comment) | https://github.com/phpstan/phpstan-src/pull/5539#issuecomment-4321836621 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| staabm | https://github.com/staabm |
| Apr 27, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145795063 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| VincentLanglet | https://github.com/VincentLanglet |
| Apr 27, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#discussion_r3145852856 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Apr 27, 2026
| https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4179163921 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2 |
| tests/PHPStan/Rules/Comparison/data/bug-14534.php | https://github.com/phpstan/phpstan-src/pull/5536/files/347eca496d5c10d13f95552ed38e7ab27282dbe2#diff-701119ec488a4e46a2bdf1ff063af3fa0da62bfc71514a458c9ff67efbc97d03 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
|
| https://github.com/VincentLanglet |
| Add test | https://github.com/phpstan/phpstan-src/pull/5536/commits/45f069f55e4a616b497528089fb44c08d03e2cd4 |
| 45f069f | https://github.com/phpstan/phpstan-src/pull/5536/commits/45f069f55e4a616b497528089fb44c08d03e2cd4 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Apr 27, 2026
| https://github.com/phpstan/phpstan-src/pull/5536#pullrequestreview-4179212546 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/5536/files/45f069f55e4a616b497528089fb44c08d03e2cd4 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| fe750c5 | https://github.com/phpstan/phpstan-src/commit/fe750c5587a75b175150feeade5894c89918134f |
| Apr 27, 2026 | https://github.com/phpstan/phpstan-src/pull/5536#event-24896796640 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
|
Recognize the \Memcached::cas() can change the \Memcached::getResultCode()
phpstan/phpstan#13444
| https://github.com/phpstan/phpstan/issues/13444 |
|
phpstan-all-method-impure seems to be ignored for native class
phpstan/phpstan#14534
| https://github.com/phpstan/phpstan/issues/14534 |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F5536 |
|
| https://github.com/staabm |
|
staabm
| https://github.com/staabm |
|
| https://github.com/phpstan/phpstan-src/pull/5536/files/45f069f55e4a616b497528089fb44c08d03e2cd4 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
|
Recognize the \Memcached::cas() can change the \Memcached::getResultCode()
| https://github.com/phpstan/phpstan/issues/13444 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/5536 |
|
| https://github.com/VincentLanglet |
|
| https://github.com/phpstan-bot |
|
| https://github.com/staabm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |