René's URL Explorer Experiment


Title: Fix isset() falsey branch not narrowing array type for dim fetches by VincentLanglet · Pull Request #4983 · phpstan/phpstan-src · GitHub

Open Graph Title: Fix isset() falsey branch not narrowing array type for dim fetches by VincentLanglet · Pull Request #4983 · phpstan/phpstan-src

X Title: Fix isset() falsey branch not narrowing array type for dim fetches by VincentLanglet · Pull Request #4983 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Fix isset() falsey branch not narrowing array type for dim fetches by VincentLanglet · Pull Request #4983 · phpstan/phpstan-src

Open Graph Description: Summary When using isset($a['key']) on a union type array, the falsey branch did not narrow the array variable's type. This caused the original union members to leak through after the i...

X Description: Summary When using isset($a['key']) on a union type array, the falsey branch did not narrow the array variable's type. This caused the original union members to leak through...

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/4983

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7275af4f-1c12-fc27-4643-b17326e07ac7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD796:3FF2FE:B839CD:FDA19C:6B00AED2
html-safe-nonce31698564b976f9cd71ad2dcab326d6800def4db47063d8efd5236419c2c11e6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzk2OjNGRjJGRTpCODM5Q0Q6RkRBMTlDOjZCMDBBRUQyIiwidmlzaXRvcl9pZCI6Ijg3NTgzNTI4NzU3OTAzMTUyMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac01d1edcdfa1abd663285376e4e60035f992fc887b3df144d7de6ae3040548c57
hovercard-subject-tagpull_request:3296313264
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/4983/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/10159dda0f56c20a17da841c751fcce600fbd76deea6209815455d3a7bc5f27d/phpstan/phpstan-src/pull/4983
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/10159dda0f56c20a17da841c751fcce600fbd76deea6209815455d3a7bc5f27d/phpstan/phpstan-src/pull/4983
og:image:altSummary When using isset($a['key']) on a union type array, the falsey branch did not narrow the array variable's type. This caused the original union members to leak through after the i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameVincentLanglet
hostnamegithub.com
expected-hostnamegithub.com
Nonec0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release729d8cda69b3d267995675dfbf89ff27ccf61bf6
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/4983#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4983
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4983
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/4983
Reloadhttps://github.com/phpstan/phpstan-src/pull/4983
Reloadhttps://github.com/phpstan/phpstan-src/pull/4983
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests185 (185)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
VincentLanglethttps://github.com/VincentLanglet
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
VincentLanglet:fix/9908https://github.com/VincentLanglet/phpstan-src/tree/fix/9908
Conversationhttps://github.com/phpstan/phpstan-src/pull/4983
Commits7 (7)https://github.com/phpstan/phpstan-src/pull/4983/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/4983/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/4983/files
Fix isset() falsey branch not narrowing array type for dim fetcheshttps://github.com/phpstan/phpstan-src/pull/4983#top
VincentLanglethttps://github.com/VincentLanglet
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
VincentLanglet:fix/9908https://github.com/VincentLanglet/phpstan-src/tree/fix/9908
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Feb 17, 2026https://github.com/phpstan/phpstan-src/pull/4983#issue-3955018360
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
phpstan/phpstan#9908https://github.com/phpstan/phpstan/issues/9908
phpstan/phpstan#10544https://github.com/phpstan/phpstan/issues/10544
phpstan/phpstan#8724https://github.com/phpstan/phpstan/issues/8724
phpstan/phpstan#5128https://github.com/phpstan/phpstan/issues/5128
phpstan/phpstan#12401https://github.com/phpstan/phpstan/issues/12401
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
phpstan-bothttps://github.com/phpstan-bot
February 17, 2026 23:37https://github.com/phpstan/phpstan-src/pull/4983#commits-pushed-3b14a35
https://github.com/phpstan-bot
https://github.com/VincentLanglet
Fix isset() falsey branch not narrowing array type for dim fetcheshttps://github.com/phpstan/phpstan-src/pull/4983/commits/3b14a35486036c4c23b1677a321d03e5a5a13212
3b14a35https://github.com/phpstan/phpstan-src/pull/4983/commits/3b14a35486036c4c23b1677a321d03e5a5a13212
phpstan/phpstan#9908https://github.com/phpstan/phpstan/issues/9908
https://github.com/VincentLanglet
More testshttps://github.com/phpstan/phpstan-src/pull/4983/commits/fed2702f718dca6a3c53c6b67e769c15cd522055
fed2702https://github.com/phpstan/phpstan-src/pull/4983/commits/fed2702f718dca6a3c53c6b67e769c15cd522055
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Feb 17, 2026 https://github.com/phpstan/phpstan-src/pull/4983#ref-pullrequest-3949532172
Fix #9908: isset condition doesn't refine type #4962 https://github.com/phpstan/phpstan-src/pull/4962
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
Feb 17, 2026 https://github.com/phpstan/phpstan-src/pull/4983#pullrequestreview-3816723724
View reviewed changes https://github.com/phpstan/phpstan-src/pull/4983/files/fed2702f718dca6a3c53c6b67e769c15cd522055
src/Analyser/TypeSpecifier.phphttps://github.com/phpstan/phpstan-src/pull/4983/files/fed2702f718dca6a3c53c6b67e769c15cd522055#diff-1076e38598f300a69c9dc998dae31374052f95bd69d0d71c11e9d0a4c188976d
VincentLanglethttps://github.com/VincentLanglet
Feb 17, 2026https://github.com/phpstan/phpstan-src/pull/4983#discussion_r2819477136
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@staabmhttps://github.com/staabm
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
staabmhttps://github.com/staabm
Feb 18, 2026https://github.com/phpstan/phpstan-src/pull/4983#discussion_r2820874464
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
VincentLanglethttps://github.com/VincentLanglet
Feb 19, 2026https://github.com/phpstan/phpstan-src/pull/4983#discussion_r2825020519
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
force-pushedhttps://github.com/phpstan/phpstan-src/compare/a81b0e8b8975923f088fe20620e283b4d7352523..660f84e5d3fa95d64e90162ce176ee408ab0ccf4
a81b0e8https://github.com/phpstan/phpstan-src/commit/a81b0e8b8975923f088fe20620e283b4d7352523
660f84ehttps://github.com/phpstan/phpstan-src/commit/660f84e5d3fa95d64e90162ce176ee408ab0ccf4
Compare https://github.com/phpstan/phpstan-src/compare/a81b0e8b8975923f088fe20620e283b4d7352523..660f84e5d3fa95d64e90162ce176ee408ab0ccf4
February 19, 2026 00:03https://github.com/phpstan/phpstan-src/pull/4983#event-22899685227
https://github.com/VincentLanglet
Simplifyhttps://github.com/phpstan/phpstan-src/pull/4983/commits/432d18aa48ca7786d7c8fa81adfdcb3cfe13831a
432d18ahttps://github.com/phpstan/phpstan-src/pull/4983/commits/432d18aa48ca7786d7c8fa81adfdcb3cfe13831a
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
force-pushedhttps://github.com/phpstan/phpstan-src/compare/660f84e5d3fa95d64e90162ce176ee408ab0ccf4..432d18aa48ca7786d7c8fa81adfdcb3cfe13831a
660f84ehttps://github.com/phpstan/phpstan-src/commit/660f84e5d3fa95d64e90162ce176ee408ab0ccf4
432d18ahttps://github.com/phpstan/phpstan-src/commit/432d18aa48ca7786d7c8fa81adfdcb3cfe13831a
Compare https://github.com/phpstan/phpstan-src/compare/660f84e5d3fa95d64e90162ce176ee408ab0ccf4..432d18aa48ca7786d7c8fa81adfdcb3cfe13831a
February 19, 2026 00:04https://github.com/phpstan/phpstan-src/pull/4983#event-22899702161
phpstan-bothttps://github.com/phpstan-bot
February 19, 2026 01:07https://github.com/phpstan/phpstan-src/pull/4983#commits-pushed-24c603c
https://github.com/phpstan-bot
https://github.com/VincentLanglet
Add regression test for #10544https://github.com/phpstan/phpstan-src/pull/4983/commits/24c603ce696153d801101dcc693f166f7bf4d896
24c603chttps://github.com/phpstan/phpstan-src/pull/4983/commits/24c603ce696153d801101dcc693f166f7bf4d896
phpstan/phpstan#10544https://github.com/phpstan/phpstan/issues/10544
https://github.com/phpstan-bot
https://github.com/VincentLanglet
Add regression test for #8724https://github.com/phpstan/phpstan-src/pull/4983/commits/cf3bf637b0c812fa8d0326bdb177c5f715cc2ac6
cf3bf63https://github.com/phpstan/phpstan-src/pull/4983/commits/cf3bf637b0c812fa8d0326bdb177c5f715cc2ac6
phpstan/phpstan#8724https://github.com/phpstan/phpstan/issues/8724
https://github.com/phpstan-bot
https://github.com/VincentLanglet
Add regression test forhttps://github.com/phpstan/phpstan-src/pull/4983/commits/c5a41400634ce22bb987d697df156082ecf5faa1
phpstan#5128https://github.com/phpstan/phpstan-src/pull/5128
c5a4140https://github.com/phpstan/phpstan-src/pull/4983/commits/c5a41400634ce22bb987d697df156082ecf5faa1
phpstan/phpstan#5128https://github.com/phpstan/phpstan/issues/5128
https://github.com/phpstan-bot
https://github.com/VincentLanglet
Add regression test for #12401https://github.com/phpstan/phpstan-src/pull/4983/commits/06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
06ae0bdhttps://github.com/phpstan/phpstan-src/pull/4983/commits/06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
phpstan/phpstan#12401https://github.com/phpstan/phpstan/issues/12401
https://github.com/staabm
staabmhttps://github.com/staabm
Feb 19, 2026 https://github.com/phpstan/phpstan-src/pull/4983#pullrequestreview-3823933177
View reviewed changes https://github.com/phpstan/phpstan-src/pull/4983/files/06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
src/Analyser/TypeSpecifier.phphttps://github.com/phpstan/phpstan-src/pull/4983/files/06ae0bd09cdf56060a5b05d715e75647b3a4eb0c#diff-1076e38598f300a69c9dc998dae31374052f95bd69d0d71c11e9d0a4c188976d
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
https://github.com/staabm
staabmhttps://github.com/staabm
Feb 19, 2026 https://github.com/phpstan/phpstan-src/pull/4983#pullrequestreview-3823956045
View reviewed changes https://github.com/phpstan/phpstan-src/pull/4983/files/06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
staabmhttps://github.com/staabm
https://github.com/phpstan/phpstan-src/pull/4983#pullrequestreview-3823956045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
force-pushedhttps://github.com/phpstan/phpstan-src/compare/06caadcc7da7254f3a512ada9e3b7b7f6dfcae37..06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
06caadchttps://github.com/phpstan/phpstan-src/commit/06caadcc7da7254f3a512ada9e3b7b7f6dfcae37
06ae0bdhttps://github.com/phpstan/phpstan-src/commit/06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
Compare https://github.com/phpstan/phpstan-src/compare/06caadcc7da7254f3a512ada9e3b7b7f6dfcae37..06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
February 19, 2026 08:58https://github.com/phpstan/phpstan-src/pull/4983#event-22908153027
https://github.com/VincentLanglet
VincentLanglethttps://github.com/VincentLanglet
2ccd7b9https://github.com/phpstan/phpstan-src/commit/2ccd7b941407a473cf97c99149a8a2f902d813a2
Feb 19, 2026https://github.com/phpstan/phpstan-src/pull/4983#event-22909884349
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
isset condition doesn't refine type phpstan/phpstan#9908 https://github.com/phpstan/phpstan/issues/9908
Union type of array is not judge correct phpstan/phpstan#10544 https://github.com/phpstan/phpstan/issues/10544
isset not narrowing down array shapes phpstan/phpstan#8724 https://github.com/phpstan/phpstan/issues/8724
Cannot rule out types by checking for present key in array shape union phpstan/phpstan#5128 https://github.com/phpstan/phpstan/issues/5128
Else after if (isset) on union of array shapes not narrowed phpstan/phpstan#12401 https://github.com/phpstan/phpstan/issues/12401
Narrow the falsey branch of isset($a['x']['y']) only when the intermediate offset is known to exist #6110 https://github.com/phpstan/phpstan-src/pull/6110
Do not narrow the falsey branch of a nested isset() at its intermediate offset #6175 https://github.com/phpstan/phpstan-src/pull/6175
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Aug 12, 2026 https://github.com/phpstan/phpstan-src/pull/4983#ref-issue-4986747902
isset() on a nested array offset narrows the falsey branch to never, leaking the intermediate offset's existence (regression in 2.1.40) phpstan/phpstan#15005 https://github.com/phpstan/phpstan/issues/15005
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4983
https://github.com/staabm
staabm https://github.com/staabm
https://github.com/phpstan/phpstan-src/pull/4983/files/06ae0bd09cdf56060a5b05d715e75647b3a4eb0c
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4983
https://github.com/VincentLanglet
https://github.com/staabm
https://github.com/phpstan-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.