René's URL Explorer Experiment


Title: Prevent unnecessary scope merging by staabm · Pull Request #4640 · phpstan/phpstan-src · GitHub

Open Graph Title: Prevent unnecessary scope merging by staabm · Pull Request #4640 · phpstan/phpstan-src

X Title: Prevent unnecessary scope merging by staabm · Pull Request #4640 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Prevent unnecessary scope merging by staabm · Pull Request #4640 · phpstan/phpstan-src

Open Graph Description: In the profiles of #4628 (comment) we can see MutatingScope->createConditionalExpressions as one of the most expensive calls (which gets called via MutatingScope->merge()): After this PR, we...

X Description: In the profiles of #4628 (comment) we can see MutatingScope->createConditionalExpressions as one of the most expensive calls (which gets called via MutatingScope->merge()): After thi...

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/4640

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d052b2db-3ae2-971c-3d21-3de4bd7a6551
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD658:1201C:85D743:B42BE4:6B00E07F
html-safe-nonce7dd43526ce164db35a14ae48ef24a6ccf578f4c4f02d6f1662706ebcda271c0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjU4OjEyMDFDOjg1RDc0MzpCNDJCRTQ6NkIwMEUwN0YiLCJ2aXNpdG9yX2lkIjoiMTk2NTAwMjMyNjMxODA0NzM1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb15a2ea08ce7338382481493e66959fa69901ea620c2f1acda65b5be807b6f1f
hovercard-subject-tagpull_request:3118181400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/4640/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf71f2e65c239e9ba2de0845b135e5447cd48bafeb670ae5ce225e5151d46e6e/phpstan/phpstan-src/pull/4640
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf71f2e65c239e9ba2de0845b135e5447cd48bafeb670ae5ce225e5151d46e6e/phpstan/phpstan-src/pull/4640
og:image:altIn the profiles of #4628 (comment) we can see MutatingScope->createConditionalExpressions as one of the most expensive calls (which gets called via MutatingScope->merge()): After this PR, we...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestaabm
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/4640#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4640
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4640
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/4640
Reloadhttps://github.com/phpstan/phpstan-src/pull/4640
Reloadhttps://github.com/phpstan/phpstan-src/pull/4640
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests186 (186)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
ondrejmirteshttps://github.com/ondrejmirtes
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
staabm:scope-copyhttps://github.com/staabm/phpstan-src/tree/scope-copy
Conversationhttps://github.com/phpstan/phpstan-src/pull/4640
Commits1 (1)https://github.com/phpstan/phpstan-src/pull/4640/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/4640/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/4640/files
Prevent unnecessary scope merginghttps://github.com/phpstan/phpstan-src/pull/4640#top
ondrejmirteshttps://github.com/ondrejmirtes
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
staabm:scope-copyhttps://github.com/staabm/phpstan-src/tree/scope-copy
https://github.com/staabm
staabmhttps://github.com/staabm
Dec 19, 2025https://github.com/phpstan/phpstan-src/pull/4640#issue-3748168080
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
#4628 (comment)https://github.com/phpstan/phpstan-src/pull/4628#issuecomment-3674032038
https://private-user-images.githubusercontent.com/120441/528704585-b2b22c21-a318-4bb5-b6cc-d188907d65a1.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyMTk4ODQsIm5iZiI6MTc5NTIxOTU4NCwicGF0aCI6Ii8xMjA0NDEvNTI4NzA0NTg1LWIyYjIyYzIxLWEzMTgtNGJiNS1iNmNjLWQxODg5MDdkNjVhMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTEyMVQwMDA2MjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOGI3N2NiMWRhNTJkMWU4NDkxODFkNjQ5ZGY5ZmQ5OGVmYzY2YzgyODNlZDc5N2Q3NjcwMDg0ODYxN2U3Y2NmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.3iuRJPicFQcQUbQh4hL-zFFG3bpN2psYjOTWpY81Bog
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/staabm
Prevent unnecessary scope merginghttps://github.com/phpstan/phpstan-src/pull/4640/commits/6469f22054fe7bb62ead451e5cf5ce127bb91172
6469f22https://github.com/phpstan/phpstan-src/pull/4640/commits/6469f22054fe7bb62ead451e5cf5ce127bb91172
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Dec 19, 2025 https://github.com/phpstan/phpstan-src/pull/4640#pullrequestreview-3599412106
View reviewed changes https://github.com/phpstan/phpstan-src/pull/4640/files/6469f22054fe7bb62ead451e5cf5ce127bb91172
ondrejmirteshttps://github.com/ondrejmirtes
https://github.com/phpstan/phpstan-src/pull/4640#pullrequestreview-3599412106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
src/Analyser/MutatingScope.phphttps://github.com/phpstan/phpstan-src/pull/4640/files/6469f22054fe7bb62ead451e5cf5ce127bb91172#diff-dc817f2bab8672057a95375a542e68599164f6ab2380e4cccd1b50583e295d85
ondrejmirteshttps://github.com/ondrejmirtes
Dec 19, 2025https://github.com/phpstan/phpstan-src/pull/4640#discussion_r2635764486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
staabmhttps://github.com/staabm
Dec 19, 2025https://github.com/phpstan/phpstan-src/pull/4640#discussion_r2635775451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Dec 19, 2025https://github.com/phpstan/phpstan-src/pull/4640#issuecomment-3675916706
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/staabm
staabmhttps://github.com/staabm
Dec 19, 2025 https://github.com/phpstan/phpstan-src/pull/4640#ref-pullrequest-3748306816
Fix MutatingScope->compareVariableTypeHolders() #4641 https://github.com/phpstan/phpstan-src/pull/4641
https://github.com/staabm
staabmhttps://github.com/staabm
Dec 20, 2025https://github.com/phpstan/phpstan-src/pull/4640#issuecomment-3677564111
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
7c49de5https://github.com/phpstan/phpstan-src/commit/7c49de5c4a75280ca14882d4a4b8832dc99bd522
Dec 20, 2025https://github.com/phpstan/phpstan-src/pull/4640#event-21683403721
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Dec 20, 2025https://github.com/phpstan/phpstan-src/pull/4640#issuecomment-3677575993
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Dec 20, 2025https://github.com/phpstan/phpstan-src/pull/4640#issuecomment-3677576568
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/staabm
staabmhttps://github.com/staabm
December 20, 2025 08:33https://github.com/phpstan/phpstan-src/pull/4640#event-21683509040
ondrejmirteshttps://github.com/ondrejmirtes
Nov 14, 2026 https://github.com/phpstan/phpstan-src/pull/4640#ref-commit-237c0ae
https://github.com/ondrejmirtes
Skip work in MutatingScope's hottest methods when the answer is knownhttps://github.com/phpstan/phpstan-src/commit/237c0ae3326c39d65ed251d1722a6e6457e09198
237c0aehttps://github.com/phpstan/phpstan-src/commit/237c0ae3326c39d65ed251d1722a6e6457e09198
#4640https://github.com/phpstan/phpstan-src/pull/4640
#4663https://github.com/phpstan/phpstan-src/pull/4663
#4726https://github.com/phpstan/phpstan-src/pull/4726
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4640
https://github.com/ondrejmirtes
ondrejmirtes https://github.com/ondrejmirtes
https://github.com/phpstan/phpstan-src/pull/4640/files/6469f22054fe7bb62ead451e5cf5ce127bb91172
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4640
https://github.com/staabm
https://github.com/ondrejmirtes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.