| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6979c8d3-7f50-0e7e-bbe2-cb51f6f9c5d3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 821A:ADA9D:1F71A5:29B199:6B00BEFD |
| html-safe-nonce | 302d0b340a23af38baebfa40f7245930900d42a17892cc6814896fba514c1860 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjFBOkFEQTlEOjFGNzFBNToyOUIxOTk6NkIwMEJFRkQiLCJ2aXNpdG9yX2lkIjoiNDYzNTc2ODMwMTI4MzIyOTQzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a4f118a018b21a19072e6166829ef7520a0e1793e8b05da478541cc1a9dccf99 |
| hovercard-subject-tag | pull_request:2839514169 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/4344/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2372c5f44d5b2440ae570c50054db24cbf241e32afc0fa77390e9fa0abd78ca9/phpstan/phpstan-src/pull/4344 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2372c5f44d5b2440ae570c50054db24cbf241e32afc0fa77390e9fa0abd78ca9/phpstan/phpstan-src/pull/4344 |
| og:image:alt | Fixes phpstan/phpstan#13444 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | biozshock |
| hostname | github.com |
| expected-hostname | github.com |
| None | 93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415 |
| turbo-cache-control | no-cache |
| go-import | github.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 219334214 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 219334214 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fee81a280ea86312b69448e261b418189bfd5b5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/phpstan/phpstan-src/pull/4344#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4344 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4344 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src |
| Reload | https://github.com/phpstan/phpstan-src/pull/4344 |
| Reload | https://github.com/phpstan/phpstan-src/pull/4344 |
| Reload | https://github.com/phpstan/phpstan-src/pull/4344 |
| phpstan | https://github.com/phpstan |
| phpstan-src | https://github.com/phpstan/phpstan-src |
| Code | https://github.com/phpstan/phpstan-src |
| Pull requests186 (186) | https://github.com/phpstan/phpstan-src/pulls |
| Actions | https://github.com/phpstan/phpstan-src/actions |
| Security and quality | https://github.com/phpstan/phpstan-src/security |
| Insights | https://github.com/phpstan/phpstan-src/insights |
| https://github.com/phpstan/phpstan-src |
| biozshock | https://github.com/biozshock |
| phpstan:2.1.x | https://github.com/phpstan/phpstan-src/tree/2.1.x |
| biozshock:fix-13444 | https://github.com/biozshock/phpstan-src/tree/fix-13444 |
| Conversation | https://github.com/phpstan/phpstan-src/pull/4344 |
| Commits1 (1) | https://github.com/phpstan/phpstan-src/pull/4344/commits |
| Checks | https://github.com/phpstan/phpstan-src/pull/4344/checks |
| Files changed | https://github.com/phpstan/phpstan-src/pull/4344/files |
| Mark Memcached:: methods as impure. | https://github.com/phpstan/phpstan-src/pull/4344#top |
| biozshock | https://github.com/biozshock |
| phpstan:2.1.x | https://github.com/phpstan/phpstan-src/tree/2.1.x |
| biozshock:fix-13444 | https://github.com/biozshock/phpstan-src/tree/fix-13444 |
|
| https://github.com/biozshock |
| biozshock | https://github.com/biozshock |
| Sep 18, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#issue-3429544446 |
| phpstan/phpstan#13444 | https://github.com/phpstan/phpstan/issues/13444 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
|
| https://github.com/biozshock |
| Mark Memcached:: methods as impure. | https://github.com/phpstan/phpstan-src/pull/4344/commits/b7370a099a6054e063b8a0d5b448ce69efd19577 |
| b7370a0 | https://github.com/phpstan/phpstan-src/pull/4344/commits/b7370a099a6054e063b8a0d5b448ce69efd19577 |
| https://github.com/biozshock |
| biozshock | https://github.com/biozshock |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/023fb7b5ae323b94ad8933c65e7a17089cc7bd40..b7370a099a6054e063b8a0d5b448ce69efd19577 |
| 023fb7b | https://github.com/phpstan/phpstan-src/commit/023fb7b5ae323b94ad8933c65e7a17089cc7bd40 |
| b7370a0 | https://github.com/phpstan/phpstan-src/commit/b7370a099a6054e063b8a0d5b448ce69efd19577 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/023fb7b5ae323b94ad8933c65e7a17089cc7bd40..b7370a099a6054e063b8a0d5b448ce69efd19577 |
| September 18, 2025 09:46 | https://github.com/phpstan/phpstan-src/pull/4344#event-19770639298 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
|
Sep 19, 2025
| https://github.com/phpstan/phpstan-src/pull/4344#pullrequestreview-3243923703 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/4344/files/b7370a099a6054e063b8a0d5b448ce69efd19577 |
| bin/functionMetadata_original.php | https://github.com/phpstan/phpstan-src/pull/4344/files/b7370a099a6054e063b8a0d5b448ce69efd19577#diff-36409e0c1cc1ea57082ef5591773531420f09ef2b99ed2d5e95c0bef3c56fc83 |
| VincentLanglet | https://github.com/VincentLanglet |
| Sep 19, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#discussion_r2362255450 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| biozshock | https://github.com/biozshock |
| Sep 20, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#discussion_r2365816243 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @VincentLanglet | https://github.com/VincentLanglet |
| https://www.php.net/manual/en/memcached.getserverbykey.php#refsect1-memcached.getserverbykey-returnvalues | https://www.php.net/manual/en/memcached.getserverbykey.php#refsect1-memcached.getserverbykey-returnvalues |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| VincentLanglet | https://github.com/VincentLanglet |
| Sep 20, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#discussion_r2365832570 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| biozshock | https://github.com/biozshock |
| Sep 20, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#discussion_r2365839389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @VincentLanglet | https://github.com/VincentLanglet |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
|
Oct 5, 2025
| https://github.com/phpstan/phpstan-src/pull/4344#ref-pullrequest-3484162746 |
|
Mark redis method as impure
#4409
| https://github.com/phpstan/phpstan-src/pull/4409 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| Oct 8, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-3382941585 |
| #4422 | https://github.com/phpstan/phpstan-src/pull/4422 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| https://github.com/biozshock |
| biozshock | https://github.com/biozshock |
| Oct 9, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-3384454257 |
| #4422 | https://github.com/phpstan/phpstan-src/pull/4422 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
| Oct 9, 2025 | https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-3384472259 |
| @biozshock | https://github.com/biozshock |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
|
Feb 10, 2026
| https://github.com/phpstan/phpstan-src/pull/4344#ref-pullrequest-3496631336 |
|
Introduce all-methods-are-(im)pure
#4422
| https://github.com/phpstan/phpstan-src/pull/4422 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
|
Apr 26, 2026
| https://github.com/phpstan/phpstan-src/pull/4344#ref-pullrequest-4330364183 |
|
Declare Memcached methods as impure
#5536
| https://github.com/phpstan/phpstan-src/pull/5536 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| Sep 20, 2026 | https://github.com/phpstan/phpstan-src/pull/4344#issuecomment-5748683974 |
| phpstan/phpstan#13444 | https://github.com/phpstan/phpstan/issues/13444 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
| https://github.com/VincentLanglet |
| VincentLanglet | https://github.com/VincentLanglet |
| Sep 20, 2026 | https://github.com/phpstan/phpstan-src/pull/4344#event-31475825560 |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4344 |
|
| https://github.com/VincentLanglet |
|
VincentLanglet
| https://github.com/VincentLanglet |
|
| https://github.com/phpstan/phpstan-src/pull/4344/files/b7370a099a6054e063b8a0d5b448ce69efd19577 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
|
Recognize the \Memcached::cas() can change the \Memcached::getResultCode()
| https://github.com/phpstan/phpstan/issues/13444 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/4344 |
|
| https://github.com/biozshock |
|
| https://github.com/VincentLanglet |
|
| https://github.com/ondrejmirtes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |