René's URL Explorer Experiment


Title: Fix missing detection of dead code in closures by staabm · Pull Request #4148 · phpstan/phpstan-src · GitHub

Open Graph Title: Fix missing detection of dead code in closures by staabm · Pull Request #4148 · phpstan/phpstan-src

X Title: Fix missing detection of dead code in closures by staabm · Pull Request #4148 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Fix missing detection of dead code in closures by staabm · Pull Request #4148 · phpstan/phpstan-src

Open Graph Description: followup to #4090 requires #4145

X Description: followup to #4090 requires #4145

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/4148

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3a2f555c-eeed-7fef-991b-903e2c0a8c17
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC40:3F8AB1:B13C10:E50B8C:6B00E64B
html-safe-nonce28fb91779f81950ec617c5fafee875035f0ef92cf49b616d1cde980253f8795e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzQwOjNGOEFCMTpCMTNDMTA6RTUwQjhDOjZCMDBFNjRCIiwidmlzaXRvcl9pZCI6IjM3NDgwNTc1MTM5MjExNDQzOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca71ccb55c51477de9f459287c8aaf3fda57aba4123f7c9c3b8ab980500d24782
hovercard-subject-tagpull_request:2685877976
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/4148/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/65bf076b14e35823505018dae49a017aa26998a5e2bb46aa2b742da7897378ce/phpstan/phpstan-src/pull/4148
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/65bf076b14e35823505018dae49a017aa26998a5e2bb46aa2b742da7897378ce/phpstan/phpstan-src/pull/4148
og:image:altfollowup to #4090 requires #4145
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestaabm
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/4148#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4148
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4148
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/4148
Reloadhttps://github.com/phpstan/phpstan-src/pull/4148
Reloadhttps://github.com/phpstan/phpstan-src/pull/4148
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests186 (186)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
ondrejmirteshttps://github.com/ondrejmirtes
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
staabm:closureshttps://github.com/staabm/phpstan-src/tree/closures
Conversationhttps://github.com/phpstan/phpstan-src/pull/4148
Commits5 (5)https://github.com/phpstan/phpstan-src/pull/4148/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/4148/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/4148/files
Fix missing detection of dead code in closureshttps://github.com/phpstan/phpstan-src/pull/4148#top
ondrejmirteshttps://github.com/ondrejmirtes
phpstan:2.1.xhttps://github.com/phpstan/phpstan-src/tree/2.1.x
staabm:closureshttps://github.com/staabm/phpstan-src/tree/closures
https://github.com/staabm
staabmhttps://github.com/staabm
Jul 22, 2025https://github.com/phpstan/phpstan-src/pull/4148#issue-3253036847
#4090https://github.com/phpstan/phpstan-src/pull/4090
#4145https://github.com/phpstan/phpstan-src/pull/4145
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
https://github.com/staabm
staabmhttps://github.com/staabm
force-pushedhttps://github.com/phpstan/phpstan-src/compare/f10c8509063f6c54f59c063096ffd4f9b5a1dbca..b00f40b1fe1c6d603120a616119819e64dadff09
f10c850https://github.com/phpstan/phpstan-src/commit/f10c8509063f6c54f59c063096ffd4f9b5a1dbca
b00f40bhttps://github.com/phpstan/phpstan-src/commit/b00f40b1fe1c6d603120a616119819e64dadff09
Compare https://github.com/phpstan/phpstan-src/compare/f10c8509063f6c54f59c063096ffd4f9b5a1dbca..b00f40b1fe1c6d603120a616119819e64dadff09
August 1, 2025 11:24https://github.com/phpstan/phpstan-src/pull/4148#event-18937810361
https://github.com/staabm
staabmhttps://github.com/staabm
Aug 1, 2025https://github.com/phpstan/phpstan-src/pull/4148#issuecomment-3144358648
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
@janedbalhttps://github.com/janedbal
1st callable is immediately invokedhttps://github.com/shipmonk-rnd/phpstan-rules/blob/9a2a033d12a516a73056bb215e6e4dec0dd33701/tests/Rule/data/ForbidCheckedExceptionInCallableRule/code.php#L106-L112
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
https://github.com/janedbal
janedbalhttps://github.com/janedbal
Aug 4, 2025https://github.com/phpstan/phpstan-src/pull/4148#issuecomment-3149447965
@staabmhttps://github.com/staabm
ThrowPoints of the closure might be gonehttps://github.com/shipmonk-rnd/phpstan-rules/blob/9a2a033d12a516a73056bb215e6e4dec0dd33701/src/Rule/ForbidCheckedExceptionInCallableRule.php#L201
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
https://github.com/staabm
staabmhttps://github.com/staabm
Aug 4, 2025https://github.com/phpstan/phpstan-src/pull/4148#issuecomment-3149578524
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
https://github.com/janedbal
janedbalhttps://github.com/janedbal
Aug 4, 2025https://github.com/phpstan/phpstan-src/pull/4148#issuecomment-3149646385
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
janedbalhttps://github.com/janedbal
Aug 4, 2025 https://github.com/phpstan/phpstan-src/pull/4148#ref-commit-7de329c
https://github.com/janedbal
ForbidCheckedExceptionInCallableRuleTest: Split test methods into ind…https://github.com/shipmonk-rnd/phpstan-rules/commit/7de329c63c1a311ef09c436af8b568f3989a23c8
7de329chttps://github.com/shipmonk-rnd/phpstan-rules/commit/7de329c63c1a311ef09c436af8b568f3989a23c8
phpstan/phpstan-src#4148https://github.com/phpstan/phpstan-src/pull/4148
https://github.com/janedbal
janedbalhttps://github.com/janedbal
Aug 4, 2025 https://github.com/phpstan/phpstan-src/pull/4148#ref-pullrequest-3288577063
ForbidCheckedExceptionInCallableRuleTest: Split test methods into individual test cases shipmonk-rnd/phpstan-rules#310 https://github.com/shipmonk-rnd/phpstan-rules/pull/310
janedbalhttps://github.com/janedbal
Aug 4, 2025 https://github.com/phpstan/phpstan-src/pull/4148#ref-commit-91a6a06
https://github.com/janedbal
integration-tests: use latest shipmonk/phpstan-ruleshttps://github.com/janedbal/phpstan/commit/91a6a061f43f22105a2203cfa0b4993b5a8b9422
91a6a06https://github.com/janedbal/phpstan/commit/91a6a061f43f22105a2203cfa0b4993b5a8b9422
phpstan/phpstan-src#4148 (comment)https://github.com/phpstan/phpstan-src/pull/4148#issuecomment-3149646385
https://github.com/janedbal
janedbalhttps://github.com/janedbal
Aug 4, 2025 https://github.com/phpstan/phpstan-src/pull/4148#ref-pullrequest-3288728728
integration-tests: use latest shipmonk/phpstan-rules phpstan/phpstan#13350 https://github.com/phpstan/phpstan/pull/13350
staabmhttps://github.com/staabm
August 4, 2025 18:20https://github.com/phpstan/phpstan-src/pull/4148#commits-pushed-e9b415f
https://github.com/staabm
Fix missing detection of dead code in closureshttps://github.com/phpstan/phpstan-src/pull/4148/commits/e9b415fdf5cc046daf8235f4d15a0effe4fdd0c2
e9b415fhttps://github.com/phpstan/phpstan-src/pull/4148/commits/e9b415fdf5cc046daf8235f4d15a0effe4fdd0c2
https://github.com/staabm
Update ExpressionResultTest.phphttps://github.com/phpstan/phpstan-src/pull/4148/commits/b6beb935a95760d0e30204adae150dd9b118883e
b6beb93https://github.com/phpstan/phpstan-src/pull/4148/commits/b6beb935a95760d0e30204adae150dd9b118883e
https://github.com/staabm
Update ExpressionResultTest.phphttps://github.com/phpstan/phpstan-src/pull/4148/commits/9df38e91ac1bc229715255d673ee32051c361b88
9df38e9https://github.com/phpstan/phpstan-src/pull/4148/commits/9df38e91ac1bc229715255d673ee32051c361b88
https://github.com/staabm
Update NodeScopeResolver.phphttps://github.com/phpstan/phpstan-src/pull/4148/commits/d6b744943958a1c52fa0beaf768c6635763b0fcc
d6b7449https://github.com/phpstan/phpstan-src/pull/4148/commits/d6b744943958a1c52fa0beaf768c6635763b0fcc
https://github.com/staabm
Update ExpressionResultTest.phphttps://github.com/phpstan/phpstan-src/pull/4148/commits/f2608e1787ffd34e84fb97124fc668a43dcec3da
f2608e1https://github.com/phpstan/phpstan-src/pull/4148/commits/f2608e1787ffd34e84fb97124fc668a43dcec3da
https://github.com/staabm
staabmhttps://github.com/staabm
force-pushedhttps://github.com/phpstan/phpstan-src/compare/23a2b41585b52be36b345dfb88b0262eee1b158d..f2608e1787ffd34e84fb97124fc668a43dcec3da
23a2b41https://github.com/phpstan/phpstan-src/commit/23a2b41585b52be36b345dfb88b0262eee1b158d
f2608e1https://github.com/phpstan/phpstan-src/commit/f2608e1787ffd34e84fb97124fc668a43dcec3da
Compare https://github.com/phpstan/phpstan-src/compare/23a2b41585b52be36b345dfb88b0262eee1b158d..f2608e1787ffd34e84fb97124fc668a43dcec3da
August 4, 2025 16:22https://github.com/phpstan/phpstan-src/pull/4148#event-18974239019
https://github.com/staabm
staabmhttps://github.com/staabm
August 4, 2025 16:27https://github.com/phpstan/phpstan-src/pull/4148#event-18974317870
https://github.com/phpstan-bot
phpstan-bothttps://github.com/phpstan-bot
Aug 4, 2025https://github.com/phpstan/phpstan-src/pull/4148#issuecomment-3151446043
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
6b2473ahttps://github.com/phpstan/phpstan-src/commit/6b2473a801bcde83c014530ba5a702577cdc8478
Aug 4, 2025https://github.com/phpstan/phpstan-src/pull/4148#event-18974344083
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Aug 4, 2025https://github.com/phpstan/phpstan-src/pull/4148#issuecomment-3151450600
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
https://github.com/staabm
staabmhttps://github.com/staabm
August 4, 2025 16:30https://github.com/phpstan/phpstan-src/pull/4148#event-18974359948
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F4148
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/4148
https://github.com/staabm
https://github.com/janedbal
https://github.com/phpstan-bot
https://github.com/ondrejmirtes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.