| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8ecf9302-2c42-b8ae-5adf-882c81552c40 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8010:26ECEB:73D1F0:96FB29:6B00D478 |
| html-safe-nonce | 715cc9307d2aa63bd23acac7e5cafeb494bbbdb080ea64a17c44b766d8e1b180 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDEwOjI2RUNFQjo3M0QxRjA6OTZGQjI5OjZCMDBENDc4IiwidmlzaXRvcl9pZCI6IjMwNTQwMzA4MjM2ODc3NzEyNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f1a2446408c2c3c41398c761dbb165d38597f7d82e459b66b41faceb59fa6fa8 |
| hovercard-subject-tag | pull_request:1480575083 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/2577/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6b28e034dd3bb69ce9ef4b8da68f070ea0f7618d54b48e1b92a8e110972409bc/phpstan/phpstan-src/pull/2577 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6b28e034dd3bb69ce9ef4b8da68f070ea0f7618d54b48e1b92a8e110972409bc/phpstan/phpstan-src/pull/2577 |
| og:image:alt | The goal of this PR is to fix https://phpstan.org/r/c17b503c-a789-4d90-87a7-31f3436f1b68 .
These issues were also fixed:
nullable lost outside guarding if-statement phpstan#9105
Wrong type assumpt... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | schlndh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5 |
| turbo-cache-control | no-cache |
| go-import | github.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 219334214 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 219334214 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4943239a6d2c591325dad6e5c313e1cafda877f6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/phpstan/phpstan-src/pull/2577#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F2577 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F2577 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src |
| Reload | https://github.com/phpstan/phpstan-src/pull/2577 |
| Reload | https://github.com/phpstan/phpstan-src/pull/2577 |
| Reload | https://github.com/phpstan/phpstan-src/pull/2577 |
| phpstan | https://github.com/phpstan |
| phpstan-src | https://github.com/phpstan/phpstan-src |
| Code | https://github.com/phpstan/phpstan-src |
| Pull requests186 (186) | https://github.com/phpstan/phpstan-src/pulls |
| Actions | https://github.com/phpstan/phpstan-src/actions |
| Security and quality | https://github.com/phpstan/phpstan-src/security |
| Insights | https://github.com/phpstan/phpstan-src/insights |
| https://github.com/phpstan/phpstan-src |
| ondrejmirtes | https://github.com/ondrejmirtes |
| phpstan:1.10.x | https://github.com/phpstan/phpstan-src/tree/1.10.x |
| schlndh:fix-nullsafeCallGreaterThanScalar | https://github.com/schlndh/phpstan-src/tree/fix-nullsafeCallGreaterThanScalar |
| Conversation | https://github.com/phpstan/phpstan-src/pull/2577 |
| Commits5 (5) | https://github.com/phpstan/phpstan-src/pull/2577/commits |
| Checks | https://github.com/phpstan/phpstan-src/pull/2577/checks |
| Files changed | https://github.com/phpstan/phpstan-src/pull/2577/files |
| Fix several issues with nullsafe type specification | https://github.com/phpstan/phpstan-src/pull/2577#top |
| ondrejmirtes | https://github.com/ondrejmirtes |
| phpstan:1.10.x | https://github.com/phpstan/phpstan-src/tree/1.10.x |
| schlndh:fix-nullsafeCallGreaterThanScalar | https://github.com/schlndh/phpstan-src/tree/fix-nullsafeCallGreaterThanScalar |
|
| https://github.com/schlndh |
| schlndh | https://github.com/schlndh |
| Aug 18, 2023 | https://github.com/phpstan/phpstan-src/pull/2577#issue-1856714903 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
| https://phpstan.org/r/c17b503c-a789-4d90-87a7-31f3436f1b68 | https://phpstan.org/r/c17b503c-a789-4d90-87a7-31f3436f1b68 |
| nullable lost outside guarding if-statement phpstan#9105 | https://github.com/phpstan/phpstan/issues/9105 |
| Wrong type assumptions phpstan#5172 | https://github.com/phpstan/phpstan/issues/5172 |
| Wrong not-null type after using null coalescing operator with nullsafe property access phpstan#8517 | https://github.com/phpstan/phpstan/issues/8517 |
| Possibly null object is wrongly enforced as non null. phpstan#7980 | https://github.com/phpstan/phpstan/issues/7980 |
| Wrong error Using nullsafe method call on non-nullable type phpstan#8664 | https://github.com/phpstan/phpstan/issues/8664 |
| Type B|null gets narrowed to type B when calling a method that returns mixed phpstan#9293 | https://github.com/phpstan/phpstan/issues/9293 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
| schlndh | https://github.com/schlndh |
| August 19, 2023 08:56 | https://github.com/phpstan/phpstan-src/pull/2577#commits-pushed-99cecba |
|
| https://github.com/schlndh |
| fix specified type for nullsafe vs scalar comparison | https://github.com/phpstan/phpstan-src/pull/2577/commits/99cecba7e4ac1c6aeee0e1ca215c8f91ce9b2f3b |
| 99cecba | https://github.com/phpstan/phpstan-src/pull/2577/commits/99cecba7e4ac1c6aeee0e1ca215c8f91ce9b2f3b |
|
| https://github.com/schlndh |
| add tests for other fixed issues | https://github.com/phpstan/phpstan-src/pull/2577/commits/8abe3dd646342c1146bd44e92f6220c16a6784db |
| 8abe3dd | https://github.com/phpstan/phpstan-src/pull/2577/commits/8abe3dd646342c1146bd44e92f6220c16a6784db |
|
| https://github.com/schlndh |
| fix bug 8517 | https://github.com/phpstan/phpstan-src/pull/2577/commits/283b40ba324ad69380cb51c6ff5df7cc8d7c63e0 |
| 283b40b | https://github.com/phpstan/phpstan-src/pull/2577/commits/283b40ba324ad69380cb51c6ff5df7cc8d7c63e0 |
| https://github.com/schlndh |
| schlndh | https://github.com/schlndh |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/050fd243d91ce8d2d19ea7742c69561ba01639c4..162e3e329011291a22f35d0fe7064375a3574ab1 |
| 050fd24 | https://github.com/phpstan/phpstan-src/commit/050fd243d91ce8d2d19ea7742c69561ba01639c4 |
| 162e3e3 | https://github.com/phpstan/phpstan-src/commit/162e3e329011291a22f35d0fe7064375a3574ab1 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/050fd243d91ce8d2d19ea7742c69561ba01639c4..162e3e329011291a22f35d0fe7064375a3574ab1 |
| August 19, 2023 06:56 | https://github.com/phpstan/phpstan-src/pull/2577#event-10135531193 |
|
| https://github.com/schlndh |
| add tests for more fixed issues | https://github.com/phpstan/phpstan-src/pull/2577/commits/12bc2c16c533e16c8f90b68c3c6c6ab61fdcbaa8 |
| 12bc2c1 | https://github.com/phpstan/phpstan-src/pull/2577/commits/12bc2c16c533e16c8f90b68c3c6c6ab61fdcbaa8 |
| https://github.com/schlndh |
| schlndh | https://github.com/schlndh |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/162e3e329011291a22f35d0fe7064375a3574ab1..12bc2c16c533e16c8f90b68c3c6c6ab61fdcbaa8 |
| 162e3e3 | https://github.com/phpstan/phpstan-src/commit/162e3e329011291a22f35d0fe7064375a3574ab1 |
| 12bc2c1 | https://github.com/phpstan/phpstan-src/commit/12bc2c16c533e16c8f90b68c3c6c6ab61fdcbaa8 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/162e3e329011291a22f35d0fe7064375a3574ab1..12bc2c16c533e16c8f90b68c3c6c6ab61fdcbaa8 |
| August 19, 2023 07:02 | https://github.com/phpstan/phpstan-src/pull/2577#event-10135541133 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
| Aug 19, 2023 | https://github.com/phpstan/phpstan-src/pull/2577#issuecomment-1684922929 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
|
Aug 19, 2023
| https://github.com/phpstan/phpstan-src/pull/2577#pullrequestreview-1585630661 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/2577/files/12bc2c16c533e16c8f90b68c3c6c6ab61fdcbaa8 |
| ondrejmirtes | https://github.com/ondrejmirtes |
| https://github.com/phpstan/phpstan-src/pull/2577#pullrequestreview-1585630661 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
| Aug 19, 2023 | https://github.com/phpstan/phpstan-src/pull/2577#issuecomment-1684923332 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
|
| https://github.com/schlndh |
| move tests out of AnalyserIntegrationTest | https://github.com/phpstan/phpstan-src/pull/2577/commits/2cd8400e2cafa0ff1cd3c79e354742698dc024ad |
| 2cd8400 | https://github.com/phpstan/phpstan-src/pull/2577/commits/2cd8400e2cafa0ff1cd3c79e354742698dc024ad |
| https://github.com/schlndh |
| schlndh | https://github.com/schlndh |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/83a0825b6d274031110e8bc4e8f396586da58400..2cd8400e2cafa0ff1cd3c79e354742698dc024ad |
| 83a0825 | https://github.com/phpstan/phpstan-src/commit/83a0825b6d274031110e8bc4e8f396586da58400 |
| 2cd8400 | https://github.com/phpstan/phpstan-src/commit/2cd8400e2cafa0ff1cd3c79e354742698dc024ad |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/83a0825b6d274031110e8bc4e8f396586da58400..2cd8400e2cafa0ff1cd3c79e354742698dc024ad |
| August 19, 2023 12:34 | https://github.com/phpstan/phpstan-src/pull/2577#event-10135974221 |
| https://github.com/schlndh |
| schlndh | https://github.com/schlndh |
| Aug 19, 2023 | https://github.com/phpstan/phpstan-src/pull/2577#issuecomment-1684936884 |
| @ondrejmirtes | https://github.com/ondrejmirtes |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
|
Aug 19, 2023
| https://github.com/phpstan/phpstan-src/pull/2577#pullrequestreview-1585639681 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/2577/files/2cd8400e2cafa0ff1cd3c79e354742698dc024ad |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
| d435f65 | https://github.com/phpstan/phpstan-src/commit/d435f658ec7526c44f12b0d0509a5f3d64ce9607 |
| Aug 19, 2023 | https://github.com/phpstan/phpstan-src/pull/2577#event-10136032348 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
| Aug 19, 2023 | https://github.com/phpstan/phpstan-src/pull/2577#issuecomment-1684942464 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
|
nullable lost outside guarding if-statement
phpstan/phpstan#9105
| https://github.com/phpstan/phpstan/issues/9105 |
|
Wrong type assumptions
phpstan/phpstan#5172
| https://github.com/phpstan/phpstan/issues/5172 |
|
Wrong not-null type after using null coalescing operator with nullsafe property access
phpstan/phpstan#8517
| https://github.com/phpstan/phpstan/issues/8517 |
|
Possibly null object is wrongly enforced as non null.
phpstan/phpstan#7980
| https://github.com/phpstan/phpstan/issues/7980 |
|
Wrong error Using nullsafe method call on non-nullable type
phpstan/phpstan#8664
| https://github.com/phpstan/phpstan/issues/8664 |
|
Type B|null gets narrowed to type B when calling a method that returns mixed
phpstan/phpstan#9293
| https://github.com/phpstan/phpstan/issues/9293 |
| https://github.com/herndlm |
| herndlm | https://github.com/herndlm |
| Aug 19, 2023 | https://github.com/phpstan/phpstan-src/pull/2577#issuecomment-1685055089 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
| https://github.com/schlndh |
| schlndh | https://github.com/schlndh |
| August 19, 2023 17:23 | https://github.com/phpstan/phpstan-src/pull/2577#event-10136730132 |
| https://github.com/ToshY |
| ToshY | https://github.com/ToshY |
|
Oct 2, 2023
| https://github.com/phpstan/phpstan-src/pull/2577#ref-issue-1922038280 |
|
Using nullsafe method call on non-nullable type mixed
phpstan/phpstan#9965
| https://github.com/phpstan/phpstan/issues/9965 |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F2577 |
|
| https://github.com/ondrejmirtes |
|
ondrejmirtes
| https://github.com/ondrejmirtes |
|
| https://github.com/phpstan/phpstan-src/pull/2577/files/2cd8400e2cafa0ff1cd3c79e354742698dc024ad |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/2577 |
|
| https://github.com/schlndh |
|
| https://github.com/ondrejmirtes |
|
| https://github.com/herndlm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |