Title: False positive missing call to parent when setUp never returns · Issue #292 · phpstan/phpstan-phpunit · GitHub
Open Graph Title: False positive missing call to parent when setUp never returns · Issue #292 · phpstan/phpstan-phpunit
X Title: False positive missing call to parent when setUp never returns · Issue #292 · phpstan/phpstan-phpunit
Description: When creating a test that has a setup method that never returns (e.g. because the whole test should be skipped), PHPStan will complain that the parent::setUp() should be called. In this case, we have to choose between either setting up t...
Open Graph Description: When creating a test that has a setup method that never returns (e.g. because the whole test should be skipped), PHPStan will complain that the parent::setUp() should be called. In this case, we ha...
X Description: When creating a test that has a setup method that never returns (e.g. because the whole test should be skipped), PHPStan will complain that the parent::setUp() should be called. In this case, we ha...
Opengraph URL: https://github.com/phpstan/phpstan-phpunit/issues/292
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"False positive missing call to parent when setUp never returns","articleBody":"When creating a test that has a setup method that never returns (e.g. because the whole test should be skipped), PHPStan will complain that the `parent::setUp()` should be called. \n\nIn this case, we have to choose between either setting up the parent before we skip the test (doing useless work in the process), setting up the parent after the skip, which will trigger an error about dead code, or baselining the original error. All of these solutions seem wrong to me and I think in this PHPStan just shouldn't tell you to call the parent.\n\nExample:\n\n```php\nfinal class MyTest extends TestCase\n{\n protected function setUp(): never\n {\n self::markTestSkipped('Currently broken due to XYZ');\n }\n}\n```","author":{"url":"https://github.com/axlon","@type":"Person","name":"axlon"},"datePublished":"2026-04-16T13:57:35Z","url":"https://github.com/phpstan/phpstan-phpunit/issues/292"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cd390ff6-c67a-53c6-ff08-1c10ad62bc98 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 906E:330B9D:350A86:486229:6B006BA1 |
| html-safe-nonce | 49baf19fe878027a68aca83ce9b93ef45cc0e77eaf70cdb513afdb732b9ef5f9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDZFOjMzMEI5RDozNTBBODY6NDg2MjI5OjZCMDA2QkExIiwidmlzaXRvcl9pZCI6IjIzNDM3NjgwNDAzODM5OTg4ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 44c11623e94ada5ee441004ba79d58cc81e283052fec0d459edebda95858ef5d |
| hovercard-subject-tag | issue:4276208851 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/phpstan/phpstan-phpunit/292/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0a5fb0d6e7bebdbeff92c3a7d41f0e18d71a20895c373ffca70dad13c849db0a/phpstan/phpstan-phpunit/issues/292 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0a5fb0d6e7bebdbeff92c3a7d41f0e18d71a20895c373ffca70dad13c849db0a/phpstan/phpstan-phpunit/issues/292 |
| og:image:alt | When creating a test that has a setup method that never returns (e.g. because the whole test should be skipped), PHPStan will complain that the parent::setUp() should be called. In this case, we ha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | axlon |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa |
| turbo-cache-control | no-preview |
| go-import | github.com/phpstan/phpstan-phpunit git https://github.com/phpstan/phpstan-phpunit.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 105883921 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-phpunit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 105883921 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-phpunit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width