René's URL Explorer Experiment


Title: Parent call inside a try-catch block(which is always executed) isn't recognised. · Issue #187 · phpstan/phpstan-phpunit · GitHub

Open Graph Title: Parent call inside a try-catch block(which is always executed) isn't recognised. · Issue #187 · phpstan/phpstan-phpunit

X Title: Parent call inside a try-catch block(which is always executed) isn't recognised. · Issue #187 · phpstan/phpstan-phpunit

Description: So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpunit doesn't recognise as a valid call to t...

Open Graph Description: So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpuni...

X Description: So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpuni...

Opengraph URL: https://github.com/phpstan/phpstan-phpunit/issues/187

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Parent call inside a try-catch block(which is always executed) isn't recognised.","articleBody":"So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which `phpstan-phpunit` doesn't recognise as a valid call to the parent method.\r\n\r\n```\r\n/**\r\n\r\n{@inheritdoc}\r\n*/\r\nprotected function tearDown(): void {\r\n  try {\r\n    parent::tearDown();\r\n  }\r\n  catch (\\Exception $exception) {\r\n    if (!(get_class($exception) === get_class($this->expectedTearDownException) && $exception->getMessage() === \r\n    $this->expectedTearDownException->getMessage())) {\r\n    throw $exception;\r\n  }\r\n}\r\n}\r\n```\r\nphpstan doesn't have this bug i checked in independently https://phpstan.org/r/1a212fa2-3cba-4c82-80db-7c75a8346f50\r\n\r\nThe main issue seems to be in \r\n`$hasParentCall = $this->hasParentClassCall($node->getOriginalNode()->getStmts(), strtolower($methodName));\r\n`\r\n```\r\n\t\tif (!$hasParentCall) {\r\n\t\t\treturn [\r\n\t\t\t\tRuleErrorBuilder::message(\r\n\t\t\t\t\tsprintf('Missing call to parent::%s() method.', $methodName)\r\n\t\t\t\t)->build(),\r\n\t\t\t];\r\n\t\t}\r\n```\r\n\r\nMainly `\\PHPStan\\Rules\\PHPUnit\\ShouldCallParentMethodsRule::hasParentClassCall`\r\n\r\nI think this lacks the logic to detect parent class calls inside a try-catch block.\r\n","author":{"url":"https://github.com/omkar-podey","@type":"Person","name":"omkar-podey"},"datePublished":"2023-05-23T10:58:15Z","url":"https://github.com/phpstan/phpstan-phpunit/issues/187"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6570afab-f9ad-4c63-a923-acc598334378
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE4D6:25F127:36275F:49C817:6B006C0E
html-safe-nonce246ca6e17af9725e4ee80bc278a097c1c49398d397c90d4dacceed141c3f077e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEQ2OjI1RjEyNzozNjI3NUY6NDlDODE3OjZCMDA2QzBFIiwidmlzaXRvcl9pZCI6IjEwMjgyMDE3OTc5Mjk0MzAwMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca686039f528e7bcfeb3fda673e38df10cffdaf3881c235b4c5ed124931640d2f
hovercard-subject-tagissue:1721808736
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/phpstan/phpstan-phpunit/187/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4eee38904e655241dd136de21142e11301844cdb749a6740482edb4430364db3/phpstan/phpstan-phpunit/issues/187
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4eee38904e655241dd136de21142e11301844cdb749a6740482edb4430364db3/phpstan/phpstan-phpunit/issues/187
og:image:altSo, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpuni...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameomkar-podey
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-preview
go-importgithub.com/phpstan/phpstan-phpunit git https://github.com/phpstan/phpstan-phpunit.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id105883921
octolytics-dimension-repository_nwophpstan/phpstan-phpunit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id105883921
octolytics-dimension-repository_network_root_nwophpstan/phpstan-phpunit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/phpstan/phpstan-phpunit/issues/187#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-phpunit%2Fissues%2F187
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-phpunit%2Fissues%2F187
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=phpstan%2Fphpstan-phpunit
Reloadhttps://github.com/phpstan/phpstan-phpunit/issues/187
Reloadhttps://github.com/phpstan/phpstan-phpunit/issues/187
Reloadhttps://github.com/phpstan/phpstan-phpunit/issues/187
phpstanhttps://github.com/phpstan
phpstan-phpunithttps://github.com/phpstan/phpstan-phpunit
Codehttps://github.com/phpstan/phpstan-phpunit
Issues34 (34)https://github.com/phpstan/phpstan-phpunit/issues
Pull requests7 (7)https://github.com/phpstan/phpstan-phpunit/pulls
Actionshttps://github.com/phpstan/phpstan-phpunit/actions
Projectshttps://github.com/phpstan/phpstan-phpunit/projects
Security and qualityhttps://github.com/phpstan/phpstan-phpunit/security
Insightshttps://github.com/phpstan/phpstan-phpunit/insights
https://github.com/phpstan/phpstan-phpunit
New issuehttps://github.com/login?return_to=https://github.com/phpstan/phpstan-phpunit/issues/187
New issuehttps://github.com/login?return_to=https://github.com/phpstan/phpstan-phpunit/issues/187
Parent call inside a try-catch block(which is always executed) isn't recognised.https://github.com/phpstan/phpstan-phpunit/issues/187#top
https://github.com/omkar-podey
omkar-podeyhttps://github.com/omkar-podey
on May 23, 2023https://github.com/phpstan/phpstan-phpunit/issues/187#issue-1721808736
https://phpstan.org/r/1a212fa2-3cba-4c82-80db-7c75a8346f50https://phpstan.org/r/1a212fa2-3cba-4c82-80db-7c75a8346f50
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
on May 23, 2023https://github.com/phpstan/phpstan-phpunit/issues/187#issuecomment-1559133196
Sign up for freehttps://github.com/signup?return_to=https://github.com/phpstan/phpstan-phpunit/issues/187
Sign in to commenthttps://github.com/login?return_to=https://github.com/phpstan/phpstan-phpunit/issues/187
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.