Title: Parent call inside a try-catch block(which is always executed) isn't recognised. · Issue #187 · phpstan/phpstan-phpunit · GitHub
Open Graph Title: Parent call inside a try-catch block(which is always executed) isn't recognised. · Issue #187 · phpstan/phpstan-phpunit
X Title: Parent call inside a try-catch block(which is always executed) isn't recognised. · Issue #187 · phpstan/phpstan-phpunit
Description: So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpunit doesn't recognise as a valid call to t...
Open Graph Description: So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpuni...
X Description: So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpuni...
Opengraph URL: https://github.com/phpstan/phpstan-phpunit/issues/187
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Parent call inside a try-catch block(which is always executed) isn't recognised.","articleBody":"So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which `phpstan-phpunit` doesn't recognise as a valid call to the parent method.\r\n\r\n```\r\n/**\r\n\r\n{@inheritdoc}\r\n*/\r\nprotected function tearDown(): void {\r\n try {\r\n parent::tearDown();\r\n }\r\n catch (\\Exception $exception) {\r\n if (!(get_class($exception) === get_class($this->expectedTearDownException) && $exception->getMessage() === \r\n $this->expectedTearDownException->getMessage())) {\r\n throw $exception;\r\n }\r\n}\r\n}\r\n```\r\nphpstan doesn't have this bug i checked in independently https://phpstan.org/r/1a212fa2-3cba-4c82-80db-7c75a8346f50\r\n\r\nThe main issue seems to be in \r\n`$hasParentCall = $this->hasParentClassCall($node->getOriginalNode()->getStmts(), strtolower($methodName));\r\n`\r\n```\r\n\t\tif (!$hasParentCall) {\r\n\t\t\treturn [\r\n\t\t\t\tRuleErrorBuilder::message(\r\n\t\t\t\t\tsprintf('Missing call to parent::%s() method.', $methodName)\r\n\t\t\t\t)->build(),\r\n\t\t\t];\r\n\t\t}\r\n```\r\n\r\nMainly `\\PHPStan\\Rules\\PHPUnit\\ShouldCallParentMethodsRule::hasParentClassCall`\r\n\r\nI think this lacks the logic to detect parent class calls inside a try-catch block.\r\n","author":{"url":"https://github.com/omkar-podey","@type":"Person","name":"omkar-podey"},"datePublished":"2023-05-23T10:58:15Z","url":"https://github.com/phpstan/phpstan-phpunit/issues/187"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6570afab-f9ad-4c63-a923-acc598334378 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E4D6:25F127:36275F:49C817:6B006C0E |
| html-safe-nonce | 246ca6e17af9725e4ee80bc278a097c1c49398d397c90d4dacceed141c3f077e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEQ2OjI1RjEyNzozNjI3NUY6NDlDODE3OjZCMDA2QzBFIiwidmlzaXRvcl9pZCI6IjEwMjgyMDE3OTc5Mjk0MzAwMzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a686039f528e7bcfeb3fda673e38df10cffdaf3881c235b4c5ed124931640d2f |
| hovercard-subject-tag | issue:1721808736 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/phpstan/phpstan-phpunit/187/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4eee38904e655241dd136de21142e11301844cdb749a6740482edb4430364db3/phpstan/phpstan-phpunit/issues/187 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4eee38904e655241dd136de21142e11301844cdb749a6740482edb4430364db3/phpstan/phpstan-phpunit/issues/187 |
| og:image:alt | So, I am overriding tearDown() and as the rule suggests i need to call the parent::teardown() inside it , the only problem here is that i want to call it from a try-catch block which phpstan-phpuni... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | omkar-podey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa |
| turbo-cache-control | no-preview |
| go-import | github.com/phpstan/phpstan-phpunit git https://github.com/phpstan/phpstan-phpunit.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 105883921 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-phpunit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 105883921 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-phpunit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width