| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ca7a5584-b175-3bbe-6f96-82a87fb03e9c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84FA:3401DB:E3F97:13E8C3:6B006363 |
| html-safe-nonce | 1eb78ef387218b6efed36f148a009471fac8fe9e1249026fb31a97a566edf402 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEZBOjM0MDFEQjpFM0Y5NzoxM0U4QzM6NkIwMDYzNjMiLCJ2aXNpdG9yX2lkIjoiNzcyNzExNjU3MzU5MjI4MTk1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e2cf7ab97835b1b87f2ce638dc9b2fb35af95acff1c6e8fb85739b5b48ffa5e0 |
| hovercard-subject-tag | pull_request:3308711073 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/phpstan/phpdoc-parser/pull/293/files |
| twitter:image | https://avatars.githubusercontent.com/u/9115419?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9115419?s=400&v=4 |
| og:image:alt | See phpstan/phpstan#7545
From what I understood, we first need phpdoc-parser to be able to parse things like @return ($this->t is T::A ? string : null) and then we'll need follow-up PR to p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/phpstan/phpdoc-parser git https://github.com/phpstan/phpdoc-parser.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 111290081 |
| octolytics-dimension-repository_nwo | phpstan/phpdoc-parser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 111290081 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpdoc-parser |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4f5c239e31f1f680e6bbc419ff92d774da616ec |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/phpstan/phpdoc-parser/pull/293/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpdoc-parser%2Fpull%2F293%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpdoc-parser%2Fpull%2F293%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=phpstan%2Fphpdoc-parser |
| Reload | https://github.com/phpstan/phpdoc-parser/pull/293/files |
| Reload | https://github.com/phpstan/phpdoc-parser/pull/293/files |
| Reload | https://github.com/phpstan/phpdoc-parser/pull/293/files |
| phpstan | https://github.com/phpstan |
| phpdoc-parser | https://github.com/phpstan/phpdoc-parser |
| Code | https://github.com/phpstan/phpdoc-parser |
| Issues7 (7) | https://github.com/phpstan/phpdoc-parser/issues |
| Pull requests14 (14) | https://github.com/phpstan/phpdoc-parser/pulls |
| Actions | https://github.com/phpstan/phpdoc-parser/actions |
| Projects | https://github.com/phpstan/phpdoc-parser/projects |
| Security and quality | https://github.com/phpstan/phpdoc-parser/security |
| Insights | https://github.com/phpstan/phpdoc-parser/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fphpstan%2Fphpdoc-parser%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fphpstan%2Fphpdoc-parser%2Fissues%2Fnew%2Fchoose |
| brambaud | https://github.com/brambaud |
| phpstan:2.3.x | https://github.com/phpstan/phpdoc-parser/tree/2.3.x |
| brambaud:issue/phpstan-src-7545/conditional-return-type-support-this | https://github.com/brambaud/phpdoc-parser/tree/issue/phpstan-src-7545/conditional-return-type-support-this |
|
Conversation
1
| https://github.com/phpstan/phpdoc-parser/pull/293 |
|
Commits
1
| https://github.com/phpstan/phpdoc-parser/pull/293/commits |
|
Checks
51
| https://github.com/phpstan/phpdoc-parser/pull/293/checks |
|
Files changed
| https://github.com/phpstan/phpdoc-parser/pull/293/files |
| Please reload this page | https://github.com/phpstan/phpdoc-parser/pull/293/files |
|
feat: add support for property access in conditional types
| https://github.com/phpstan/phpdoc-parser/pull/293/files#top |
|
Show all changes
1 commit
| https://github.com/phpstan/phpdoc-parser/pull/293/files |
|
d5ac20e
feat: add support for property access in conditional types
brambaud Feb 20, 2026
| https://github.com/phpstan/phpdoc-parser/pull/293/commits/d5ac20e6c801f2ad0484e819d7ab5f14b82662c8 |
|
Clear filters
| https://github.com/phpstan/phpdoc-parser/pull/293/files |
| Please reload this page | https://github.com/phpstan/phpdoc-parser/pull/293/files |
| Please reload this page | https://github.com/phpstan/phpdoc-parser/pull/293/files |
|
ConditionalTypeForPropertyNode.php
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-1fc20e01c712fe63aa241ab6a5e76c4f58b4cd97d1a8c77cff5daf9c52f4cc1a |
|
PropertyAccessNode.php
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-51b66eaec0f8f9c43db8181c975b4d0e26ba8b517b1bd7d9b26b7788a8575fb9 |
|
PropertyAccessPathItem.php
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-0617ba033165761345c0f38a4b10f20b5dfdff2a5a0697bec63a59354faab66d |
|
Lexer.php
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-5b2a6ad326ef6352f776b19087e035f332c2c60673c6ca09c0c06fb4080e9097 |
|
TypeParser.php
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-8310d893400b80c480ffe6d8b59b25a546791c2bb8c6eb03454869d14aecf666 |
|
Printer.php
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-b363ae918f8fc38470412b221b8b7d4e42632542713d776ce34d06961a83d62c |
|
TypeParserTest.php
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-1f8ca9548d16a6ae6a38225df681a13d39762d18ad9d8b65a21fa6b141a76192 |
| src/Ast/Type/ConditionalTypeForPropertyNode.php | https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-1fc20e01c712fe63aa241ab6a5e76c4f58b4cd97d1a8c77cff5daf9c52f4cc1a |
|
View file
| https://github.com/phpstan/phpdoc-parser/blob/d5ac20e6c801f2ad0484e819d7ab5f14b82662c8/src/Ast/Type/ConditionalTypeForPropertyNode.php |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpdoc-parser/pull/293/{{ revealButtonHref }} |
| src/Ast/Type/PropertyAccessNode.php | https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-51b66eaec0f8f9c43db8181c975b4d0e26ba8b517b1bd7d9b26b7788a8575fb9 |
|
View file
| https://github.com/phpstan/phpdoc-parser/blob/d5ac20e6c801f2ad0484e819d7ab5f14b82662c8/src/Ast/Type/PropertyAccessNode.php |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpdoc-parser/pull/293/{{ revealButtonHref }} |
| src/Ast/Type/PropertyAccessPathItem.php | https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-0617ba033165761345c0f38a4b10f20b5dfdff2a5a0697bec63a59354faab66d |
|
View file
| https://github.com/phpstan/phpdoc-parser/blob/d5ac20e6c801f2ad0484e819d7ab5f14b82662c8/src/Ast/Type/PropertyAccessPathItem.php |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpdoc-parser/pull/293/{{ revealButtonHref }} |
| src/Lexer/Lexer.php | https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-5b2a6ad326ef6352f776b19087e035f332c2c60673c6ca09c0c06fb4080e9097 |
|
View file
| https://github.com/phpstan/phpdoc-parser/blob/d5ac20e6c801f2ad0484e819d7ab5f14b82662c8/src/Lexer/Lexer.php |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpdoc-parser/pull/293/{{ revealButtonHref }} |
|
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-5b2a6ad326ef6352f776b19087e035f332c2c60673c6ca09c0c06fb4080e9097 |
|
| https://github.com/phpstan/phpdoc-parser/pull/293/files#diff-5b2a6ad326ef6352f776b19087e035f332c2c60673c6ca09c0c06fb4080e9097 |
| Please reload this page | https://github.com/phpstan/phpdoc-parser/pull/293/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |