René's URL Explorer Experiment


Title: resolveDeprecatedTag incorrectly grabs multiline deprecation messages · Issue #25 · phpstan/phpdoc-parser · GitHub

Open Graph Title: resolveDeprecatedTag incorrectly grabs multiline deprecation messages · Issue #25 · phpstan/phpdoc-parser

X Title: resolveDeprecatedTag incorrectly grabs multiline deprecation messages · Issue #25 · phpstan/phpdoc-parser

Description: Identified in phpstan/phpstan#1983 I provided some faulty logic in \PHPStan\PhpDoc\PhpDocNodeResolver::resolveDeprecatedTag. The $key value is always 0, not the original index of the key amongst its neighbors. The goal was to take the cu...

Open Graph Description: Identified in phpstan/phpstan#1983 I provided some faulty logic in \PHPStan\PhpDoc\PhpDocNodeResolver::resolveDeprecatedTag. The $key value is always 0, not the original index of the key amongst it...

X Description: Identified in phpstan/phpstan#1983 I provided some faulty logic in \PHPStan\PhpDoc\PhpDocNodeResolver::resolveDeprecatedTag. The $key value is always 0, not the original index of the key amongst it...

Opengraph URL: https://github.com/phpstan/phpdoc-parser/issues/25

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"resolveDeprecatedTag incorrectly grabs multiline deprecation messages","articleBody":"Identified in https://github.com/phpstan/phpstan/pull/1983\r\n\r\nI provided some faulty logic in \\PHPStan\\PhpDoc\\PhpDocNodeResolver::resolveDeprecatedTag. The `$key` value is always `0`, not the original index of the key amongst its neighbors. The goal was to take the current key and find all entries below it, rebuilding the multiple line message.\r\n\r\n```\r\n\tprivate function resolveDeprecatedTag(PhpDocNode $phpDocNode, NameScope $nameScope): ?\\PHPStan\\PhpDoc\\Tag\\DeprecatedTag\r\n\t{\r\n\t\tforeach ($phpDocNode->getDeprecatedTagValues() as $key => $deprecatedTagValue) {\r\n\t\t\t$totalChildren = count($phpDocNode->children);\r\n\t\t\t/** @var \\PHPStan\\PhpDocParser\\Ast\\PhpDoc\\PhpDocTextNode[] $textNodes */\r\n\t\t\t$textNodes = array_filter($phpDocNode->children, static function (PhpDocChildNode $child): bool {\r\n\t\t\t\treturn $child instanceof PhpDocTextNode;\r\n\t\t\t});\r\n\t\t\t$deprecatedMessage = $deprecatedTagValue->description;\r\n\t\t\tif (count($textNodes) > 0) {\r\n\t\t\t\tfor ($i = $key; $i \u003c $totalChildren; $i++) {\r\n\t\t\t\t\t// Skip invalid children.\r\n\t\t\t\t\tif (!isset($textNodes[$i])) {\r\n\t\t\t\t\t\tcontinue;\r\n\t\t\t\t\t}\r\n\t\t\t\t\t$textNodeText = trim($textNodes[$i]->text);\r\n\t\t\t\t\t// Break at the first empty new line, as this is probably\r\n\t\t\t\t\t// leading to a new tag and no longer part of the multiline\r\n\t\t\t\t\t// deprecation message.\r\n\t\t\t\t\tif ($textNodeText === '') {\r\n\t\t\t\t\t\tbreak;\r\n\t\t\t\t\t}\r\n\t\t\t\t\t$deprecatedMessage .= ' ' . $textNodeText;\r\n\t\t\t\t}\r\n\t\t\t}\r\n\t\t\t$deprecatedMessage = trim($deprecatedMessage);\r\n\t\t\treturn new DeprecatedTag($deprecatedMessage === '' ? null : $deprecatedMessage);\r\n\t\t}\r\n\r\n\t\treturn null;\r\n\t}\r\n```","author":{"url":"https://github.com/mglaman","@type":"Person","name":"mglaman"},"datePublished":"2019-04-24T13:33:11Z","url":"https://github.com/phpstan/phpdoc-parser/issues/25"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:494f8cfa-c2ab-859c-6fac-da6f07eaf936
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9CCE:2AB36C:38C05B:4D6156:6B006D1C
html-safe-nonce802b60fc92fa98b2400620260f4dbd8ea92b377caa350b7b2192ca7c84cee5f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0NFOjJBQjM2QzozOEMwNUI6NEQ2MTU2OjZCMDA2RDFDIiwidmlzaXRvcl9pZCI6IjY1NDYxNjIxNDgxNTY5MjcyNjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac198bba4a029f6a8178c5a1c201bb9c320ca1b67a633c478aba2b56c3fed5ffcf
hovercard-subject-tagissue:436699994
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/phpstan/phpdoc-parser/25/issue_layout
twitter:imagehttps://opengraph.githubassets.com/55e4c8c1178d0efbcd36bf6cde78ca3551f91dad5eb8c11b59f0d4ea4b727652/phpstan/phpdoc-parser/issues/25
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/55e4c8c1178d0efbcd36bf6cde78ca3551f91dad5eb8c11b59f0d4ea4b727652/phpstan/phpdoc-parser/issues/25
og:image:altIdentified in phpstan/phpstan#1983 I provided some faulty logic in \PHPStan\PhpDoc\PhpDocNodeResolver::resolveDeprecatedTag. The $key value is always 0, not the original index of the key amongst it...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemglaman
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-preview
go-importgithub.com/phpstan/phpdoc-parser git https://github.com/phpstan/phpdoc-parser.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id111290081
octolytics-dimension-repository_nwophpstan/phpdoc-parser
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id111290081
octolytics-dimension-repository_network_root_nwophpstan/phpdoc-parser
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/phpstan/phpdoc-parser/issues/25#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpdoc-parser%2Fissues%2F25
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpdoc-parser%2Fissues%2F25
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=phpstan%2Fphpdoc-parser
Reloadhttps://github.com/phpstan/phpdoc-parser/issues/25
Reloadhttps://github.com/phpstan/phpdoc-parser/issues/25
Reloadhttps://github.com/phpstan/phpdoc-parser/issues/25
phpstanhttps://github.com/phpstan
phpdoc-parserhttps://github.com/phpstan/phpdoc-parser
Codehttps://github.com/phpstan/phpdoc-parser
Issues7 (7)https://github.com/phpstan/phpdoc-parser/issues
Pull requests14 (14)https://github.com/phpstan/phpdoc-parser/pulls
Actionshttps://github.com/phpstan/phpdoc-parser/actions
Projectshttps://github.com/phpstan/phpdoc-parser/projects
Security and qualityhttps://github.com/phpstan/phpdoc-parser/security
Insightshttps://github.com/phpstan/phpdoc-parser/insights
https://github.com/phpstan/phpdoc-parser
New issuehttps://github.com/login?return_to=https://github.com/phpstan/phpdoc-parser/issues/25
New issuehttps://github.com/login?return_to=https://github.com/phpstan/phpdoc-parser/issues/25
resolveDeprecatedTag incorrectly grabs multiline deprecation messageshttps://github.com/phpstan/phpdoc-parser/issues/25#top
https://github.com/mglaman
mglamanhttps://github.com/mglaman
on Apr 24, 2019https://github.com/phpstan/phpdoc-parser/issues/25#issue-436699994
phpstan/phpstan#1983https://github.com/phpstan/phpstan/pull/1983
https://github.com/mglaman
mglamanhttps://github.com/mglaman
on Apr 24, 2019https://github.com/phpstan/phpdoc-parser/issues/25#issuecomment-486234541
mglamanhttps://github.com/mglaman
completedhttps://github.com/phpstan/phpdoc-parser/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 24, 2019https://github.com/phpstan/phpdoc-parser/issues/25#event-2297232820
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on May 1, 2021https://github.com/phpstan/phpdoc-parser/issues/25#issuecomment-830472293
github-actionshttps://github.com/apps/github-actions
on May 1, 2021https://github.com/phpstan/phpdoc-parser/issues/25#event-4672551741
Sign up for freehttps://github.com/signup?return_to=https://github.com/phpstan/phpdoc-parser/issues/25
Sign in to commenthttps://github.com/login?return_to=https://github.com/phpstan/phpdoc-parser/issues/25
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.