Title: Refactor TokenList by kamil-tekiela · Pull Request #504 · phpmyadmin/sql-parser · GitHub
Open Graph Title: Refactor TokenList by kamil-tekiela · Pull Request #504 · phpmyadmin/sql-parser
X Title: Refactor TokenList by kamil-tekiela · Pull Request #504 · phpmyadmin/sql-parser
Description: Tokens class was not used anywhere in PMA project. It's very likely broken. It has serious feature envy on TokensList. The two methods had very unclear purpose and behaviour. The build() method in TokensList is now split into static and non-static variants. The reason for this is that CreateStatement is ready yet to use TokensList and it has to use an array instead. To make it less confusing, the new method is called buildFromArray which better reflects the purpose of the static method. This requires a small change in the main PMA repo. The build() method never actually accepted strings. It seems it was done only out of laziness in unit tests. The $length parameter isn't used anywhere, so I see no reason to keep it around. Edit: I had to revert change to AlterOperation because the property is used publicly in JsonSerializer.
Open Graph Description: Tokens class was not used anywhere in PMA project. It's very likely broken. It has serious feature envy on TokensList. The two methods had very unclear purpose and behaviour. The build() method...
X Description: Tokens class was not used anywhere in PMA project. It's very likely broken. It has serious feature envy on TokensList. The two methods had very unclear purpose and behaviour. The build() me...
Opengraph URL: https://github.com/phpmyadmin/sql-parser/pull/504
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:ec834690-e0f6-ec9c-4ac8-85da05feeaad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D634:18B8BA:C20695:10DC3C8:6996DC6A |
| html-safe-nonce | aa73d47b4a9ce83de6819eb0e731fab7a2f3dfc5805bf4742c30521c48b4f35d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjM0OjE4QjhCQTpDMjA2OTU6MTBEQzNDODo2OTk2REM2QSIsInZpc2l0b3JfaWQiOiI1MTIzMzg4MDI0NDEyMzYzODgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d02e88882b645c01471590179ec385de0e53c2b7525100a78cd5df47d70738f5 |
| hovercard-subject-tag | pull_request:1496282971 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/phpmyadmin/sql-parser/pull/504/commits/49e122ff51c427fdd8b386d8b4a7cbac12f6a26c |
| twitter:image | https://avatars.githubusercontent.com/u/6583064?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6583064?s=400&v=4 |
| og:image:alt | Tokens class was not used anywhere in PMA project. It's very likely broken. It has serious feature envy on TokensList. The two methods had very unclear purpose and behaviour. The build() method... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/phpmyadmin/sql-parser git https://github.com/phpmyadmin/sql-parser.git |
| octolytics-dimension-user_id | 1351977 |
| octolytics-dimension-user_login | phpmyadmin |
| octolytics-dimension-repository_id | 36256604 |
| octolytics-dimension-repository_nwo | phpmyadmin/sql-parser |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36256604 |
| octolytics-dimension-repository_network_root_nwo | phpmyadmin/sql-parser |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1c98ba212ddfc3e30024d245fa7d1030145c2e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width