René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"factories use container as service locator and uses classnames as keys..","articleBody":"I just stumbled over the middleware and was surprised that the docs said it supports psr-11, wondering what  it would load through it.\r\n\r\nA quick look at the code revealed several issues:\r\n * the factory classes all use the container in a ServiceLocator anti-pattern, which is discouraged in [psr-11 section.13](https://www.php-fig.org/psr/psr-11).\r\n* the identifier within the container is a classname, a better way would be to use an interface here, and then have the classes implementing the service stored for that interface.\r\n* for configuration the key \"config\" is used, which might conflict with the config of some frameworks, furthermore, there is no clear interface, o and even worse the provided ConfigProvider is final, and loads static confic files from its own config dir, that are meant for a specific framework, thus making it a necessity to replace the not-mentioned interfaceless config provider with your own.\r\n","author":{"url":"https://github.com/ppetermann","@type":"Person","name":"ppetermann"},"datePublished":"2018-08-25T17:39:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/23/phpdebugbar/issues/23"}