René's URL Explorer Experiment


Title: Implement Result::getQueryResult() by simon-mundy · Pull Request #14 · php-db/phpdb-pgsql · GitHub

Open Graph Title: Implement Result::getQueryResult() by simon-mundy · Pull Request #14 · php-db/phpdb-pgsql

X Title: Implement Result::getQueryResult() by simon-mundy · Pull Request #14 · php-db/phpdb-pgsql

Description: Summary Fixes #12. Driver\ResultInterface::getQueryResult() arrived in php-db/phpdb#172 and Pgsql\Result never implemented it, so loading the class was a fatal and composer update followed by composer test failed before a single test ran. Implemented as Pdo\Result does upstream: guard on isQueryResult(), clone the given prototype or a default ResultSet, initialize it from this result. php-db/phpdb 0.6.x-dev requires php ^8.3, so the lock cannot pick up the interface change while the package still allows 8.2. The php constraint, config.platform.php and the PhpStan check in .laminas-ci.json move to 8.3 with it. That is part of #10, brought forward here because the fix cannot install otherwise. Test plan test/unit/ResultTest.php covers the seeded result set, the prototype clone and the rejection, using PhpDbTestAsset\Pgsql\ResultStub to answer isQueryResult() and getFieldCount() — the only two methods getQueryResult() reaches that read the pgsql resource, which needs a live connection. test/integration/ResultTest.php covers the real path through the native driver: a select seeding a result set with the right field count and rows, and SET search_path TO public as a statement with no fields. phpcs, phpstan and the unit suite pass. The integration suite has not been run locally — no Postgres available here — so it runs for the first time in CI. Notes Ordering: this should land before #11, which is blocked on it. Six of that PR's matrix legs fail with this fatal, and its codecov and mutation-test jobs stay skipped while any test leg is red. #11 then rebases and drops its own copy of the php constraint change. composer audit reports a high-severity command injection advisory against squizlabs/php_codesniffer (CVE-2026-67434, fixed in 3.13.6). It arrives through laminas/laminas-coding-standard, which #11 removes, so no fix here.

Open Graph Description: Summary Fixes #12. Driver\ResultInterface::getQueryResult() arrived in php-db/phpdb#172 and Pgsql\Result never implemented it, so loading the class was a fatal and composer update followed by compo...

X Description: Summary Fixes #12. Driver\ResultInterface::getQueryResult() arrived in php-db/phpdb#172 and Pgsql\Result never implemented it, so loading the class was a fatal and composer update followed by compo...

Opengraph URL: https://github.com/php-db/phpdb-pgsql/pull/14

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:608b64a8-47a6-346e-e6fd-b908ea2b29ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id824C:340182:2A937B:3BD11C:6AFD740F
html-safe-noncee634d05883d652c55357ef79a70c6f4c5b15cd0b681fc96f5f958dc74c448ff1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjRDOjM0MDE4MjoyQTkzN0I6M0JEMTFDOjZBRkQ3NDBGIiwidmlzaXRvcl9pZCI6Ijc0ODY4NjI5MTkxNjY5NDgzNjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac89c458d02e973753516726931be1f77168cb988fd7dff9fcc091531fe8ad7a08
hovercard-subject-tagpull_request:4345692694
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/php-db/phpdb-pgsql/pull/14/files
twitter:imagehttps://avatars.githubusercontent.com/u/46739456?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/46739456?s=400&v=4
og:image:altSummary Fixes #12. Driver\ResultInterface::getQueryResult() arrived in php-db/phpdb#172 and Pgsql\Result never implemented it, so loading the class was a fatal and composer update followed by compo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee54006cf2b96d1ac260960edd10003132911469ccd1ec99c9803119fe2a4e032
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/php-db/phpdb-pgsql git https://github.com/php-db/phpdb-pgsql.git
octolytics-dimension-user_id219474457
octolytics-dimension-user_loginphp-db
octolytics-dimension-repository_id946781573
octolytics-dimension-repository_nwophp-db/phpdb-pgsql
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id946781573
octolytics-dimension-repository_network_root_nwophp-db/phpdb-pgsql
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5be0bf2b8cf26f8897d31e6bc3c232d328b12a54
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/php-db/phpdb-pgsql/pull/14/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb-pgsql%2Fpull%2F14%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb-pgsql%2Fpull%2F14%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=php-db%2Fphpdb-pgsql
Reloadhttps://github.com/php-db/phpdb-pgsql/pull/14/files
Reloadhttps://github.com/php-db/phpdb-pgsql/pull/14/files
Reloadhttps://github.com/php-db/phpdb-pgsql/pull/14/files
php-dbhttps://github.com/php-db
phpdb-pgsqlhttps://github.com/php-db/phpdb-pgsql
Codehttps://github.com/php-db/phpdb-pgsql
Issues2 (2)https://github.com/php-db/phpdb-pgsql/issues
Pull requests1 (1)https://github.com/php-db/phpdb-pgsql/pulls
Actionshttps://github.com/php-db/phpdb-pgsql/actions
Projectshttps://github.com/php-db/phpdb-pgsql/projects
Security and qualityhttps://github.com/php-db/phpdb-pgsql/security
Insightshttps://github.com/php-db/phpdb-pgsql/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fphp-db%2Fphpdb-pgsql%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fphp-db%2Fphpdb-pgsql%2Fissues%2Fnew%2Fchoose
simon-mundyhttps://github.com/simon-mundy
php-db:0.1.xhttps://github.com/php-db/phpdb-pgsql/tree/0.1.x
simon-mundy:result-get-query-resulthttps://github.com/simon-mundy/phpdb-pgsql/tree/result-get-query-result
Conversation 0 https://github.com/php-db/phpdb-pgsql/pull/14
Commits 2 https://github.com/php-db/phpdb-pgsql/pull/14/commits
Checks 12 https://github.com/php-db/phpdb-pgsql/pull/14/checks
Files changed https://github.com/php-db/phpdb-pgsql/pull/14/files
Please reload this pagehttps://github.com/php-db/phpdb-pgsql/pull/14/files
Implement Result::getQueryResult() https://github.com/php-db/phpdb-pgsql/pull/14/files#top
Show all changes 2 commits https://github.com/php-db/phpdb-pgsql/pull/14/files
88681e7 Implement Result::getQueryResult() simon-mundy Aug 24, 2026 https://github.com/php-db/phpdb-pgsql/pull/14/commits/88681e7542101e9cb5f58fe8f336093fe2018ec1
f7ccb24 Require phpstan ^2.2 and drop the two stale implode baseline entries simon-mundy Aug 24, 2026 https://github.com/php-db/phpdb-pgsql/pull/14/commits/f7ccb24e12460a2170d7d4d96eabb59f869172ea
Clear filters https://github.com/php-db/phpdb-pgsql/pull/14/files
Please reload this pagehttps://github.com/php-db/phpdb-pgsql/pull/14/files
Please reload this pagehttps://github.com/php-db/phpdb-pgsql/pull/14/files
.laminas-ci.json https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3fb49ad00d3736f1ca8276f568f5d8bbe8c1604f6187ab5ecf921e1012f47c98
composer.json https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
composer.lock https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5
phpstan-baseline.neon https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-995edee38ad4f8387e58ebd52c31bcc04c56cc2448d331b1cf5e0b35c57b9efa
Result.php https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3411303ebfd2f5ea55e9ee70a50839526be61465bc070f6814749753da4e2085
ResultStub.php https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-f7271924295f70dc7ebe85f5ee0d05e2c6b60bd9b13884b1470e44ea42747f5d
ResultTest.php https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3b183a90d8a0a0b17f3a7fdd25f06c5b79c9dd5e2404f62292edb01c40d8e57e
ResultTest.php https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-d1e9cd4cf8f1cdeb00c555a18ce43a10a6761e804e385578dd5adc2c987e24bb
.laminas-ci.jsonhttps://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3fb49ad00d3736f1ca8276f568f5d8bbe8c1604f6187ab5ecf921e1012f47c98
View file https://github.com/simon-mundy/phpdb-pgsql/blob/f7ccb24e12460a2170d7d4d96eabb59f869172ea/.laminas-ci.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php-db/phpdb-pgsql/pull/14/{{ revealButtonHref }}
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3fb49ad00d3736f1ca8276f568f5d8bbe8c1604f6187ab5ecf921e1012f47c98
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3fb49ad00d3736f1ca8276f568f5d8bbe8c1604f6187ab5ecf921e1012f47c98
composer.jsonhttps://github.com/php-db/phpdb-pgsql/pull/14/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
View file https://github.com/simon-mundy/phpdb-pgsql/blob/f7ccb24e12460a2170d7d4d96eabb59f869172ea/composer.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php-db/phpdb-pgsql/pull/14/{{ revealButtonHref }}
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34
composer.lockhttps://github.com/php-db/phpdb-pgsql/pull/14/files#diff-f37acfaa6b11f575a9a6f41a75fa73a61d0f8ebc2c9b8cddc215d8aca10e44f5
View file https://github.com/simon-mundy/phpdb-pgsql/blob/f7ccb24e12460a2170d7d4d96eabb59f869172ea/composer.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/php-db/phpdb-pgsql/pull/14/files
phpstan-baseline.neonhttps://github.com/php-db/phpdb-pgsql/pull/14/files#diff-995edee38ad4f8387e58ebd52c31bcc04c56cc2448d331b1cf5e0b35c57b9efa
View file https://github.com/simon-mundy/phpdb-pgsql/blob/f7ccb24e12460a2170d7d4d96eabb59f869172ea/phpstan-baseline.neon
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php-db/phpdb-pgsql/pull/14/{{ revealButtonHref }}
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-995edee38ad4f8387e58ebd52c31bcc04c56cc2448d331b1cf5e0b35c57b9efa
src/Result.phphttps://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3411303ebfd2f5ea55e9ee70a50839526be61465bc070f6814749753da4e2085
View file https://github.com/simon-mundy/phpdb-pgsql/blob/f7ccb24e12460a2170d7d4d96eabb59f869172ea/src/Result.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php-db/phpdb-pgsql/pull/14/{{ revealButtonHref }}
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3411303ebfd2f5ea55e9ee70a50839526be61465bc070f6814749753da4e2085
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3411303ebfd2f5ea55e9ee70a50839526be61465bc070f6814749753da4e2085
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3411303ebfd2f5ea55e9ee70a50839526be61465bc070f6814749753da4e2085
https://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3411303ebfd2f5ea55e9ee70a50839526be61465bc070f6814749753da4e2085
test/asset/ResultStub.phphttps://github.com/php-db/phpdb-pgsql/pull/14/files#diff-f7271924295f70dc7ebe85f5ee0d05e2c6b60bd9b13884b1470e44ea42747f5d
View file https://github.com/simon-mundy/phpdb-pgsql/blob/f7ccb24e12460a2170d7d4d96eabb59f869172ea/test/asset/ResultStub.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php-db/phpdb-pgsql/pull/14/{{ revealButtonHref }}
test/integration/ResultTest.phphttps://github.com/php-db/phpdb-pgsql/pull/14/files#diff-3b183a90d8a0a0b17f3a7fdd25f06c5b79c9dd5e2404f62292edb01c40d8e57e
View file https://github.com/simon-mundy/phpdb-pgsql/blob/f7ccb24e12460a2170d7d4d96eabb59f869172ea/test/integration/ResultTest.php
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php-db/phpdb-pgsql/pull/14/{{ revealButtonHref }}
Please reload this pagehttps://github.com/php-db/phpdb-pgsql/pull/14/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.