René's URL Explorer Experiment


Title: Mago compliance: settle the API decisions behind remaining src analyzer issues by simon-mundy · Pull Request #255 · php-db/phpdb · GitHub

Open Graph Title: Mago compliance: settle the API decisions behind remaining src analyzer issues by simon-mundy · Pull Request #255 · php-db/phpdb

X Title: Mago compliance: settle the API decisions behind remaining src analyzer issues by simon-mundy · Pull Request #255 · php-db/phpdb

Description: Database abstraction layer, SQL abstraction, result set abstraction, and RowDataGateway and TableDataGateway implementations - Mago compliance: settle the API decisions behind remaining src analyzer issues by simon-mundy · Pull Request #255 · php-db/phpdb

Open Graph Description: Mago compliance, part 3 of 12: the analyzer issues that needed an API decision rather than a mechanical fix. Each commit settles one decision. The analyzer baseline goes from 197 entries to 170 and...

X Description: Mago compliance, part 3 of 12: the analyzer issues that needed an API decision rather than a mechanical fix. Each commit settles one decision. The analyzer baseline goes from 197 entries to 170 and...

Opengraph URL: https://github.com/php-db/phpdb/pull/255

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a36b2d3-4a5c-fa40-6c0d-607effed190b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3CE:33E80C:1276E:18CD5:6AFD6551
html-safe-nonceaa2af64433a29d2334647bd7992d5f36e47cc4caedba616041c7251f0c6e8ae7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0NFOjMzRTgwQzoxMjc2RToxOENENTo2QUZENjU1MSIsInZpc2l0b3JfaWQiOiI2NjM5NjcwNjg1NzcxNTg4OTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccbaae1706f6fa6725479db3a3c0552b6f660208cf7a3bf75e75a2a67316d41ae
hovercard-subject-tagpull_request:5365927345
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/255/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/629e9c306b8a8721ec582a3a5a2ad07d748942d5c0760526274fb9a21e69cc3e/php-db/phpdb/pull/255
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/629e9c306b8a8721ec582a3a5a2ad07d748942d5c0760526274fb9a21e69cc3e/php-db/phpdb/pull/255
og:image:altMago compliance, part 3 of 12: the analyzer issues that needed an API decision rather than a mechanical fix. Each commit settles one decision. The analyzer baseline goes from 197 entries to 170 and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesimon-mundy
hostnamegithub.com
expected-hostnamegithub.com
None42a67d7c7488271ca8d7e6dc3942424e6de3bff43b1ed4a9c6f0e1a69b73b389
turbo-cache-controlno-cache
go-importgithub.com/php-db/phpdb git https://github.com/php-db/phpdb.git
octolytics-dimension-user_id219474457
octolytics-dimension-user_loginphp-db
octolytics-dimension-repository_id879488168
octolytics-dimension-repository_nwophp-db/phpdb
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id879488168
octolytics-dimension-repository_network_root_nwophp-db/phpdb
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5c3779ac05f3590d8d7ea0c02b14e678ae8179ae
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/php-db/phpdb/pull/255#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F255
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F255
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb
Reloadhttps://github.com/php-db/phpdb/pull/255
Reloadhttps://github.com/php-db/phpdb/pull/255
Reloadhttps://github.com/php-db/phpdb/pull/255
php-dbhttps://github.com/php-db
phpdbhttps://github.com/php-db/phpdb
Codehttps://github.com/php-db/phpdb
Issues34 (34)https://github.com/php-db/phpdb/issues
Pull requests8 (8)https://github.com/php-db/phpdb/pulls
Discussionshttps://github.com/php-db/phpdb/discussions
Actionshttps://github.com/php-db/phpdb/actions
Projectshttps://github.com/php-db/phpdb/projects
Security and qualityhttps://github.com/php-db/phpdb/security
Insightshttps://github.com/php-db/phpdb/insights
https://github.com/php-db/phpdb
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:qa/mago-api-decisionshttps://github.com/simon-mundy/phpdb/tree/qa/mago-api-decisions
Conversationhttps://github.com/php-db/phpdb/pull/255
Commits9 (9)https://github.com/php-db/phpdb/pull/255/commits
Checkshttps://github.com/php-db/phpdb/pull/255/checks
Files changedhttps://github.com/php-db/phpdb/pull/255/files
Mago compliance: settle the API decisions behind remaining src analyzer issueshttps://github.com/php-db/phpdb/pull/255#top
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:qa/mago-api-decisionshttps://github.com/simon-mundy/phpdb/tree/qa/mago-api-decisions
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Nov 17, 2026https://github.com/php-db/phpdb/pull/255#issue-6455220364
Bring TableGateway and RowGateway to Mago compliance #233https://github.com/php-db/phpdb/pull/233
Configure mago guard to enforce the library's layering #249https://github.com/php-db/phpdb/pull/249
Clear Mago findings in the Sql platform layer #252https://github.com/php-db/phpdb/pull/252
Clear the non-BC Mago findings in Container, Adapter and ResultSet #253https://github.com/php-db/phpdb/pull/253
Clear the Mago lint findings in the test suite #254https://github.com/php-db/phpdb/pull/254
Please reload this pagehttps://github.com/php-db/phpdb/pull/255
simon-mundyhttps://github.com/simon-mundy
November 17, 2026 21:28https://github.com/php-db/phpdb/pull/255#commits-pushed-9f97438
https://github.com/simon-mundy
Declare native return types on getHelpers() and getResource()https://github.com/php-db/phpdb/pull/255/commits/9f974387d8193fcf70caacabe998fe8613e47d01
9f97438https://github.com/php-db/phpdb/pull/255/commits/9f974387d8193fcf70caacabe998fe8613e47d01
https://github.com/simon-mundy
Type Pdo\Result's properties and make next() return voidhttps://github.com/php-db/phpdb/pull/255/commits/3704b68f81050c5d685a5aff26d2808e0437983c
3704b68https://github.com/php-db/phpdb/pull/255/commits/3704b68f81050c5d685a5aff26d2808e0437983c
https://github.com/simon-mundy
Type Profiler's $profiles and $currentIndex propertieshttps://github.com/php-db/phpdb/pull/255/commits/a41888f1e4813470043ff91e03682cbeb2d51a21
a41888fhttps://github.com/php-db/phpdb/pull/255/commits/a41888f1e4813470043ff91e03682cbeb2d51a21
https://github.com/simon-mundy
Make AbstractPdo::getResultPrototype() non-nullablehttps://github.com/php-db/phpdb/pull/255/commits/ceddedb6911bf533efbb135a7d0053304010a56b
ceddedbhttps://github.com/php-db/phpdb/pull/255/commits/ceddedb6911bf533efbb135a7d0053304010a56b
https://github.com/simon-mundy
Name ParameterContainer's ArrayAccess parameter $offsethttps://github.com/php-db/phpdb/pull/255/commits/ba5e96e795be8762ec467088b3d39b72c02cd69c
ba5e96ehttps://github.com/php-db/phpdb/pull/255/commits/ba5e96e795be8762ec467088b3d39b72c02cd69c
https://github.com/simon-mundy
Tag extensible classes @api instead of making them finalhttps://github.com/php-db/phpdb/pull/255/commits/d81303a94d0c9370c6d0f5fe21118e63a3133e7a
d81303ahttps://github.com/php-db/phpdb/pull/255/commits/d81303a94d0c9370c6d0f5fe21118e63a3133e7a
php-db#248https://github.com/php-db/phpdb/pull/248
https://github.com/simon-mundy
Accept FactoryInterface's container type in the abstract adapter factoryhttps://github.com/php-db/phpdb/pull/255/commits/72dc42ae9dfecb8f799fff35783bb651c95e00ea
72dc42ahttps://github.com/php-db/phpdb/pull/255/commits/72dc42ae9dfecb8f799fff35783bb651c95e00ea
https://github.com/simon-mundy
Count AbstractResultSet's first row without casting mixed to arrayhttps://github.com/php-db/phpdb/pull/255/commits/1a32f744e591b4b059520a9653311b28bf6439b3
1a32f74https://github.com/php-db/phpdb/pull/255/commits/1a32f744e591b4b059520a9653311b28bf6439b3
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Nov 17, 2026https://github.com/php-db/phpdb/pull/255#issuecomment-6962530841
Codecovhttps://app.codecov.io/gh/php-db/phpdb/pull/255?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/php-db/phpdb/pull/255
Bring Mago back to green against phpdb 0.6.x php-db/phpdb-mysql#87 https://github.com/php-db/phpdb-mysql/pull/87
Bring Mago back to green against phpdb 0.6.x php-db/phpdb-pgsql#16 https://github.com/php-db/phpdb-pgsql/pull/16
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 17, 2026 23:38https://github.com/php-db/phpdb/pull/255#event-36468283996
started reviewinghttps://github.com/php-db/phpdb/sessions/4a39ddd7-65a9-4003-b016-332257bd0234
simon-mundyhttps://github.com/simon-mundy
November 17, 2026 23:39https://github.com/php-db/phpdb/pull/255#event-36468313262
View session https://github.com/php-db/phpdb/sessions/4a39ddd7-65a9-4003-b016-332257bd0234
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 17, 2026 https://github.com/php-db/phpdb/pull/255#pullrequestreview-5948516722
View reviewed changes https://github.com/php-db/phpdb/pull/255/files/1a32f744e591b4b059520a9653311b28bf6439b3
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/php-db/phpdb/pull/255#pullrequestreview-5948516722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Document the actual fallback counting behaviorhttps://github.com/php-db/phpdb/pull/255#discussion_r4607302904
Please reload this pagehttps://github.com/php-db/phpdb/pull/255
src/ResultSet/AbstractResultSet.phphttps://github.com/php-db/phpdb/pull/255/files/1a32f744e591b4b059520a9653311b28bf6439b3#diff-8b9863458b0ac65210ea095907fcc634f58bb21f7fbb1b7e3c270b1c63fade81
Please reload this pagehttps://github.com/php-db/phpdb/pull/255
https://github.com/simon-mundy
Describe getFieldCount()'s counting as it is implementedhttps://github.com/php-db/phpdb/pull/255/commits/b8b1e19eb74650b74d4da75e0071fc0817fe220a
b8b1e19https://github.com/php-db/phpdb/pull/255/commits/b8b1e19eb74650b74d4da75e0071fc0817fe220a
https://github.co/hiddenchars
https://github.com/php-db/phpdb/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F255
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/php-db/phpdb/pull/255/files/1a32f744e591b4b059520a9653311b28bf6439b3
Please reload this pagehttps://github.com/php-db/phpdb/pull/255
Please reload this pagehttps://github.com/php-db/phpdb/pull/255
https://github.com/simon-mundy
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.