| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0a36b2d3-4a5c-fa40-6c0d-607effed190b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D3CE:33E80C:1276E:18CD5:6AFD6551 |
| html-safe-nonce | aa2af64433a29d2334647bd7992d5f36e47cc4caedba616041c7251f0c6e8ae7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0NFOjMzRTgwQzoxMjc2RToxOENENTo2QUZENjU1MSIsInZpc2l0b3JfaWQiOiI2NjM5NjcwNjg1NzcxNTg4OTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cbaae1706f6fa6725479db3a3c0552b6f660208cf7a3bf75e75a2a67316d41ae |
| hovercard-subject-tag | pull_request:5365927345 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/255/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/629e9c306b8a8721ec582a3a5a2ad07d748942d5c0760526274fb9a21e69cc3e/php-db/phpdb/pull/255 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/629e9c306b8a8721ec582a3a5a2ad07d748942d5c0760526274fb9a21e69cc3e/php-db/phpdb/pull/255 |
| og:image:alt | Mago compliance, part 3 of 12: the analyzer issues that needed an API decision rather than a mechanical fix. Each commit settles one decision. The analyzer baseline goes from 197 entries to 170 and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simon-mundy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42a67d7c7488271ca8d7e6dc3942424e6de3bff43b1ed4a9c6f0e1a69b73b389 |
| turbo-cache-control | no-cache |
| go-import | github.com/php-db/phpdb git https://github.com/php-db/phpdb.git |
| octolytics-dimension-user_id | 219474457 |
| octolytics-dimension-user_login | php-db |
| octolytics-dimension-repository_id | 879488168 |
| octolytics-dimension-repository_nwo | php-db/phpdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 879488168 |
| octolytics-dimension-repository_network_root_nwo | php-db/phpdb |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5c3779ac05f3590d8d7ea0c02b14e678ae8179ae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php-db/phpdb/pull/255#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F255 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F255 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb |
| Reload | https://github.com/php-db/phpdb/pull/255 |
| Reload | https://github.com/php-db/phpdb/pull/255 |
| Reload | https://github.com/php-db/phpdb/pull/255 |
| php-db | https://github.com/php-db |
| phpdb | https://github.com/php-db/phpdb |
| Code | https://github.com/php-db/phpdb |
| Issues34 (34) | https://github.com/php-db/phpdb/issues |
| Pull requests8 (8) | https://github.com/php-db/phpdb/pulls |
| Discussions | https://github.com/php-db/phpdb/discussions |
| Actions | https://github.com/php-db/phpdb/actions |
| Projects | https://github.com/php-db/phpdb/projects |
| Security and quality | https://github.com/php-db/phpdb/security |
| Insights | https://github.com/php-db/phpdb/insights |
| https://github.com/php-db/phpdb |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:qa/mago-api-decisions | https://github.com/simon-mundy/phpdb/tree/qa/mago-api-decisions |
| Conversation | https://github.com/php-db/phpdb/pull/255 |
| Commits9 (9) | https://github.com/php-db/phpdb/pull/255/commits |
| Checks | https://github.com/php-db/phpdb/pull/255/checks |
| Files changed | https://github.com/php-db/phpdb/pull/255/files |
| Mago compliance: settle the API decisions behind remaining src analyzer issues | https://github.com/php-db/phpdb/pull/255#top |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:qa/mago-api-decisions | https://github.com/simon-mundy/phpdb/tree/qa/mago-api-decisions |
|
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/255#issue-6455220364 |
| Bring TableGateway and RowGateway to Mago compliance #233 | https://github.com/php-db/phpdb/pull/233 |
| Configure mago guard to enforce the library's layering #249 | https://github.com/php-db/phpdb/pull/249 |
| Clear Mago findings in the Sql platform layer #252 | https://github.com/php-db/phpdb/pull/252 |
| Clear the non-BC Mago findings in Container, Adapter and ResultSet #253 | https://github.com/php-db/phpdb/pull/253 |
| Clear the Mago lint findings in the test suite #254 | https://github.com/php-db/phpdb/pull/254 |
| Please reload this page | https://github.com/php-db/phpdb/pull/255 |
| simon-mundy | https://github.com/simon-mundy |
| November 17, 2026 21:28 | https://github.com/php-db/phpdb/pull/255#commits-pushed-9f97438 |
|
| https://github.com/simon-mundy |
| Declare native return types on getHelpers() and getResource() | https://github.com/php-db/phpdb/pull/255/commits/9f974387d8193fcf70caacabe998fe8613e47d01 |
| 9f97438 | https://github.com/php-db/phpdb/pull/255/commits/9f974387d8193fcf70caacabe998fe8613e47d01 |
|
| https://github.com/simon-mundy |
| Type Pdo\Result's properties and make next() return void | https://github.com/php-db/phpdb/pull/255/commits/3704b68f81050c5d685a5aff26d2808e0437983c |
| 3704b68 | https://github.com/php-db/phpdb/pull/255/commits/3704b68f81050c5d685a5aff26d2808e0437983c |
|
| https://github.com/simon-mundy |
| Type Profiler's $profiles and $currentIndex properties | https://github.com/php-db/phpdb/pull/255/commits/a41888f1e4813470043ff91e03682cbeb2d51a21 |
| a41888f | https://github.com/php-db/phpdb/pull/255/commits/a41888f1e4813470043ff91e03682cbeb2d51a21 |
|
| https://github.com/simon-mundy |
| Make AbstractPdo::getResultPrototype() non-nullable | https://github.com/php-db/phpdb/pull/255/commits/ceddedb6911bf533efbb135a7d0053304010a56b |
| ceddedb | https://github.com/php-db/phpdb/pull/255/commits/ceddedb6911bf533efbb135a7d0053304010a56b |
|
| https://github.com/simon-mundy |
| Name ParameterContainer's ArrayAccess parameter $offset | https://github.com/php-db/phpdb/pull/255/commits/ba5e96e795be8762ec467088b3d39b72c02cd69c |
| ba5e96e | https://github.com/php-db/phpdb/pull/255/commits/ba5e96e795be8762ec467088b3d39b72c02cd69c |
|
| https://github.com/simon-mundy |
| Tag extensible classes @api instead of making them final | https://github.com/php-db/phpdb/pull/255/commits/d81303a94d0c9370c6d0f5fe21118e63a3133e7a |
| d81303a | https://github.com/php-db/phpdb/pull/255/commits/d81303a94d0c9370c6d0f5fe21118e63a3133e7a |
| php-db#248 | https://github.com/php-db/phpdb/pull/248 |
|
| https://github.com/simon-mundy |
| Accept FactoryInterface's container type in the abstract adapter factory | https://github.com/php-db/phpdb/pull/255/commits/72dc42ae9dfecb8f799fff35783bb651c95e00ea |
| 72dc42a | https://github.com/php-db/phpdb/pull/255/commits/72dc42ae9dfecb8f799fff35783bb651c95e00ea |
|
| https://github.com/simon-mundy |
| Count AbstractResultSet's first row without casting mixed to array | https://github.com/php-db/phpdb/pull/255/commits/1a32f744e591b4b059520a9653311b28bf6439b3 |
| 1a32f74 | https://github.com/php-db/phpdb/pull/255/commits/1a32f744e591b4b059520a9653311b28bf6439b3 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/255#issuecomment-6962530841 |
| Codecov | https://app.codecov.io/gh/php-db/phpdb/pull/255?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db |
| Let us know! | https://github.com/codecov/feedback/issues/255 |
| Please reload this page | https://github.com/php-db/phpdb/pull/255 |
|
Bring Mago back to green against phpdb 0.6.x
php-db/phpdb-mysql#87
| https://github.com/php-db/phpdb-mysql/pull/87 |
|
Bring Mago back to green against phpdb 0.6.x
php-db/phpdb-pgsql#16
| https://github.com/php-db/phpdb-pgsql/pull/16 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| November 17, 2026 23:38 | https://github.com/php-db/phpdb/pull/255#event-36468283996 |
| started reviewing | https://github.com/php-db/phpdb/sessions/4a39ddd7-65a9-4003-b016-332257bd0234 |
| simon-mundy | https://github.com/simon-mundy |
| November 17, 2026 23:39 | https://github.com/php-db/phpdb/pull/255#event-36468313262 |
|
View session
| https://github.com/php-db/phpdb/sessions/4a39ddd7-65a9-4003-b016-332257bd0234 |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/255#pullrequestreview-5948516722 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/255/files/1a32f744e591b4b059520a9653311b28bf6439b3 |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/php-db/phpdb/pull/255#pullrequestreview-5948516722 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Document the actual fallback counting behavior | https://github.com/php-db/phpdb/pull/255#discussion_r4607302904 |
| Please reload this page | https://github.com/php-db/phpdb/pull/255 |
| src/ResultSet/AbstractResultSet.php | https://github.com/php-db/phpdb/pull/255/files/1a32f744e591b4b059520a9653311b28bf6439b3#diff-8b9863458b0ac65210ea095907fcc634f58bb21f7fbb1b7e3c270b1c63fade81 |
| Please reload this page | https://github.com/php-db/phpdb/pull/255 |
|
| https://github.com/simon-mundy |
| Describe getFieldCount()'s counting as it is implemented | https://github.com/php-db/phpdb/pull/255/commits/b8b1e19eb74650b74d4da75e0071fc0817fe220a |
| b8b1e19 | https://github.com/php-db/phpdb/pull/255/commits/b8b1e19eb74650b74d4da75e0071fc0817fe220a |
| https://github.co/hiddenchars |
| https://github.com/php-db/phpdb/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F255 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/php-db/phpdb/pull/255/files/1a32f744e591b4b059520a9653311b28bf6439b3 |
| Please reload this page | https://github.com/php-db/phpdb/pull/255 |
| Please reload this page | https://github.com/php-db/phpdb/pull/255 |
|
| https://github.com/simon-mundy |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |