| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:258fcd62-6f70-9858-7714-cd2920a6f187 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E654:33AF49:DBCA6:1307B4:6AFD6BAD |
| html-safe-nonce | c9eedc1c7e46f0ec96254e7c64e8561964b9adb88c59ad1df893825689cb7381 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjU0OjMzQUY0OTpEQkNBNjoxMzA3QjQ6NkFGRDZCQUQiLCJ2aXNpdG9yX2lkIjoiOTY5NzE2Nzk4NzYyODcxNzI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 68527071cf0220659db02449d468abd1f510c328f201e8a57e4e0e6f14f2032c |
| hovercard-subject-tag | pull_request:5354285134 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/254/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/09c22abfc00ac97e649c73cf3d2cdf9f80290e2b9022c65d15bbd47d80432431/php-db/phpdb/pull/254 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/09c22abfc00ac97e649c73cf3d2cdf9f80290e2b9022c65d15bbd47d80432431/php-db/phpdb/pull/254 |
| og:image:alt | Problem
lint-baseline.toml carried 92 Mago lint findings in the test suite (test/unit/Sql, test/unit/Adapter, test/unit/ResultSet), including:
@ error suppression and an empty catch;
snake_case te... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simon-mundy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9985ca2e21b59673104d4d830d4afeb946c67f248f273ab2e824c31c8db46e4a |
| turbo-cache-control | no-cache |
| go-import | github.com/php-db/phpdb git https://github.com/php-db/phpdb.git |
| octolytics-dimension-user_id | 219474457 |
| octolytics-dimension-user_login | php-db |
| octolytics-dimension-repository_id | 879488168 |
| octolytics-dimension-repository_nwo | php-db/phpdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 879488168 |
| octolytics-dimension-repository_network_root_nwo | php-db/phpdb |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0db9e8d463c3f4540570e6ad3c501a06db9dc02a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php-db/phpdb/pull/254#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F254 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F254 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb |
| Reload | https://github.com/php-db/phpdb/pull/254 |
| Reload | https://github.com/php-db/phpdb/pull/254 |
| Reload | https://github.com/php-db/phpdb/pull/254 |
| php-db | https://github.com/php-db |
| phpdb | https://github.com/php-db/phpdb |
| Code | https://github.com/php-db/phpdb |
| Issues34 (34) | https://github.com/php-db/phpdb/issues |
| Pull requests8 (8) | https://github.com/php-db/phpdb/pulls |
| Discussions | https://github.com/php-db/phpdb/discussions |
| Actions | https://github.com/php-db/phpdb/actions |
| Projects | https://github.com/php-db/phpdb/projects |
| Security and quality | https://github.com/php-db/phpdb/security |
| Insights | https://github.com/php-db/phpdb/insights |
| https://github.com/php-db/phpdb |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:qa/mago-test-lint | https://github.com/simon-mundy/phpdb/tree/qa/mago-test-lint |
| Conversation | https://github.com/php-db/phpdb/pull/254 |
| Commits5 (5) | https://github.com/php-db/phpdb/pull/254/commits |
| Checks | https://github.com/php-db/phpdb/pull/254/checks |
| Files changed | https://github.com/php-db/phpdb/pull/254/files |
| Clear the Mago lint findings in the test suite | https://github.com/php-db/phpdb/pull/254#top |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:qa/mago-test-lint | https://github.com/simon-mundy/phpdb/tree/qa/mago-test-lint |
|
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/254#issue-6441560785 |
| Please reload this page | https://github.com/php-db/phpdb/pull/254 |
| simon-mundy | https://github.com/simon-mundy |
| November 17, 2026 19:59 | https://github.com/php-db/phpdb/pull/254#commits-pushed-2142d71 |
|
| https://github.com/simon-mundy |
| Use named arguments and plain adapter service names in tests | https://github.com/php-db/phpdb/pull/254/commits/2142d716c2ff0541e16409339b2087948ad5f785 |
| 2142d71 | https://github.com/php-db/phpdb/pull/254/commits/2142d716c2ff0541e16409339b2087948ad5f785 |
|
| https://github.com/simon-mundy |
| Remove error suppression and empty catch from adapter tests | https://github.com/php-db/phpdb/pull/254/commits/4bd4d0bb6ae892d3829aa5ade5779b95b08190b5 |
| 4bd4d0b | https://github.com/php-db/phpdb/pull/254/commits/4bd4d0bb6ae892d3829aa5ade5779b95b08190b5 |
|
| https://github.com/simon-mundy |
| Remove redundant variables and assignments in arguments from adapter … | https://github.com/php-db/phpdb/pull/254/commits/cc5e5e814506af19c013444d69438a362576b741 |
| cc5e5e8 | https://github.com/php-db/phpdb/pull/254/commits/cc5e5e814506af19c013444d69438a362576b741 |
|
| https://github.com/simon-mundy |
| Give snake-case Sql tests and variables behaviour-describing camelCas… | https://github.com/php-db/phpdb/pull/254/commits/c88ad7b7857f92e1e32100d8634836a60ba1dbe3 |
| c88ad7b | https://github.com/php-db/phpdb/pull/254/commits/c88ad7b7857f92e1e32100d8634836a60ba1dbe3 |
|
| https://github.com/simon-mundy |
| Clear remaining test lint findings and prune the lint baseline | https://github.com/php-db/phpdb/pull/254/commits/e3d87ab827ad9ad30eff072dbe085d490cb9d1fb |
| e3d87ab | https://github.com/php-db/phpdb/pull/254/commits/e3d87ab827ad9ad30eff072dbe085d490cb9d1fb |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/254#issuecomment-6944237241 |
| Codecov | https://app.codecov.io/gh/php-db/phpdb/pull/254?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db |
| Let us know! | https://github.com/codecov/feedback/issues/255 |
| Please reload this page | https://github.com/php-db/phpdb/pull/254 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/254#ref-pullrequest-6455220364 |
|
Mago compliance: settle the API decisions behind remaining src analyzer issues
#255
| https://github.com/php-db/phpdb/pull/255 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| November 17, 2026 23:38 | https://github.com/php-db/phpdb/pull/254#event-36468293350 |
| started reviewing | https://github.com/php-db/phpdb/sessions/5a17df77-359f-41a7-8e58-b7d86aacbdac |
| simon-mundy | https://github.com/simon-mundy |
| November 17, 2026 23:39 | https://github.com/php-db/phpdb/pull/254#event-36468325010 |
|
View session
| https://github.com/php-db/phpdb/sessions/5a17df77-359f-41a7-8e58-b7d86aacbdac |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/254#pullrequestreview-5948503248 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/254/files/e3d87ab827ad9ad30eff072dbe085d490cb9d1fb |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/php-db/phpdb/pull/254#pullrequestreview-5948503248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/php-db/phpdb/pull/254 |
| https://github.co/hiddenchars |
| https://github.com/php-db/phpdb/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F254 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/php-db/phpdb/pull/254/files/e3d87ab827ad9ad30eff072dbe085d490cb9d1fb |
| Please reload this page | https://github.com/php-db/phpdb/pull/254 |
| Please reload this page | https://github.com/php-db/phpdb/pull/254 |
|
| https://github.com/simon-mundy |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |