| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e2baab4d-421d-568e-ae11-8d050190d9f1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFB0:14C89B:2DBBA89:3FF907C:6AFD6AD8 |
| html-safe-nonce | 7199b3306d5d98f1ea1b7721dc97c28c6b240041a7a5ce481163047158a3b8c6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkIwOjE0Qzg5QjoyREJCQTg5OjNGRjkwN0M6NkFGRDZBRDgiLCJ2aXNpdG9yX2lkIjoiMjM4MDk0OTkyNzcyMjYyNjE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | eaf8cb153cfc509a034a463d3f5d37594ffe7b968d4aff165df170d4ed8cca84 |
| hovercard-subject-tag | pull_request:5150061670 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/248/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/90bd9c9bd99d876dd96994d68f9fd0c01831412677b5bcefee9af186aaada191/php-db/phpdb/pull/248 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/90bd9c9bd99d876dd96994d68f9fd0c01831412677b5bcefee9af186aaada191/php-db/phpdb/pull/248 |
| og:image:alt | Takes src/Adapter from 265 baselined Mago findings to 22 (212 → 21 analyzer, 53 → 1 lint). Every finding left needs a public signature change or a class split, listed under Still baselined for a de... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simon-mundy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9985ca2e21b59673104d4d830d4afeb946c67f248f273ab2e824c31c8db46e4a |
| turbo-cache-control | no-cache |
| go-import | github.com/php-db/phpdb git https://github.com/php-db/phpdb.git |
| octolytics-dimension-user_id | 219474457 |
| octolytics-dimension-user_login | php-db |
| octolytics-dimension-repository_id | 879488168 |
| octolytics-dimension-repository_nwo | php-db/phpdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 879488168 |
| octolytics-dimension-repository_network_root_nwo | php-db/phpdb |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0db9e8d463c3f4540570e6ad3c501a06db9dc02a |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php-db/phpdb/pull/248#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F248 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F248 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb |
| Reload | https://github.com/php-db/phpdb/pull/248 |
| Reload | https://github.com/php-db/phpdb/pull/248 |
| Reload | https://github.com/php-db/phpdb/pull/248 |
| php-db | https://github.com/php-db |
| phpdb | https://github.com/php-db/phpdb |
| Code | https://github.com/php-db/phpdb |
| Issues34 (34) | https://github.com/php-db/phpdb/issues |
| Pull requests8 (8) | https://github.com/php-db/phpdb/pulls |
| Discussions | https://github.com/php-db/phpdb/discussions |
| Actions | https://github.com/php-db/phpdb/actions |
| Projects | https://github.com/php-db/phpdb/projects |
| Security and quality | https://github.com/php-db/phpdb/security |
| Insights | https://github.com/php-db/phpdb/insights |
| https://github.com/php-db/phpdb |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:qa/mago-adapter | https://github.com/simon-mundy/phpdb/tree/qa/mago-adapter |
| Conversation | https://github.com/php-db/phpdb/pull/248 |
| Commits9 (9) | https://github.com/php-db/phpdb/pull/248/commits |
| Checks | https://github.com/php-db/phpdb/pull/248/checks |
| Files changed | https://github.com/php-db/phpdb/pull/248/files |
| Bring src/Adapter to Mago compliance | https://github.com/php-db/phpdb/pull/248#top |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:qa/mago-adapter | https://github.com/simon-mundy/phpdb/tree/qa/mago-adapter |
|
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Nov 4, 2026 | https://github.com/php-db/phpdb/pull/248#issue-6197757070 |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
| #233 | https://github.com/php-db/phpdb/pull/233 |
| #233 | https://github.com/php-db/phpdb/pull/233 |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
| simon-mundy | https://github.com/simon-mundy |
| November 4, 2026 17:36 | https://github.com/php-db/phpdb/pull/248#commits-pushed-65628da |
|
| https://github.com/simon-mundy |
| Tag the Adapter API and type its constants and arrays | https://github.com/php-db/phpdb/pull/248/commits/65628dabe5553c6bb34641aa6d56ef75121a8d56 |
| 65628da | https://github.com/php-db/phpdb/pull/248/commits/65628dabe5553c6bb34641aa6d56ef75121a8d56 |
|
| https://github.com/simon-mundy |
| Resolve ParameterContainer positions without undefined-key warnings | https://github.com/php-db/phpdb/pull/248/commits/941409a8fb599764d493cc3f4f768cdbe2833053 |
| 941409a | https://github.com/php-db/phpdb/pull/248/commits/941409a8fb599764d493cc3f4f768cdbe2833053 |
|
| https://github.com/simon-mundy |
| Guard the PDO driver's connection, driver and feature provider | https://github.com/php-db/phpdb/pull/248/commits/e6a3949b0f23912ce6f11ffa2d6a652a1cc045dd |
| e6a3949 | https://github.com/php-db/phpdb/pull/248/commits/e6a3949b0f23912ce6f11ffa2d6a652a1cc045dd |
|
| https://github.com/simon-mundy |
| Split PDO parameter binding and store null SQL as empty | https://github.com/php-db/phpdb/pull/248/commits/73cd8acfe31f5b0a95104ead574123072004f2f6 |
| 73cd8ac | https://github.com/php-db/phpdb/pull/248/commits/73cd8acfe31f5b0a95104ead574123072004f2f6 |
|
| https://github.com/simon-mundy |
| Fix Adapter helper, platform quoting and profiler findings | https://github.com/php-db/phpdb/pull/248/commits/8cfb860c5246ca44028631e0cb1aae6376e01ba6 |
| 8cfb860 | https://github.com/php-db/phpdb/pull/248/commits/8cfb860c5246ca44028631e0cb1aae6376e01ba6 |
|
| https://github.com/simon-mundy |
| Clear the Adapter Mago baseline entries | https://github.com/php-db/phpdb/pull/248/commits/5de451d9ee38ad44d9898efbf8349c71a89d3388 |
| 5de451d | https://github.com/php-db/phpdb/pull/248/commits/5de451d9ee38ad44d9898efbf8349c71a89d3388 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Nov 4, 2026 | https://github.com/php-db/phpdb/pull/248#issuecomment-6624414669 |
| Codecov | https://app.codecov.io/gh/php-db/phpdb/pull/248?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db |
| Let us know! | https://github.com/codecov/feedback/issues/255 |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 4, 2026
| https://github.com/php-db/phpdb/pull/248#ref-pullrequest-6197783190 |
|
Configure mago guard to enforce the library's layering
#249
| https://github.com/php-db/phpdb/pull/249 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| November 4, 2026 10:27 | https://github.com/php-db/phpdb/pull/248#event-35117666997 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Nov 4, 2026 | https://github.com/php-db/phpdb/pull/248#event-35117689875 |
| started reviewing | https://github.com/php-db/phpdb/sessions/a829e925-4754-48bb-a8dd-946eedc4e56f |
| simon-mundy | https://github.com/simon-mundy |
| November 4, 2026 10:28 | https://github.com/php-db/phpdb/pull/248#event-35117706490 |
|
View session
| https://github.com/php-db/phpdb/sessions/a829e925-4754-48bb-a8dd-946eedc4e56f |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
|
enhancement
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aenhancement |
|
qa
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aqa |
| Nov 4, 2026 | https://github.com/php-db/phpdb/pull/248#event-35117734635 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Nov 4, 2026 | https://github.com/php-db/phpdb/pull/248#event-35117744247 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Nov 4, 2026 | https://github.com/php-db/phpdb/pull/248#event-35117748462 |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Nov 4, 2026
| https://github.com/php-db/phpdb/pull/248#pullrequestreview-5766955848 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/248/files/5de451d9ee38ad44d9898efbf8349c71a89d3388 |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/php-db/phpdb/pull/248#pullrequestreview-5766955848 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Preserve the quote helper’s $value named parameter | https://github.com/php-db/phpdb/pull/248#discussion_r4466429266 |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
| src/Adapter/Adapter.php | https://github.com/php-db/phpdb/pull/248/files/5de451d9ee38ad44d9898efbf8349c71a89d3388#diff-55955428038b9bf948e0383865ab55ceee44aabe8418040d92e9b78814064b0f |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
|
| https://github.com/simon-mundy |
| Preserve the $value parameter name on the quote identifier helper | https://github.com/php-db/phpdb/pull/248/commits/3288a926d781a144ef7d0ca8df92fb5232a3d0ad |
| 3288a92 | https://github.com/php-db/phpdb/pull/248/commits/3288a926d781a144ef7d0ca8df92fb5232a3d0ad |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/248#ref-pullrequest-6436612668 |
|
Double a quote character inside an identifier instead of replacing it
#250
| https://github.com/php-db/phpdb/pull/250 |
| https://github.com/tyrsson |
| tyrsson | https://github.com/tyrsson |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/248#pullrequestreview-5933397481 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/248/files/9e4c1b52bed6394272b3a68365c823e0fea9a021 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/248#event-36367963314 |
| simon-mundy | https://github.com/simon-mundy |
| November 17, 2026 16:27 | https://github.com/php-db/phpdb/pull/248#commits-pushed-bcff454 |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into qa/mago-adapter | https://github.com/php-db/phpdb/pull/248/commits/bcff45468f12ccc87110f3079b9767f8d5fac959 |
| bcff454 | https://github.com/php-db/phpdb/pull/248/commits/bcff45468f12ccc87110f3079b9767f8d5fac959 |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into qa/mago-adapter | https://github.com/php-db/phpdb/pull/248/commits/9e4c1b52bed6394272b3a68365c823e0fea9a021 |
| 9e4c1b5 | https://github.com/php-db/phpdb/pull/248/commits/9e4c1b52bed6394272b3a68365c823e0fea9a021 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| 20fb241 | https://github.com/php-db/phpdb/commit/20fb241bff83ff55ed607996c4d72bd25c82136c |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/248#event-36368888713 |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/248#event-36368894428 |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/248#ref-commit-d3c1c56 |
|
| https://github.com/simon-mundy |
| Expect the doubled quote in the platform tests merged from 0.6.x | https://github.com/simon-mundy/phpdb/commit/d3c1c563b94091bbf0ec51e2cf7615ff36abd0f4 |
| d3c1c56 | https://github.com/simon-mundy/phpdb/commit/d3c1c563b94091bbf0ec51e2cf7615ff36abd0f4 |
| php-db#248 | https://github.com/php-db/phpdb/pull/248 |
| https://github.co/hiddenchars |
| https://github.com/php-db/phpdb/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F248 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/php-db/phpdb/pull/248/files/5de451d9ee38ad44d9898efbf8349c71a89d3388 |
|
| https://github.com/tyrsson |
|
tyrsson
| https://github.com/tyrsson |
|
| https://github.com/php-db/phpdb/pull/248/files/9e4c1b52bed6394272b3a68365c823e0fea9a021 |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
|
| https://github.com/simon-mundy |
|
simon-mundy
| https://github.com/simon-mundy |
|
enhancement
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aenhancement |
|
qa
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aqa |
|
@phpdb
| https://github.com/orgs/php-db/projects/2 |
| Please reload this page | https://github.com/php-db/phpdb/pull/248 |
|
| https://github.com/simon-mundy |
|
| https://github.com/tyrsson |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |