René's URL Explorer Experiment


Title: Quote predicate names as identifiers where fragment quoting renders broken SQL by simon-mundy · Pull Request #244 · php-db/phpdb · GitHub

Open Graph Title: Quote predicate names as identifiers where fragment quoting renders broken SQL by simon-mundy · Pull Request #244 · php-db/phpdb

X Title: Quote predicate names as identifiers where fragment quoting renders broken SQL by simon-mundy · Pull Request #244 · php-db/phpdb

Description: Database abstraction layer, SQL abstraction, result set abstraction, and RowDataGateway and TableDataGateway implementations - Quote predicate names as identifiers where fragment quoting renders broken SQL by simon-mundy · Pull Request #244 · php-db/phpdb

Open Graph Description: Merge order: builds on #241's shared IdentifierQuoter, so merge #241 first. Until then this diff also shows #241's changes. Problem A predicate's left-hand name is rendered through Abs...

X Description: Merge order: builds on #241's shared IdentifierQuoter, so merge #241 first. Until then this diff also shows #241's changes. Problem A predicate's left-hand name is rendered...

Opengraph URL: https://github.com/php-db/phpdb/pull/244

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cadfa3e4-9240-719d-b57a-f49ffd964162
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD18E:8D9FD:2609C:3420B:6AFD662F
html-safe-noncefe527a8aaa8c2098995fb3a9572de60c0c964bd52a5e4ca30c530de4d9bd2e40
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMThFOjhEOUZEOjI2MDlDOjM0MjBCOjZBRkQ2NjJGIiwidmlzaXRvcl9pZCI6Ijg3NTEwNTUyNTgyMDI3NjA3NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1e4621fba3e12433ff837ef454c1e0850506a89f5b2a8af4c2062d047718e80c
hovercard-subject-tagpull_request:4839113670
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/244/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2bea5241cf0ebe5d6ffacacbe3198580d497495392acf0e4cf9abb918d8357c0/php-db/phpdb/pull/244
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2bea5241cf0ebe5d6ffacacbe3198580d497495392acf0e4cf9abb918d8357c0/php-db/phpdb/pull/244
og:image:altMerge order: builds on #241's shared IdentifierQuoter, so merge #241 first. Until then this diff also shows #241's changes. Problem A predicate's left-hand name is rendered through Abs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesimon-mundy
hostnamegithub.com
expected-hostnamegithub.com
None42a67d7c7488271ca8d7e6dc3942424e6de3bff43b1ed4a9c6f0e1a69b73b389
turbo-cache-controlno-cache
go-importgithub.com/php-db/phpdb git https://github.com/php-db/phpdb.git
octolytics-dimension-user_id219474457
octolytics-dimension-user_loginphp-db
octolytics-dimension-repository_id879488168
octolytics-dimension-repository_nwophp-db/phpdb
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id879488168
octolytics-dimension-repository_network_root_nwophp-db/phpdb
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5c3779ac05f3590d8d7ea0c02b14e678ae8179ae
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/php-db/phpdb/pull/244#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F244
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F244
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb
Reloadhttps://github.com/php-db/phpdb/pull/244
Reloadhttps://github.com/php-db/phpdb/pull/244
Reloadhttps://github.com/php-db/phpdb/pull/244
php-dbhttps://github.com/php-db
phpdbhttps://github.com/php-db/phpdb
Codehttps://github.com/php-db/phpdb
Issues34 (34)https://github.com/php-db/phpdb/issues
Pull requests8 (8)https://github.com/php-db/phpdb/pulls
Discussionshttps://github.com/php-db/phpdb/discussions
Actionshttps://github.com/php-db/phpdb/actions
Projectshttps://github.com/php-db/phpdb/projects
Security and qualityhttps://github.com/php-db/phpdb/security
Insightshttps://github.com/php-db/phpdb/insights
https://github.com/php-db/phpdb
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:fix/predicate-identifierhttps://github.com/simon-mundy/phpdb/tree/fix/predicate-identifier
Conversationhttps://github.com/php-db/phpdb/pull/244
Commits9 (9)https://github.com/php-db/phpdb/pull/244/commits
Checkshttps://github.com/php-db/phpdb/pull/244/checks
Files changedhttps://github.com/php-db/phpdb/pull/244/files
Quote predicate names as identifiers where fragment quoting renders broken SQLhttps://github.com/php-db/phpdb/pull/244#top
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:fix/predicate-identifierhttps://github.com/simon-mundy/phpdb/tree/fix/predicate-identifier
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Oct 13, 2026https://github.com/php-db/phpdb/pull/244#issue-5825425876
Please reload this pagehttps://github.com/php-db/phpdb/pull/244
#241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
#243https://github.com/php-db/phpdb/pull/243
#238https://github.com/php-db/phpdb/pull/238
#241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
Please reload this pagehttps://github.com/php-db/phpdb/pull/244
https://github.com/simon-mundy
Quote predicate names as identifiers where fragment quoting renders b…https://github.com/php-db/phpdb/pull/244/commits/730e0a34fe6eb05fd7973273bf0a68ac96cf9532
730e0a3https://github.com/php-db/phpdb/pull/244/commits/730e0a34fe6eb05fd7973273bf0a68ac96cf9532
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 13, 2026https://github.com/php-db/phpdb/pull/244#issuecomment-6139408997
Please reload this pagehttps://github.com/php-db/phpdb/pull/244
Codecovhttps://app.codecov.io/gh/php-db/phpdb/pull/244?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/php-db/phpdb/pull/244
simon-mundyhttps://github.com/simon-mundy
November 4, 2026 14:27https://github.com/php-db/phpdb/pull/244#commits-pushed-2696ef9
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/predicate-identifierhttps://github.com/php-db/phpdb/pull/244/commits/2696ef9a5ae69c8d077e45451e9e594632be854c
2696ef9https://github.com/php-db/phpdb/pull/244/commits/2696ef9a5ae69c8d077e45451e9e594632be854c
https://github.com/simon-mundy
Mergehttps://github.com/php-db/phpdb/pull/244/commits/2f4242bbd7797c75d435ff719e3acaf22d2c68f5
php-db#241https://github.com/php-db/phpdb/pull/241
's shared IdentifierQuoter into fix/predicate-identifierhttps://github.com/php-db/phpdb/pull/244/commits/2f4242bbd7797c75d435ff719e3acaf22d2c68f5
2f4242bhttps://github.com/php-db/phpdb/pull/244/commits/2f4242bbd7797c75d435ff719e3acaf22d2c68f5
https://github.com/simon-mundy
Quote predicate and identifier arguments through IdentifierQuoterhttps://github.com/php-db/phpdb/pull/244/commits/b59f42d5ef79c773864e2963b336a52b3742067c
b59f42dhttps://github.com/php-db/phpdb/pull/244/commits/b59f42d5ef79c773864e2963b336a52b3742067c
https://github.com/simon-mundy
Merge fix/select-column-identifier into fix/predicate-identifierhttps://github.com/php-db/phpdb/pull/244/commits/c6af72fca6774c46d16674e0ccd19632b1543808
c6af72fhttps://github.com/php-db/phpdb/pull/244/commits/c6af72fca6774c46d16674e0ccd19632b1543808
Quote Select, join and GROUP BY column names as identifiers #241 https://github.com/php-db/phpdb/pull/241
Quote ORDER BY names as identifiers where fragment quoting breaks them #243 https://github.com/php-db/phpdb/pull/243
https://github.com/simon-mundy
Merge fix/select-column-identifier into fix/predicate-identifierhttps://github.com/php-db/phpdb/pull/244/commits/5f971bcd5556d5d694c42a8a43534f4173163dac
5f971bchttps://github.com/php-db/phpdb/pull/244/commits/5f971bcd5556d5d694c42a8a43534f4173163dac
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Nov 17, 2026 https://github.com/php-db/phpdb/pull/244#ref-pullrequest-6436612668
Double a quote character inside an identifier instead of replacing it #250 https://github.com/php-db/phpdb/pull/250
https://github.com/tyrsson
tyrssonhttps://github.com/tyrsson
Nov 17, 2026 https://github.com/php-db/phpdb/pull/244#pullrequestreview-5933390435
View reviewed changes https://github.com/php-db/phpdb/pull/244/files/5f971bcd5556d5d694c42a8a43534f4173163dac
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
tyrssonhttps://github.com/tyrsson
stale reviewhttps://github.com/php-db/phpdb/pull/244#pullrequestreview-5933390435
November 17, 2026 05:24https://github.com/php-db/phpdb/pull/244#event-36367906796
https://github.com/tyrsson
tyrssonhttps://github.com/tyrsson
Nov 17, 2026 https://github.com/php-db/phpdb/pull/244#pullrequestreview-5933436495
View reviewed changes https://github.com/php-db/phpdb/pull/244/files/5f971bcd5556d5d694c42a8a43534f4173163dac
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
tyrssonhttps://github.com/tyrsson
stale reviewhttps://github.com/php-db/phpdb/pull/244#pullrequestreview-5933436495
November 17, 2026 05:29https://github.com/php-db/phpdb/pull/244#event-36368244510
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/predicate-identifierhttps://github.com/php-db/phpdb/pull/244/commits/dd379a9603cf116ee64aca64ff92f5c72a3c3491
dd379a9https://github.com/php-db/phpdb/pull/244/commits/dd379a9603cf116ee64aca64ff92f5c72a3c3491
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
0.6.0https://github.com/php-db/phpdb/milestone/22
Nov 17, 2026https://github.com/php-db/phpdb/pull/244#event-36369144521
simon-mundyhttps://github.com/simon-mundy
November 17, 2026 16:50https://github.com/php-db/phpdb/pull/244#commits-pushed-359a23e
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/predicate-identifierhttps://github.com/php-db/phpdb/pull/244/commits/359a23ecd7d97204d18976f86d751baa98f2f47f
359a23ehttps://github.com/php-db/phpdb/pull/244/commits/359a23ecd7d97204d18976f86d751baa98f2f47f
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/predicate-identifierhttps://github.com/php-db/phpdb/pull/244/commits/3c3e19c748b209e084fc5f0017f755bb2bb2e48b
3c3e19chttps://github.com/php-db/phpdb/pull/244/commits/3c3e19c748b209e084fc5f0017f755bb2bb2e48b
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
8b240cdhttps://github.com/php-db/phpdb/commit/8b240cd173282f59650345aceb2a99773058b5cc
Nov 17, 2026https://github.com/php-db/phpdb/pull/244#event-36370858561
Please reload this pagehttps://github.com/php-db/phpdb/pull/244
simon-mundyhttps://github.com/simon-mundy
Nov 17, 2026 https://github.com/php-db/phpdb/pull/244#ref-commit-b4503e9
https://github.com/simon-mundy
Expect doubled quotes in the predicate name tests merged from 0.6.xhttps://github.com/simon-mundy/phpdb/commit/b4503e9792582ce2f2c6695ecabf7dd098f981af
b4503e9https://github.com/simon-mundy/phpdb/commit/b4503e9792582ce2f2c6695ecabf7dd098f981af
php-db#244https://github.com/php-db/phpdb/pull/244
https://github.co/hiddenchars
https://github.com/php-db/phpdb/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F244
https://github.com/tyrsson
tyrsson https://github.com/tyrsson
https://github.com/php-db/phpdb/pull/244/files/5f971bcd5556d5d694c42a8a43534f4173163dac
Please reload this pagehttps://github.com/php-db/phpdb/pull/244
0.6.0 https://github.com/php-db/phpdb/milestone/22
Please reload this pagehttps://github.com/php-db/phpdb/pull/244
https://github.com/simon-mundy
https://github.com/tyrsson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.