René's URL Explorer Experiment


Title: Quote ORDER BY names as identifiers where fragment quoting breaks them by simon-mundy · Pull Request #243 · php-db/phpdb · GitHub

Open Graph Title: Quote ORDER BY names as identifiers where fragment quoting breaks them by simon-mundy · Pull Request #243 · php-db/phpdb

X Title: Quote ORDER BY names as identifiers where fragment quoting breaks them by simon-mundy · Pull Request #243 · php-db/phpdb

Description: Database abstraction layer, SQL abstraction, result set abstraction, and RowDataGateway and TableDataGateway implementations - Quote ORDER BY names as identifiers where fragment quoting breaks them by simon-mundy · Pull Request #243 · php-db/phpdb

Open Graph Description: Merge order: builds on #241's shared IdentifierQuoter, so merge #241 first. Until then this diff also shows #241's changes. Problem Select::order() renders some order names as broken SQL. ...

X Description: Merge order: builds on #241's shared IdentifierQuoter, so merge #241 first. Until then this diff also shows #241's changes. Problem Select::order() renders some order names as brok...

Opengraph URL: https://github.com/php-db/phpdb/pull/243

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cb086c3a-1ba9-482a-0c9d-bef5cb646fcc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC44:2543CD:22D000:30F285:6AFD7258
html-safe-noncea3de6d78f8785bad500f1e2bec51d98f6d108be45ccf65d176dd41522d407701
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzQ0OjI1NDNDRDoyMkQwMDA6MzBGMjg1OjZBRkQ3MjU4IiwidmlzaXRvcl9pZCI6IjkwNjkxNTQwNDcwODY3MjA4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac60b5b43342b820f3f0ff2ee4f94bffe3a86d3cd3b42865a1f85f0a99c04ca2c1
hovercard-subject-tagpull_request:4839098271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/243/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a693e3e12f39b0bd0db775d4a53365f816fa1019290291b9ee65b09372107f2a/php-db/phpdb/pull/243
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a693e3e12f39b0bd0db775d4a53365f816fa1019290291b9ee65b09372107f2a/php-db/phpdb/pull/243
og:image:altMerge order: builds on #241's shared IdentifierQuoter, so merge #241 first. Until then this diff also shows #241's changes. Problem Select::order() renders some order names as broken SQL. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesimon-mundy
hostnamegithub.com
expected-hostnamegithub.com
Nonee54006cf2b96d1ac260960edd10003132911469ccd1ec99c9803119fe2a4e032
turbo-cache-controlno-cache
go-importgithub.com/php-db/phpdb git https://github.com/php-db/phpdb.git
octolytics-dimension-user_id219474457
octolytics-dimension-user_loginphp-db
octolytics-dimension-repository_id879488168
octolytics-dimension-repository_nwophp-db/phpdb
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id879488168
octolytics-dimension-repository_network_root_nwophp-db/phpdb
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5be0bf2b8cf26f8897d31e6bc3c232d328b12a54
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/php-db/phpdb/pull/243#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F243
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F243
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb
Reloadhttps://github.com/php-db/phpdb/pull/243
Reloadhttps://github.com/php-db/phpdb/pull/243
Reloadhttps://github.com/php-db/phpdb/pull/243
php-dbhttps://github.com/php-db
phpdbhttps://github.com/php-db/phpdb
Codehttps://github.com/php-db/phpdb
Issues34 (34)https://github.com/php-db/phpdb/issues
Pull requests8 (8)https://github.com/php-db/phpdb/pulls
Discussionshttps://github.com/php-db/phpdb/discussions
Actionshttps://github.com/php-db/phpdb/actions
Projectshttps://github.com/php-db/phpdb/projects
Security and qualityhttps://github.com/php-db/phpdb/security
Insightshttps://github.com/php-db/phpdb/insights
https://github.com/php-db/phpdb
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:fix/order-name-identifierhttps://github.com/simon-mundy/phpdb/tree/fix/order-name-identifier
Conversationhttps://github.com/php-db/phpdb/pull/243
Commits7 (7)https://github.com/php-db/phpdb/pull/243/commits
Checkshttps://github.com/php-db/phpdb/pull/243/checks
Files changedhttps://github.com/php-db/phpdb/pull/243/files
Quote ORDER BY names as identifiers where fragment quoting breaks themhttps://github.com/php-db/phpdb/pull/243#top
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:fix/order-name-identifierhttps://github.com/simon-mundy/phpdb/tree/fix/order-name-identifier
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Oct 13, 2026https://github.com/php-db/phpdb/pull/243#issue-5825407378
Please reload this pagehttps://github.com/php-db/phpdb/pull/243
#241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
#244https://github.com/php-db/phpdb/pull/244
#238https://github.com/php-db/phpdb/pull/238
#241https://github.com/php-db/phpdb/pull/241
Quote Select, join and GROUP BY column names as identifiers #241https://github.com/php-db/phpdb/pull/241
#241https://github.com/php-db/phpdb/pull/241
Please reload this pagehttps://github.com/php-db/phpdb/pull/243
https://github.com/simon-mundy
Quote ORDER BY names as identifiers where fragment quoting breaks themhttps://github.com/php-db/phpdb/pull/243/commits/ea0bc14a524e2af722c9859398beaedea0f2ce4f
ea0bc14https://github.com/php-db/phpdb/pull/243/commits/ea0bc14a524e2af722c9859398beaedea0f2ce4f
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 13, 2026https://github.com/php-db/phpdb/pull/243#issuecomment-6139385776
Please reload this pagehttps://github.com/php-db/phpdb/pull/243
Codecovhttps://app.codecov.io/gh/php-db/phpdb/pull/243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/php-db/phpdb/pull/243
simon-mundyhttps://github.com/simon-mundy
November 4, 2026 14:26https://github.com/php-db/phpdb/pull/243#commits-pushed-7ec95be
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/order-name-identifierhttps://github.com/php-db/phpdb/pull/243/commits/7ec95be73afb5d79c26962b902c9728f501e218e
7ec95behttps://github.com/php-db/phpdb/pull/243/commits/7ec95be73afb5d79c26962b902c9728f501e218e
https://github.com/simon-mundy
Mergehttps://github.com/php-db/phpdb/pull/243/commits/a5678539062a01deeca0f6c24dc28ee3193a745e
php-db#241https://github.com/php-db/phpdb/pull/241
's shared IdentifierQuoter into fix/order-name-identi…https://github.com/php-db/phpdb/pull/243/commits/a5678539062a01deeca0f6c24dc28ee3193a745e
a567853https://github.com/php-db/phpdb/pull/243/commits/a5678539062a01deeca0f6c24dc28ee3193a745e
https://github.com/simon-mundy
Quote ORDER BY names through the shared IdentifierQuoterhttps://github.com/php-db/phpdb/pull/243/commits/3b2c1402dda47d7f761abb1133f9d0ed1c92e9a3
3b2c140https://github.com/php-db/phpdb/pull/243/commits/3b2c1402dda47d7f761abb1133f9d0ed1c92e9a3
https://github.com/simon-mundy
Merge fix/select-column-identifier into fix/order-name-identifierhttps://github.com/php-db/phpdb/pull/243/commits/69e1419742b522c0e091a05c88a9a17b698e4d52
69e1419https://github.com/php-db/phpdb/pull/243/commits/69e1419742b522c0e091a05c88a9a17b698e4d52
Quote Select, join and GROUP BY column names as identifiers #241 https://github.com/php-db/phpdb/pull/241
Quote predicate names as identifiers where fragment quoting renders broken SQL #244 https://github.com/php-db/phpdb/pull/244
https://github.com/simon-mundy
Merge fix/select-column-identifier into fix/order-name-identifierhttps://github.com/php-db/phpdb/pull/243/commits/8da57fa9f812bf94d601c95047ae0af52b000f26
8da57fahttps://github.com/php-db/phpdb/pull/243/commits/8da57fa9f812bf94d601c95047ae0af52b000f26
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Nov 17, 2026 https://github.com/php-db/phpdb/pull/243#ref-pullrequest-6436612668
Double a quote character inside an identifier instead of replacing it #250 https://github.com/php-db/phpdb/pull/250
https://github.com/tyrsson
tyrssonhttps://github.com/tyrsson
Nov 17, 2026 https://github.com/php-db/phpdb/pull/243#pullrequestreview-5933309163
View reviewed changes https://github.com/php-db/phpdb/pull/243/files/8da57fa9f812bf94d601c95047ae0af52b000f26
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
tyrssonhttps://github.com/tyrsson
stale reviewhttps://github.com/php-db/phpdb/pull/243#pullrequestreview-5933309163
November 17, 2026 05:16https://github.com/php-db/phpdb/pull/243#event-36367260793
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/order-name-identifierhttps://github.com/php-db/phpdb/pull/243/commits/0a4f02000febcab23e68d24a1ed6c14795ee332a
0a4f020https://github.com/php-db/phpdb/pull/243/commits/0a4f02000febcab23e68d24a1ed6c14795ee332a
https://github.com/tyrsson
tyrssonhttps://github.com/tyrsson
Nov 17, 2026 https://github.com/php-db/phpdb/pull/243#pullrequestreview-5933432553
View reviewed changes https://github.com/php-db/phpdb/pull/243/files/0a4f02000febcab23e68d24a1ed6c14795ee332a
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
4b44eafhttps://github.com/php-db/phpdb/commit/4b44eaf8a2ca6f1d59855bb2487c868072a54568
Nov 17, 2026https://github.com/php-db/phpdb/pull/243#event-36368216565
Please reload this pagehttps://github.com/php-db/phpdb/pull/243
simon-mundyhttps://github.com/simon-mundy
Nov 17, 2026 https://github.com/php-db/phpdb/pull/243#ref-commit-d7971e2
https://github.com/simon-mundy
Expect doubled quotes in the identifier tests merged from 0.6.xhttps://github.com/simon-mundy/phpdb/commit/d7971e2fbb8e0e966e1e0a689141947d161a4a53
d7971e2https://github.com/simon-mundy/phpdb/commit/d7971e2fbb8e0e966e1e0a689141947d161a4a53
php-db#241https://github.com/php-db/phpdb/pull/241
php-db#243https://github.com/php-db/phpdb/pull/243
https://github.co/hiddenchars
https://github.com/php-db/phpdb/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F243
https://github.com/tyrsson
tyrsson https://github.com/tyrsson
https://github.com/php-db/phpdb/pull/243/files/0a4f02000febcab23e68d24a1ed6c14795ee332a
Please reload this pagehttps://github.com/php-db/phpdb/pull/243
Please reload this pagehttps://github.com/php-db/phpdb/pull/243
https://github.com/simon-mundy
https://github.com/tyrsson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.