René's URL Explorer Experiment


Title: Quote Select, join and GROUP BY column names as identifiers by simon-mundy · Pull Request #241 · php-db/phpdb · GitHub

Open Graph Title: Quote Select, join and GROUP BY column names as identifiers by simon-mundy · Pull Request #241 · php-db/phpdb

X Title: Quote Select, join and GROUP BY column names as identifiers by simon-mundy · Pull Request #241 · php-db/phpdb

Description: Database abstraction layer, SQL abstraction, result set abstraction, and RowDataGateway and TableDataGateway implementations - Quote Select, join and GROUP BY column names as identifiers by simon-mundy · Pull Request #241 · php-db/phpdb

Open Graph Description: Merge order: merge this PR before #243 and #244. Both build on the IdentifierQuoter added here, so until this PR is merged their diffs also show its changes. Problem Select fragment-quotes column ...

X Description: Merge order: merge this PR before #243 and #244. Both build on the IdentifierQuoter added here, so until this PR is merged their diffs also show its changes. Problem Select fragment-quotes column ...

Opengraph URL: https://github.com/php-db/phpdb/pull/241

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:465eb4a9-b06e-583e-70c5-fd81f0f16453
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD26C:BC587:E429F:141FCB:6AFD6B64
html-safe-nonce8c5909c2f595241d2584e6a2660ba8c2eb58f90922e5de4431ba4d748de94d1d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjZDOkJDNTg3OkU0MjlGOjE0MUZDQjo2QUZENkI2NCIsInZpc2l0b3JfaWQiOiIzMDkwOTc2Mzg1NzcwODEwMjEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac035fef3f731ce93de1bd6450d7d7a3456bef7c07727ab3b8e90d520d3f5a139d
hovercard-subject-tagpull_request:4837271385
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/241/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/da317b9a32233bc4420f9b7b029fac0016b5525014a14c1f348ed8d79cd67457/php-db/phpdb/pull/241
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da317b9a32233bc4420f9b7b029fac0016b5525014a14c1f348ed8d79cd67457/php-db/phpdb/pull/241
og:image:altMerge order: merge this PR before #243 and #244. Both build on the IdentifierQuoter added here, so until this PR is merged their diffs also show its changes. Problem Select fragment-quotes column ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesimon-mundy
hostnamegithub.com
expected-hostnamegithub.com
None9985ca2e21b59673104d4d830d4afeb946c67f248f273ab2e824c31c8db46e4a
turbo-cache-controlno-cache
go-importgithub.com/php-db/phpdb git https://github.com/php-db/phpdb.git
octolytics-dimension-user_id219474457
octolytics-dimension-user_loginphp-db
octolytics-dimension-repository_id879488168
octolytics-dimension-repository_nwophp-db/phpdb
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id879488168
octolytics-dimension-repository_network_root_nwophp-db/phpdb
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0db9e8d463c3f4540570e6ad3c501a06db9dc02a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/php-db/phpdb/pull/241#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F241
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F241
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb
Reloadhttps://github.com/php-db/phpdb/pull/241
Reloadhttps://github.com/php-db/phpdb/pull/241
Reloadhttps://github.com/php-db/phpdb/pull/241
php-dbhttps://github.com/php-db
phpdbhttps://github.com/php-db/phpdb
Codehttps://github.com/php-db/phpdb
Issues34 (34)https://github.com/php-db/phpdb/issues
Pull requests8 (8)https://github.com/php-db/phpdb/pulls
Discussionshttps://github.com/php-db/phpdb/discussions
Actionshttps://github.com/php-db/phpdb/actions
Projectshttps://github.com/php-db/phpdb/projects
Security and qualityhttps://github.com/php-db/phpdb/security
Insightshttps://github.com/php-db/phpdb/insights
https://github.com/php-db/phpdb
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:fix/select-column-identifierhttps://github.com/simon-mundy/phpdb/tree/fix/select-column-identifier
Conversationhttps://github.com/php-db/phpdb/pull/241
Commits7 (7)https://github.com/php-db/phpdb/pull/241/commits
Checkshttps://github.com/php-db/phpdb/pull/241/checks
Files changedhttps://github.com/php-db/phpdb/pull/241/files
Quote Select, join and GROUP BY column names as identifiershttps://github.com/php-db/phpdb/pull/241#top
simon-mundyhttps://github.com/simon-mundy
php-db:0.6.xhttps://github.com/php-db/phpdb/tree/0.6.x
simon-mundy:fix/select-column-identifierhttps://github.com/simon-mundy/phpdb/tree/fix/select-column-identifier
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Oct 13, 2026https://github.com/php-db/phpdb/pull/241#issue-5823193065
Please reload this pagehttps://github.com/php-db/phpdb/pull/241
#243https://github.com/php-db/phpdb/pull/243
#244https://github.com/php-db/phpdb/pull/244
#243https://github.com/php-db/phpdb/pull/243
#244https://github.com/php-db/phpdb/pull/244
#238https://github.com/php-db/phpdb/pull/238
#243https://github.com/php-db/phpdb/pull/243
#244https://github.com/php-db/phpdb/pull/244
#243https://github.com/php-db/phpdb/pull/243
#244https://github.com/php-db/phpdb/pull/244
Quote Update SET columns as identifiers and bind them under valid placeholder names #238https://github.com/php-db/phpdb/pull/238
Please reload this pagehttps://github.com/php-db/phpdb/pull/241
https://github.com/simon-mundy
Quote Select, join and GROUP BY column names as identifiershttps://github.com/php-db/phpdb/pull/241/commits/2c910048e1e9f44e95dd45a610ae6477b29838f5
2c91004https://github.com/php-db/phpdb/pull/241/commits/2c910048e1e9f44e95dd45a610ae6477b29838f5
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 13, 2026https://github.com/php-db/phpdb/pull/241#issuecomment-6136443085
Please reload this pagehttps://github.com/php-db/phpdb/pull/241
Codecovhttps://app.codecov.io/gh/php-db/phpdb/pull/241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/php-db/phpdb/pull/241
https://github.com/simon-mundy
Keep fragment quoting for column strings it already renders as valid SQLhttps://github.com/php-db/phpdb/pull/241/commits/84996870976e6be9b6f7550b1101849c161e58ea
8499687https://github.com/php-db/phpdb/pull/241/commits/84996870976e6be9b6f7550b1101849c161e58ea
Quote ORDER BY names as identifiers where fragment quoting breaks them #243 https://github.com/php-db/phpdb/pull/243
Quote predicate names as identifiers where fragment quoting renders broken SQL #244 https://github.com/php-db/phpdb/pull/244
simon-mundyhttps://github.com/simon-mundy
November 4, 2026 14:26https://github.com/php-db/phpdb/pull/241#commits-pushed-967bd02
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/select-column-identifierhttps://github.com/php-db/phpdb/pull/241/commits/967bd0233315fafdc5e7f467e2e21147ad5d8d4b
967bd02https://github.com/php-db/phpdb/pull/241/commits/967bd0233315fafdc5e7f467e2e21147ad5d8d4b
https://github.com/simon-mundy
Quote identifier strings through one shared IdentifierQuoterhttps://github.com/php-db/phpdb/pull/241/commits/4c19e83502efb745a483f0bc42be3bea49578dea
4c19e83https://github.com/php-db/phpdb/pull/241/commits/4c19e83502efb745a483f0bc42be3bea49578dea
simon-mundyhttps://github.com/simon-mundy
Nov 4, 2026 https://github.com/php-db/phpdb/pull/241#ref-commit-a567853
https://github.com/simon-mundy
Mergehttps://github.com/simon-mundy/phpdb/commit/a5678539062a01deeca0f6c24dc28ee3193a745e
php-db#241https://github.com/php-db/phpdb/pull/241
's shared IdentifierQuoter into fix/order-name-identi…https://github.com/simon-mundy/phpdb/commit/a5678539062a01deeca0f6c24dc28ee3193a745e
a567853https://github.com/simon-mundy/phpdb/commit/a5678539062a01deeca0f6c24dc28ee3193a745e
simon-mundyhttps://github.com/simon-mundy
Nov 4, 2026 https://github.com/php-db/phpdb/pull/241#ref-commit-2f4242b
https://github.com/simon-mundy
Mergehttps://github.com/simon-mundy/phpdb/commit/2f4242bbd7797c75d435ff719e3acaf22d2c68f5
php-db#241https://github.com/php-db/phpdb/pull/241
's shared IdentifierQuoter into fix/predicate-identifierhttps://github.com/simon-mundy/phpdb/commit/2f4242bbd7797c75d435ff719e3acaf22d2c68f5
2f4242bhttps://github.com/simon-mundy/phpdb/commit/2f4242bbd7797c75d435ff719e3acaf22d2c68f5
simon-mundyhttps://github.com/simon-mundy
November 4, 2026 16:28https://github.com/php-db/phpdb/pull/241#commits-pushed-9e79c6d
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/select-column-identifierhttps://github.com/php-db/phpdb/pull/241/commits/9e79c6d209fe1dbb53a0a82c3ed2cdbdb74c0088
9e79c6dhttps://github.com/php-db/phpdb/pull/241/commits/9e79c6d209fe1dbb53a0a82c3ed2cdbdb74c0088
https://github.com/simon-mundy
Cover the identifier exception factories in InvalidArgumentExceptionTesthttps://github.com/php-db/phpdb/pull/241/commits/59d7710b31186fcaccbdff8810097d8d12c56809
59d7710https://github.com/php-db/phpdb/pull/241/commits/59d7710b31186fcaccbdff8810097d8d12c56809
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
Nov 17, 2026 https://github.com/php-db/phpdb/pull/241#ref-pullrequest-6436612668
Double a quote character inside an identifier instead of replacing it #250 https://github.com/php-db/phpdb/pull/250
https://github.com/tyrsson
tyrssonhttps://github.com/tyrsson
Nov 17, 2026 https://github.com/php-db/phpdb/pull/241#pullrequestreview-5933204931
View reviewed changes https://github.com/php-db/phpdb/pull/241/files/5ed3670279bb738744641eee666fca480216a1e1
https://github.com/simon-mundy
Merge branch '0.6.x' into fix/select-column-identifierhttps://github.com/php-db/phpdb/pull/241/commits/5ed3670279bb738744641eee666fca480216a1e1
5ed3670https://github.com/php-db/phpdb/pull/241/commits/5ed3670279bb738744641eee666fca480216a1e1
https://github.com/tyrsson
tyrssonhttps://github.com/tyrsson
Nov 17, 2026 https://github.com/php-db/phpdb/pull/241#pullrequestreview-5933279252
View reviewed changes https://github.com/php-db/phpdb/pull/241/files/5ed3670279bb738744641eee666fca480216a1e1
https://github.com/simon-mundy
simon-mundyhttps://github.com/simon-mundy
633cbechttps://github.com/php-db/phpdb/commit/633cbec11dc0664f3cbfb993af2709fff3ce24be
Nov 17, 2026https://github.com/php-db/phpdb/pull/241#event-36367043847
Please reload this pagehttps://github.com/php-db/phpdb/pull/241
simon-mundyhttps://github.com/simon-mundy
Nov 17, 2026 https://github.com/php-db/phpdb/pull/241#ref-commit-d7971e2
https://github.com/simon-mundy
Expect doubled quotes in the identifier tests merged from 0.6.xhttps://github.com/simon-mundy/phpdb/commit/d7971e2fbb8e0e966e1e0a689141947d161a4a53
d7971e2https://github.com/simon-mundy/phpdb/commit/d7971e2fbb8e0e966e1e0a689141947d161a4a53
php-db#241https://github.com/php-db/phpdb/pull/241
php-db#243https://github.com/php-db/phpdb/pull/243
https://github.co/hiddenchars
https://github.com/php-db/phpdb/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F241
https://github.com/tyrsson
tyrsson https://github.com/tyrsson
https://github.com/php-db/phpdb/pull/241/files/5ed3670279bb738744641eee666fca480216a1e1
Please reload this pagehttps://github.com/php-db/phpdb/pull/241
Please reload this pagehttps://github.com/php-db/phpdb/pull/241
https://github.com/simon-mundy
https://github.com/tyrsson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.