| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:465eb4a9-b06e-583e-70c5-fd81f0f16453 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D26C:BC587:E429F:141FCB:6AFD6B64 |
| html-safe-nonce | 8c5909c2f595241d2584e6a2660ba8c2eb58f90922e5de4431ba4d748de94d1d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjZDOkJDNTg3OkU0MjlGOjE0MUZDQjo2QUZENkI2NCIsInZpc2l0b3JfaWQiOiIzMDkwOTc2Mzg1NzcwODEwMjEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 035fef3f731ce93de1bd6450d7d7a3456bef7c07727ab3b8e90d520d3f5a139d |
| hovercard-subject-tag | pull_request:4837271385 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/241/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/da317b9a32233bc4420f9b7b029fac0016b5525014a14c1f348ed8d79cd67457/php-db/phpdb/pull/241 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/da317b9a32233bc4420f9b7b029fac0016b5525014a14c1f348ed8d79cd67457/php-db/phpdb/pull/241 |
| og:image:alt | Merge order: merge this PR before #243 and #244. Both build on the IdentifierQuoter added here, so until this PR is merged their diffs also show its changes.
Problem
Select fragment-quotes column ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simon-mundy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9985ca2e21b59673104d4d830d4afeb946c67f248f273ab2e824c31c8db46e4a |
| turbo-cache-control | no-cache |
| go-import | github.com/php-db/phpdb git https://github.com/php-db/phpdb.git |
| octolytics-dimension-user_id | 219474457 |
| octolytics-dimension-user_login | php-db |
| octolytics-dimension-repository_id | 879488168 |
| octolytics-dimension-repository_nwo | php-db/phpdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 879488168 |
| octolytics-dimension-repository_network_root_nwo | php-db/phpdb |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0db9e8d463c3f4540570e6ad3c501a06db9dc02a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php-db/phpdb/pull/241#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F241 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F241 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb |
| Reload | https://github.com/php-db/phpdb/pull/241 |
| Reload | https://github.com/php-db/phpdb/pull/241 |
| Reload | https://github.com/php-db/phpdb/pull/241 |
| php-db | https://github.com/php-db |
| phpdb | https://github.com/php-db/phpdb |
| Code | https://github.com/php-db/phpdb |
| Issues34 (34) | https://github.com/php-db/phpdb/issues |
| Pull requests8 (8) | https://github.com/php-db/phpdb/pulls |
| Discussions | https://github.com/php-db/phpdb/discussions |
| Actions | https://github.com/php-db/phpdb/actions |
| Projects | https://github.com/php-db/phpdb/projects |
| Security and quality | https://github.com/php-db/phpdb/security |
| Insights | https://github.com/php-db/phpdb/insights |
| https://github.com/php-db/phpdb |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:fix/select-column-identifier | https://github.com/simon-mundy/phpdb/tree/fix/select-column-identifier |
| Conversation | https://github.com/php-db/phpdb/pull/241 |
| Commits7 (7) | https://github.com/php-db/phpdb/pull/241/commits |
| Checks | https://github.com/php-db/phpdb/pull/241/checks |
| Files changed | https://github.com/php-db/phpdb/pull/241/files |
| Quote Select, join and GROUP BY column names as identifiers | https://github.com/php-db/phpdb/pull/241#top |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:fix/select-column-identifier | https://github.com/simon-mundy/phpdb/tree/fix/select-column-identifier |
|
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Oct 13, 2026 | https://github.com/php-db/phpdb/pull/241#issue-5823193065 |
| Please reload this page | https://github.com/php-db/phpdb/pull/241 |
| #243 | https://github.com/php-db/phpdb/pull/243 |
| #244 | https://github.com/php-db/phpdb/pull/244 |
| #243 | https://github.com/php-db/phpdb/pull/243 |
| #244 | https://github.com/php-db/phpdb/pull/244 |
| #238 | https://github.com/php-db/phpdb/pull/238 |
| #243 | https://github.com/php-db/phpdb/pull/243 |
| #244 | https://github.com/php-db/phpdb/pull/244 |
| #243 | https://github.com/php-db/phpdb/pull/243 |
| #244 | https://github.com/php-db/phpdb/pull/244 |
| Quote Update SET columns as identifiers and bind them under valid placeholder names #238 | https://github.com/php-db/phpdb/pull/238 |
| Please reload this page | https://github.com/php-db/phpdb/pull/241 |
|
| https://github.com/simon-mundy |
| Quote Select, join and GROUP BY column names as identifiers | https://github.com/php-db/phpdb/pull/241/commits/2c910048e1e9f44e95dd45a610ae6477b29838f5 |
| 2c91004 | https://github.com/php-db/phpdb/pull/241/commits/2c910048e1e9f44e95dd45a610ae6477b29838f5 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Oct 13, 2026 | https://github.com/php-db/phpdb/pull/241#issuecomment-6136443085 |
| Please reload this page | https://github.com/php-db/phpdb/pull/241 |
| Codecov | https://app.codecov.io/gh/php-db/phpdb/pull/241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db |
| Let us know! | https://github.com/codecov/feedback/issues/255 |
| Please reload this page | https://github.com/php-db/phpdb/pull/241 |
|
| https://github.com/simon-mundy |
| Keep fragment quoting for column strings it already renders as valid SQL | https://github.com/php-db/phpdb/pull/241/commits/84996870976e6be9b6f7550b1101849c161e58ea |
| 8499687 | https://github.com/php-db/phpdb/pull/241/commits/84996870976e6be9b6f7550b1101849c161e58ea |
|
Quote ORDER BY names as identifiers where fragment quoting breaks them
#243
| https://github.com/php-db/phpdb/pull/243 |
|
Quote predicate names as identifiers where fragment quoting renders broken SQL
#244
| https://github.com/php-db/phpdb/pull/244 |
| simon-mundy | https://github.com/simon-mundy |
| November 4, 2026 14:26 | https://github.com/php-db/phpdb/pull/241#commits-pushed-967bd02 |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into fix/select-column-identifier | https://github.com/php-db/phpdb/pull/241/commits/967bd0233315fafdc5e7f467e2e21147ad5d8d4b |
| 967bd02 | https://github.com/php-db/phpdb/pull/241/commits/967bd0233315fafdc5e7f467e2e21147ad5d8d4b |
|
| https://github.com/simon-mundy |
| Quote identifier strings through one shared IdentifierQuoter | https://github.com/php-db/phpdb/pull/241/commits/4c19e83502efb745a483f0bc42be3bea49578dea |
| 4c19e83 | https://github.com/php-db/phpdb/pull/241/commits/4c19e83502efb745a483f0bc42be3bea49578dea |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 4, 2026
| https://github.com/php-db/phpdb/pull/241#ref-commit-a567853 |
|
| https://github.com/simon-mundy |
| Merge | https://github.com/simon-mundy/phpdb/commit/a5678539062a01deeca0f6c24dc28ee3193a745e |
| php-db#241 | https://github.com/php-db/phpdb/pull/241 |
| 's shared IdentifierQuoter into fix/order-name-identi… | https://github.com/simon-mundy/phpdb/commit/a5678539062a01deeca0f6c24dc28ee3193a745e |
| a567853 | https://github.com/simon-mundy/phpdb/commit/a5678539062a01deeca0f6c24dc28ee3193a745e |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 4, 2026
| https://github.com/php-db/phpdb/pull/241#ref-commit-2f4242b |
|
| https://github.com/simon-mundy |
| Merge | https://github.com/simon-mundy/phpdb/commit/2f4242bbd7797c75d435ff719e3acaf22d2c68f5 |
| php-db#241 | https://github.com/php-db/phpdb/pull/241 |
| 's shared IdentifierQuoter into fix/predicate-identifier | https://github.com/simon-mundy/phpdb/commit/2f4242bbd7797c75d435ff719e3acaf22d2c68f5 |
| 2f4242b | https://github.com/simon-mundy/phpdb/commit/2f4242bbd7797c75d435ff719e3acaf22d2c68f5 |
| simon-mundy | https://github.com/simon-mundy |
| November 4, 2026 16:28 | https://github.com/php-db/phpdb/pull/241#commits-pushed-9e79c6d |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into fix/select-column-identifier | https://github.com/php-db/phpdb/pull/241/commits/9e79c6d209fe1dbb53a0a82c3ed2cdbdb74c0088 |
| 9e79c6d | https://github.com/php-db/phpdb/pull/241/commits/9e79c6d209fe1dbb53a0a82c3ed2cdbdb74c0088 |
|
| https://github.com/simon-mundy |
| Cover the identifier exception factories in InvalidArgumentExceptionTest | https://github.com/php-db/phpdb/pull/241/commits/59d7710b31186fcaccbdff8810097d8d12c56809 |
| 59d7710 | https://github.com/php-db/phpdb/pull/241/commits/59d7710b31186fcaccbdff8810097d8d12c56809 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/241#ref-pullrequest-6436612668 |
|
Double a quote character inside an identifier instead of replacing it
#250
| https://github.com/php-db/phpdb/pull/250 |
| https://github.com/tyrsson |
| tyrsson | https://github.com/tyrsson |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/241#pullrequestreview-5933204931 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/241/files/5ed3670279bb738744641eee666fca480216a1e1 |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into fix/select-column-identifier | https://github.com/php-db/phpdb/pull/241/commits/5ed3670279bb738744641eee666fca480216a1e1 |
| 5ed3670 | https://github.com/php-db/phpdb/pull/241/commits/5ed3670279bb738744641eee666fca480216a1e1 |
| https://github.com/tyrsson |
| tyrsson | https://github.com/tyrsson |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/241#pullrequestreview-5933279252 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/241/files/5ed3670279bb738744641eee666fca480216a1e1 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| 633cbec | https://github.com/php-db/phpdb/commit/633cbec11dc0664f3cbfb993af2709fff3ce24be |
| Nov 17, 2026 | https://github.com/php-db/phpdb/pull/241#event-36367043847 |
| Please reload this page | https://github.com/php-db/phpdb/pull/241 |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 17, 2026
| https://github.com/php-db/phpdb/pull/241#ref-commit-d7971e2 |
|
| https://github.com/simon-mundy |
| Expect doubled quotes in the identifier tests merged from 0.6.x | https://github.com/simon-mundy/phpdb/commit/d7971e2fbb8e0e966e1e0a689141947d161a4a53 |
| d7971e2 | https://github.com/simon-mundy/phpdb/commit/d7971e2fbb8e0e966e1e0a689141947d161a4a53 |
| php-db#241 | https://github.com/php-db/phpdb/pull/241 |
| php-db#243 | https://github.com/php-db/phpdb/pull/243 |
| https://github.co/hiddenchars |
| https://github.com/php-db/phpdb/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F241 |
|
| https://github.com/tyrsson |
|
tyrsson
| https://github.com/tyrsson |
|
| https://github.com/php-db/phpdb/pull/241/files/5ed3670279bb738744641eee666fca480216a1e1 |
| Please reload this page | https://github.com/php-db/phpdb/pull/241 |
| Please reload this page | https://github.com/php-db/phpdb/pull/241 |
|
| https://github.com/simon-mundy |
|
| https://github.com/tyrsson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |