| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:787e5d2e-b885-ff30-88c3-815e3d4c912e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD30:28836A:10C451:17628A:6AFD8B90 |
| html-safe-nonce | 10224178e8e017927547bbf23a0fb320aac2500075f7d23c3957d75b76f4143b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDMwOjI4ODM2QToxMEM0NTE6MTc2MjhBOjZBRkQ4QjkwIiwidmlzaXRvcl9pZCI6Ijc4NDgzNzE2OTA4NjA4MDkxMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 74af3d48af5e46008d2ab91ff29d430e6602b90e740d278ba4552d235bf964ae |
| hovercard-subject-tag | pull_request:4837121568 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php-db/phpdb/240/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2cacd19d6958f6f766e184fa55a1e11c0834859581f6ce957daee94ff7bc5970/php-db/phpdb/pull/240 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2cacd19d6958f6f766e184fa55a1e11c0834859581f6ce957daee94ff7bc5970/php-db/phpdb/pull/240 |
| og:image:alt | Problem
A custom specification on In/NotIn loses list values and leaves orphan parameters:
$in = (new Predicate\In('id', [1, 2]))->setSpecification('%1$s = ANY (ARRAY[%2$s])');
(... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simon-mundy |
| hostname | github.com |
| expected-hostname | github.com |
| None | bc86424ef34a73b386237872800e922d149d65ba907f63d6f150a2dcb8433bea |
| turbo-cache-control | no-cache |
| go-import | github.com/php-db/phpdb git https://github.com/php-db/phpdb.git |
| octolytics-dimension-user_id | 219474457 |
| octolytics-dimension-user_login | php-db |
| octolytics-dimension-repository_id | 879488168 |
| octolytics-dimension-repository_nwo | php-db/phpdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 879488168 |
| octolytics-dimension-repository_network_root_nwo | php-db/phpdb |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 927a6c5ab1c32b38830f1b9d3050c0b9e9aa92e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php-db/phpdb/pull/240#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F240 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F240 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php-db%2Fphpdb |
| Reload | https://github.com/php-db/phpdb/pull/240 |
| Reload | https://github.com/php-db/phpdb/pull/240 |
| Reload | https://github.com/php-db/phpdb/pull/240 |
| php-db | https://github.com/php-db |
| phpdb | https://github.com/php-db/phpdb |
| Code | https://github.com/php-db/phpdb |
| Issues34 (34) | https://github.com/php-db/phpdb/issues |
| Pull requests8 (8) | https://github.com/php-db/phpdb/pulls |
| Discussions | https://github.com/php-db/phpdb/discussions |
| Actions | https://github.com/php-db/phpdb/actions |
| Projects | https://github.com/php-db/phpdb/projects |
| Security and quality | https://github.com/php-db/phpdb/security |
| Insights | https://github.com/php-db/phpdb/insights |
| https://github.com/php-db/phpdb |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:fix/in-custom-specification-values | https://github.com/simon-mundy/phpdb/tree/fix/in-custom-specification-values |
| Conversation | https://github.com/php-db/phpdb/pull/240 |
| Commits9 (9) | https://github.com/php-db/phpdb/pull/240/commits |
| Checks | https://github.com/php-db/phpdb/pull/240/checks |
| Files changed | https://github.com/php-db/phpdb/pull/240/files |
| Render every value of an In list through a custom specification | https://github.com/php-db/phpdb/pull/240#top |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:fix/in-custom-specification-values | https://github.com/simon-mundy/phpdb/tree/fix/in-custom-specification-values |
|
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Oct 13, 2026 | https://github.com/php-db/phpdb/pull/240#issue-5823008787 |
| Please reload this page | https://github.com/php-db/phpdb/pull/240 |
|
| https://github.com/simon-mundy |
| Render every value of an In list through a custom specification | https://github.com/php-db/phpdb/pull/240/commits/ea5dbb952052067950434eda9925c98da5509df4 |
| ea5dbb9 | https://github.com/php-db/phpdb/pull/240/commits/ea5dbb952052067950434eda9925c98da5509df4 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Oct 13, 2026 | https://github.com/php-db/phpdb/pull/240#issuecomment-6136193079 |
| Codecov | https://app.codecov.io/gh/php-db/phpdb/pull/240?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=php-db |
| Let us know! | https://github.com/codecov/feedback/issues/255 |
| Please reload this page | https://github.com/php-db/phpdb/pull/240 |
| simon-mundy | https://github.com/simon-mundy |
| November 4, 2026 11:00 | https://github.com/php-db/phpdb/pull/240#commits-pushed-bad329d |
|
| https://github.com/simon-mundy |
| Merge remote-tracking branch 'origin/0.6.x' into upd/240 | https://github.com/php-db/phpdb/pull/240/commits/bad329dc64d0623b2ea97a912f1e57bff61ec582 |
| bad329d | https://github.com/php-db/phpdb/pull/240/commits/bad329dc64d0623b2ea97a912f1e57bff61ec582 |
|
| https://github.com/simon-mundy |
| Reject unsupported conversions in custom In specifications | https://github.com/php-db/phpdb/pull/240/commits/ad9d06a12578900e6b5d854cc40cb9a18bedbff7 |
| ad9d06a | https://github.com/php-db/phpdb/pull/240/commits/ad9d06a12578900e6b5d854cc40cb9a18bedbff7 |
| https://github.com/tyrsson |
| tyrsson | https://github.com/tyrsson |
|
Nov 4, 2026
| https://github.com/php-db/phpdb/pull/240#ref-pullrequest-6195113003 |
|
Reject custom In specifications that cannot be expanded safely
#247
| https://github.com/php-db/phpdb/pull/247 |
| simon-mundy | https://github.com/simon-mundy |
| November 4, 2026 13:56 | https://github.com/php-db/phpdb/pull/240#commits-pushed-356d4b6 |
|
| https://github.com/simon-mundy |
| Reject mixed placeholder styles in custom In specifications | https://github.com/php-db/phpdb/pull/240/commits/356d4b604515fa50e3d8d856bddb34879639ff29 |
| 356d4b6 | https://github.com/php-db/phpdb/pull/240/commits/356d4b604515fa50e3d8d856bddb34879639ff29 |
| php-db#247 | https://github.com/php-db/phpdb/pull/247 |
|
| https://github.com/simon-mundy |
| Build each argument's placeholders in one pass | https://github.com/php-db/phpdb/pull/240/commits/9a6c608a360834e3982ba75e907eb334681ae119 |
| 9a6c608 | https://github.com/php-db/phpdb/pull/240/commits/9a6c608a360834e3982ba75e907eb334681ae119 |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into fix/in-custom-specification-values | https://github.com/php-db/phpdb/pull/240/commits/88dc7b7655c93a7b79ee1c6675125b72f3e615e6 |
| 88dc7b7 | https://github.com/php-db/phpdb/pull/240/commits/88dc7b7655c93a7b79ee1c6675125b72f3e615e6 |
|
| https://github.com/simon-mundy |
| Address review feedback on custom In specifications | https://github.com/php-db/phpdb/pull/240/commits/79b6d16a88c2198a5d32097ec2d199ba6b420f9a |
| 79b6d16 | https://github.com/php-db/phpdb/pull/240/commits/79b6d16a88c2198a5d32097ec2d199ba6b420f9a |
|
| https://github.com/simon-mundy |
| Merge remote-tracking branch 'fork/fix/in-custom-specification-values… | https://github.com/php-db/phpdb/pull/240/commits/b6075849d31a18aa83dda1415b386ccd83c9a90d |
| b607584 | https://github.com/php-db/phpdb/pull/240/commits/b6075849d31a18aa83dda1415b386ccd83c9a90d |
| https://github.com/tyrsson |
| tyrsson | https://github.com/tyrsson |
|
Nov 4, 2026
| https://github.com/php-db/phpdb/pull/240#pullrequestreview-5762711874 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/240/files/427ffd0a5f33b00fa2d93951d324f29b70ef9152 |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into fix/in-custom-specification-values | https://github.com/php-db/phpdb/pull/240/commits/427ffd0a5f33b00fa2d93951d324f29b70ef9152 |
| 427ffd0 | https://github.com/php-db/phpdb/pull/240/commits/427ffd0a5f33b00fa2d93951d324f29b70ef9152 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| 680459a | https://github.com/php-db/phpdb/commit/680459a92e170ea8e67626626e246475a699d5ef |
| Nov 4, 2026 | https://github.com/php-db/phpdb/pull/240#event-35089604970 |
| Please reload this page | https://github.com/php-db/phpdb/pull/240 |
| simon-mundy | https://github.com/simon-mundy |
|
Nov 4, 2026
| https://github.com/php-db/phpdb/pull/240#ref-commit-5d7d9dc |
|
| https://github.com/simon-mundy |
| Merge branch '0.6.x' into fix/expression-set-specification | https://github.com/simon-mundy/phpdb/commit/5d7d9dc4cf8e1f3fd7fec1c0009cc6e096f0d075 |
| 5d7d9dc | https://github.com/simon-mundy/phpdb/commit/5d7d9dc4cf8e1f3fd7fec1c0009cc6e096f0d075 |
| php-db#235 | https://github.com/php-db/phpdb/pull/235 |
| php-db#240 | https://github.com/php-db/phpdb/pull/240 |
| php-db#240 | https://github.com/php-db/phpdb/pull/240 |
| https://github.co/hiddenchars |
| https://github.com/php-db/phpdb/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F240 |
|
| https://github.com/tyrsson |
|
tyrsson
| https://github.com/tyrsson |
|
| https://github.com/php-db/phpdb/pull/240/files/427ffd0a5f33b00fa2d93951d324f29b70ef9152 |
| Please reload this page | https://github.com/php-db/phpdb/pull/240 |
| Please reload this page | https://github.com/php-db/phpdb/pull/240 |
|
| https://github.com/simon-mundy |
|
| https://github.com/tyrsson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |