| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:b3ad8883-df84-fb51-f835-ddb4b8831440 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD64:30E9CC:EBBCA:1573FE:6AFD72DF |
| html-safe-nonce | bfe0d0771c595f2c5191c348c35bc9e0c9c6af7bbebe9792337471e990fc8493 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDY0OjMwRTlDQzpFQkJDQToxNTczRkU6NkFGRDcyREYiLCJ2aXNpdG9yX2lkIjoiNzEyMTcxMzA3MTc2ODA0MDE1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | db2a32008334bae1d80d409d933198cde329d6d4d5428ad8af6bd61167f15ed6 |
| hovercard-subject-tag | pull_request:4249811298 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/php-db/phpdb/pull/172 |
| twitter:image | https://opengraph.githubassets.com/be41e3a0a4c9f368e1477abeb15ee21845b2c69ac971e1fa38f9dbbb853ca5b6/php-db/phpdb/pull/172 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/be41e3a0a4c9f368e1477abeb15ee21845b2c69ac971e1fa38f9dbbb853ca5b6/php-db/phpdb/pull/172 |
| og:image:alt | Summary
Implements #171: splits Adapter::query() into two single-purpose methods, deprecating query() as a BC-preserving proxy.
prepareQuery(string $sql, ParameterContainer|array $parameters = [])... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | simon-mundy |
| hostname | github.com |
| expected-hostname | github.com |
| None | e54006cf2b96d1ac260960edd10003132911469ccd1ec99c9803119fe2a4e032 |
| turbo-cache-control | no-cache |
| go-import | github.com/php-db/phpdb git https://github.com/php-db/phpdb.git |
| octolytics-dimension-user_id | 219474457 |
| octolytics-dimension-user_login | php-db |
| octolytics-dimension-repository_id | 879488168 |
| octolytics-dimension-repository_nwo | php-db/phpdb |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 879488168 |
| octolytics-dimension-repository_network_root_nwo | php-db/phpdb |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5be0bf2b8cf26f8897d31e6bc3c232d328b12a54 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php-db/phpdb/pull/172#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F172 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F172 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=php-db%2Fphpdb |
| Reload | https://github.com/php-db/phpdb/pull/172 |
| Reload | https://github.com/php-db/phpdb/pull/172 |
| Reload | https://github.com/php-db/phpdb/pull/172 |
| php-db | https://github.com/php-db |
| phpdb | https://github.com/php-db/phpdb |
| Code | https://github.com/php-db/phpdb |
| Issues34 (34) | https://github.com/php-db/phpdb/issues |
| Pull requests8 (8) | https://github.com/php-db/phpdb/pulls |
| Discussions | https://github.com/php-db/phpdb/discussions |
| Actions | https://github.com/php-db/phpdb/actions |
| Projects | https://github.com/php-db/phpdb/projects |
| Security and quality | https://github.com/php-db/phpdb/security |
| Insights | https://github.com/php-db/phpdb/insights |
| https://github.com/php-db/phpdb |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:171-rfc-split-adapter-query | https://github.com/simon-mundy/phpdb/tree/171-rfc-split-adapter-query |
| Conversation | https://github.com/php-db/phpdb/pull/172 |
| Commits6 (6) | https://github.com/php-db/phpdb/pull/172/commits |
| Checks | https://github.com/php-db/phpdb/pull/172/checks |
| Files changed | https://github.com/php-db/phpdb/pull/172/files |
| Split Adapter::query() into prepareQuery() and executeQuery() | https://github.com/php-db/phpdb/pull/172#top |
| simon-mundy | https://github.com/simon-mundy |
| php-db:0.6.x | https://github.com/php-db/phpdb/tree/0.6.x |
| simon-mundy:171-rfc-split-adapter-query | https://github.com/simon-mundy/phpdb/tree/171-rfc-split-adapter-query |
|
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Aug 11, 2026 | https://github.com/php-db/phpdb/pull/172#issue-5116202824 |
| Please reload this page | https://github.com/php-db/phpdb/pull/172 |
| #171 | https://github.com/php-db/phpdb/issues/171 |
| Please reload this page | https://github.com/php-db/phpdb/pull/172 |
|
| https://github.com/simon-mundy |
| Split Adapter::query() into prepareQuery() and executeQuery() | https://github.com/php-db/phpdb/pull/172/commits/6a148867dcf52f37ac6dc2d1acbd3c1792aa76c8 |
| 6a14886 | https://github.com/php-db/phpdb/pull/172/commits/6a148867dcf52f37ac6dc2d1acbd3c1792aa76c8 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| tyrsson | https://github.com/tyrsson |
| August 11, 2026 02:55 | https://github.com/php-db/phpdb/pull/172#event-29257131976 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| Aug 11, 2026 | https://github.com/php-db/phpdb/pull/172#event-29257133394 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
|
enhancement
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aenhancement |
|
qa
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aqa |
|
next minor
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3A%22next%20minor%22 |
| Aug 11, 2026 | https://github.com/php-db/phpdb/pull/172#event-29257142753 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Aug 11, 2026 | https://github.com/php-db/phpdb/pull/172#event-29257146915 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Aug 11, 2026 | https://github.com/php-db/phpdb/pull/172#event-29257148158 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| 0.6.0 | https://github.com/php-db/phpdb/milestone/22 |
| Aug 11, 2026 | https://github.com/php-db/phpdb/pull/172#event-29257148684 |
| simon-mundy | https://github.com/simon-mundy |
| August 11, 2026 13:09 | https://github.com/php-db/phpdb/pull/172#commits-pushed-2676fd3 |
|
| https://github.com/simon-mundy |
| Fix inaccurate return type on Select::resolveTable() | https://github.com/php-db/phpdb/pull/172/commits/2676fd3a141b5ca6a4c667f65f2fa768591dae97 |
| 2676fd3 | https://github.com/php-db/phpdb/pull/172/commits/2676fd3a141b5ca6a4c667f65f2fa768591dae97 |
|
| https://github.com/simon-mundy |
| Add prepareQuery() and executeQuery() to AdapterInterface | https://github.com/php-db/phpdb/pull/172/commits/f659607f3c298ad5ac5c1a257b28f447e4d1ff14 |
| f659607 | https://github.com/php-db/phpdb/pull/172/commits/f659607f3c298ad5ac5c1a257b28f447e4d1ff14 |
|
| https://github.com/simon-mundy |
| Simplify deprecated Adapter::query() using match and a guard clause | https://github.com/php-db/phpdb/pull/172/commits/57788b07111020690d44ebbfe6bc0e19406c51b8 |
| 57788b0 | https://github.com/php-db/phpdb/pull/172/commits/57788b07111020690d44ebbfe6bc0e19406c51b8 |
|
| https://github.com/simon-mundy |
| Shorten Adapter::query() invalid-mode exception message | https://github.com/php-db/phpdb/pull/172/commits/76945023904a4a02cc7af7736fc950a987dfc9d3 |
| 7694502 | https://github.com/php-db/phpdb/pull/172/commits/76945023904a4a02cc7af7736fc950a987dfc9d3 |
|
| https://github.com/simon-mundy |
| Order executeQuery() union type with scalar last | https://github.com/php-db/phpdb/pull/172/commits/6b1b072f3b44b06ce71aa4e8f8cbeae6fbaf02e4 |
| 6b1b072 | https://github.com/php-db/phpdb/pull/172/commits/6b1b072f3b44b06ce71aa4e8f8cbeae6fbaf02e4 |
| https://github.com/tyrsson |
| tyrsson | https://github.com/tyrsson |
|
Aug 12, 2026
| https://github.com/php-db/phpdb/pull/172#pullrequestreview-4918027153 |
|
View reviewed changes
| https://github.com/php-db/phpdb/pull/172/files/6b1b072f3b44b06ce71aa4e8f8cbeae6fbaf02e4 |
| tyrsson | https://github.com/tyrsson |
| https://github.com/php-db/phpdb/pull/172#pullrequestreview-4918027153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/php-db/phpdb/pull/172 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Aug 12, 2026 | https://github.com/php-db/phpdb/pull/172#event-29348074975 |
| https://github.com/simon-mundy |
| simon-mundy | https://github.com/simon-mundy |
| 5c561a6 | https://github.com/php-db/phpdb/commit/5c561a620d20088fef9111f090da295ab82d7cd0 |
| Aug 12, 2026 | https://github.com/php-db/phpdb/pull/172#event-29368881751 |
| Please reload this page | https://github.com/php-db/phpdb/pull/172 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| @phpdb | https://github.com/orgs/php-db/projects/2 |
| Aug 12, 2026 | https://github.com/php-db/phpdb/pull/172#event-29368903629 |
|
Result does not implement ResultInterface::getQueryResult() — fatal against current php-db/phpdb 0.6.x-dev
php-db/phpdb-pgsql#12
| https://github.com/php-db/phpdb-pgsql/issues/12 |
|
Implement Result::getQueryResult()
php-db/phpdb-pgsql#14
| https://github.com/php-db/phpdb-pgsql/pull/14 |
| simon-mundy | https://github.com/simon-mundy |
|
Aug 26, 2026
| https://github.com/php-db/phpdb/pull/172#ref-commit-88681e7 |
|
| https://github.com/simon-mundy |
| Implement Result::getQueryResult() | https://github.com/php-db/phpdb-pgsql/commit/88681e7542101e9cb5f58fe8f336093fe2018ec1 |
| 88681e7 | https://github.com/php-db/phpdb-pgsql/commit/88681e7542101e9cb5f58fe8f336093fe2018ec1 |
| php-db/phpdb#172 | https://github.com/php-db/phpdb/pull/172 |
| https://github.co/hiddenchars |
| https://github.com/php-db/phpdb/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp-db%2Fphpdb%2Fpull%2F172 |
|
| https://github.com/tyrsson |
|
tyrsson
| https://github.com/tyrsson |
|
| https://github.com/php-db/phpdb/pull/172/files/6b1b072f3b44b06ce71aa4e8f8cbeae6fbaf02e4 |
| Please reload this page | https://github.com/php-db/phpdb/pull/172 |
|
| https://github.com/simon-mundy |
|
simon-mundy
| https://github.com/simon-mundy |
|
enhancement
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aenhancement |
|
next minor
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3A%22next%20minor%22 |
|
qa
| https://github.com/php-db/phpdb/issues?q=state%3Aopen%20label%3Aqa |
|
@phpdb
| https://github.com/orgs/php-db/projects/2 |
|
0.6.0
| https://github.com/php-db/phpdb/milestone/22 |
| Please reload this page | https://github.com/php-db/phpdb/pull/172 |
|
| https://github.com/simon-mundy |
|
| https://github.com/tyrsson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |