René's URL Explorer Experiment


Title: Fix GH-8924 str_split of empty string must return empty array by mvorisek · Pull Request #8945 · php/php-src · GitHub

Open Graph Title: Fix GH-8924 str_split of empty string must return empty array by mvorisek · Pull Request #8945 · php/php-src

X Title: Fix GH-8924 str_split of empty string must return empty array by mvorisek · Pull Request #8945 · php/php-src

Description: The inconsistency was introduced in 0818fae by a mistake as found out by @emkey08. mb_str_split behaves properly and empty input is covered by a test already. As some algorithms might rely on the bad - always non-empty array - behaviour, targetting master only.

Open Graph Description: The inconsistency was introduced in 0818fae by a mistake as found out by @emkey08. mb_str_split behaves properly and empty input is covered by a test already. As some algorithms might rely on the b...

X Description: The inconsistency was introduced in 0818fae by a mistake as found out by @emkey08. mb_str_split behaves properly and empty input is covered by a test already. As some algorithms might rely on the b...

Opengraph URL: https://github.com/php/php-src/pull/8945

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:82b8369c-2264-5972-7e9b-fa4e29aaef90
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC28:14F601:102B8B3:14B24C6:6B00FF20
html-safe-nonce8ddc74b692e2e5c3166be6c7440a65060c553284d2fc0e40dff6eeb69947da50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzI4OjE0RjYwMToxMDJCOEIzOjE0QjI0QzY6NkIwMEZGMjAiLCJ2aXNpdG9yX2lkIjoiNTIyNDQwOTk4ODg2MDAxODQ2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac37cbf5b076fed8d0d62e0675351c620ee0ce552cafa4ea9aeb875c9af70b0713
hovercard-subject-tagpull_request:989855837
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/php/php-src/pull/8945/files
twitter:imagehttps://avatars.githubusercontent.com/u/2228672?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2228672?s=400&v=4
og:image:altThe inconsistency was introduced in 0818fae by a mistake as found out by @emkey08. mb_str_split behaves properly and empty input is covered by a test already. As some algorithms might rely on the b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/php/php-src git https://github.com/php/php-src.git
octolytics-dimension-user_id25158
octolytics-dimension-user_loginphp
octolytics-dimension-repository_id1903522
octolytics-dimension-repository_nwophp/php-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1903522
octolytics-dimension-repository_network_root_nwophp/php-src
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/php/php-src/pull/8945/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F8945%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F8945%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=php%2Fphp-src
Reloadhttps://github.com/php/php-src/pull/8945/files
Reloadhttps://github.com/php/php-src/pull/8945/files
Reloadhttps://github.com/php/php-src/pull/8945/files
phphttps://github.com/php
php-srchttps://github.com/php/php-src
Codehttps://github.com/php/php-src
Issues1k (1k)https://github.com/php/php-src/issues
Pull requests1.3k (1.3k)https://github.com/php/php-src/pulls
Actionshttps://github.com/php/php-src/actions
Security and quality83 (83)https://github.com/php/php-src/security
Insightshttps://github.com/php/php-src/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fphp%2Fphp-src%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fphp%2Fphp-src%2Fissues%2Fnew%2Fchoose
mvorisekhttps://github.com/mvorisek
php:masterhttps://github.com/php/php-src/tree/master
mvorisek:fix_str_splithttps://github.com/mvorisek/php-src/tree/fix_str_split
Conversation 5 https://github.com/php/php-src/pull/8945
Commits 1 https://github.com/php/php-src/pull/8945/commits
Checks 0 https://github.com/php/php-src/pull/8945/checks
Files changed https://github.com/php/php-src/pull/8945/files
Please reload this pagehttps://github.com/php/php-src/pull/8945/files
Fix GH-8924 str_split of empty string must return empty array https://github.com/php/php-src/pull/8945/files#top
Show all changes 1 commit https://github.com/php/php-src/pull/8945/files
2ac65bf Fix GH-8924 str_split of empty string must return empty array mvorisek Jul 7, 2022 https://github.com/php/php-src/pull/8945/commits/2ac65bf03cd1cd57419d957dc352827eff2e8efd
Clear filters https://github.com/php/php-src/pull/8945/files
Please reload this pagehttps://github.com/php/php-src/pull/8945/files
Please reload this pagehttps://github.com/php/php-src/pull/8945/files
string.c https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503
str_split_basic.phpt https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2
str_split_variation3.phpt https://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389
str_split_variation4.phpt https://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac
str_split_variation5.phpt https://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8
https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56
ext/standard/string.chttps://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503
View file https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/string.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php/php-src/pull/8945/{{ revealButtonHref }}
https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503
https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503
https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56
ext/standard/tests/strings/str_split_basic.phpthttps://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2
View file https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_basic.phpt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php/php-src/pull/8945/{{ revealButtonHref }}
https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2
https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2
https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2
https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56
ext/standard/tests/strings/str_split_variation3.phpthttps://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389
View file https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_variation3.phpt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php/php-src/pull/8945/{{ revealButtonHref }}
https://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389
https://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389
https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56
ext/standard/tests/strings/str_split_variation4.phpthttps://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac
View file https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_variation4.phpt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php/php-src/pull/8945/{{ revealButtonHref }}
https://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac
https://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac
https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56
ext/standard/tests/strings/str_split_variation5.phpthttps://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8
View file https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_variation5.phpt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/php/php-src/pull/8945/{{ revealButtonHref }}
https://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8
https://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.