| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:82b8369c-2264-5972-7e9b-fa4e29aaef90 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC28:14F601:102B8B3:14B24C6:6B00FF20 |
| html-safe-nonce | 8ddc74b692e2e5c3166be6c7440a65060c553284d2fc0e40dff6eeb69947da50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzI4OjE0RjYwMToxMDJCOEIzOjE0QjI0QzY6NkIwMEZGMjAiLCJ2aXNpdG9yX2lkIjoiNTIyNDQwOTk4ODg2MDAxODQ2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 37cbf5b076fed8d0d62e0675351c620ee0ce552cafa4ea9aeb875c9af70b0713 |
| hovercard-subject-tag | pull_request:989855837 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/php/php-src/pull/8945/files |
| twitter:image | https://avatars.githubusercontent.com/u/2228672?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2228672?s=400&v=4 |
| og:image:alt | The inconsistency was introduced in 0818fae by a mistake as found out by @emkey08.
mb_str_split behaves properly and empty input is covered by a test already.
As some algorithms might rely on the b... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/php/php-src git https://github.com/php/php-src.git |
| octolytics-dimension-user_id | 25158 |
| octolytics-dimension-user_login | php |
| octolytics-dimension-repository_id | 1903522 |
| octolytics-dimension-repository_nwo | php/php-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1903522 |
| octolytics-dimension-repository_network_root_nwo | php/php-src |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/php/php-src/pull/8945/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F8945%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F8945%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=php%2Fphp-src |
| Reload | https://github.com/php/php-src/pull/8945/files |
| Reload | https://github.com/php/php-src/pull/8945/files |
| Reload | https://github.com/php/php-src/pull/8945/files |
| php | https://github.com/php |
| php-src | https://github.com/php/php-src |
| Code | https://github.com/php/php-src |
| Issues1k (1k) | https://github.com/php/php-src/issues |
| Pull requests1.3k (1.3k) | https://github.com/php/php-src/pulls |
| Actions | https://github.com/php/php-src/actions |
| Security and quality83 (83) | https://github.com/php/php-src/security |
| Insights | https://github.com/php/php-src/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fphp%2Fphp-src%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fphp%2Fphp-src%2Fissues%2Fnew%2Fchoose |
| mvorisek | https://github.com/mvorisek |
| php:master | https://github.com/php/php-src/tree/master |
| mvorisek:fix_str_split | https://github.com/mvorisek/php-src/tree/fix_str_split |
|
Conversation
5
| https://github.com/php/php-src/pull/8945 |
|
Commits
1
| https://github.com/php/php-src/pull/8945/commits |
|
Checks
0
| https://github.com/php/php-src/pull/8945/checks |
|
Files changed
| https://github.com/php/php-src/pull/8945/files |
| Please reload this page | https://github.com/php/php-src/pull/8945/files |
|
Fix GH-8924 str_split of empty string must return empty array
| https://github.com/php/php-src/pull/8945/files#top |
|
Show all changes
1 commit
| https://github.com/php/php-src/pull/8945/files |
|
2ac65bf
Fix GH-8924 str_split of empty string must return empty array
mvorisek Jul 7, 2022
| https://github.com/php/php-src/pull/8945/commits/2ac65bf03cd1cd57419d957dc352827eff2e8efd |
|
Clear filters
| https://github.com/php/php-src/pull/8945/files |
| Please reload this page | https://github.com/php/php-src/pull/8945/files |
| Please reload this page | https://github.com/php/php-src/pull/8945/files |
|
string.c
| https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503 |
|
str_split_basic.phpt
| https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2 |
|
str_split_variation3.phpt
| https://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389 |
|
str_split_variation4.phpt
| https://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac |
|
str_split_variation5.phpt
| https://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8 |
|
| https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56 |
| ext/standard/string.c | https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503 |
|
View file
| https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/string.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/8945/{{ revealButtonHref }} |
|
| https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503 |
|
| https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503 |
|
| https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56 |
| ext/standard/tests/strings/str_split_basic.phpt | https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2 |
|
View file
| https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_basic.phpt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/8945/{{ revealButtonHref }} |
|
| https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2 |
|
| https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2 |
|
| https://github.com/php/php-src/pull/8945/files#diff-3788860644ff130aa170b8a18f0a32dd59b71919f9719a416adb04ad1d67b2d2 |
|
| https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56 |
| ext/standard/tests/strings/str_split_variation3.phpt | https://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389 |
|
View file
| https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_variation3.phpt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/8945/{{ revealButtonHref }} |
|
| https://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389 |
|
| https://github.com/php/php-src/pull/8945/files#diff-b1fee29019dc36e611a017e78e1878f11d1c69cac4cf2d102f7f17e14abb9389 |
|
| https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56 |
| ext/standard/tests/strings/str_split_variation4.phpt | https://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac |
|
View file
| https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_variation4.phpt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/8945/{{ revealButtonHref }} |
|
| https://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac |
|
| https://github.com/php/php-src/pull/8945/files#diff-59808ffc670bb96a8d59fe6eeb3c640f8b821155ee09425c8599a936fd3d17ac |
|
| https://github.com/php/php-src/blob/master/.github/CODEOWNERS#L56 |
| ext/standard/tests/strings/str_split_variation5.phpt | https://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8 |
|
View file
| https://github.com/mvorisek/php-src/blob/2ac65bf03cd1cd57419d957dc352827eff2e8efd/ext/standard/tests/strings/str_split_variation5.phpt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/8945/{{ revealButtonHref }} |
|
| https://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8 |
|
| https://github.com/php/php-src/pull/8945/files#diff-cbace2d71799881b817ee606139c133a6a89af0b39e43b90a7574917748360e8 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |