| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:88c12e01-27c9-9331-526e-5ab38713582b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 985A:311640:9CBFC9:C87F5B:6B00F163 |
| html-safe-nonce | 39ff22fd2fcbbbb5e20de2362bf58815a35b191200ca46375f73d759b05f2728 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODVBOjMxMTY0MDo5Q0JGQzk6Qzg3RjVCOjZCMDBGMTYzIiwidmlzaXRvcl9pZCI6IjQ0OTg0NDU1MTM3OTE2OTcyNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b62f85e6f6a3e42e088b7f76a74bc70a8b0158467219aa360492e1dabd0d3d4b |
| hovercard-subject-tag | pull_request:989855837 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php/php-src/8945/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/70233a5463ea74a48dbea5dc74632bf271ca58588ac36b9c88358bcc2353fb6f/php/php-src/pull/8945 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/70233a5463ea74a48dbea5dc74632bf271ca58588ac36b9c88358bcc2353fb6f/php/php-src/pull/8945 |
| og:image:alt | The inconsistency was introduced in 0818fae by a mistake as found out by @emkey08.
mb_str_split behaves properly and empty input is covered by a test already.
As some algorithms might rely on the b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mvorisek |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/php/php-src git https://github.com/php/php-src.git |
| octolytics-dimension-user_id | 25158 |
| octolytics-dimension-user_login | php |
| octolytics-dimension-repository_id | 1903522 |
| octolytics-dimension-repository_nwo | php/php-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1903522 |
| octolytics-dimension-repository_network_root_nwo | php/php-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php/php-src/pull/8945#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F8945 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F8945 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php%2Fphp-src |
| Reload | https://github.com/php/php-src/pull/8945 |
| Reload | https://github.com/php/php-src/pull/8945 |
| Reload | https://github.com/php/php-src/pull/8945 |
| php | https://github.com/php |
| php-src | https://github.com/php/php-src |
| Code | https://github.com/php/php-src |
| Issues1k (1k) | https://github.com/php/php-src/issues |
| Pull requests1.3k (1.3k) | https://github.com/php/php-src/pulls |
| Actions | https://github.com/php/php-src/actions |
| Security and quality83 (83) | https://github.com/php/php-src/security |
| Insights | https://github.com/php/php-src/insights |
| https://github.com/php/php-src |
| mvorisek | https://github.com/mvorisek |
| php:master | https://github.com/php/php-src/tree/master |
| mvorisek:fix_str_split | https://github.com/mvorisek/php-src/tree/fix_str_split |
| Conversation | https://github.com/php/php-src/pull/8945 |
| Commits1 (1) | https://github.com/php/php-src/pull/8945/commits |
| Checks | https://github.com/php/php-src/pull/8945/checks |
| Files changed | https://github.com/php/php-src/pull/8945/files |
| Fix GH-8924 str_split of empty string must return empty array | https://github.com/php/php-src/pull/8945#top |
| mvorisek | https://github.com/mvorisek |
| php:master | https://github.com/php/php-src/tree/master |
| mvorisek:fix_str_split | https://github.com/mvorisek/php-src/tree/fix_str_split |
|
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
| Jul 7, 2022 | https://github.com/php/php-src/pull/8945#issue-1297017162 |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
| 0818fae | https://github.com/php/php-src/commit/0818faee7f4f3501b5521e31a830e647cea2d1ec |
| @emkey08 | https://github.com/emkey08 |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Extension: standard
| https://github.com/php/php-src/issues?q=state%3Aopen%20label%3A%22Extension%3A%20standard%22 |
| Jul 7, 2022 | https://github.com/php/php-src/pull/8945#event-6949452689 |
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
| July 7, 2022 08:25 | https://github.com/php/php-src/pull/8945#event-6949456263 |
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
| force-pushed | https://github.com/php/php-src/compare/4bbd9d8dd8290f0f045948a55ef03a7e9009d430..68e07662ed0119e9edb8c19119fd4737791e53e1 |
| 4bbd9d8 | https://github.com/php/php-src/commit/4bbd9d8dd8290f0f045948a55ef03a7e9009d430 |
| 68e0766 | https://github.com/php/php-src/commit/68e07662ed0119e9edb8c19119fd4737791e53e1 |
|
Compare
| https://github.com/php/php-src/compare/4bbd9d8dd8290f0f045948a55ef03a7e9009d430..68e07662ed0119e9edb8c19119fd4737791e53e1 |
| July 7, 2022 08:46 | https://github.com/php/php-src/pull/8945#event-6949614685 |
| https://github.com/cmb69 |
| cmb69 | https://github.com/cmb69 |
|
Jul 7, 2022
| https://github.com/php/php-src/pull/8945#pullrequestreview-1031351049 |
|
View reviewed changes
| https://github.com/php/php-src/pull/8945/files |
| cmb69 | https://github.com/cmb69 |
| https://github.com/php/php-src/pull/8945#pullrequestreview-1031351049 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
| ext/standard/string.c | https://github.com/php/php-src/pull/8945/files#diff-fcf8a2a38ee4a0e3e2cb7c47251c9920ba8c5886d85969f676f9ddbee7aba503 |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
| force-pushed | https://github.com/php/php-src/compare/7a5b7ebd3b9a14ade07acdb8915a9f7afd1eda88..4f68399b51e287ddfcc5d85aba1ec57370e4c010 |
| 7a5b7eb | https://github.com/php/php-src/commit/7a5b7ebd3b9a14ade07acdb8915a9f7afd1eda88 |
| 4f68399 | https://github.com/php/php-src/commit/4f68399b51e287ddfcc5d85aba1ec57370e4c010 |
|
Compare
| https://github.com/php/php-src/compare/7a5b7ebd3b9a14ade07acdb8915a9f7afd1eda88..4f68399b51e287ddfcc5d85aba1ec57370e4c010 |
| July 7, 2022 10:49 | https://github.com/php/php-src/pull/8945#event-6950492049 |
|
| https://github.com/mvorisek |
|
| https://github.com/cmb69 |
| Fix | https://github.com/php/php-src/pull/8945/commits/2ac65bf03cd1cd57419d957dc352827eff2e8efd |
| phpGH-8924 | https://github.com/php/php-src/issues/8924 |
| str_split of empty string must return empty array | https://github.com/php/php-src/pull/8945/commits/2ac65bf03cd1cd57419d957dc352827eff2e8efd |
| 2ac65bf | https://github.com/php/php-src/pull/8945/commits/2ac65bf03cd1cd57419d957dc352827eff2e8efd |
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
| force-pushed | https://github.com/php/php-src/compare/4f68399b51e287ddfcc5d85aba1ec57370e4c010..2ac65bf03cd1cd57419d957dc352827eff2e8efd |
| 4f68399 | https://github.com/php/php-src/commit/4f68399b51e287ddfcc5d85aba1ec57370e4c010 |
| 2ac65bf | https://github.com/php/php-src/commit/2ac65bf03cd1cd57419d957dc352827eff2e8efd |
|
Compare
| https://github.com/php/php-src/compare/4f68399b51e287ddfcc5d85aba1ec57370e4c010..2ac65bf03cd1cd57419d957dc352827eff2e8efd |
| July 7, 2022 10:51 | https://github.com/php/php-src/pull/8945#event-6950508520 |
| https://github.com/cmb69 |
| cmb69 | https://github.com/cmb69 |
|
Jul 7, 2022
| https://github.com/php/php-src/pull/8945#pullrequestreview-1031434731 |
|
View reviewed changes
| https://github.com/php/php-src/pull/8945/files/2ac65bf03cd1cd57419d957dc352827eff2e8efd |
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
|
Jul 7, 2022
| https://github.com/php/php-src/pull/8945#ref-pullrequest-1295480111 |
|
Fix handling of str_split / mb_str_split string arg compound types + default return type for mb_str_split
phpstan/phpstan-src#1496
| https://github.com/phpstan/phpstan-src/pull/1496 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| Jul 8, 2022 | https://github.com/php/php-src/pull/8945#issuecomment-1178961966 |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
| https://github.com/cmb69 |
| cmb69 | https://github.com/cmb69 |
| Jul 8, 2022 | https://github.com/php/php-src/pull/8945#issuecomment-1178969108 |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
| e809254 | https://github.com/php/php-src/commit/e80925445c535ea83d8104f836207cdca608ffa0 |
| Jul 8, 2022 | https://github.com/php/php-src/pull/8945#event-6960778610 |
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
| July 8, 2022 16:54 | https://github.com/php/php-src/pull/8945#event-6961551259 |
| iluuu1994 | https://github.com/iluuu1994 |
|
Jul 14, 2022
| https://github.com/php/php-src/pull/8945#ref-commit-dc6e4e5 |
|
| https://github.com/iluuu1994 |
| Fix RC func info of str_split | https://github.com/iluuu1994/php-src/commit/dc6e4e511f99b9fccb21eb177098e4d2344fd795 |
| dc6e4e5 | https://github.com/iluuu1994/php-src/commit/dc6e4e511f99b9fccb21eb177098e4d2344fd795 |
| phpGH-8945 | https://github.com/php/php-src/pull/8945 |
| https://github.com/iluuu1994 |
| iluuu1994 | https://github.com/iluuu1994 |
|
Jul 14, 2022
| https://github.com/php/php-src/pull/8945#ref-pullrequest-1305414310 |
|
Fix RC func info of str_split
#9016
| https://github.com/php/php-src/pull/9016 |
| iluuu1994 | https://github.com/iluuu1994 |
|
Jul 15, 2022
| https://github.com/php/php-src/pull/8945#ref-commit-63912b5 |
|
| https://github.com/iluuu1994 |
| Fix RC func info of str_split ( | https://github.com/php/php-src/commit/63912b5ecdf2362f74d774cc57c7aade611587ba |
| #9016 | https://github.com/php/php-src/pull/9016 |
| ) | https://github.com/php/php-src/commit/63912b5ecdf2362f74d774cc57c7aade611587ba |
| 63912b5 | https://github.com/php/php-src/commit/63912b5ecdf2362f74d774cc57c7aade611587ba |
| GH-8945 | https://github.com/php/php-src/pull/8945 |
|
str_split returns an empty array since PHP 8.2
phpstan/phpstan-src#1544
| https://github.com/phpstan/phpstan-src/pull/1544 |
|
Fix str_split UPGRADE note
#9123
| https://github.com/php/php-src/pull/9123 |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F8945 |
|
| https://github.com/cmb69 |
|
cmb69
| https://github.com/cmb69 |
|
| https://github.com/php/php-src/pull/8945/files/2ac65bf03cd1cd57419d957dc352827eff2e8efd |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
|
Extension: standard
| https://github.com/php/php-src/issues?q=state%3Aopen%20label%3A%22Extension%3A%20standard%22 |
| Please reload this page | https://github.com/php/php-src/pull/8945 |
|
| https://github.com/mvorisek |
|
| https://github.com/devnexen |
|
| https://github.com/cmb69 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |