| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bd15b084-a535-d0d3-204a-fd89b1348248 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 81A0:F4C68:A2DFFE:CFDDAA:697F709A |
| html-safe-nonce | a7f9511d25df3742d04a8b8322c379d5e19d66a07d4d6d4269805fbdd2d18fc5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUEwOkY0QzY4OkEyREZGRTpDRkREQUE6Njk3RjcwOUEiLCJ2aXNpdG9yX2lkIjoiNTQ5MTMzNDM0MjE5NjAzMTY0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 58c3e04d6ca4bb7d762eb25b58cc70914c7c4ed3133aa7314afe71cf7aed2e4f |
| hovercard-subject-tag | pull_request:220716943 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/php/php-src/3579/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/87889f691a9af10e66915d18a00021e22ec8903c9d83815a10e3e01f4fdc0b02/php/php-src/pull/3579 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/87889f691a9af10e66915d18a00021e22ec8903c9d83815a10e3e01f4fdc0b02/php/php-src/pull/3579 |
| og:image:alt | This is a different attempt at #3574 /cc @dstogov.
The level of BC break for ArrayObject here is pretty much the same, but I think this approach is cleaner and also covers some other cases (e.g. Da... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nikic |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/php/php-src git https://github.com/php/php-src.git |
| octolytics-dimension-user_id | 25158 |
| octolytics-dimension-user_login | php |
| octolytics-dimension-repository_id | 1903522 |
| octolytics-dimension-repository_nwo | php/php-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1903522 |
| octolytics-dimension-repository_network_root_nwo | php/php-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/php/php-src/pull/3579#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F3579 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F3579 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=php%2Fphp-src |
| Reload | https://github.com/php/php-src/pull/3579 |
| Reload | https://github.com/php/php-src/pull/3579 |
| Reload | https://github.com/php/php-src/pull/3579 |
|
php
| https://github.com/php |
| php-src | https://github.com/php/php-src |
|
Notifications
| https://github.com/login?return_to=%2Fphp%2Fphp-src |
|
Fork
8k
| https://github.com/login?return_to=%2Fphp%2Fphp-src |
|
Star
39.8k
| https://github.com/login?return_to=%2Fphp%2Fphp-src |
|
Code
| https://github.com/php/php-src |
|
Issues
944
| https://github.com/php/php-src/issues |
|
Pull requests
809
| https://github.com/php/php-src/pulls |
|
Actions
| https://github.com/php/php-src/actions |
|
Security
37
| https://github.com/php/php-src/security |
|
Insights
| https://github.com/php/php-src/pulse |
|
Code
| https://github.com/php/php-src |
|
Issues
| https://github.com/php/php-src/issues |
|
Pull requests
| https://github.com/php/php-src/pulls |
|
Actions
| https://github.com/php/php-src/actions |
|
Security
| https://github.com/php/php-src/security |
|
Insights
| https://github.com/php/php-src/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fphp%2Fphp-src%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fphp%2Fphp-src%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/php/php-src/pull/3579#issue-comment-box |
| nikic | https://github.com/nikic |
| php:master | https://github.com/php/php-src/tree/master |
| nikic:get_properties_for | https://github.com/nikic/php-src/tree/get_properties_for |
|
Introduce get_properties_for
| https://github.com/php/php-src/pull/3579#top |
| nikic | https://github.com/nikic |
| php:master | https://github.com/php/php-src/tree/master |
| nikic:get_properties_for | https://github.com/nikic/php-src/tree/get_properties_for |
|
Conversation
10
| https://github.com/php/php-src/pull/3579 |
|
Commits
3
| https://github.com/php/php-src/pull/3579/commits |
|
Checks
0
| https://github.com/php/php-src/pull/3579/checks |
|
Files changed
| https://github.com/php/php-src/pull/3579/files |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/{{ revealButtonHref }} |
|
| https://github.com/nikic |
| nikic | https://github.com/nikic |
| Oct 5, 2018 | https://github.com/php/php-src/pull/3579#issue-367230766 |
| #3574 | https://github.com/php/php-src/pull/3574 |
| @dstogov | https://github.com/dstogov |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| nikic | https://github.com/nikic |
| October 5, 2018 15:10 | https://github.com/php/php-src/pull/3579#commits-pushed-c6c69b3 |
|
| https://github.com/nikic |
| Introduce get_properties_for() handler | https://github.com/php/php-src/pull/3579/commits/c6c69b33718df666c6142d2ffe23223d54a134c0 |
| c6c69b3 | https://github.com/php/php-src/pull/3579/commits/c6c69b33718df666c6142d2ffe23223d54a134c0 |
|
| https://github.com/nikic |
| Migrate ext/date to get_properties_for where appropriate | https://github.com/php/php-src/pull/3579/commits/d2e7506717ada86f69314078b7a0d2504e2ec05e |
| d2e7506 | https://github.com/php/php-src/pull/3579/commits/d2e7506717ada86f69314078b7a0d2504e2ec05e |
|
| https://github.com/nikic |
| Don't overload get_properties for ArrayObject | https://github.com/php/php-src/pull/3579/commits/ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99 |
| ee0dcce | https://github.com/php/php-src/pull/3579/commits/ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
| force-pushed | https://github.com/php/php-src/compare/41658fbf57ce61e419485f6d4ccefa8abb230b55..ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99 |
| 41658fb | https://github.com/php/php-src/commit/41658fbf57ce61e419485f6d4ccefa8abb230b55 |
| ee0dcce | https://github.com/php/php-src/commit/ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99 |
|
Compare
| https://github.com/php/php-src/compare/41658fbf57ce61e419485f6d4ccefa8abb230b55..ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99 |
| October 7, 2018 12:54 | https://github.com/php/php-src/pull/3579#event-1888992933 |
| https://github.com/dstogov |
| dstogov | https://github.com/dstogov |
|
Oct 8, 2018
| https://github.com/php/php-src/pull/3579#pullrequestreview-162368844 |
|
View reviewed changes
| https://github.com/php/php-src/pull/3579/files/ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99 |
| dstogov | https://github.com/dstogov |
| https://github.com/php/php-src/pull/3579#pullrequestreview-162368844 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| Zend/zend_types.h | https://github.com/php/php-src/pull/3579/files/ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99#diff-dca4782c62f10b418ea7193e4641e688ffd7a9c97869f2b1a3a96e28da5653aa |
| dstogov | https://github.com/dstogov |
| Oct 8, 2018 | https://github.com/php/php-src/pull/3579#discussion_r223282668 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| dstogov | https://github.com/dstogov |
| Oct 8, 2018 | https://github.com/php/php-src/pull/3579#discussion_r223284503 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
| Oct 8, 2018 | https://github.com/php/php-src/pull/3579#issuecomment-427760158 |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| @dstogov | https://github.com/dstogov |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/dstogov |
| dstogov | https://github.com/dstogov |
| Oct 9, 2018 | https://github.com/php/php-src/pull/3579#issuecomment-428352450 |
| @nikic | https://github.com/nikic |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
| Oct 10, 2018 | https://github.com/php/php-src/pull/3579#issuecomment-428490260 |
| 7ec8087 | https://github.com/php/php-src/commit/7ec8087f8097955bfc6b97d1a916c6ffc39908f4 |
| 1270e50 | https://github.com/php/php-src/commit/1270e5008a1828863a7f96873dff002680eac5c5 |
| a5fa51a | https://github.com/php/php-src/commit/a5fa51afbbd87bedeb1c5fd7c9a6cf3c971ab14c |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
| Oct 10, 2018 | https://github.com/php/php-src/pull/3579#event-1894879449 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
|
Oct 10, 2018
| https://github.com/php/php-src/pull/3579#ref-pullrequest-366721245 |
|
Don't overload ArrayObject get_properties
#3574
| https://github.com/php/php-src/pull/3574 |
| https://github.com/dstogov |
| dstogov | https://github.com/dstogov |
| Oct 11, 2018 | https://github.com/php/php-src/pull/3579#issuecomment-428876735 |
| @nikic | https://github.com/nikic |
| #1 | https://github.com/php/php-src/pull/1 |
| #2 | https://github.com/php/php-src/pull/2 |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
| Oct 11, 2018 | https://github.com/php/php-src/pull/3579#issuecomment-428879632 |
| @dstogov | https://github.com/dstogov |
| https://github.com/zendframework/zf1/blob/release-1.12.3/library/Zend/Registry.php#L204 | https://github.com/zendframework/zf1/blob/release-1.12.3/library/Zend/Registry.php#L204 |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/dstogov |
| dstogov | https://github.com/dstogov |
| Oct 11, 2018 | https://github.com/php/php-src/pull/3579#issuecomment-428883188 |
| @nikic | https://github.com/nikic |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
| Oct 11, 2018 | https://github.com/php/php-src/pull/3579#issuecomment-428970734 |
| @dstogov | https://github.com/dstogov |
| 0b6063f | https://github.com/php/php-src/commit/0b6063f33112b4685bc3c23ae823556fec8f32f1 |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
| https://github.com/nikic |
| nikic | https://github.com/nikic |
|
Oct 23, 2018
| https://github.com/php/php-src/pull/3579#ref-pullrequest-213897255 |
|
Implement get_serialize_properties() handler
#2419
| https://github.com/php/php-src/pull/2419 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F3579 |
|
| https://github.com/dstogov |
|
dstogov
| https://github.com/dstogov |
|
| https://github.com/php/php-src/pull/3579/files/ee0dcce7a871e11fb0b08f86b7ab1e7bed04bd99 |
| Please reload this page | https://github.com/php/php-src/pull/3579 |
|
| https://github.com/nikic |
|
| https://github.com/dstogov |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |