| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:f0ff7539-0fa9-6287-97d8-b5ab08389a71 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCC6:AF314:0DFD:11ED:6B007D09 |
| html-safe-nonce | 6462abeb1ed396bba3f623648d63509ee7636756d956f35d5da361a71a81d3f1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0M2OkFGMzE0OjBERkQ6MTFFRDo2QjAwN0QwOSIsInZpc2l0b3JfaWQiOiI3NTExNjI0ODAxNDkyOTU4NDczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7f4364cddbd11e42dc14ba25142e98f150be183419b539ad9f28a70168f89d84 |
| hovercard-subject-tag | pull_request:2927804703 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/php/php-src/pull/20223 |
| twitter:image | https://opengraph.githubassets.com/86c31521fdd221b9a4ff276126b93703172d5ee185ef7a9ba6aabcd9a67dcf68/php/php-src/pull/20223 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/86c31521fdd221b9a4ff276126b93703172d5ee185ef7a9ba6aabcd9a67dcf68/php/php-src/pull/20223 |
| og:image:alt | Positive and negative zero normally compare equal, but when specifically retrieving a minimum or maximum from a list of numbers, we should consider -0.0 to be lower than 0.0 instead of treating the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TimWolla |
| hostname | github.com |
| expected-hostname | github.com |
| None | 82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83 |
| turbo-cache-control | no-cache |
| go-import | github.com/php/php-src git https://github.com/php/php-src.git |
| octolytics-dimension-user_id | 25158 |
| octolytics-dimension-user_login | php |
| octolytics-dimension-repository_id | 1903522 |
| octolytics-dimension-repository_nwo | php/php-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1903522 |
| octolytics-dimension-repository_network_root_nwo | php/php-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d1bc2aa1939001689f5ce935982c10a6138f745c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/php/php-src/pull/20223#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F20223 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F20223 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=php%2Fphp-src |
| Reload | https://github.com/php/php-src/pull/20223 |
| Reload | https://github.com/php/php-src/pull/20223 |
| Reload | https://github.com/php/php-src/pull/20223 |
| php | https://github.com/php |
| php-src | https://github.com/php/php-src |
| Code | https://github.com/php/php-src |
| Issues1k (1k) | https://github.com/php/php-src/issues |
| Pull requests1.3k (1.3k) | https://github.com/php/php-src/pulls |
| Actions | https://github.com/php/php-src/actions |
| Security and quality83 (83) | https://github.com/php/php-src/security |
| Insights | https://github.com/php/php-src/insights |
| https://github.com/php/php-src |
| TimWolla | https://github.com/TimWolla |
| php:PHP-8.5 | https://github.com/php/php-src/tree/PHP-8.5 |
| TimWolla:min-max-negative-zero | https://github.com/TimWolla/php-src/tree/min-max-negative-zero |
| Conversation | https://github.com/php/php-src/pull/20223 |
| Commits2 (2) | https://github.com/php/php-src/pull/20223/commits |
| Checks | https://github.com/php/php-src/pull/20223/checks |
| Files changed | https://github.com/php/php-src/pull/20223/files |
| standard: Handle negative zero in min()/max() | https://github.com/php/php-src/pull/20223#top |
| TimWolla | https://github.com/TimWolla |
| php:PHP-8.5 | https://github.com/php/php-src/tree/PHP-8.5 |
| TimWolla:min-max-negative-zero | https://github.com/TimWolla/php-src/tree/min-max-negative-zero |
|
| https://github.com/TimWolla |
| TimWolla | https://github.com/TimWolla |
| Oct 19, 2025 | https://github.com/php/php-src/pull/20223#issue-3530090123 |
| #20221 | https://github.com/php/php-src/issues/20221 |
| Please reload this page | https://github.com/php/php-src/pull/20223 |
|
| https://github.com/TimWolla |
| standard: Handle negative zero in min()/max() | https://github.com/php/php-src/pull/20223/commits/ae9fd517fe62bab1572416fc283cb577395eca74 |
| ae9fd51 | https://github.com/php/php-src/pull/20223/commits/ae9fd517fe62bab1572416fc283cb577395eca74 |
| php#20221 | https://github.com/php/php-src/issues/20221 |
| https://github.com/TimWolla |
| TimWolla | https://github.com/TimWolla |
| ndossche | https://github.com/ndossche |
| October 19, 2025 13:48 | https://github.com/php/php-src/pull/20223#event-20366845201 |
| https://github.com/TimWolla |
| TimWolla | https://github.com/TimWolla |
| bukka | https://github.com/bukka |
| code owner | https://github.com/php/php-src/blob/1cb166cbbbbdc6c292a96ea58603a32c253889fa/.github/CODEOWNERS#L54 |
| October 19, 2025 13:48 | https://github.com/php/php-src/pull/20223#event-20366845262 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Extension: standard
| https://github.com/php/php-src/issues?q=state%3Aopen%20label%3A%22Extension%3A%20standard%22 |
| Oct 19, 2025 | https://github.com/php/php-src/pull/20223#event-20366846348 |
|
| https://github.com/TimWolla |
| standard: Handle min()/max() for float(-0.0) and int(0) | https://github.com/php/php-src/pull/20223/commits/0c4ae1216e6693db98a371dc448586764b3aa77d |
| 0c4ae12 | https://github.com/php/php-src/pull/20223/commits/0c4ae1216e6693db98a371dc448586764b3aa77d |
| https://github.com/mvorisek |
| mvorisek | https://github.com/mvorisek |
|
Oct 19, 2025
| https://github.com/php/php-src/pull/20223#pullrequestreview-3354574390 |
|
View reviewed changes
| https://github.com/php/php-src/pull/20223/files/0c4ae1216e6693db98a371dc448586764b3aa77d |
| ext/standard/tests/math/gh20221.phpt | https://github.com/php/php-src/pull/20223/files/0c4ae1216e6693db98a371dc448586764b3aa77d#diff-9104d05031d708f61c696b05a09c639a15521c9bd4e3b844856ae27083efdcbc |
| mvorisek | https://github.com/mvorisek |
| Oct 19, 2025 | https://github.com/php/php-src/pull/20223#discussion_r2443370828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://3v4l.org/9UMvV | https://3v4l.org/9UMvV |
| Please reload this page | https://github.com/php/php-src/pull/20223 |
| https://github.com/ndossche |
| ndossche | https://github.com/ndossche |
|
Nov 2, 2025
| https://github.com/php/php-src/pull/20223#pullrequestreview-3408971342 |
|
View reviewed changes
| https://github.com/php/php-src/pull/20223/files/0c4ae1216e6693db98a371dc448586764b3aa77d |
| ndossche | https://github.com/ndossche |
| https://github.com/php/php-src/pull/20223#pullrequestreview-3408971342 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/php/php-src/pull/20223 |
| https://github.com/devnexen |
| devnexen | https://github.com/devnexen |
|
Aug 29, 2026
| https://github.com/php/php-src/pull/20223#ref-pullrequest-5286684269 |
|
Fix inconsistent min()/max() tie-breaking on signed zero via the frameless 2-arg fast path
#23505
| https://github.com/php/php-src/pull/23505 |
| https://github.com/anun333 |
| anun333 | https://github.com/anun333 |
| Oct 26, 2026 | https://github.com/php/php-src/pull/20223#issuecomment-6416785007 |
| #23505 | https://github.com/php/php-src/pull/23505 |
| Please reload this page | https://github.com/php/php-src/pull/20223 |
| https://github.com/mrinella |
| mrinella | https://github.com/mrinella |
|
Oct 28, 2026
| https://github.com/php/php-src/pull/20223#ref-issue-3529863672 |
|
max/min return wrong value if signed (negative) zero
#20221
| https://github.com/php/php-src/issues/20221 |
| https://github.com/anun333 |
| anun333 | https://github.com/anun333 |
| Oct 29, 2026 | https://github.com/php/php-src/pull/20223#issuecomment-6484996753 |
| #23505 | https://github.com/php/php-src/pull/23505 |
| #23505 | https://github.com/php/php-src/pull/23505 |
| #23505 | https://github.com/php/php-src/pull/23505 |
| #23505 | https://github.com/php/php-src/pull/23505 |
| Please reload this page | https://github.com/php/php-src/pull/20223 |
| https://github.co/hiddenchars |
| https://github.com/php/php-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphp%2Fphp-src%2Fpull%2F20223 |
|
| https://github.com/ndossche |
|
ndossche
| https://github.com/ndossche |
|
| https://github.com/php/php-src/pull/20223/files/0c4ae1216e6693db98a371dc448586764b3aa77d |
|
| https://github.com/bukka |
|
bukka
| https://github.com/bukka |
|
| https://github.com/mvorisek |
|
mvorisek
| https://github.com/mvorisek |
|
| https://github.com/php/php-src/pull/20223/files/0c4ae1216e6693db98a371dc448586764b3aa77d |
| Please reload this page | https://github.com/php/php-src/pull/20223 |
|
Extension: standard
| https://github.com/php/php-src/issues?q=state%3Aopen%20label%3A%22Extension%3A%20standard%22 |
| Please reload this page | https://github.com/php/php-src/pull/20223 |
|
| https://github.com/TimWolla |
|
| https://github.com/anun333 |
|
| https://github.com/mvorisek |
|
| https://github.com/ndossche |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |