| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1eeca64f-48b0-9d4d-0b8c-94de2384c5d6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D0AE:19AA62:6108B:7D4C3:6B00C4F1 |
| html-safe-nonce | f63c256f70a66bcb4346558d40917286183fdfea39a8fa02e3c66d628d74608a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEFFOjE5QUE2Mjo2MTA4Qjo3RDRDMzo2QjAwQzRGMSIsInZpc2l0b3JfaWQiOiI2OTQzNDQwNjQ4NzM3NDQxMDA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 80a4c60eb588457814c5e316169eee4e34063824e4badbc678130e87256c6c9d |
| hovercard-subject-tag | pull_request:187847860 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/patternfly/patternfly-react/345/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ae21f421e4ce6877dbbea3a591b5d67f829ec818eded454bb821f104e1f5cf33/patternfly/patternfly-react/pull/345 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ae21f421e4ce6877dbbea3a591b5d67f829ec818eded454bb821f104e1f5cf33/patternfly/patternfly-react/pull/345 |
| og:image:alt | affects: patternfly-react
Add aria roles and attributes
Enable keyboard navigation
Implements roving tabindex as described by W3C WAI-ARIA Authoring Practices
User can use the up and down arrow k... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | michaelkro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4 |
| turbo-cache-control | no-cache |
| go-import | github.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git |
| octolytics-dimension-user_id | 6391110 |
| octolytics-dimension-user_login | patternfly |
| octolytics-dimension-repository_id | 84372347 |
| octolytics-dimension-repository_nwo | patternfly/patternfly-react |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 84372347 |
| octolytics-dimension-repository_network_root_nwo | patternfly/patternfly-react |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ef013399cf0a3c324bea644a685d7c1e0f06b5b7 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/patternfly/patternfly-react/pull/345#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F345 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F345 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=patternfly%2Fpatternfly-react |
| Reload | https://github.com/patternfly/patternfly-react/pull/345 |
| Reload | https://github.com/patternfly/patternfly-react/pull/345 |
| Reload | https://github.com/patternfly/patternfly-react/pull/345 |
| patternfly | https://github.com/patternfly |
| patternfly-react | https://github.com/patternfly/patternfly-react |
| Code | https://github.com/patternfly/patternfly-react |
| Issues222 (222) | https://github.com/patternfly/patternfly-react/issues |
| Pull requests36 (36) | https://github.com/patternfly/patternfly-react/pulls |
| Discussions | https://github.com/patternfly/patternfly-react/discussions |
| Actions | https://github.com/patternfly/patternfly-react/actions |
| Projects | https://github.com/patternfly/patternfly-react/projects |
| Wiki | https://github.com/patternfly/patternfly-react/wiki |
| Security and quality | https://github.com/patternfly/patternfly-react/security |
| Insights | https://github.com/patternfly/patternfly-react/insights |
| https://github.com/patternfly/patternfly-react |
| priley86 | https://github.com/priley86 |
| patternfly:master | https://github.com/patternfly/patternfly-react/tree/master |
| michaelkro:treeview-improvements | https://github.com/michaelkro/patternfly-react/tree/treeview-improvements |
| Conversation | https://github.com/patternfly/patternfly-react/pull/345 |
| Commits21 (21) | https://github.com/patternfly/patternfly-react/pull/345/commits |
| Checks | https://github.com/patternfly/patternfly-react/pull/345/checks |
| Files changed | https://github.com/patternfly/patternfly-react/pull/345/files |
| feat(TreeView Component): address accessibility concerns | https://github.com/patternfly/patternfly-react/pull/345#top |
| priley86 | https://github.com/priley86 |
| patternfly:master | https://github.com/patternfly/patternfly-react/tree/master |
| michaelkro:treeview-improvements | https://github.com/michaelkro/patternfly-react/tree/treeview-improvements |
|
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| May 14, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issue-322844163 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| Enable keyboard navigation | https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1b.html#kbd_label |
| W3C WAI-ARIA Authoring Practices | https://www.w3.org/TR/wai-aria-practices-1.1/#kbd_roving_tabindex |
| #321 | https://github.com/patternfly/patternfly-react/issues/321 |
| Storybook | https://rawgit.com/michaelkro/patternfly-react/treeview-improvements-storybook/index.html?knob-Highlight%20on%20hover=true&knob-Highlight%20on%20select=true&selectedKind=patternfly-react%2FWidgets%2FTree%20View&selectedStory=TreeView&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs |
| MDN | https://developer.mozilla.org/en-US/docs/Web/Events/keypress |
| w3.org | https://www.w3.org/TR/2017/NOTE-wai-aria-practices-1.1-20171214/examples/treeview/treeview-2/treeview-2a.html |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| May 14, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-388841151 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| Build 1655 | https://coveralls.io/builds/17791575 |
| packages/patternfly-react/src/components/TreeView/TreeView.js | https://coveralls.io/builds/17791575/source?filename=packages%2Fpatternfly-react%2Fsrc%2Fcomponents%2FTreeView%2FTreeView.js#L61 |
| packages/patternfly-react/src/components/TreeView/TreeViewNode.js | https://coveralls.io/builds/17791575/source?filename=packages%2Fpatternfly-react%2Fsrc%2Fcomponents%2FTreeView%2FTreeViewNode.js#L34 |
| https://coveralls.io/builds/17791575 |
| Build 1632 | https://coveralls.io/builds/17722263 |
| Coveralls | https://coveralls.io |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/2999bb9b1cde8b129deea85dbb46e4093988e789..26e928c453062abae1c3e005482181e01e3c0dc0 |
| 2999bb9 | https://github.com/patternfly/patternfly-react/commit/2999bb9b1cde8b129deea85dbb46e4093988e789 |
| 26e928c | https://github.com/patternfly/patternfly-react/commit/26e928c453062abae1c3e005482181e01e3c0dc0 |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/2999bb9b1cde8b129deea85dbb46e4093988e789..26e928c453062abae1c3e005482181e01e3c0dc0 |
| May 14, 2018 20:39 | https://github.com/patternfly/patternfly-react/pull/345#event-1625758823 |
| https://github.com/seanforyou23 |
| seanforyou23 | https://github.com/seanforyou23 |
|
May 16, 2018
| https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-120646681 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/345/files |
| seanforyou23 | https://github.com/seanforyou23 |
| https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-120646681 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| W3 note on keyboard interaction | https://www.w3.org/TR/wai-aria-practices/#keyboard-interaction-21 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| packages/core/src/components/TreeView/TreeViewNode.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-302f47ba4708e3c1093586f44cad00e1e8a305227f9ce035a47746f37e414da0 |
| seanforyou23 | https://github.com/seanforyou23 |
| May 16, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r188630673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://www.w3.org/TR/wai-aria-practices/#tree_roles_states_props | https://www.w3.org/TR/wai-aria-practices/#tree_roles_states_props |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| packages/core/src/components/TreeView/TreeViewNode.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-302f47ba4708e3c1093586f44cad00e1e8a305227f9ce035a47746f37e414da0 |
| seanforyou23 | https://github.com/seanforyou23 |
| May 16, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r188631935 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://www.w3.org/TR/wai-aria-practices/#tree_roles_states_props | https://www.w3.org/TR/wai-aria-practices/#tree_roles_states_props |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| packages/core/src/components/TreeView/TreeView.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-40bd05406efb04044089c2e14fd7be0052c1d0a79de4ac417fae7c866bee4f43 |
| seanforyou23 | https://github.com/seanforyou23 |
| May 16, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r188635182 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://www.w3.org/TR/wai-aria-1.1/#namecalculation | https://www.w3.org/TR/wai-aria-1.1/#namecalculation |
| https://www.w3.org/TR/accname-1.1/#mapping_additional_nd_te | https://www.w3.org/TR/accname-1.1/#mapping_additional_nd_te |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| packages/core/src/components/TreeView/TreeView.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-40bd05406efb04044089c2e14fd7be0052c1d0a79de4ac417fae7c866bee4f43 |
| seanforyou23 | https://github.com/seanforyou23 |
| May 16, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r188636963 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| successful examples | http://www.oaa-accessibility.org/examplep/treeview1/ |
| https://www.w3.org/TR/wai-aria-1.1/#application | https://www.w3.org/TR/wai-aria-1.1/#application |
| managing focus | https://www.w3.org/TR/wai-aria-1.1/#managingfocus |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| packages/core/src/components/TreeView/TreeView.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-40bd05406efb04044089c2e14fd7be0052c1d0a79de4ac417fae7c866bee4f43 |
| seanforyou23 | https://github.com/seanforyou23 |
| May 16, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r188639636 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://www.w3.org/TR/wai-aria-practices/#tree_roles_states_props | https://www.w3.org/TR/wai-aria-practices/#tree_roles_states_props |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| michaelkro | https://github.com/michaelkro |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r189574270 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/jgiardino |
| jgiardino | https://github.com/jgiardino |
| May 16, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-389647582 |
| @michaelkro | https://github.com/michaelkro |
| @seanforyou23 | https://github.com/seanforyou23 |
| ARIA documentation for creating a tree view | https://www.w3.org/TR/wai-aria-practices-1.1/#TreeView |
| ARIA authoring practices | https://www.w3.org/TR/wai-aria-practices-1.1/ |
| one of their examples of the tree view | https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1b.html |
| @seanforyou23 | https://github.com/seanforyou23 |
| ARIA example | https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1b.html |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/seanforyou23 |
| seanforyou23 | https://github.com/seanforyou23 |
| May 16, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-389660571 |
| @jgiardino | https://github.com/jgiardino |
| @michaelkro | https://github.com/michaelkro |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/jgiardino |
| jgiardino | https://github.com/jgiardino |
| May 17, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-390049198 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| one of the ARIA examples | https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1b.html |
| @seanforyou23 | https://github.com/seanforyou23 |
| tree view example | https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1b.html#rps_label |
| keyboard support in a tree view | https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1b.html#kbd_label |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/jgiardino |
| jgiardino | https://github.com/jgiardino |
| May 17, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-390049604 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| May 18, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-390183494 |
| @jgiardino | https://github.com/jgiardino |
| @seanforyou23 | https://github.com/seanforyou23 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| May 18, 2018 | https://github.com/patternfly/patternfly-react/pull/345#event-1634791848 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/4b680350787b60f4e8aac83973da6a1b1b1a780a..8eb6c32e8e2520e805f5ad9584ffe44cdb1ee773 |
| 4b68035 | https://github.com/patternfly/patternfly-react/commit/4b680350787b60f4e8aac83973da6a1b1b1a780a |
| 8eb6c32 | https://github.com/patternfly/patternfly-react/commit/8eb6c32e8e2520e805f5ad9584ffe44cdb1ee773 |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/4b680350787b60f4e8aac83973da6a1b1b1a780a..8eb6c32e8e2520e805f5ad9584ffe44cdb1ee773 |
| May 21, 2018 14:29 | https://github.com/patternfly/patternfly-react/pull/345#event-1637160306 |
| https://github.com/dmiller9911 |
| dmiller9911 | https://github.com/dmiller9911 |
|
May 21, 2018
| https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-121818867 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/345/files |
| packages/core/src/components/TreeView/TreeViewNode.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-302f47ba4708e3c1093586f44cad00e1e8a305227f9ce035a47746f37e414da0 |
| dmiller9911 | https://github.com/dmiller9911 |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r189607159 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| michaelkro | https://github.com/michaelkro |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r189689606 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://github.com/patternfly/patternfly-react/pull/345/files#diff-1727600946cffc597dc998fd3026f9e2R127 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/4b859a11e3474a42f72572e504c32059f8207232..6fb075c3ab65591cdb5487a491a17f9de5dc65c1 |
| 4b859a1 | https://github.com/patternfly/patternfly-react/commit/4b859a11e3474a42f72572e504c32059f8207232 |
| 6fb075c | https://github.com/patternfly/patternfly-react/commit/6fb075c3ab65591cdb5487a491a17f9de5dc65c1 |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/4b859a11e3474a42f72572e504c32059f8207232..6fb075c3ab65591cdb5487a491a17f9de5dc65c1 |
| May 21, 2018 19:26 | https://github.com/patternfly/patternfly-react/pull/345#event-1637742350 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#event-1637746821 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-390767295 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| @jgiardino | https://github.com/jgiardino |
| @seanforyou23 | https://github.com/seanforyou23 |
| comment | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-389647582 |
| comment | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-390049198 |
| keyboard support in a tree view | https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-1/treeview-1b.html#kbd_label |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
|
May 21, 2018
| https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-121932688 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/345/files |
| packages/core/src/components/TreeView/TreeViewNode.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-302f47ba4708e3c1093586f44cad00e1e8a305227f9ce035a47746f37e414da0 |
| priley86 | https://github.com/priley86 |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r189701629 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
|
May 21, 2018
| https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-121933250 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/345/files |
| packages/core/src/components/TreeView/TreeViewNode.js | https://github.com/patternfly/patternfly-react/pull/345/files#diff-302f47ba4708e3c1093586f44cad00e1e8a305227f9ce035a47746f37e414da0 |
| priley86 | https://github.com/priley86 |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r189702123 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| michaelkro | https://github.com/michaelkro |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#discussion_r189703293 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| keyboard roving index | https://www.w3.org/TR/wai-aria-practices-1.1/#kbd_roving_tabindex |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
| May 21, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-390770622 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| michaelkro | https://github.com/michaelkro |
| August 10, 2018 10:48 | https://github.com/patternfly/patternfly-react/pull/345#commits-pushed-aa4a136 |
|
| https://github.com/michaelkro |
| Align html structure with w3.org guidelines | https://github.com/patternfly/patternfly-react/pull/345/commits/aa4a136c3223f5028b9c6fd9722f60ffc9d021b9 |
| aa4a136 | https://github.com/patternfly/patternfly-react/pull/345/commits/aa4a136c3223f5028b9c6fd9722f60ffc9d021b9 |
|
| https://github.com/michaelkro |
| Fix keyboard navigation | https://github.com/patternfly/patternfly-react/pull/345/commits/709a4fddb8144fd4dde347dbf666cb872273cd14 |
| 709a4fd | https://github.com/patternfly/patternfly-react/pull/345/commits/709a4fddb8144fd4dde347dbf666cb872273cd14 |
|
| https://github.com/michaelkro |
| Roving tab index | https://github.com/patternfly/patternfly-react/pull/345/commits/81347fa54875843fccb49ef396a9cf8ec97827b4 |
| 81347fa | https://github.com/patternfly/patternfly-react/pull/345/commits/81347fa54875843fccb49ef396a9cf8ec97827b4 |
|
| https://github.com/michaelkro |
| Add aria attributes | https://github.com/patternfly/patternfly-react/pull/345/commits/2869d4eb0c71cc3588b5185194b539dd9d02f777 |
| 2869d4e | https://github.com/patternfly/patternfly-react/pull/345/commits/2869d4eb0c71cc3588b5185194b539dd9d02f777 |
|
| https://github.com/michaelkro |
| Fix CI errors | https://github.com/patternfly/patternfly-react/pull/345/commits/4bd58d2b7775f68be06c77bafbcf2822bf92704e |
| 4bd58d2 | https://github.com/patternfly/patternfly-react/pull/345/commits/4bd58d2b7775f68be06c77bafbcf2822bf92704e |
|
| https://github.com/michaelkro |
| Use data attribute instead of id | https://github.com/patternfly/patternfly-react/pull/345/commits/50885f9d541b64e4701bd825240a8e555ebec163 |
| 50885f9 | https://github.com/patternfly/patternfly-react/pull/345/commits/50885f9d541b64e4701bd825240a8e555ebec163 |
|
| https://github.com/michaelkro |
| Support left/right arrow for expand/collapse | https://github.com/patternfly/patternfly-react/pull/345/commits/4c0cdc86e22e2bcced468f797ae6044b3a279df8 |
| 4c0cdc8 | https://github.com/patternfly/patternfly-react/pull/345/commits/4c0cdc86e22e2bcced468f797ae6044b3a279df8 |
|
| https://github.com/michaelkro |
| Extract keyboard key strings to helpers | https://github.com/patternfly/patternfly-react/pull/345/commits/02d8451a1e67b9b7a6d8172a2647c659d56761b3 |
| 02d8451 | https://github.com/patternfly/patternfly-react/pull/345/commits/02d8451a1e67b9b7a6d8172a2647c659d56761b3 |
|
| https://github.com/michaelkro |
| Implement keyboard search | https://github.com/patternfly/patternfly-react/pull/345/commits/f1d5fed4cfee900d81e527f2641a3f6929a93fef |
| f1d5fed | https://github.com/patternfly/patternfly-react/pull/345/commits/f1d5fed4cfee900d81e527f2641a3f6929a93fef |
|
| https://github.com/michaelkro |
| Add accessibleName prop | https://github.com/patternfly/patternfly-react/pull/345/commits/78c1fda89073f724fc875cae55b3f29a4065d7ad |
| 78c1fda | https://github.com/patternfly/patternfly-react/pull/345/commits/78c1fda89073f724fc875cae55b3f29a4065d7ad |
|
| https://github.com/michaelkro |
| Update storybook with keyboard nav details | https://github.com/patternfly/patternfly-react/pull/345/commits/886a24ad1d99168cbe338b46a6ac6c0160ba9f5c |
| 886a24a | https://github.com/patternfly/patternfly-react/pull/345/commits/886a24ad1d99168cbe338b46a6ac6c0160ba9f5c |
|
| https://github.com/michaelkro |
| Implement * (asterisk) keyboard action | https://github.com/patternfly/patternfly-react/pull/345/commits/b4379a5eb88946113fa1a903918bbed947048526 |
| b4379a5 | https://github.com/patternfly/patternfly-react/pull/345/commits/b4379a5eb88946113fa1a903918bbed947048526 |
|
| https://github.com/michaelkro |
| Add less file | https://github.com/patternfly/patternfly-react/pull/345/commits/f174496b8278498d4657c9b08f7bcbad29fde0a5 |
| f174496 | https://github.com/patternfly/patternfly-react/pull/345/commits/f174496b8278498d4657c9b08f7bcbad29fde0a5 |
|
| https://github.com/michaelkro |
| More tests | https://github.com/patternfly/patternfly-react/pull/345/commits/e07110126dac07529b8ec19353cf095729114762 |
| e071101 | https://github.com/patternfly/patternfly-react/pull/345/commits/e07110126dac07529b8ec19353cf095729114762 |
|
| https://github.com/michaelkro |
| Add keyboard support for Home and End keys | https://github.com/patternfly/patternfly-react/pull/345/commits/8d615fdfe12880044a4a8d9054c2375147c85ba9 |
| 8d615fd | https://github.com/patternfly/patternfly-react/pull/345/commits/8d615fdfe12880044a4a8d9054c2375147c85ba9 |
|
| https://github.com/michaelkro |
| Move to patternfly-react from core | https://github.com/patternfly/patternfly-react/pull/345/commits/45a7b2c98143a2cede5a9410f3b25de09e3ba27e |
| 45a7b2c | https://github.com/patternfly/patternfly-react/pull/345/commits/45a7b2c98143a2cede5a9410f3b25de09e3ba27e |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/f72281daebb28e19bf364f3c9a76719bab26ebf1..45a7b2c98143a2cede5a9410f3b25de09e3ba27e |
| f72281d | https://github.com/patternfly/patternfly-react/commit/f72281daebb28e19bf364f3c9a76719bab26ebf1 |
| 45a7b2c | https://github.com/patternfly/patternfly-react/commit/45a7b2c98143a2cede5a9410f3b25de09e3ba27e |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/f72281daebb28e19bf364f3c9a76719bab26ebf1..45a7b2c98143a2cede5a9410f3b25de09e3ba27e |
| August 10, 2018 14:48 | https://github.com/patternfly/patternfly-react/pull/345#event-1782681797 |
|
| https://github.com/michaelkro |
| Hide icons in screen readers | https://github.com/patternfly/patternfly-react/pull/345/commits/b8b3697173ca4f7aae5d80657790e2d3e436619e |
| b8b3697 | https://github.com/patternfly/patternfly-react/pull/345/commits/b8b3697173ca4f7aae5d80657790e2d3e436619e |
| https://github.com/seanforyou23 |
| seanforyou23 | https://github.com/seanforyou23 |
|
Aug 10, 2018
| https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-145275172 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/345/files/b8b3697173ca4f7aae5d80657790e2d3e436619e |
| https://github.com/mcarrano |
| mcarrano | https://github.com/mcarrano |
|
ux approved
| https://github.com/patternfly/patternfly-react/issues?q=state%3Aopen%20label%3A%22ux%20approved%22 |
|
ux review
| https://github.com/patternfly/patternfly-react/issues?q=state%3Aopen%20label%3A%22ux%20review%22 |
| Aug 10, 2018 | https://github.com/patternfly/patternfly-react/pull/345#event-1783108180 |
| https://github.com/mcarrano |
| mcarrano | https://github.com/mcarrano |
| Aug 10, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-412167989 |
| @michaelkro | https://github.com/michaelkro |
| @jgiardino | https://github.com/jgiardino |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/jgiardino |
| jgiardino | https://github.com/jgiardino |
|
css approved
| https://github.com/patternfly/patternfly-react/issues?q=state%3Aopen%20label%3A%22css%20approved%22 |
| Aug 10, 2018 | https://github.com/patternfly/patternfly-react/pull/345#event-1783126781 |
| https://github.com/jgiardino |
| jgiardino | https://github.com/jgiardino |
| Aug 10, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-412169198 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
|
| https://github.com/michaelkro |
| Update snapshot | https://github.com/patternfly/patternfly-react/pull/345/commits/eec8cf4164475e8d9c47fe8489257bb8e063ec52 |
| eec8cf4 | https://github.com/patternfly/patternfly-react/pull/345/commits/eec8cf4164475e8d9c47fe8489257bb8e063ec52 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| seanforyou23 | https://github.com/seanforyou23 |
| stale review | https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-145275172 |
| eec8cf4 | https://github.com/patternfly/patternfly-react/commit/eec8cf4164475e8d9c47fe8489257bb8e063ec52 |
| August 13, 2018 11:31 | https://github.com/patternfly/patternfly-react/pull/345#event-1785127881 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
| Aug 13, 2018 | https://github.com/patternfly/patternfly-react/pull/345#issuecomment-412516208 |
| @michaelkro | https://github.com/michaelkro |
| @seanforyou23 | https://github.com/seanforyou23 |
| @jgiardino | https://github.com/jgiardino |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
|
Aug 13, 2018
| https://github.com/patternfly/patternfly-react/pull/345#pullrequestreview-145649623 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/345/files/eec8cf4164475e8d9c47fe8489257bb8e063ec52 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
| 41c0fa3 | https://github.com/patternfly/patternfly-react/commit/41c0fa36d84a206d2f85599ad01ca2c25dbfde86 |
| Aug 13, 2018 | https://github.com/patternfly/patternfly-react/pull/345#event-1785344954 |
| https://github.com/michaelkro |
| michaelkro | https://github.com/michaelkro |
| September 18, 2018 12:18 | https://github.com/patternfly/patternfly-react/pull/345#event-1852213299 |
| https://github.co/hiddenchars |
| https://github.com/patternfly/patternfly-react/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F345 |
|
| https://github.com/dmiller9911 |
|
dmiller9911
| https://github.com/dmiller9911 |
|
| https://github.com/patternfly/patternfly-react/pull/345/files/8eb6c32e8e2520e805f5ad9584ffe44cdb1ee773 |
|
| https://github.com/priley86 |
|
priley86
| https://github.com/priley86 |
|
| https://github.com/patternfly/patternfly-react/pull/345/files/eec8cf4164475e8d9c47fe8489257bb8e063ec52 |
|
| https://github.com/seanforyou23 |
|
seanforyou23
| https://github.com/seanforyou23 |
|
| https://github.com/patternfly/patternfly-react/pull/345/files/b8b3697173ca4f7aae5d80657790e2d3e436619e |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
|
Component: Treeview a11y enhancements/Patterns
| https://github.com/patternfly/patternfly-react/issues/321 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/345 |
|
| https://github.com/michaelkro |
|
| https://github.com/coveralls |
|
| https://github.com/jgiardino |
|
| https://github.com/seanforyou23 |
|
| https://github.com/priley86 |
|
| https://github.com/dabeng |
|
| https://github.com/mcarrano |
|
| https://github.com/dmiller9911 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |