| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7defa91b-6e4c-8cae-21c4-f0835d480027 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC0E:114DF4:90087D:BFCA75:6B00B4D3 |
| html-safe-nonce | 6006379530f77ebf7acbfa12ee4748a5af8a4e0971b31014db2a09d05bda5547 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzBFOjExNERGNDo5MDA4N0Q6QkZDQTc1OjZCMDBCNEQzIiwidmlzaXRvcl9pZCI6IjY2MTAwNTU3MDA4NTQ5MTIyMTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 02214933b58f394e13fe21474505c4c7a364dc2a6077c00c5887c3448af0367c |
| hovercard-subject-tag | pull_request:187139488 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/patternfly/patternfly-react/336/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/35d5a3b81ca96d434056e9210efdbeb38154211d970d8f90f31be35b7560abdd/patternfly/patternfly-react/pull/336 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/35d5a3b81ca96d434056e9210efdbeb38154211d970d8f90f31be35b7560abdd/patternfly/patternfly-react/pull/336 |
| og:image:alt | affects: patternfly-react
What:
Dividing onNotificationClick to two Functions:
onNotificationAsRead
onNotificationClick
Fixing an issue where unwanted onNotificationClick actions are called whe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | glekner |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2 |
| turbo-cache-control | no-cache |
| go-import | github.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git |
| octolytics-dimension-user_id | 6391110 |
| octolytics-dimension-user_login | patternfly |
| octolytics-dimension-repository_id | 84372347 |
| octolytics-dimension-repository_nwo | patternfly/patternfly-react |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 84372347 |
| octolytics-dimension-repository_network_root_nwo | patternfly/patternfly-react |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5429cbfc6aca8c7b9a086a3c8f47400346f38cc9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/patternfly/patternfly-react/pull/336#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F336 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F336 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=patternfly%2Fpatternfly-react |
| Reload | https://github.com/patternfly/patternfly-react/pull/336 |
| Reload | https://github.com/patternfly/patternfly-react/pull/336 |
| Reload | https://github.com/patternfly/patternfly-react/pull/336 |
| patternfly | https://github.com/patternfly |
| patternfly-react | https://github.com/patternfly/patternfly-react |
| Code | https://github.com/patternfly/patternfly-react |
| Issues222 (222) | https://github.com/patternfly/patternfly-react/issues |
| Pull requests36 (36) | https://github.com/patternfly/patternfly-react/pulls |
| Discussions | https://github.com/patternfly/patternfly-react/discussions |
| Actions | https://github.com/patternfly/patternfly-react/actions |
| Projects | https://github.com/patternfly/patternfly-react/projects |
| Wiki | https://github.com/patternfly/patternfly-react/wiki |
| Security and quality | https://github.com/patternfly/patternfly-react/security |
| Insights | https://github.com/patternfly/patternfly-react/insights |
| https://github.com/patternfly/patternfly-react |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| patternfly:master | https://github.com/patternfly/patternfly-react/tree/master |
| glekner:fix-notification-onclick | https://github.com/glekner/patternfly-react/tree/fix-notification-onclick |
| Conversation | https://github.com/patternfly/patternfly-react/pull/336 |
| Commits1 (1) | https://github.com/patternfly/patternfly-react/pull/336/commits |
| Checks | https://github.com/patternfly/patternfly-react/pull/336/checks |
| Files changed | https://github.com/patternfly/patternfly-react/pull/336/files |
| fix(NotificationDrawer) - Dividing onNotificationClick to two functions | https://github.com/patternfly/patternfly-react/pull/336#top |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| patternfly:master | https://github.com/patternfly/patternfly-react/tree/master |
| glekner:fix-notification-onclick | https://github.com/glekner/patternfly-react/tree/fix-notification-onclick |
|
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#issue-321862066 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| May 10, 2018 09:09 | https://github.com/patternfly/patternfly-react/pull/336#event-1619373921 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#event-1619376485 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#event-1619376827 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#event-1619377145 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/6ad4c66b56efcbc93dd426bc265373095294596d..f71dbe14c8fe51c96b1be61756f5a8f2d5188594 |
| 6ad4c66 | https://github.com/patternfly/patternfly-react/commit/6ad4c66b56efcbc93dd426bc265373095294596d |
| f71dbe1 | https://github.com/patternfly/patternfly-react/commit/f71dbe14c8fe51c96b1be61756f5a8f2d5188594 |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/6ad4c66b56efcbc93dd426bc265373095294596d..f71dbe14c8fe51c96b1be61756f5a8f2d5188594 |
| May 10, 2018 09:31 | https://github.com/patternfly/patternfly-react/pull/336#event-1619410854 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
May 10, 2018
| https://github.com/patternfly/patternfly-react/pull/336#pullrequestreview-119070424 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/336/files |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| https://github.com/patternfly/patternfly-react/pull/336#pullrequestreview-119070424 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
| packages/core/src/components/Notification/Wrappers/NotificationDrawerPanelWrapper.js | https://github.com/patternfly/patternfly-react/pull/336/files#diff-02239bf39a6d9225a2415002469c6c12a8b22d86fdd81451a157fd9b6b5752bf |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#discussion_r187316622 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| stale review | https://github.com/patternfly/patternfly-react/pull/336#pullrequestreview-119070424 |
| 13533df | https://github.com/patternfly/patternfly-react/commit/13533df923b8c776677f59d5342ab221778d6ac9 |
| May 10, 2018 13:04 | https://github.com/patternfly/patternfly-react/pull/336#event-1619730727 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/f71dbe14c8fe51c96b1be61756f5a8f2d5188594..13533df923b8c776677f59d5342ab221778d6ac9 |
| f71dbe1 | https://github.com/patternfly/patternfly-react/commit/f71dbe14c8fe51c96b1be61756f5a8f2d5188594 |
| 13533df | https://github.com/patternfly/patternfly-react/commit/13533df923b8c776677f59d5342ab221778d6ac9 |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/f71dbe14c8fe51c96b1be61756f5a8f2d5188594..13533df923b8c776677f59d5342ab221778d6ac9 |
| May 10, 2018 13:04 | https://github.com/patternfly/patternfly-react/pull/336#event-1619730730 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
May 10, 2018
| https://github.com/patternfly/patternfly-react/pull/336#pullrequestreview-119089342 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/336/files |
| packages/core/src/components/Notification/Wrappers/NotificationDrawerPanelWrapper.js | https://github.com/patternfly/patternfly-react/pull/336/files#diff-02239bf39a6d9225a2415002469c6c12a8b22d86fdd81451a157fd9b6b5752bf |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#discussion_r187332058 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
| packages/core/src/components/Notification/Wrappers/NotificationDrawerPanelWrapper.js | https://github.com/patternfly/patternfly-react/pull/336/files#diff-02239bf39a6d9225a2415002469c6c12a8b22d86fdd81451a157fd9b6b5752bf |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#discussion_r187332142 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/13533df923b8c776677f59d5342ab221778d6ac9..12f45524597cb1ac5966282e33afc089fb0eec05 |
| 13533df | https://github.com/patternfly/patternfly-react/commit/13533df923b8c776677f59d5342ab221778d6ac9 |
| 12f4552 | https://github.com/patternfly/patternfly-react/commit/12f45524597cb1ac5966282e33afc089fb0eec05 |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/13533df923b8c776677f59d5342ab221778d6ac9..12f45524597cb1ac5966282e33afc089fb0eec05 |
| May 10, 2018 13:45 | https://github.com/patternfly/patternfly-react/pull/336#event-1619810086 |
|
| https://github.com/glekner |
| fix(Dividing onNotificationClick): dividing onNotificationClick to tw… | https://github.com/patternfly/patternfly-react/pull/336/commits/2f1f66454b5fc721fe77fc4384dc611b175b86bf |
| 2f1f664 | https://github.com/patternfly/patternfly-react/pull/336/commits/2f1f66454b5fc721fe77fc4384dc611b175b86bf |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/12f45524597cb1ac5966282e33afc089fb0eec05..2f1f66454b5fc721fe77fc4384dc611b175b86bf |
| 12f4552 | https://github.com/patternfly/patternfly-react/commit/12f45524597cb1ac5966282e33afc089fb0eec05 |
| 2f1f664 | https://github.com/patternfly/patternfly-react/commit/2f1f66454b5fc721fe77fc4384dc611b175b86bf |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/12f45524597cb1ac5966282e33afc089fb0eec05..2f1f66454b5fc721fe77fc4384dc611b175b86bf |
| May 10, 2018 14:08 | https://github.com/patternfly/patternfly-react/pull/336#event-1619857515 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
May 10, 2018
| https://github.com/patternfly/patternfly-react/pull/336#pullrequestreview-119105500 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/336/files/2f1f66454b5fc721fe77fc4384dc611b175b86bf |
| https://github.com/cdcabrera |
| cdcabrera | https://github.com/cdcabrera |
|
May 10, 2018
| https://github.com/patternfly/patternfly-react/pull/336#pullrequestreview-119129203 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/336/files/2f1f66454b5fc721fe77fc4384dc611b175b86bf |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| f19e4f7 | https://github.com/patternfly/patternfly-react/commit/f19e4f77f9dffef802dd0ea9af89962f3597e014 |
| May 10, 2018 | https://github.com/patternfly/patternfly-react/pull/336#event-1620059914 |
| https://github.com/glekner |
| glekner | https://github.com/glekner |
| May 10, 2018 18:43 | https://github.com/patternfly/patternfly-react/pull/336#event-1620429485 |
| https://github.co/hiddenchars |
| https://github.com/patternfly/patternfly-react/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F336 |
|
| https://github.com/cdcabrera |
|
cdcabrera
| https://github.com/cdcabrera |
|
| https://github.com/patternfly/patternfly-react/pull/336/files/2f1f66454b5fc721fe77fc4384dc611b175b86bf |
|
| https://github.com/jeff-phillips-18 |
|
jeff-phillips-18
| https://github.com/jeff-phillips-18 |
|
| https://github.com/patternfly/patternfly-react/pull/336/files/2f1f66454b5fc721fe77fc4384dc611b175b86bf |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/336 |
|
| https://github.com/glekner |
|
| https://github.com/cdcabrera |
|
| https://github.com/jeff-phillips-18 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |