| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7c340d5a-be0d-a53f-5272-b9691fa3ad4e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0E6:2978F1:B9957:F49BB:6B00BA04 |
| html-safe-nonce | e5a9cfa3f3e66ab0b6151ceb8f63dfafebd9c380b2ee2821144bd64891163735 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEU2OjI5NzhGMTpCOTk1NzpGNDlCQjo2QjAwQkEwNCIsInZpc2l0b3JfaWQiOiI3ODkwNzY4NTc1NzYwMjE4NjI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8de804314044be1ab36323a133b26a242e61d5905b22f36a462cf3c51d92ca53 |
| hovercard-subject-tag | pull_request:180008662 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/patternfly/patternfly-react/298/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/466867df54b6c0d622ee48ec880576d24564fa6a2aacd097a690b50e387184cb/patternfly/patternfly-react/pull/298 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/466867df54b6c0d622ee48ec880576d24564fa6a2aacd097a690b50e387184cb/patternfly/patternfly-react/pull/298 |
| og:image:alt | Fix for issue #277 where the hideCloseIcon property did not have an effect on expanded content. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chalettu |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2 |
| turbo-cache-control | no-cache |
| go-import | github.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git |
| octolytics-dimension-user_id | 6391110 |
| octolytics-dimension-user_login | patternfly |
| octolytics-dimension-repository_id | 84372347 |
| octolytics-dimension-repository_nwo | patternfly/patternfly-react |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 84372347 |
| octolytics-dimension-repository_network_root_nwo | patternfly/patternfly-react |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5429cbfc6aca8c7b9a086a3c8f47400346f38cc9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/patternfly/patternfly-react/pull/298#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F298 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F298 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=patternfly%2Fpatternfly-react |
| Reload | https://github.com/patternfly/patternfly-react/pull/298 |
| Reload | https://github.com/patternfly/patternfly-react/pull/298 |
| Reload | https://github.com/patternfly/patternfly-react/pull/298 |
| patternfly | https://github.com/patternfly |
| patternfly-react | https://github.com/patternfly/patternfly-react |
| Code | https://github.com/patternfly/patternfly-react |
| Issues222 (222) | https://github.com/patternfly/patternfly-react/issues |
| Pull requests36 (36) | https://github.com/patternfly/patternfly-react/pulls |
| Discussions | https://github.com/patternfly/patternfly-react/discussions |
| Actions | https://github.com/patternfly/patternfly-react/actions |
| Projects | https://github.com/patternfly/patternfly-react/projects |
| Wiki | https://github.com/patternfly/patternfly-react/wiki |
| Security and quality | https://github.com/patternfly/patternfly-react/security |
| Insights | https://github.com/patternfly/patternfly-react/insights |
| https://github.com/patternfly/patternfly-react |
| priley86 | https://github.com/priley86 |
| patternfly:master | https://github.com/patternfly/patternfly-react/tree/master |
| chalettu:listview-hide_close_icon | https://github.com/chalettu/patternfly-react/tree/listview-hide_close_icon |
| Conversation | https://github.com/patternfly/patternfly-react/pull/298 |
| Commits3 (3) | https://github.com/patternfly/patternfly-react/pull/298/commits |
| Checks | https://github.com/patternfly/patternfly-react/pull/298/checks |
| Files changed | https://github.com/patternfly/patternfly-react/pull/298/files |
| fix(ListView): Fixed issue with hideCloseIcon not being respected | https://github.com/patternfly/patternfly-react/pull/298#top |
| priley86 | https://github.com/priley86 |
| patternfly:master | https://github.com/patternfly/patternfly-react/tree/master |
| chalettu:listview-hide_close_icon | https://github.com/chalettu/patternfly-react/tree/listview-hide_close_icon |
|
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| Apr 6, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issue-312056336 |
| #277 | https://github.com/patternfly/patternfly-react/issues/277 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
|
| https://github.com/chalettu |
| fix(ListView): Fixed issue with hideCloseIcon not being respected | https://github.com/patternfly/patternfly-react/pull/298/commits/ab53aaceca3387464ad2190f24781166b1a657ae |
| ab53aac | https://github.com/patternfly/patternfly-react/pull/298/commits/ab53aaceca3387464ad2190f24781166b1a657ae |
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| Apr 6, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379322642 |
| https://user-images.githubusercontent.com/230549/38435129-000f8924-398e-11e8-80a4-87f0100ebf56.gif |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| priley86 | https://github.com/priley86 |
| April 6, 2018 17:32 | https://github.com/patternfly/patternfly-react/pull/298#event-1561389956 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| Apr 6, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379325984 |
| Build 1111 | https://coveralls.io/builds/16388559 |
| https://coveralls.io/builds/16388559 |
| Build 1105 | https://coveralls.io/builds/16344812 |
| Coveralls | https://coveralls.io |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/coveralls |
| coveralls | https://github.com/coveralls |
| Apr 6, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379325988 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| Build 1159 | https://coveralls.io/builds/16487872 |
| https://coveralls.io/builds/16487872 |
| Build 1158 | https://coveralls.io/builds/16487594 |
| Coveralls | https://coveralls.io |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
Apr 6, 2018
| https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110180283 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae |
| src/components/ListView/ListViewGroupItemContainer.js | https://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae#diff-38ed37ed464c01fcefac141a2c68702059893fe7225033e82affbc65f4a3a8ac |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Apr 6, 2018 | https://github.com/patternfly/patternfly-react/pull/298#discussion_r179853090 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
Apr 6, 2018
| https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110180492 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae |
| src/components/ListView/ListView.stories.js | https://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae#diff-5e3f35d2936c030b0a930208e21d9f7a5122964edac3a4841e078d767a126eb5 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Apr 6, 2018 | https://github.com/patternfly/patternfly-react/pull/298#discussion_r179853259 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
|
| https://github.com/chalettu |
| fix(ListView): Updated close icon to use knob in storybook | https://github.com/patternfly/patternfly-react/pull/298/commits/a63125bc719936fc531295beea8aad76bf09ed4a |
| a63125b | https://github.com/patternfly/patternfly-react/pull/298/commits/a63125bc719936fc531295beea8aad76bf09ed4a |
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| Apr 6, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379384823 |
| @jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| https://user-images.githubusercontent.com/230549/38444892-5e9a7d62-39ae-11e8-9a2d-a749dbf260c8.gif |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
Apr 7, 2018
| https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110255746 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a |
| src/components/ListView/ListViewItem.js | https://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a#diff-c936774eea1eafb7979392dc12a3bce027dfbe06ef293993550652ad4f9ce806 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Apr 7, 2018 | https://github.com/patternfly/patternfly-react/pull/298#discussion_r179916971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Apr 12, 2018 | https://github.com/patternfly/patternfly-react/pull/298#discussion_r181173372 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @chalettu | https://github.com/chalettu |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
Apr 7, 2018
| https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110255755 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a |
| src/components/ListView/ListViewItem.js | https://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a#diff-c936774eea1eafb7979392dc12a3bce027dfbe06ef293993550652ad4f9ce806 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Apr 7, 2018 | https://github.com/patternfly/patternfly-react/pull/298#discussion_r179916980 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| Apr 12, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-380823832 |
| @jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Apr 12, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-380895786 |
| @chalettu | https://github.com/chalettu |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
|
| https://github.com/chalettu |
| fix(ListView): Removed parameter hideCloseIcon | https://github.com/patternfly/patternfly-react/pull/298/commits/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
| cd076f5 | https://github.com/patternfly/patternfly-react/pull/298/commits/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| force-pushed | https://github.com/patternfly/patternfly-react/compare/3400d2717ee1113931db374d8cac8610d2356618..cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
| 3400d27 | https://github.com/patternfly/patternfly-react/commit/3400d2717ee1113931db374d8cac8610d2356618 |
| cd076f5 | https://github.com/patternfly/patternfly-react/commit/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
|
Compare
| https://github.com/patternfly/patternfly-react/compare/3400d2717ee1113931db374d8cac8610d2356618..cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
| April 12, 2018 18:18 | https://github.com/patternfly/patternfly-react/pull/298#event-1571655256 |
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| Apr 12, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-380902710 |
| @jeff-phillips-18 | https://github.com/jeff-phillips-18 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/jeff-phillips-18 |
| jeff-phillips-18 | https://github.com/jeff-phillips-18 |
|
Apr 12, 2018
| https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-111744779 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
|
Apr 13, 2018
| https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-112041253 |
|
View reviewed changes
| https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
| Apr 13, 2018 | https://github.com/patternfly/patternfly-react/pull/298#issuecomment-381160143 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| https://github.com/priley86 |
| priley86 | https://github.com/priley86 |
| 0b5fc10 | https://github.com/patternfly/patternfly-react/commit/0b5fc1085851d13042530274ab5de7609a64665f |
| Apr 13, 2018 | https://github.com/patternfly/patternfly-react/pull/298#event-1573449965 |
| https://github.com/chalettu |
| chalettu | https://github.com/chalettu |
| April 23, 2018 16:37 | https://github.com/patternfly/patternfly-react/pull/298#event-1589619074 |
| https://github.co/hiddenchars |
| https://github.com/patternfly/patternfly-react/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F298 |
|
| https://github.com/jeff-phillips-18 |
|
jeff-phillips-18
| https://github.com/jeff-phillips-18 |
|
| https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
|
| https://github.com/priley86 |
|
priley86
| https://github.com/priley86 |
|
| https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
| Please reload this page | https://github.com/patternfly/patternfly-react/pull/298 |
|
| https://github.com/chalettu |
|
| https://github.com/coveralls |
|
| https://github.com/jeff-phillips-18 |
|
| https://github.com/priley86 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |