René's URL Explorer Experiment


Title: fix(ListView): Fixed issue with hideCloseIcon not being respected by chalettu · Pull Request #298 · patternfly/patternfly-react · GitHub

Open Graph Title: fix(ListView): Fixed issue with hideCloseIcon not being respected by chalettu · Pull Request #298 · patternfly/patternfly-react

X Title: fix(ListView): Fixed issue with hideCloseIcon not being respected by chalettu · Pull Request #298 · patternfly/patternfly-react

Description: A set of React components for the PatternFly project. - fix(ListView): Fixed issue with hideCloseIcon not being respected by chalettu · Pull Request #298 · patternfly/patternfly-react

Open Graph Description: Fix for issue #277 where the hideCloseIcon property did not have an effect on expanded content.

X Description: Fix for issue #277 where the hideCloseIcon property did not have an effect on expanded content.

Opengraph URL: https://github.com/patternfly/patternfly-react/pull/298

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c340d5a-be0d-a53f-5272-b9691fa3ad4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0E6:2978F1:B9957:F49BB:6B00BA04
html-safe-noncee5a9cfa3f3e66ab0b6151ceb8f63dfafebd9c380b2ee2821144bd64891163735
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEU2OjI5NzhGMTpCOTk1NzpGNDlCQjo2QjAwQkEwNCIsInZpc2l0b3JfaWQiOiI3ODkwNzY4NTc1NzYwMjE4NjI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8de804314044be1ab36323a133b26a242e61d5905b22f36a462cf3c51d92ca53
hovercard-subject-tagpull_request:180008662
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/patternfly/patternfly-react/298/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/466867df54b6c0d622ee48ec880576d24564fa6a2aacd097a690b50e387184cb/patternfly/patternfly-react/pull/298
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/466867df54b6c0d622ee48ec880576d24564fa6a2aacd097a690b50e387184cb/patternfly/patternfly-react/pull/298
og:image:altFix for issue #277 where the hideCloseIcon property did not have an effect on expanded content.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechalettu
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-cache
go-importgithub.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git
octolytics-dimension-user_id6391110
octolytics-dimension-user_loginpatternfly
octolytics-dimension-repository_id84372347
octolytics-dimension-repository_nwopatternfly/patternfly-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id84372347
octolytics-dimension-repository_network_root_nwopatternfly/patternfly-react
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/patternfly/patternfly-react/pull/298#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F298
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F298
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=patternfly%2Fpatternfly-react
Reloadhttps://github.com/patternfly/patternfly-react/pull/298
Reloadhttps://github.com/patternfly/patternfly-react/pull/298
Reloadhttps://github.com/patternfly/patternfly-react/pull/298
patternflyhttps://github.com/patternfly
patternfly-reacthttps://github.com/patternfly/patternfly-react
Codehttps://github.com/patternfly/patternfly-react
Issues222 (222)https://github.com/patternfly/patternfly-react/issues
Pull requests36 (36)https://github.com/patternfly/patternfly-react/pulls
Discussionshttps://github.com/patternfly/patternfly-react/discussions
Actionshttps://github.com/patternfly/patternfly-react/actions
Projectshttps://github.com/patternfly/patternfly-react/projects
Wikihttps://github.com/patternfly/patternfly-react/wiki
Security and qualityhttps://github.com/patternfly/patternfly-react/security
Insightshttps://github.com/patternfly/patternfly-react/insights
https://github.com/patternfly/patternfly-react
priley86https://github.com/priley86
patternfly:masterhttps://github.com/patternfly/patternfly-react/tree/master
chalettu:listview-hide_close_iconhttps://github.com/chalettu/patternfly-react/tree/listview-hide_close_icon
Conversationhttps://github.com/patternfly/patternfly-react/pull/298
Commits3 (3)https://github.com/patternfly/patternfly-react/pull/298/commits
Checkshttps://github.com/patternfly/patternfly-react/pull/298/checks
Files changedhttps://github.com/patternfly/patternfly-react/pull/298/files
fix(ListView): Fixed issue with hideCloseIcon not being respectedhttps://github.com/patternfly/patternfly-react/pull/298#top
priley86https://github.com/priley86
patternfly:masterhttps://github.com/patternfly/patternfly-react/tree/master
chalettu:listview-hide_close_iconhttps://github.com/chalettu/patternfly-react/tree/listview-hide_close_icon
https://github.com/chalettu
chalettuhttps://github.com/chalettu
Apr 6, 2018https://github.com/patternfly/patternfly-react/pull/298#issue-312056336
#277https://github.com/patternfly/patternfly-react/issues/277
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/chalettu
fix(ListView): Fixed issue with hideCloseIcon not being respectedhttps://github.com/patternfly/patternfly-react/pull/298/commits/ab53aaceca3387464ad2190f24781166b1a657ae
ab53aachttps://github.com/patternfly/patternfly-react/pull/298/commits/ab53aaceca3387464ad2190f24781166b1a657ae
https://github.com/chalettu
chalettuhttps://github.com/chalettu
Apr 6, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379322642
https://user-images.githubusercontent.com/230549/38435129-000f8924-398e-11e8-80a4-87f0100ebf56.gif
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/chalettu
chalettuhttps://github.com/chalettu
priley86https://github.com/priley86
April 6, 2018 17:32https://github.com/patternfly/patternfly-react/pull/298#event-1561389956
https://github.com/coveralls
coverallshttps://github.com/coveralls
Apr 6, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379325984
Build 1111https://coveralls.io/builds/16388559
https://coveralls.io/builds/16388559
Build 1105https://coveralls.io/builds/16344812
Coverallshttps://coveralls.io
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/coveralls
coverallshttps://github.com/coveralls
Apr 6, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379325988
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
Build 1159https://coveralls.io/builds/16487872
https://coveralls.io/builds/16487872
Build 1158https://coveralls.io/builds/16487594
Coverallshttps://coveralls.io
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/jeff-phillips-18
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 6, 2018 https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110180283
View reviewed changes https://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae
src/components/ListView/ListViewGroupItemContainer.jshttps://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae#diff-38ed37ed464c01fcefac141a2c68702059893fe7225033e82affbc65f4a3a8ac
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 6, 2018https://github.com/patternfly/patternfly-react/pull/298#discussion_r179853090
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/jeff-phillips-18
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 6, 2018 https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110180492
View reviewed changes https://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae
src/components/ListView/ListView.stories.jshttps://github.com/patternfly/patternfly-react/pull/298/files/ab53aaceca3387464ad2190f24781166b1a657ae#diff-5e3f35d2936c030b0a930208e21d9f7a5122964edac3a4841e078d767a126eb5
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 6, 2018https://github.com/patternfly/patternfly-react/pull/298#discussion_r179853259
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/chalettu
fix(ListView): Updated close icon to use knob in storybookhttps://github.com/patternfly/patternfly-react/pull/298/commits/a63125bc719936fc531295beea8aad76bf09ed4a
a63125bhttps://github.com/patternfly/patternfly-react/pull/298/commits/a63125bc719936fc531295beea8aad76bf09ed4a
https://github.com/chalettu
chalettuhttps://github.com/chalettu
Apr 6, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-379384823
@jeff-phillips-18https://github.com/jeff-phillips-18
https://user-images.githubusercontent.com/230549/38444892-5e9a7d62-39ae-11e8-9a2d-a749dbf260c8.gif
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/jeff-phillips-18
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 7, 2018 https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110255746
View reviewed changes https://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a
src/components/ListView/ListViewItem.jshttps://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a#diff-c936774eea1eafb7979392dc12a3bce027dfbe06ef293993550652ad4f9ce806
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 7, 2018https://github.com/patternfly/patternfly-react/pull/298#discussion_r179916971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 12, 2018https://github.com/patternfly/patternfly-react/pull/298#discussion_r181173372
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@chalettuhttps://github.com/chalettu
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/jeff-phillips-18
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 7, 2018 https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-110255755
View reviewed changes https://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a
src/components/ListView/ListViewItem.jshttps://github.com/patternfly/patternfly-react/pull/298/files/a63125bc719936fc531295beea8aad76bf09ed4a#diff-c936774eea1eafb7979392dc12a3bce027dfbe06ef293993550652ad4f9ce806
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 7, 2018https://github.com/patternfly/patternfly-react/pull/298#discussion_r179916980
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/chalettu
chalettuhttps://github.com/chalettu
Apr 12, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-380823832
@jeff-phillips-18https://github.com/jeff-phillips-18
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/jeff-phillips-18
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 12, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-380895786
@chalettuhttps://github.com/chalettu
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/chalettu
fix(ListView): Removed parameter hideCloseIconhttps://github.com/patternfly/patternfly-react/pull/298/commits/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
cd076f5https://github.com/patternfly/patternfly-react/pull/298/commits/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
https://github.com/chalettu
chalettuhttps://github.com/chalettu
force-pushedhttps://github.com/patternfly/patternfly-react/compare/3400d2717ee1113931db374d8cac8610d2356618..cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
3400d27https://github.com/patternfly/patternfly-react/commit/3400d2717ee1113931db374d8cac8610d2356618
cd076f5https://github.com/patternfly/patternfly-react/commit/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
Compare https://github.com/patternfly/patternfly-react/compare/3400d2717ee1113931db374d8cac8610d2356618..cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
April 12, 2018 18:18https://github.com/patternfly/patternfly-react/pull/298#event-1571655256
https://github.com/chalettu
chalettuhttps://github.com/chalettu
Apr 12, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-380902710
@jeff-phillips-18https://github.com/jeff-phillips-18
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/jeff-phillips-18
jeff-phillips-18https://github.com/jeff-phillips-18
Apr 12, 2018 https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-111744779
View reviewed changes https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
https://github.com/priley86
priley86https://github.com/priley86
Apr 13, 2018 https://github.com/patternfly/patternfly-react/pull/298#pullrequestreview-112041253
View reviewed changes https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
https://github.com/priley86
priley86https://github.com/priley86
Apr 13, 2018https://github.com/patternfly/patternfly-react/pull/298#issuecomment-381160143
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/priley86
priley86https://github.com/priley86
0b5fc10https://github.com/patternfly/patternfly-react/commit/0b5fc1085851d13042530274ab5de7609a64665f
Apr 13, 2018https://github.com/patternfly/patternfly-react/pull/298#event-1573449965
https://github.com/chalettu
chalettuhttps://github.com/chalettu
April 23, 2018 16:37https://github.com/patternfly/patternfly-react/pull/298#event-1589619074
https://github.co/hiddenchars
https://github.com/patternfly/patternfly-react/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F298
https://github.com/jeff-phillips-18
jeff-phillips-18 https://github.com/jeff-phillips-18
https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
https://github.com/priley86
priley86 https://github.com/priley86
https://github.com/patternfly/patternfly-react/pull/298/files/cd076f5a5bb8d1d2a3186ce60dabf4eb9993bb19
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/298
https://github.com/chalettu
https://github.com/coveralls
https://github.com/jeff-phillips-18
https://github.com/priley86
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.