René's URL Explorer Experiment


Title: fix(cards): match height container can be null if not rendered by priley86 · Pull Request #296 · patternfly/patternfly-react · GitHub

Open Graph Title: fix(cards): match height container can be null if not rendered by priley86 · Pull Request #296 · patternfly/patternfly-react

X Title: fix(cards): match height container can be null if not rendered by priley86 · Pull Request #296 · patternfly/patternfly-react

Description: What: I noticed that when a modal overlay pops up in our downstream app that the card match container element can become null. It seems that we are rendering/re-rendering the card content. This seems to be an edge case but a sanity check does not hurt. Otherwise this will just give a reference error in the console when the modal opens. Still testing this downstream... Link to Storybook: Additional issues:

Open Graph Description: What: I noticed that when a modal overlay pops up in our downstream app that the card match container element can become null. It seems that we are rendering/re-rendering the card content. This see...

X Description: What: I noticed that when a modal overlay pops up in our downstream app that the card match container element can become null. It seems that we are rendering/re-rendering the card content. This see...

Opengraph URL: https://github.com/patternfly/patternfly-react/pull/296

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bd0a3afd-cdd7-ec70-0092-331530ccca98
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8FC8:D0E46:612BF4:8255CE:6B00D2CE
html-safe-nonce36a2d39fe8f6618338bfd4c158a9303549b7d0cf0d453f1c2cf3487b74afe0b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkM4OkQwRTQ2OjYxMkJGNDo4MjU1Q0U6NkIwMEQyQ0UiLCJ2aXNpdG9yX2lkIjoiNTk1NjcyNzY2MTE1Njk0NjYzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd29a9cc9cfb0eecdc211749a70b4e85184b6640268b9b468a96775eca4032645
hovercard-subject-tagpull_request:179669408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/patternfly/patternfly-react/pull/296/files
twitter:imagehttps://avatars.githubusercontent.com/u/4237045?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4237045?s=400&v=4
og:image:altWhat: I noticed that when a modal overlay pops up in our downstream app that the card match container element can become null. It seems that we are rendering/re-rendering the card content. This see...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git
octolytics-dimension-user_id6391110
octolytics-dimension-user_loginpatternfly
octolytics-dimension-repository_id84372347
octolytics-dimension-repository_nwopatternfly/patternfly-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id84372347
octolytics-dimension-repository_network_root_nwopatternfly/patternfly-react
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/patternfly/patternfly-react/pull/296/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F296%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F296%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=patternfly%2Fpatternfly-react
Reloadhttps://github.com/patternfly/patternfly-react/pull/296/files
Reloadhttps://github.com/patternfly/patternfly-react/pull/296/files
Reloadhttps://github.com/patternfly/patternfly-react/pull/296/files
patternflyhttps://github.com/patternfly
patternfly-reacthttps://github.com/patternfly/patternfly-react
Codehttps://github.com/patternfly/patternfly-react
Issues222 (222)https://github.com/patternfly/patternfly-react/issues
Pull requests36 (36)https://github.com/patternfly/patternfly-react/pulls
Discussionshttps://github.com/patternfly/patternfly-react/discussions
Actionshttps://github.com/patternfly/patternfly-react/actions
Projectshttps://github.com/patternfly/patternfly-react/projects
Wikihttps://github.com/patternfly/patternfly-react/wiki
Security and qualityhttps://github.com/patternfly/patternfly-react/security
Insightshttps://github.com/patternfly/patternfly-react/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpatternfly%2Fpatternfly-react%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpatternfly%2Fpatternfly-react%2Fissues%2Fnew%2Fchoose
priley86https://github.com/priley86
patternfly:masterhttps://github.com/patternfly/patternfly-react/tree/master
priley86:fix-card-match-heighthttps://github.com/priley86/patternfly-react/tree/fix-card-match-height
Conversation 5 https://github.com/patternfly/patternfly-react/pull/296
Commits 1 https://github.com/patternfly/patternfly-react/pull/296/commits
Checks 0 https://github.com/patternfly/patternfly-react/pull/296/checks
Files changed https://github.com/patternfly/patternfly-react/pull/296/files
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/296/files
fix(cards): match height container can be null if not rendered https://github.com/patternfly/patternfly-react/pull/296/files#top
Show all changes 1 commit https://github.com/patternfly/patternfly-react/pull/296/files
19935be fix(cards): match height container can be null if not rendered priley86 Apr 5, 2018 https://github.com/patternfly/patternfly-react/pull/296/commits/19935be92ba14711615a39f2c06cf8b8a9a1c399
Clear filters https://github.com/patternfly/patternfly-react/pull/296/files
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/296/files
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/296/files
src/components/Cards/CardHeightMatching.jshttps://github.com/patternfly/patternfly-react/pull/296/files#diff-84dfdd155d024ec89a865d83abb7056f518e09cd5f3c87c27d2be686c63a5c03
View file https://github.com/priley86/patternfly-react/blob/19935be92ba14711615a39f2c06cf8b8a9a1c399/src/components/Cards/CardHeightMatching.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/patternfly/patternfly-react/pull/296/{{ revealButtonHref }}
https://github.com/patternfly/patternfly-react/pull/296/files#diff-84dfdd155d024ec89a865d83abb7056f518e09cd5f3c87c27d2be686c63a5c03
https://github.com/patternfly/patternfly-react/pull/296/files#diff-84dfdd155d024ec89a865d83abb7056f518e09cd5f3c87c27d2be686c63a5c03
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.