René's URL Explorer Experiment


Title: WIP feat(tables): adds react-bootstrap-table and patternfly tables by priley86 · Pull Request #134 · patternfly/patternfly-react · GitHub

Open Graph Title: WIP feat(tables): adds react-bootstrap-table and patternfly tables by priley86 · Pull Request #134 · patternfly/patternfly-react

X Title: WIP feat(tables): adds react-bootstrap-table and patternfly tables by priley86 · Pull Request #134 · patternfly/patternfly-react

Description: What: Pushing an initial PR to showcase react-bootstrap-table and some markup rendered. Good things: 👍 API is very comprehensive and would handle most PF functionality (sort, pagination, column visibility, csv export, etc) Bad things: 👎 Markup is not semantic. Multiple

elements rendered inside div's 👎 Table is not really accessible it seems, even with keyboard navigation mode I can't go backwards when shift-tabbing. 👎 Custom CSS added in react-bootstrap-table-all.min.css is not good so I removed it and added a few custom classes to get it much closer. 👎 There is always an additional div rendering in the th element. Any knows how to remove it? (see Data Tables example started) 👎 PF has custom carrot rendered w/ sorting_asc class (example here). We need to customize the th using a ref it appears. Link to Storybook cc: @jeff-phillips-18 @ohadlevy @yaacov @amirfefer At this point, I am wondering if we should go ahead and consider reactabular as it seems to have complete customization and should help avoid these sort of things... Would ❤️ any more thoughts when you have a chance 😄 Additional issues:

Open Graph Description: What: Pushing an initial PR to showcase react-bootstrap-table and some markup rendered. Good things: 👍 API is very comprehensive and would handle most PF functionality (sort, pagination, column vis...

X Description: What: Pushing an initial PR to showcase react-bootstrap-table and some markup rendered. Good things: 👍 API is very comprehensive and would handle most PF functionality (sort, pagination, column vis...

Opengraph URL: https://github.com/patternfly/patternfly-react/pull/134

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fb84d0ef-ee50-47af-141c-72a37985b5e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8C6:65478:8F85EB:C09733:6B00E408
html-safe-nonce62c94edc635d101fc6fa4b827ccdbf8629c7ab214fb46f727565d6daf3fd1ece
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEM2OjY1NDc4OjhGODVFQjpDMDk3MzM6NkIwMEU0MDgiLCJ2aXNpdG9yX2lkIjoiODQ4NTk4MzU1NjE2NDcwNzMzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac648c9c672519416ada548d777a3457fa7439977c965b5b53db6858e5fed5a361
hovercard-subject-tagpull_request:159077197
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/patternfly/patternfly-react/pull/134/files
twitter:imagehttps://avatars.githubusercontent.com/u/4237045?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4237045?s=400&v=4
og:image:altWhat: Pushing an initial PR to showcase react-bootstrap-table and some markup rendered. Good things: 👍 API is very comprehensive and would handle most PF functionality (sort, pagination, column vis...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git
octolytics-dimension-user_id6391110
octolytics-dimension-user_loginpatternfly
octolytics-dimension-repository_id84372347
octolytics-dimension-repository_nwopatternfly/patternfly-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id84372347
octolytics-dimension-repository_network_root_nwopatternfly/patternfly-react
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/patternfly/patternfly-react/pull/134/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F134%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fpull%2F134%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=patternfly%2Fpatternfly-react
Reloadhttps://github.com/patternfly/patternfly-react/pull/134/files
Reloadhttps://github.com/patternfly/patternfly-react/pull/134/files
Reloadhttps://github.com/patternfly/patternfly-react/pull/134/files
patternflyhttps://github.com/patternfly
patternfly-reacthttps://github.com/patternfly/patternfly-react
Codehttps://github.com/patternfly/patternfly-react
Issues222 (222)https://github.com/patternfly/patternfly-react/issues
Pull requests36 (36)https://github.com/patternfly/patternfly-react/pulls
Discussionshttps://github.com/patternfly/patternfly-react/discussions
Actionshttps://github.com/patternfly/patternfly-react/actions
Projectshttps://github.com/patternfly/patternfly-react/projects
Wikihttps://github.com/patternfly/patternfly-react/wiki
Security and qualityhttps://github.com/patternfly/patternfly-react/security
Insightshttps://github.com/patternfly/patternfly-react/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpatternfly%2Fpatternfly-react%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpatternfly%2Fpatternfly-react%2Fissues%2Fnew%2Fchoose
priley86https://github.com/priley86
patternfly:masterhttps://github.com/patternfly/patternfly-react/tree/master
priley86:tableshttps://github.com/priley86/patternfly-react/tree/tables
Conversation 7 https://github.com/patternfly/patternfly-react/pull/134
Commits 2 https://github.com/patternfly/patternfly-react/pull/134/commits
Checks 0 https://github.com/patternfly/patternfly-react/pull/134/checks
Files changed https://github.com/patternfly/patternfly-react/pull/134/files
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/134/files
WIP feat(tables): adds react-bootstrap-table and patternfly tables https://github.com/patternfly/patternfly-react/pull/134/files#top
Show all changes 2 commits https://github.com/patternfly/patternfly-react/pull/134/files
21ed791 feat(sass): Move from Less to Sass, create dist directory. jeff-phillips-18 Dec 15, 2017 https://github.com/patternfly/patternfly-react/pull/134/commits/21ed791a055b5f64c450f9b4201545c0aea89dca
37a1624 feat(tables): adds react-bootstrap-table and patternfly tables priley86 Dec 19, 2017 https://github.com/patternfly/patternfly-react/pull/134/commits/37a1624862d6d1e4aa4cc0fe3ebbe0f2d1f7d842
Clear filters https://github.com/patternfly/patternfly-react/pull/134/files
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/134/files
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/134/files
package-lock.json https://github.com/patternfly/patternfly-react/pull/134/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/patternfly/patternfly-react/pull/134/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
_patternfly-react.scss https://github.com/patternfly/patternfly-react/pull/134/files#diff-a24487c4fea094269deefa17d1fa49b915e3c7a95e697dc0c705504ae68f89f8
Table.js https://github.com/patternfly/patternfly-react/pull/134/files#diff-3e60dcc89034bfd7930b7f3cfe2937476e30fd5ef67ebb7115be170e2af52b39
Table.stories.js https://github.com/patternfly/patternfly-react/pull/134/files#diff-ca85cb60cae5036b23c6c014998b661fa54f568d1e189c7797d8b65c86d49438
mockTableItems.js https://github.com/patternfly/patternfly-react/pull/134/files#diff-233360b255d54e50e036f69e79619c054449fb5e20643dbae385c8fa4719f1bc
constants.js https://github.com/patternfly/patternfly-react/pull/134/files#diff-6d01d0ebb662202aa00a0a7869253cd4ff91f29df3c813300737c5c8cbb9dbf0
index.js https://github.com/patternfly/patternfly-react/pull/134/files#diff-9aa6b25aa4aab24215ebcedc56e0ff3c2a2e481a30b42eb3ca0fcce2c7752789
index.js https://github.com/patternfly/patternfly-react/pull/134/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556
package-lock.jsonhttps://github.com/patternfly/patternfly-react/pull/134/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
View file https://github.com/priley86/patternfly-react/blob/37a1624862d6d1e4aa4cc0fe3ebbe0f2d1f7d842/package-lock.json
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/134/files
package.jsonhttps://github.com/patternfly/patternfly-react/pull/134/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/priley86/patternfly-react/blob/37a1624862d6d1e4aa4cc0fe3ebbe0f2d1f7d842/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/patternfly/patternfly-react/pull/134/{{ revealButtonHref }}
https://github.com/patternfly/patternfly-react/pull/134/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/patternfly/patternfly-react/pull/134/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
sass/patternfly-react/_patternfly-react.scsshttps://github.com/patternfly/patternfly-react/pull/134/files#diff-a24487c4fea094269deefa17d1fa49b915e3c7a95e697dc0c705504ae68f89f8
View file https://github.com/priley86/patternfly-react/blob/37a1624862d6d1e4aa4cc0fe3ebbe0f2d1f7d842/sass/patternfly-react/_patternfly-react.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/patternfly/patternfly-react/pull/134/{{ revealButtonHref }}
src/components/Table/Table.jshttps://github.com/patternfly/patternfly-react/pull/134/files#diff-3e60dcc89034bfd7930b7f3cfe2937476e30fd5ef67ebb7115be170e2af52b39
View file https://github.com/priley86/patternfly-react/blob/37a1624862d6d1e4aa4cc0fe3ebbe0f2d1f7d842/src/components/Table/Table.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/patternfly/patternfly-react/pull/134/{{ revealButtonHref }}
src/components/Table/Table.stories.jshttps://github.com/patternfly/patternfly-react/pull/134/files#diff-ca85cb60cae5036b23c6c014998b661fa54f568d1e189c7797d8b65c86d49438
View file https://github.com/priley86/patternfly-react/blob/37a1624862d6d1e4aa4cc0fe3ebbe0f2d1f7d842/src/components/Table/Table.stories.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/patternfly/patternfly-react/pull/134/{{ revealButtonHref }}
Please reload this pagehttps://github.com/patternfly/patternfly-react/pull/134/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.