Title: PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome · Issue #1362 · patternfly/patternfly-react · GitHub
Open Graph Title: PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome · Issue #1362 · patternfly/patternfly-react
X Title: PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome · Issue #1362 · patternfly/patternfly-react
Description: The CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/sass/patternfly-react/_type-ah...
Open Graph Description: The CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/pattern...
X Description: The CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/pattern...
Opengraph URL: https://github.com/patternfly/patternfly-react/issues/1362
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome","articleBody":"The CSS we add on top of react-bootstrap-typeahead includes `height: fit-content`.\r\nSeen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/sass/patternfly-react/_type-ahead-select.scss#L8\r\nand here in our LESS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/less/type-ahead-select.less#L8\r\n\r\nAccording to https://developer.mozilla.org/en-US/docs/Web/CSS/height ,\r\n`fit-content` is only supported in Chrome. My project needs to support IE11, and needs this typeahead component.\r\n\r\nI tracked down where this line was originally added in PR https://github.com/patternfly/patternfly-react/pull/409, to fix the issue https://github.com/patternfly/patternfly-react/issues/413. ~~I'm a little confused, because when I remove this `fit-content` rule from the CSS, I still can't reproduce the issue. Maybe we don't need it at all? @Laviro, if you have time maybe you can help me figure out what's going on there.~~ Ok, I can now reproduce the issue in Storybook at https://1363-pr-patternfly-react-patternfly.surge.sh/, but I can't seem to reproduce it in my downstream project... 🤔 I'll try and figure that out separately, but we should find an IE11-friendly way we can fix the bug instead of using `fit-content`.","author":{"url":"https://github.com/mturley","@type":"Person","name":"mturley"},"datePublished":"2019-02-11T15:16:00Z","url":"https://github.com/patternfly/patternfly-react/issues/1362"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:88f4c38d-e789-0a7e-6fce-b99e6bfba32e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D3F8:3F4253:578EC7:76B9CD:6B00D266 |
| html-safe-nonce | 3111b10e8c997f14082c7a906b8fe91a7bd07aec9448aaaf26b994109b8d1e84 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0Y4OjNGNDI1Mzo1NzhFQzc6NzZCOUNEOjZCMDBEMjY2IiwidmlzaXRvcl9pZCI6IjEyMTM2MDIyNTYwNTg4OTY5OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 57b3df9b8514f00caf728246436c929b068555491c679e6c2b0b1343929a0c6f |
| hovercard-subject-tag | issue:408829516 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/patternfly/patternfly-react/1362/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e0adb65ee720f6d266266ede24129c01bd2929a92f8d7776742af9e6d3f6fc8e/patternfly/patternfly-react/issues/1362 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e0adb65ee720f6d266266ede24129c01bd2929a92f8d7776742af9e6d3f6fc8e/patternfly/patternfly-react/issues/1362 |
| og:image:alt | The CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/pattern... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mturley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5 |
| turbo-cache-control | no-preview |
| go-import | github.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git |
| octolytics-dimension-user_id | 6391110 |
| octolytics-dimension-user_login | patternfly |
| octolytics-dimension-repository_id | 84372347 |
| octolytics-dimension-repository_nwo | patternfly/patternfly-react |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 84372347 |
| octolytics-dimension-repository_network_root_nwo | patternfly/patternfly-react |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4943239a6d2c591325dad6e5c313e1cafda877f6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width