René's URL Explorer Experiment


Title: PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome · Issue #1362 · patternfly/patternfly-react · GitHub

Open Graph Title: PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome · Issue #1362 · patternfly/patternfly-react

X Title: PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome · Issue #1362 · patternfly/patternfly-react

Description: The CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/sass/patternfly-react/_type-ah...

Open Graph Description: The CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/pattern...

X Description: The CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/pattern...

Opengraph URL: https://github.com/patternfly/patternfly-react/issues/1362

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"PF3: TypeAheadSelect CSS includes `height: fit-content` rule which is only supported by Chrome","articleBody":"The CSS we add on top of react-bootstrap-typeahead includes `height: fit-content`.\r\nSeen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/sass/patternfly-react/_type-ahead-select.scss#L8\r\nand here in our LESS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/less/type-ahead-select.less#L8\r\n\r\nAccording to https://developer.mozilla.org/en-US/docs/Web/CSS/height ,\r\n`fit-content` is only supported in Chrome. My project needs to support IE11, and needs this typeahead component.\r\n\r\nI tracked down where this line was originally added in PR https://github.com/patternfly/patternfly-react/pull/409, to fix the issue https://github.com/patternfly/patternfly-react/issues/413. ~~I'm a little confused, because when I remove this `fit-content` rule from the CSS, I still can't reproduce the issue. Maybe we don't need it at all? @Laviro, if you have time maybe you can help me figure out what's going on there.~~ Ok, I can now reproduce the issue in Storybook at https://1363-pr-patternfly-react-patternfly.surge.sh/, but I can't seem to reproduce it in my downstream project... 🤔 I'll try and figure that out separately, but we should find an IE11-friendly way we can fix the bug instead of using `fit-content`.","author":{"url":"https://github.com/mturley","@type":"Person","name":"mturley"},"datePublished":"2019-02-11T15:16:00Z","url":"https://github.com/patternfly/patternfly-react/issues/1362"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:88f4c38d-e789-0a7e-6fce-b99e6bfba32e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD3F8:3F4253:578EC7:76B9CD:6B00D266
html-safe-nonce3111b10e8c997f14082c7a906b8fe91a7bd07aec9448aaaf26b994109b8d1e84
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0Y4OjNGNDI1Mzo1NzhFQzc6NzZCOUNEOjZCMDBEMjY2IiwidmlzaXRvcl9pZCI6IjEyMTM2MDIyNTYwNTg4OTY5OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac57b3df9b8514f00caf728246436c929b068555491c679e6c2b0b1343929a0c6f
hovercard-subject-tagissue:408829516
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/patternfly/patternfly-react/1362/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e0adb65ee720f6d266266ede24129c01bd2929a92f8d7776742af9e6d3f6fc8e/patternfly/patternfly-react/issues/1362
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e0adb65ee720f6d266266ede24129c01bd2929a92f8d7776742af9e6d3f6fc8e/patternfly/patternfly-react/issues/1362
og:image:altThe CSS we add on top of react-bootstrap-typeahead includes height: fit-content. Seen here in our SCSS file: https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/pattern...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemturley
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
go-importgithub.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git
octolytics-dimension-user_id6391110
octolytics-dimension-user_loginpatternfly
octolytics-dimension-repository_id84372347
octolytics-dimension-repository_nwopatternfly/patternfly-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id84372347
octolytics-dimension-repository_network_root_nwopatternfly/patternfly-react
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/patternfly/patternfly-react/issues/1362#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fissues%2F1362
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fissues%2F1362
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=patternfly%2Fpatternfly-react
Reloadhttps://github.com/patternfly/patternfly-react/issues/1362
Reloadhttps://github.com/patternfly/patternfly-react/issues/1362
Reloadhttps://github.com/patternfly/patternfly-react/issues/1362
patternflyhttps://github.com/patternfly
patternfly-reacthttps://github.com/patternfly/patternfly-react
Codehttps://github.com/patternfly/patternfly-react
Issues222 (222)https://github.com/patternfly/patternfly-react/issues
Pull requests36 (36)https://github.com/patternfly/patternfly-react/pulls
Discussionshttps://github.com/patternfly/patternfly-react/discussions
Actionshttps://github.com/patternfly/patternfly-react/actions
Projectshttps://github.com/patternfly/patternfly-react/projects
Wikihttps://github.com/patternfly/patternfly-react/wiki
Security and qualityhttps://github.com/patternfly/patternfly-react/security
Insightshttps://github.com/patternfly/patternfly-react/insights
https://github.com/patternfly/patternfly-react
New issuehttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/1362
New issuehttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/1362
#1369https://github.com/patternfly/patternfly-react/pull/1369
PF3: TypeAheadSelect CSS includes height: fit-content rule which is only supported by Chromehttps://github.com/patternfly/patternfly-react/issues/1362#top
#1369https://github.com/patternfly/patternfly-react/pull/1369
https://github.com/mturley
mturleyhttps://github.com/mturley
on Feb 11, 2019https://github.com/patternfly/patternfly-react/issues/1362#issue-408829516
https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/sass/patternfly-react/_type-ahead-select.scss#L8https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/sass/patternfly-react/_type-ahead-select.scss#L8
https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/less/type-ahead-select.less#L8https://github.com/patternfly/patternfly-react/blob/master/packages/patternfly-3/patternfly-react/less/type-ahead-select.less#L8
https://developer.mozilla.org/en-US/docs/Web/CSS/heighthttps://developer.mozilla.org/en-US/docs/Web/CSS/height
#409https://github.com/patternfly/patternfly-react/pull/409
#413https://github.com/patternfly/patternfly-react/issues/413
@LaVirohttps://github.com/LaViro
https://1363-pr-patternfly-react-patternfly.surge.sh/https://1363-pr-patternfly-react-patternfly.surge.sh/
mturleyhttps://github.com/mturley
bug 🐛https://github.com/patternfly/patternfly-react/issues?q=state%3Aopen%20label%3A%22bug%20%3Abug%3A%22
on Feb 11, 2019https://github.com/patternfly/patternfly-react/issues/1362#event-2130848514
https://github.com/mturley
mturleyhttps://github.com/mturley
on Feb 11, 2019https://github.com/patternfly/patternfly-react/issues/1362#issuecomment-462368645
@jeff-phillips-18https://github.com/jeff-phillips-18
@dgutridehttps://github.com/dgutride
mturleyhttps://github.com/mturley
on Feb 11, 2019https://github.com/patternfly/patternfly-react/issues/1362#event-2130940537
fix(TypeAheadSelect): Remove `height: fit-content` rule not supported…https://github.com/mturley/patternfly-react/commit/e5c0e0e9d1ffc848b183fc54cfa7a262eda0a354
e5c0e0ehttps://github.com/mturley/patternfly-react/commit/e5c0e0e9d1ffc848b183fc54cfa7a262eda0a354
fix(TypeAheadSelect): Fix input height overflow issue without breakin…https://github.com/mturley/patternfly-react/commit/aa6818dba31818ad20b11f18edbbbdc7fef6e5d2
aa6818dhttps://github.com/mturley/patternfly-react/commit/aa6818dba31818ad20b11f18edbbbdc7fef6e5d2
https://github.com/jeff-phillips-18
jeff-phillips-18https://github.com/jeff-phillips-18
on Feb 12, 2019https://github.com/patternfly/patternfly-react/issues/1362#issuecomment-462777606
@mturleyhttps://github.com/mturley
https://github.com/Ron-Lavi
Ron-Lavihttps://github.com/Ron-Lavi
on Feb 12, 2019https://github.com/patternfly/patternfly-react/issues/1362#issuecomment-462829088
#1369https://github.com/patternfly/patternfly-react/pull/1369
https://github.com/mturley
mturleyhttps://github.com/mturley
on Feb 12, 2019https://github.com/patternfly/patternfly-react/issues/1362#issuecomment-462850165
https://github.com/Ron-Lavi
Ron-Lavihttps://github.com/Ron-Lavi
on Feb 12, 2019https://github.com/patternfly/patternfly-react/issues/1362#issuecomment-462873704
https://github.com/mturley
mturleyhttps://github.com/mturley
on Feb 12, 2019https://github.com/patternfly/patternfly-react/issues/1362#issuecomment-462874531
jeff-phillips-18https://github.com/jeff-phillips-18
completedhttps://github.com/patternfly/patternfly-react/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1369https://github.com/patternfly/patternfly-react/pull/1369
on Mar 8, 2019https://github.com/patternfly/patternfly-react/issues/1362#event-2191072327
jeff-phillips-18https://github.com/jeff-phillips-18
on Mar 8, 2019https://github.com/patternfly/patternfly-react/issues/1362#event-2191072489
fix(TypeAheadSelect): Fix input height overflow issue without breakin…https://github.com/patternfly/patternfly-react/commit/0b2905b9e1d37e86b48114da1e7923d7caf01cb0
https://docs.github.com/articles/closing-issues-via-commit-messages
0b2905bhttps://github.com/patternfly/patternfly-react/commit/0b2905b9e1d37e86b48114da1e7923d7caf01cb0
Sign up for freehttps://github.com/signup?return_to=https://github.com/patternfly/patternfly-react/issues/1362
Sign in to commenthttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/1362
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.