Title: Bug - Modal - aria-hidden=true is forced on all siblings · Issue #12422 · patternfly/patternfly-react · GitHub
Open Graph Title: Bug - Modal - aria-hidden=true is forced on all siblings · Issue #12422 · patternfly/patternfly-react
X Title: Bug - Modal - aria-hidden=true is forced on all siblings · Issue #12422 · patternfly/patternfly-react
Description: Describe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select component we use for our dropdown menus (I ass...
Open Graph Description: Describe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select compon...
X Description: Describe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select compon...
Opengraph URL: https://github.com/patternfly/patternfly-react/issues/12422
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug - Modal - aria-hidden=true is forced on all siblings","articleBody":"**Describe the problem**\nThe `toggleSiblingsFromScreenReaders` function in Modal sets `aria-hidden` label on all siblings to `true` on both mount and update. This has unfortunate side-effect on `Select` component we use for our dropdown menus (I assume this is the case for all components that use `Popper`) . The dropdown (displayed and opened within then modal) gets attached to document `body` on the same level as the modal wrapper, making it it's sibling, and when modal re-renders, this function sets the `aria-hidden=\"true\"` label to the opened dropdown. This causes issues in accessibility and also in our Playwright tests (Playwright uses accessibility tree for navigation).\nhttps://github.com/patternfly/patternfly-react/blob/57fe8ee7cc6c44b7af797d6a52a30d19ef59785c/packages/react-core/src/components/Modal/Modal.tsx#L109\n\n**How do you reproduce the problem?**\nThis is a non-deterministic behaviour, so I was not really able to find a reliable way of reproducing this. I assume it is caused by the usage of the function in `componentDidUpdate` within the Modal.\n\n**Expected behavior**\n`toggleSiblingsFromScreenReaders` function does not affect `Popper` based components.\n\n**Is this issue blocking you?**\nNo, but causes frequent flakes in testing.\n\n**Screenshots**\n This screenshot from Playwright trace shows the menu attached on the same level as `Modal` with `aria-hidde` set to `true`. \n\n\n\n**What is your environment?**\n - OS: Fedora 43\n - Browser: Chrome\n - Version: 146.0.7680.177-1\n\n**What is your product and what release date are you targeting?**\n\n- Product: RHEL Image Builder service on console.redhat.com\n\n**Any other information?**\nNo.\n\n---\n\n**Jira Issue:** [PF-4154](https://redhat.atlassian.net/browse/PF-4154)","author":{"url":"https://github.com/tkoscieln","@type":"Person","name":"tkoscieln"},"datePublished":"2026-05-12T12:57:19Z","url":"https://github.com/patternfly/patternfly-react/issues/12422"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3dd653da-fed5-50ad-aee7-e13f32ed9683 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D002:2E7EBB:D4FE6E:10DD863:6B010052 |
| html-safe-nonce | 1357ca7f8eb18c046014c9aa78d15e9dad375200288c87fe13006c96b0ad5889 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDAyOjJFN0VCQjpENEZFNkU6MTBERDg2Mzo2QjAxMDA1MiIsInZpc2l0b3JfaWQiOiI5MTQ5ODU0ODkwMTcwODQzMjE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7ba9c91de24aa60db8a1db9c09a2cafe2f50d5a4f9dccb8e3ebdafac4a9dcf01 |
| hovercard-subject-tag | issue:4429289804 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/patternfly/patternfly-react/12422/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3e05691f49e50d9083c30c78a80161dd5c8a081bea259692fa29ed868cc8c0ce/patternfly/patternfly-react/issues/12422 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3e05691f49e50d9083c30c78a80161dd5c8a081bea259692fa29ed868cc8c0ce/patternfly/patternfly-react/issues/12422 |
| og:image:alt | Describe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select compon... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tkoscieln |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git |
| octolytics-dimension-user_id | 6391110 |
| octolytics-dimension-user_login | patternfly |
| octolytics-dimension-repository_id | 84372347 |
| octolytics-dimension-repository_nwo | patternfly/patternfly-react |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 84372347 |
| octolytics-dimension-repository_network_root_nwo | patternfly/patternfly-react |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width