René's URL Explorer Experiment


Title: Bug - Modal - aria-hidden=true is forced on all siblings · Issue #12422 · patternfly/patternfly-react · GitHub

Open Graph Title: Bug - Modal - aria-hidden=true is forced on all siblings · Issue #12422 · patternfly/patternfly-react

X Title: Bug - Modal - aria-hidden=true is forced on all siblings · Issue #12422 · patternfly/patternfly-react

Description: Describe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select component we use for our dropdown menus (I ass...

Open Graph Description: Describe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select compon...

X Description: Describe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select compon...

Opengraph URL: https://github.com/patternfly/patternfly-react/issues/12422

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug - Modal - aria-hidden=true is forced on all siblings","articleBody":"**Describe the problem**\nThe `toggleSiblingsFromScreenReaders` function in Modal sets `aria-hidden` label on all siblings to `true` on both mount and update. This has unfortunate side-effect on `Select` component we use for our dropdown menus (I assume this is the case for all components that use `Popper`) . The dropdown (displayed and opened within then modal) gets attached to document `body` on the same level as the modal wrapper, making it it's sibling, and when modal re-renders, this function sets the `aria-hidden=\"true\"` label to the opened dropdown. This causes issues in accessibility and also in our Playwright tests (Playwright uses accessibility tree for navigation).\nhttps://github.com/patternfly/patternfly-react/blob/57fe8ee7cc6c44b7af797d6a52a30d19ef59785c/packages/react-core/src/components/Modal/Modal.tsx#L109\n\n**How do you reproduce the problem?**\nThis is a non-deterministic behaviour, so I was not really able to find a reliable way of reproducing this. I assume it is caused by the usage of the function in `componentDidUpdate` within the Modal.\n\n**Expected behavior**\n`toggleSiblingsFromScreenReaders` function does not affect `Popper` based components.\n\n**Is this issue blocking you?**\nNo, but causes frequent flakes in testing.\n\n**Screenshots**\n This screenshot from Playwright trace shows the menu attached on the same level as `Modal` with `aria-hidde` set to `true`. \n\n![image](https://github.com/user-attachments/assets/ac004fd1-49bf-4499-b968-a9cb4f6e1791)\n\n**What is your environment?**\n - OS: Fedora 43\n - Browser: Chrome\n - Version: 146.0.7680.177-1\n\n**What is your product and what release date are you targeting?**\n\n- Product: RHEL Image Builder service on console.redhat.com\n\n**Any other information?**\nNo.\n\n---\n\n**Jira Issue:** [PF-4154](https://redhat.atlassian.net/browse/PF-4154)","author":{"url":"https://github.com/tkoscieln","@type":"Person","name":"tkoscieln"},"datePublished":"2026-05-12T12:57:19Z","url":"https://github.com/patternfly/patternfly-react/issues/12422"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3dd653da-fed5-50ad-aee7-e13f32ed9683
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD002:2E7EBB:D4FE6E:10DD863:6B010052
html-safe-nonce1357ca7f8eb18c046014c9aa78d15e9dad375200288c87fe13006c96b0ad5889
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDAyOjJFN0VCQjpENEZFNkU6MTBERDg2Mzo2QjAxMDA1MiIsInZpc2l0b3JfaWQiOiI5MTQ5ODU0ODkwMTcwODQzMjE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7ba9c91de24aa60db8a1db9c09a2cafe2f50d5a4f9dccb8e3ebdafac4a9dcf01
hovercard-subject-tagissue:4429289804
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/patternfly/patternfly-react/12422/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3e05691f49e50d9083c30c78a80161dd5c8a081bea259692fa29ed868cc8c0ce/patternfly/patternfly-react/issues/12422
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e05691f49e50d9083c30c78a80161dd5c8a081bea259692fa29ed868cc8c0ce/patternfly/patternfly-react/issues/12422
og:image:altDescribe the problem The toggleSiblingsFromScreenReaders function in Modal sets aria-hidden label on all siblings to true on both mount and update. This has unfortunate side-effect on Select compon...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametkoscieln
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git
octolytics-dimension-user_id6391110
octolytics-dimension-user_loginpatternfly
octolytics-dimension-repository_id84372347
octolytics-dimension-repository_nwopatternfly/patternfly-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id84372347
octolytics-dimension-repository_network_root_nwopatternfly/patternfly-react
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/patternfly/patternfly-react/issues/12422#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fissues%2F12422
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fissues%2F12422
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=patternfly%2Fpatternfly-react
Reloadhttps://github.com/patternfly/patternfly-react/issues/12422
Reloadhttps://github.com/patternfly/patternfly-react/issues/12422
Reloadhttps://github.com/patternfly/patternfly-react/issues/12422
patternflyhttps://github.com/patternfly
patternfly-reacthttps://github.com/patternfly/patternfly-react
Codehttps://github.com/patternfly/patternfly-react
Issues222 (222)https://github.com/patternfly/patternfly-react/issues
Pull requests36 (36)https://github.com/patternfly/patternfly-react/pulls
Discussionshttps://github.com/patternfly/patternfly-react/discussions
Actionshttps://github.com/patternfly/patternfly-react/actions
Projectshttps://github.com/patternfly/patternfly-react/projects
Wikihttps://github.com/patternfly/patternfly-react/wiki
Security and qualityhttps://github.com/patternfly/patternfly-react/security
Insightshttps://github.com/patternfly/patternfly-react/insights
https://github.com/patternfly/patternfly-react
New issuehttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/12422
New issuehttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/12422
Bughttps://github.com/patternfly/patternfly-react/issues?q=type:"Bug"
#12424https://github.com/patternfly/patternfly-react/pull/12424
Bug - Modal - aria-hidden=true is forced on all siblingshttps://github.com/patternfly/patternfly-react/issues/12422#top
#12424https://github.com/patternfly/patternfly-react/pull/12424
https://github.com/thatblindgeye
https://github.com/tkoscieln
tkoscielnhttps://github.com/tkoscieln
on May 12, 2026https://github.com/patternfly/patternfly-react/issues/12422#issue-4429289804
patternfly-react/packages/react-core/src/components/Modal/Modal.tsxhttps://github.com/patternfly/patternfly-react/blob/57fe8ee7cc6c44b7af797d6a52a30d19ef59785c/packages/react-core/src/components/Modal/Modal.tsx#L109
57fe8eehttps://github.com/patternfly/patternfly-react/commit/57fe8ee7cc6c44b7af797d6a52a30d19ef59785c
https://private-user-images.githubusercontent.com/147053087/591087704-ac004fd1-49bf-4499-b968-a9cb4f6e1791.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyMjgwMzAsIm5iZiI6MTc5NTIyNzczMCwicGF0aCI6Ii8xNDcwNTMwODcvNTkxMDg3NzA0LWFjMDA0ZmQxLTQ5YmYtNDQ5OS1iOTY4LWE5Y2I0ZjZlMTc5MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTEyMVQwMjIyMTBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04ZWZjMGEwZjdlMTA5MTUzNjgwZGRlZWNjNWM1ZjZhODQ2NDEzYmU4ZWM5NzUzN2ViMTk5MTZmY2NjNTVjZDRlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.txWTl8LIJ-IF8lMFuwG8LS4z5u7L1L5OioIHl2KetbM
PF-4154https://redhat.atlassian.net/browse/PF-4154
tkoscielnhttps://github.com/tkoscieln
Bughttps://github.com/patternfly/patternfly-react/issues?q=type:"Bug"
on May 12, 2026https://github.com/patternfly/patternfly-react/issues/12422#event-25430848865
patternfly-buildhttps://github.com/patternfly-build
PatternFly Issueshttps://github.com/orgs/patternfly/projects/7
on May 12, 2026https://github.com/patternfly/patternfly-react/issues/12422#event-25430860919
github-project-automationhttps://github.com/apps/github-project-automation
PatternFly Issueshttps://github.com/orgs/patternfly/projects/7
on May 12, 2026https://github.com/patternfly/patternfly-react/issues/12422
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
on Jul 20, 2026https://github.com/patternfly/patternfly-react/issues/12422#issuecomment-5022776475
GitHub Actionshttps://help.github.com/en/actions
github-actionshttps://github.com/apps/github-actions
Stalehttps://github.com/patternfly/patternfly-react/issues?q=state%3Aopen%20label%3A%22Stale%22
on Jul 20, 2026https://github.com/patternfly/patternfly-react/issues/12422#event-28214193079
patternfly-jira-synchttps://github.com/patternfly-jira-sync
thatblindgeyehttps://github.com/thatblindgeye
on Jul 22, 2026https://github.com/patternfly/patternfly-react/issues/12422#event-28341864266
github-actionshttps://github.com/apps/github-actions
Stalehttps://github.com/patternfly/patternfly-react/issues?q=state%3Aopen%20label%3A%22Stale%22
on Jul 29, 2026https://github.com/patternfly/patternfly-react/issues/12422#event-28662120934
thatblindgeyehttps://github.com/thatblindgeye
completedhttps://github.com/patternfly/patternfly-react/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#12424https://github.com/patternfly/patternfly-react/pull/12424
on Jul 30, 2026https://github.com/patternfly/patternfly-react/issues/12422#event-28734854704
RXTX4816https://github.com/RXTX4816
on Sep 14, 2026https://github.com/patternfly/patternfly-react/issues/12422#event-31109882538
fix(deps): bump PatternFly to 6.6.2 for the nested-modal aria-hidden fixhttps://github.com/RXTX4816/cockpit-compose/commit/c37cd1b0c5f76aa53ef5698b0f202ad8d6268c61
c37cd1bhttps://github.com/RXTX4816/cockpit-compose/commit/c37cd1b0c5f76aa53ef5698b0f202ad8d6268c61
fix(deps): bump PatternFly to 6.6.2 for the nested-modal aria-hidden …https://github.com/RXTX4816/cockpit-compose/commit/4f1e287d0bff0f3775e9d84ce437bc9857210676
4f1e287https://github.com/RXTX4816/cockpit-compose/commit/4f1e287d0bff0f3775e9d84ce437bc9857210676
Sign up for freehttps://github.com/signup?return_to=https://github.com/patternfly/patternfly-react/issues/12422
Sign in to commenthttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/12422
thatblindgeyehttps://github.com/thatblindgeye
Bughttps://github.com/patternfly/patternfly-react/issues?q=type:"Bug"
PatternFly Issueshttps://github.com/orgs/patternfly/projects/7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.