René's URL Explorer Experiment


Title: Bug - [DragDropSort / DragButton] - aria-label is not customizable and not translatable · Issue #12416 · patternfly/patternfly-react · GitHub

Open Graph Title: Bug - [DragDropSort / DragButton] - aria-label is not customizable and not translatable · Issue #12416 · patternfly/patternfly-react

X Title: Bug - [DragDropSort / DragButton] - aria-label is not customizable and not translatable · Issue #12416 · patternfly/patternfly-react

Description: Describe the problem Two issues in @patternfly/react-drag-drop: The DragButton component has a hardcoded English aria-label default of "Drag button" that cannot be customized by consumers of DragDropSort. DragButton accepts an aria-label...

Open Graph Description: Describe the problem Two issues in @patternfly/react-drag-drop: The DragButton component has a hardcoded English aria-label default of "Drag button" that cannot be customized by consumers of DragDr...

X Description: Describe the problem Two issues in @patternfly/react-drag-drop: The DragButton component has a hardcoded English aria-label default of "Drag button" that cannot be customized by consumers...

Opengraph URL: https://github.com/patternfly/patternfly-react/issues/12416

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug - [DragDropSort / DragButton] - aria-label is not customizable and not translatable","articleBody":"**Describe the problem**\n\nTwo issues in `@patternfly/react-drag-drop`:\n\n1. The `DragButton` component has a hardcoded English `aria-label` default of `\"Drag button\"` that cannot be customized by consumers of `DragDropSort`.\n\n   `DragButton` accepts an `aria-label` prop ([source](https://github.com/patternfly/patternfly-react/blob/main/packages/react-drag-drop/src/components/DragDrop/DragButton.tsx#L24)), but `Draggable` only passes dnd-kit's `{...attributes}` and `{...listeners}` to it — not consumer-provided props. And `item.props` in `DraggableObject` is spread onto the `Draggable` wrapper `\u003cdiv>`, not onto `DragButton`.\n\n   This means there is no way for consumers using `DragDropSort` to provide a translated `aria-label` for the drag handle, which is an i18n/a11y gap.\n\n2. `DragDropContainer` renders the literal text `\"0\"` as the drag overlay when a draggable item has a falsy numeric `id` (e.g. `0`).\n\n**How do you reproduce the problem?**\n\n```tsx\nimport { DragDropSort } from '@patternfly/react-drag-drop';\n\nconst items = [\n  { id: 0, content: 'First item' },\n  { id: 1, content: 'Second item' },\n];\n\n\u003cDragDropSort items={items} onDrop={(_, newItems) => setItems(newItems)} />\n```\n\n3. Inspect the rendered drag handle button — it always has `aria-label=\"Drag button\"` regardless of locale.\n\n4. Drag the first item (id `0`). The drag overlay renders the text `\"0\"` instead of the item content. This is because [`getDragOverlay`](https://github.com/patternfly/patternfly-react/blob/main/packages/react-drag-drop/src/components/DragDrop/DragDropContainer.tsx#L243) has `if (!activeId) return` which is true for `0`, and the [overlay JSX](https://github.com/patternfly/patternfly-react/blob/main/packages/react-drag-drop/src/components/DragDrop/DragDropContainer.tsx#L293) uses `activeId && getDragOverlay()` which short-circuits to `0` — React renders this as the text `\"0\"`.\n\n**Expected behavior**\n\n5. Consumers should be able to provide a custom/translated `aria-label` for the `DragButton`, either via:\n\n   - A prop on `DraggableObject` (e.g. `item.props.dragButtonAriaLabel`)\n   - Forwarding relevant props from `item.props` to `DragButton`\n\n6. Falsy numeric ids (e.g. `0`) should work correctly. The checks should use `activeId != null` instead of `!activeId` / `activeId &&`.\n\n**Is this issue blocking you?**\n\nNot blocking. Workaround for issue 1: not possible without forking the component. We currently accept the English-only label. Workaround for issue 2: use string ids.\n\n**Screenshots**\n\nN/A\n\n**What is your environment?**\n\n- `@patternfly/react-drag-drop`: 6.x (pre-release)\n\n- React 18\n\n**What is your product and what release date are you targeting?**\n\nOpenShift Console (no hard deadline for this specific issue)\n\n**Any other information?**\n\nN/A\n\n---\n\n**Jira Issue:** [PF-4132](https://redhat.atlassian.net/browse/PF-4132)","author":{"url":"https://github.com/logonoff","@type":"Person","name":"logonoff"},"datePublished":"2026-05-07T18:38:04Z","url":"https://github.com/patternfly/patternfly-react/issues/12416"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2e32003d-ca73-3db9-3d20-e1dccb4b172d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id99F4:21E3E7:BE8D28:FCF692:6B00F218
html-safe-nonce61f6206075d7305a794c726d879ddfafa2e912bb5cfb6d2f226f38c27e6fa9da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUY0OjIxRTNFNzpCRThEMjg6RkNGNjkyOjZCMDBGMjE4IiwidmlzaXRvcl9pZCI6IjI2NDAwMTU3MjAzMTgwMzg1NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1c34c9016a3e148f5f7f999e1fce091bfa09da892f766dc7e4083c51214327ae
hovercard-subject-tagissue:4401137074
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/patternfly/patternfly-react/12416/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dca724b1890da3b627ee5316d08afe3d3ad6de371a53511c8950aba6c15ce0a1/patternfly/patternfly-react/issues/12416
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dca724b1890da3b627ee5316d08afe3d3ad6de371a53511c8950aba6c15ce0a1/patternfly/patternfly-react/issues/12416
og:image:altDescribe the problem Two issues in @patternfly/react-drag-drop: The DragButton component has a hardcoded English aria-label default of "Drag button" that cannot be customized by consumers of DragDr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelogonoff
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/patternfly/patternfly-react git https://github.com/patternfly/patternfly-react.git
octolytics-dimension-user_id6391110
octolytics-dimension-user_loginpatternfly
octolytics-dimension-repository_id84372347
octolytics-dimension-repository_nwopatternfly/patternfly-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id84372347
octolytics-dimension-repository_network_root_nwopatternfly/patternfly-react
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/patternfly/patternfly-react/issues/12416#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fissues%2F12416
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpatternfly%2Fpatternfly-react%2Fissues%2F12416
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=patternfly%2Fpatternfly-react
Reloadhttps://github.com/patternfly/patternfly-react/issues/12416
Reloadhttps://github.com/patternfly/patternfly-react/issues/12416
Reloadhttps://github.com/patternfly/patternfly-react/issues/12416
patternflyhttps://github.com/patternfly
patternfly-reacthttps://github.com/patternfly/patternfly-react
Codehttps://github.com/patternfly/patternfly-react
Issues222 (222)https://github.com/patternfly/patternfly-react/issues
Pull requests36 (36)https://github.com/patternfly/patternfly-react/pulls
Discussionshttps://github.com/patternfly/patternfly-react/discussions
Actionshttps://github.com/patternfly/patternfly-react/actions
Projectshttps://github.com/patternfly/patternfly-react/projects
Wikihttps://github.com/patternfly/patternfly-react/wiki
Security and qualityhttps://github.com/patternfly/patternfly-react/security
Insightshttps://github.com/patternfly/patternfly-react/insights
https://github.com/patternfly/patternfly-react
New issuehttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/12416
New issuehttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/12416
#12417https://github.com/patternfly/patternfly-react/pull/12417
Bug - [DragDropSort / DragButton] - aria-label is not customizable and not translatablehttps://github.com/patternfly/patternfly-react/issues/12416#top
#12417https://github.com/patternfly/patternfly-react/pull/12417
https://github.com/logonoff
logonoffhttps://github.com/logonoff
on May 7, 2026https://github.com/patternfly/patternfly-react/issues/12416#issue-4401137074
sourcehttps://github.com/patternfly/patternfly-react/blob/main/packages/react-drag-drop/src/components/DragDrop/DragButton.tsx#L24
getDragOverlayhttps://github.com/patternfly/patternfly-react/blob/main/packages/react-drag-drop/src/components/DragDrop/DragDropContainer.tsx#L243
overlay JSXhttps://github.com/patternfly/patternfly-react/blob/main/packages/react-drag-drop/src/components/DragDrop/DragDropContainer.tsx#L293
PF-4132https://redhat.atlassian.net/browse/PF-4132
patternfly-buildhttps://github.com/patternfly-build
PatternFly Issueshttps://github.com/orgs/patternfly/projects/7
on May 7, 2026https://github.com/patternfly/patternfly-react/issues/12416#event-25275053631
github-project-automationhttps://github.com/apps/github-project-automation
PatternFly Issueshttps://github.com/orgs/patternfly/projects/7
on May 7, 2026https://github.com/patternfly/patternfly-react/issues/12416
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
on May 7, 2026https://github.com/patternfly/patternfly-react/issues/12416#issuecomment-4400042687
coderabbitaihttps://coderabbit.ai?utm_source=cr_app&utm_medium=github
#12140https://github.com/patternfly/patternfly-react/pull/12140
#12192https://github.com/patternfly/patternfly-react/pull/12192
#12240https://github.com/patternfly/patternfly-react/pull/12240
#12306https://github.com/patternfly/patternfly-react/pull/12306
#12388https://github.com/patternfly/patternfly-react/pull/12388
discordhttps://discord.gg/coderabbit
thatblindgeyehttps://github.com/thatblindgeye
completedhttps://github.com/patternfly/patternfly-react/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#12417https://github.com/patternfly/patternfly-react/pull/12417
on May 13, 2026https://github.com/patternfly/patternfly-react/issues/12416#event-25488240276
Sign up for freehttps://github.com/signup?return_to=https://github.com/patternfly/patternfly-react/issues/12416
Sign in to commenthttps://github.com/login?return_to=https://github.com/patternfly/patternfly-react/issues/12416
PatternFly Issueshttps://github.com/orgs/patternfly/projects/7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.