Title: Symfonize all the things! · Issue #154 · pattern-lab/patternlab-php-core · GitHub
Open Graph Title: Symfonize all the things! · Issue #154 · pattern-lab/patternlab-php-core
X Title: Symfonize all the things! · Issue #154 · pattern-lab/patternlab-php-core
Description: I'd like to propose refactoring Pattern Lab PHP to use Symfony components and best practices as much as possible. Pros: Less custom code. Pattern Lab PHP already uses several Symfony components. Code is more approachable by people who kn...
Open Graph Description: I'd like to propose refactoring Pattern Lab PHP to use Symfony components and best practices as much as possible. Pros: Less custom code. Pattern Lab PHP already uses several Symfony components. Co...
X Description: I'd like to propose refactoring Pattern Lab PHP to use Symfony components and best practices as much as possible. Pros: Less custom code. Pattern Lab PHP already uses several Symfony components...
Opengraph URL: https://github.com/pattern-lab/patternlab-php-core/issues/154
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Symfonize all the things!","articleBody":"I'd like to propose refactoring Pattern Lab PHP to use Symfony components and best practices as much as possible.\r\n\r\n**Pros:**\r\n- Less custom code.\r\n- Pattern Lab PHP already uses several Symfony components.\r\n- Code is more approachable by people who know Symfony, making it easier to contribute.\r\n- Same skills can also be used in other projects like Drupal and Drupal Console. Lots of synergy opportunities!\r\n- Current static classes cause tight coupling and are bad for unit testing.\r\n- Dependency injection and decoupling console commands from business logic could make all kinds of interesting things possible...\r\n\r\n**Cons:**\r\n- ?\r\n\r\n**Background:**\r\n\r\nThe secret plan I mentioned in #150 was to replace Pattern Lab's console code with Symfony's Console component. My experiments with that have been very positive, but I quickly realized that a full rewrite using dependency injection and separation of concerns would be really nice. Or at least something I'd be very interested in and motivated to do! :)\r\n\r\n**Implementation plan:**\r\n\r\nWe could add new Symfonized implementations of PL core code, with the old console commands using the old code and the new console commands using the new code. And when the time is right, we'd just leave out all the old code and release PL 3.0.\r\n\r\n**Tasks:**\r\n\r\n- [ ] Decouple editions from core #155 ","author":{"url":"https://github.com/aleksip","@type":"Person","name":"aleksip"},"datePublished":"2017-11-12T19:36:31Z","url":"https://github.com/pattern-lab/patternlab-php-core/issues/154"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c4ca87ee-5b91-5599-a5ba-aa5bc3bce621 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E452:2F6A82:11DF8C9:1770916:6B000C19 |
| html-safe-nonce | 7003b8af2e952c74c4d85ab066a374a2304ca371d3a9b7801bc6beb9270c3e3b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDUyOjJGNkE4MjoxMURGOEM5OjE3NzA5MTY6NkIwMDBDMTkiLCJ2aXNpdG9yX2lkIjoiNjI1NDg2Njk3NjgwODY2MzI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5a33ae11593f9a7efdbe56ca16457a866a7b4d8e6c0ce53e4dbce492d0839a25 |
| hovercard-subject-tag | issue:273258095 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/pattern-lab/patternlab-php-core/154/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8b04e7939889f6d52c13157fb251454a819f73e34ad92be4bd5c5525dccffce5/pattern-lab/patternlab-php-core/issues/154 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8b04e7939889f6d52c13157fb251454a819f73e34ad92be4bd5c5525dccffce5/pattern-lab/patternlab-php-core/issues/154 |
| og:image:alt | I'd like to propose refactoring Pattern Lab PHP to use Symfony components and best practices as much as possible. Pros: Less custom code. Pattern Lab PHP already uses several Symfony components. Co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aleksip |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/pattern-lab/patternlab-php-core git https://github.com/pattern-lab/patternlab-php-core.git |
| octolytics-dimension-user_id | 4733935 |
| octolytics-dimension-user_login | pattern-lab |
| octolytics-dimension-repository_id | 21992205 |
| octolytics-dimension-repository_nwo | pattern-lab/patternlab-php-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21992205 |
| octolytics-dimension-repository_network_root_nwo | pattern-lab/patternlab-php-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width