René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Race condition sending subscription while socket is connected, but before op=connected","articleBody":"1. Subscribe to queryA\r\n    - it is not connected yet, so it will trigger reconnect.\r\n2. Socket opens, thus state=CONNECTED\r\n    - Sends `op=connect`\r\n3. Subscribe to queryB\r\n    - SOCKET is connected (state=CONNECTED), but we haven't received op=connected yet.\r\n    - BUG: it will call sendSubscription now, because it only checks current state\r\n4. Server responds to (2) with `op=connected`\r\n5. On op=connected, we replay pending subscriptions, including the one that was already sent in (3)\r\n\r\nThat results in sending JSON over the socket in this order:\r\n\r\n1. socket CONNECT\r\n2. send op=connect\r\n3. send op=subscribe (query A)\r\n4. receive op=connected\r\n5. send op=subscribe (query A)\r\n6. send op=subscribe (query B)\r\n\r\nThat results in having 2 subscriptions for query A, and one for query B, when we should only have one of each.\r\n\r\nI have a unit test that proves this, and a fix will be forthcoming.","author":{"url":"https://github.com/jhansche","@type":"Person","name":"jhansche"},"datePublished":"2017-04-27T00:19:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/46/ParseLiveQuery-Android/issues/46"}