René's URL Explorer Experiment


Title: Fix goto_assignments config by lgeiger · Pull Request #457 · palantir/python-language-server · GitHub

Open Graph Title: Fix goto_assignments config by lgeiger · Pull Request #457 · palantir/python-language-server

X Title: Fix goto_assignments config by lgeiger · Pull Request #457 · palantir/python-language-server

Description: An implementation of the Language Server Protocol for Python - Fix goto_assignments config by lgeiger · Pull Request #457 · palantir/python-language-server

Open Graph Description: This PR explicitly retrieves jedi.goto_assignments parameters from the config. This fixes a bug introduced in #404 where the enabled config argument was passed to jedi and would fail with TypeError...

X Description: This PR explicitly retrieves jedi.goto_assignments parameters from the config. This fixes a bug introduced in #404 where the enabled config argument was passed to jedi and would fail with TypeError...

Opengraph URL: https://github.com/palantir/python-language-server/pull/457

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:64d69945-cb0c-b7ae-6fe2-b1708503458b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB9E:2E960D:5ECFF02:834371B:6A5E7AF7
html-safe-nonce19b6fed9cf6d9ffe26fa42ef68a3e513cae68efa4081d71dd21eb05f02b61cf6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjlFOjJFOTYwRDo1RUNGRjAyOjgzNDM3MUI6NkE1RTdBRjciLCJ2aXNpdG9yX2lkIjoiMjAyODAyMDE3MzgyODQyMjM5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0c7f629d819597a2392ae00209c6ff60df5938d99ea8aa59dd29fa4818e732df
hovercard-subject-tagpull_request:235362051
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/palantir/python-language-server/457/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/198c11fb6ff6265602415e7a4b6b675fa11db497679db4ce5352e35ec0a115ca/palantir/python-language-server/pull/457
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/198c11fb6ff6265602415e7a4b6b675fa11db497679db4ce5352e35ec0a115ca/palantir/python-language-server/pull/457
og:image:altThis PR explicitly retrieves jedi.goto_assignments parameters from the config. This fixes a bug introduced in #404 where the enabled config argument was passed to jedi and would fail with TypeError...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelgeiger
hostnamegithub.com
expected-hostnamegithub.com
None71950bbe6bf7e15662b868c102fed9d1682c29a05970d9b2daa2e4dd3522c52e
turbo-cache-controlno-cache
go-importgithub.com/palantir/python-language-server git https://github.com/palantir/python-language-server.git
octolytics-dimension-user_id303157
octolytics-dimension-user_loginpalantir
octolytics-dimension-repository_id78797564
octolytics-dimension-repository_nwopalantir/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id78797564
octolytics-dimension-repository_network_root_nwopalantir/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7514606601325843bc1c464d2d8bf5fe9af2c154
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/palantir/python-language-server/pull/457#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpalantir%2Fpython-language-server%2Fpull%2F457
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpalantir%2Fpython-language-server%2Fpull%2F457
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=palantir%2Fpython-language-server
Reloadhttps://github.com/palantir/python-language-server/pull/457
Reloadhttps://github.com/palantir/python-language-server/pull/457
Reloadhttps://github.com/palantir/python-language-server/pull/457
Please reload this pagehttps://github.com/palantir/python-language-server/pull/457
palantir https://github.com/palantir
python-language-serverhttps://github.com/palantir/python-language-server
Notifications https://github.com/login?return_to=%2Fpalantir%2Fpython-language-server
Fork 290 https://github.com/login?return_to=%2Fpalantir%2Fpython-language-server
Star 2.7k https://github.com/login?return_to=%2Fpalantir%2Fpython-language-server
Code https://github.com/palantir/python-language-server
Issues 160 https://github.com/palantir/python-language-server/issues
Pull requests 27 https://github.com/palantir/python-language-server/pulls
Actions https://github.com/palantir/python-language-server/actions
Security and quality 0 https://github.com/palantir/python-language-server/security
Insights https://github.com/palantir/python-language-server/pulse
Code https://github.com/palantir/python-language-server
Issues https://github.com/palantir/python-language-server/issues
Pull requests https://github.com/palantir/python-language-server/pulls
Actions https://github.com/palantir/python-language-server/actions
Security and quality https://github.com/palantir/python-language-server/security
Insights https://github.com/palantir/python-language-server/pulse
gatesnhttps://github.com/gatesn
palantir:develophttps://github.com/palantir/python-language-server/tree/develop
lgeiger:fix-pyls-definitionhttps://github.com/lgeiger/python-language-server/tree/fix-pyls-definition
Conversationhttps://github.com/palantir/python-language-server/pull/457
Commits2 (2)https://github.com/palantir/python-language-server/pull/457/commits
Checkshttps://github.com/palantir/python-language-server/pull/457/checks
Files changedhttps://github.com/palantir/python-language-server/pull/457/files
Fix goto_assignments confighttps://github.com/palantir/python-language-server/pull/457#top
gatesnhttps://github.com/gatesn
palantir:develophttps://github.com/palantir/python-language-server/tree/develop
lgeiger:fix-pyls-definitionhttps://github.com/lgeiger/python-language-server/tree/fix-pyls-definition
https://github.com/lgeiger
lgeigerhttps://github.com/lgeiger
Dec 3, 2018https://github.com/palantir/python-language-server/pull/457#issue-386706876
#404https://github.com/palantir/python-language-server/pull/404
Please reload this pagehttps://github.com/palantir/python-language-server/pull/457
lgeigerhttps://github.com/lgeiger
December 3, 2018 09:09https://github.com/palantir/python-language-server/pull/457#commits-pushed-9c60f2e
https://github.com/lgeiger
Don't pass 'enabled' argument to jedi.goto_assignmentshttps://github.com/palantir/python-language-server/pull/457/commits/9c60f2e91461dc8484bdda1eb9e0543ebe2b92e6
9c60f2ehttps://github.com/palantir/python-language-server/pull/457/commits/9c60f2e91461dc8484bdda1eb9e0543ebe2b92e6
https://github.com/lgeiger
Explicitely retrieve jedi parameters from confighttps://github.com/palantir/python-language-server/pull/457/commits/23dfe65cf58121967559f8965a3ff584b61ee42f
23dfe65https://github.com/palantir/python-language-server/pull/457/commits/23dfe65cf58121967559f8965a3ff584b61ee42f
lgeigerhttps://github.com/lgeiger
Dec 3, 2018 https://github.com/palantir/python-language-server/pull/457#ref-commit-e35cdbb
https://github.com/lgeiger
Add follow_imports config to goto-definitionhttps://github.com/atom-community/ide-python/commit/e35cdbb6af821ebe1f14c0578f9f05732025f920
e35cdbbhttps://github.com/atom-community/ide-python/commit/e35cdbb6af821ebe1f14c0578f9f05732025f920
palantir/python-language-server#457https://github.com/palantir/python-language-server/pull/457
https://github.com/lgeiger
lgeigerhttps://github.com/lgeiger
Dec 3, 2018 https://github.com/palantir/python-language-server/pull/457#ref-pullrequest-386708462
Add follow_imports config to goto-definition atom-community/ide-python#147 https://github.com/atom-community/ide-python/pull/147
https://github.com/gatesn
gatesnhttps://github.com/gatesn
Dec 3, 2018 https://github.com/palantir/python-language-server/pull/457#pullrequestreview-180675348
View reviewed changes https://github.com/palantir/python-language-server/pull/457/files/23dfe65cf58121967559f8965a3ff584b61ee42f
https://github.com/gatesn
gatesnhttps://github.com/gatesn
d7fb817https://github.com/palantir/python-language-server/commit/d7fb817e8f992bd5c6a287f5afb5e999a1e29449
Dec 3, 2018https://github.com/palantir/python-language-server/pull/457#event-2000878152
https://github.com/lgeiger
lgeigerhttps://github.com/lgeiger
December 3, 2018 09:37https://github.com/palantir/python-language-server/pull/457#event-2000885386
lgeigerhttps://github.com/lgeiger
Dec 3, 2018 https://github.com/palantir/python-language-server/pull/457#ref-commit-e03fcd7
https://github.com/lgeiger
Addhttps://github.com/atom-community/ide-python/commit/e03fcd7e1fd27f542d5e119179a21dc78485f595
follow_importshttps://github.com/atom-community/ide-python/commit/e03fcd7e1fd27f542d5e119179a21dc78485f595
config to goto-definition (https://github.com/atom-community/ide-python/commit/e03fcd7e1fd27f542d5e119179a21dc78485f595
#147https://github.com/atom-community/ide-python/pull/147
)https://github.com/atom-community/ide-python/commit/e03fcd7e1fd27f542d5e119179a21dc78485f595
e03fcd7https://github.com/atom-community/ide-python/commit/e03fcd7e1fd27f542d5e119179a21dc78485f595
palantir/python-language-server#457https://github.com/palantir/python-language-server/pull/457
https://github.com/lgeiger
lgeigerhttps://github.com/lgeiger
Dec 3, 2018 https://github.com/palantir/python-language-server/pull/457#ref-issue-383968429
Hyperclick doesn't work with python-language-server 0.21.3 atom-community/ide-python#143 https://github.com/atom-community/ide-python/issues/143
jseninhttps://github.com/jsenin
Dec 18, 2018 https://github.com/palantir/python-language-server/pull/457#ref-commit-807dee5
https://github.com/lgeiger
Fix goto_assignments config (https://github.com/jsenin/python-language-server/commit/807dee5ac675ac753b5f9ff8a79d52331b3a1093
palantir#457https://github.com/palantir/python-language-server/pull/457
)https://github.com/jsenin/python-language-server/commit/807dee5ac675ac753b5f9ff8a79d52331b3a1093
807dee5https://github.com/jsenin/python-language-server/commit/807dee5ac675ac753b5f9ff8a79d52331b3a1093
https://github.co/hiddenchars
https://github.com/palantir/python-language-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpalantir%2Fpython-language-server%2Fpull%2F457
https://github.com/gatesn
gatesn https://github.com/gatesn
https://github.com/palantir/python-language-server/pull/457/files/23dfe65cf58121967559f8965a3ff584b61ee42f
Please reload this pagehttps://github.com/palantir/python-language-server/pull/457
https://github.com/lgeiger
https://github.com/gatesn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.