Title: __str__ method is not safe · Issue #83 · oremanj/python-netfilterqueue · GitHub
Open Graph Title: __str__ method is not safe · Issue #83 · oremanj/python-netfilterqueue
X Title: __str__ method is not safe · Issue #83 · oremanj/python-netfilterqueue
Description: This code results with segmentation fault from typing import List import netfilterqueue from netfilterqueue import NetfilterQueue packet_storage: List[netfilterqueue.Packet] = [] def print_packets(): for packet in packet_storage: print(p...
Open Graph Description: This code results with segmentation fault from typing import List import netfilterqueue from netfilterqueue import NetfilterQueue packet_storage: List[netfilterqueue.Packet] = [] def print_packets(...
X Description: This code results with segmentation fault from typing import List import netfilterqueue from netfilterqueue import NetfilterQueue packet_storage: List[netfilterqueue.Packet] = [] def print_packets(...
Opengraph URL: https://github.com/oremanj/python-netfilterqueue/issues/83
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"__str__ method is not safe","articleBody":"This code results with segmentation fault\r\n\r\n```\r\nfrom typing import List\r\n\r\nimport netfilterqueue\r\nfrom netfilterqueue import NetfilterQueue\r\n\r\n\r\npacket_storage: List[netfilterqueue.Packet] = []\r\n\r\n\r\ndef print_packets():\r\n for packet in packet_storage:\r\n print(packet)\r\n\r\n\r\ndef handle_packet(packet: netfilterqueue.Packet):\r\n packet.retain()\r\n packet.accept()\r\n packet_storage.append(packet)\r\n print_packets()\r\n\r\n\r\nq = NetfilterQueue()\r\nq.bind(11, handle_packet)\r\nq.run()\r\n```\r\nLooks like __str__ method is not safe, because there is no check for NULL of `self.payload`:\r\n```\r\n def __str__(self):\r\n cdef iphdr *hdr = \u003ciphdr*\u003eself.payload\r\n protocol = PROTOCOLS.get(hdr.protocol, \"Unknown protocol\")\r\n return \"%s packet, %s bytes\" % (protocol, self.payload_len)\r\n ```\r\n\r\nIs this ok, can that be fixed? \r\n ","author":{"url":"https://github.com/elqver","@type":"Person","name":"elqver"},"datePublished":"2022-02-08T13:55:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/83/python-netfilterqueue/issues/83"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6221a2cc-db1a-4114-8c7f-910383ae0e5f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B186:22D870:15CC439:1C4CE03:69908395 |
| html-safe-nonce | f5df31863660048cc55db1c271755c7b48464d0a6cf1f5fdec22b128abe2e536 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTg2OjIyRDg3MDoxNUNDNDM5OjFDNENFMDM6Njk5MDgzOTUiLCJ2aXNpdG9yX2lkIjoiNTQzMDc2MDkwMjI5ODIwNzEyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f11e43f7892a87450044eda8910560ac5ef10e79827f9110a702f51218fb366a |
| hovercard-subject-tag | issue:1127290646 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/oremanj/python-netfilterqueue/83/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dce8ce73c2694d846f7062cd051d465affa66cbef57dbc0cc9c41995d0ec7d2c/oremanj/python-netfilterqueue/issues/83 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dce8ce73c2694d846f7062cd051d465affa66cbef57dbc0cc9c41995d0ec7d2c/oremanj/python-netfilterqueue/issues/83 |
| og:image:alt | This code results with segmentation fault from typing import List import netfilterqueue from netfilterqueue import NetfilterQueue packet_storage: List[netfilterqueue.Packet] = [] def print_packets(... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | elqver |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/oremanj/python-netfilterqueue git https://github.com/oremanj/python-netfilterqueue.git |
| octolytics-dimension-user_id | 4316136 |
| octolytics-dimension-user_login | oremanj |
| octolytics-dimension-repository_id | 1736893 |
| octolytics-dimension-repository_nwo | oremanj/python-netfilterqueue |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1736893 |
| octolytics-dimension-repository_network_root_nwo | oremanj/python-netfilterqueue |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width