René's URL Explorer Experiment

Title: test: verify Kotlin interop with a unit test and a Kotlin sample operator E2E test by exijn · Pull Request #3513 · operator-framework/java-operator-sdk · GitHub

Open Graph Title: test: verify Kotlin interop with a unit test and a Kotlin sample operator E2E test by exijn · Pull Request #3513 · operator-framework/java-operator-sdk

X Title: test: verify Kotlin interop with a unit test and a Kotlin sample operator E2E test by exijn · Pull Request #3513 · operator-framework/java-operator-sdk

Description: Closes #2967 What this does Adds Kotlin interop test coverage in two forms, per review discussion: A unit-level smoke test in operator-framework-core verifying that JOSDK behaves correctly when a DependentResource is implemented in Kotlin. A new sample module, sample-operators/kotlin-operator, with a minimalist Kotlin operator and a full dual-mode (local + remote-deployed) E2E test, mirroring the other samples. Kotlin has no concept of checked vs. unchecked exceptions, so Kotlin code can throw a plain Exception from an overridden method (e.g. DependentResource#reconcile) without declaring it — even though the Java-declared method signature doesn't include throws Exception. Before #2965, NodeExecutor only caught RuntimeException, so such an exception thrown from Kotlin would silently bypass the workflow's error handling and not trigger a retry. 1. Unit-level smoke test (operator-framework-core) The new test (KotlinCheckedExceptionDependentResourceTest.kt): Defines a Kotlin DependentResource whose reconcile throws a custom checked Exception. Runs it through the real Workflow/WorkflowReconcileExecutor/NodeExecutor (no mocked cluster needed). Asserts the exception is captured in WorkflowReconcileResult#getErroredDependents() and that throwAggregateExceptionIfErrorsPresent() throws AggregatedOperatorException, confirming a retry would be triggered. I verified this test actually exercises the fix: temporarily reverting NodeExecutor's catch (Exception e) back to catch (RuntimeException e) (the pre-#2965 behavior) makes the test fail, since the checked exception is then silently swallowed and getErroredDependents() stays empty. Adds kotlin-maven-plugin (test scope only, 2.4.10) to operator-framework-core/pom.xml, compiling sources under src/test/kotlin. No other module is affected, and no Kotlin dependency is added to the main/runtime classpath. 2. New sample: sample-operators/kotlin-operator Per review feedback, added a full sample operator implemented entirely in Kotlin (CR, spec, status, reconciler, main), to validate more than just the checked-exception path: ConfigMapCopyReconciler copies spec.message from a ConfigMapCopy custom resource into a ConfigMap, exercising custom resource deserialization via the fabric8 client and the full reconciliation runtime (not just exception handling). ConfigMapCopyE2E is a dual-mode E2E test, following the same pattern as the other samples: LocallyRunOperatorExtension for local mode, ClusterDeployedOperatorExtension (+ a real Pod deployment described in k8s/operator.yaml, built via jib-maven-plugin) for remote mode. Wired into sample-operators/pom.xml and the end-to-end-tests matrix in .github/workflows/e2e-test.yml, so it runs against a real (Minikube) cluster in CI like the other samples. Relation to #2965 #2965 fixed NodeExecutor, AbstractWorkflowExecutor, and PollingEventSource to catch Exception instead of RuntimeException (with // Exception is required because of Kotlin comments already in place), and opened #2967 as a follow-up to add tests validating this behavior with actual Kotlin code. I also grepped the codebase for any remaining catch (RuntimeException in main sources and found none left to fix. Test plan ./mvnw -pl operator-framework-core -am test — unit test passes; verified it fails against the pre-#2965 catch (RuntimeException) behavior and passes against current catch (Exception) behavior ./mvnw -pl sample-operators/kotlin-operator -am test-compile — new sample module compiles, including CRD generation from the Kotlin-annotated custom resource sample-operators/kotlin-operator E2E test against a real cluster — will be exercised by the end-to-end-tests CI job (no local cluster available to verify manually in this environment)

Open Graph Description: Closes #2967 What this does Adds Kotlin interop test coverage in two forms, per review discussion: A unit-level smoke test in operator-framework-core verifying that JOSDK behaves correctly when a ...

X Description: Closes #2967 What this does Adds Kotlin interop test coverage in two forms, per review discussion: A unit-level smoke test in operator-framework-core verifying that JOSDK behaves correctly when a ...

Opengraph URL: https://github.com/operator-framework/java-operator-sdk/pull/3513

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width