| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2591abd3-641d-dd8b-3ccc-7ab3d6462ada |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5F0:2280FE:AFE957:E99082:6A51A466 |
| html-safe-nonce | fcdf01c3a08c4f813dd1e9ffd6ab56ea2735d1dfcdb4adb21433521c5c865648 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUYwOjIyODBGRTpBRkU5NTc6RTk5MDgyOjZBNTFBNDY2IiwidmlzaXRvcl9pZCI6IjY3NTUyODM4OTEwMzkzNDc4MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b8e827824ad7ba39e00850df5538688538f34d7b8c5ab0da5e5440fa9ad58929 |
| hovercard-subject-tag | pull_request:1131745447 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/operator-framework/java-operator-sdk/1618/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4f95cb7e117b9123fddfe4e0651e2f940002be4ce3be448c30d14c909f3e726b/operator-framework/java-operator-sdk/pull/1618 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4f95cb7e117b9123fddfe4e0651e2f940002be4ce3be448c30d14c909f3e726b/operator-framework/java-operator-sdk/pull/1618 |
| og:image:alt | alternative to:
#1615
This might be a better solution since, will stop the leader elector if somebody explicitly calls stop |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | csviri |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/operator-framework/java-operator-sdk git https://github.com/operator-framework/java-operator-sdk.git |
| octolytics-dimension-user_id | 38202270 |
| octolytics-dimension-user_login | operator-framework |
| octolytics-dimension-repository_id | 188592933 |
| octolytics-dimension-repository_nwo | operator-framework/java-operator-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 188592933 |
| octolytics-dimension-repository_network_root_nwo | operator-framework/java-operator-sdk |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/operator-framework/java-operator-sdk/pull/1618#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foperator-framework%2Fjava-operator-sdk%2Fpull%2F1618 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foperator-framework%2Fjava-operator-sdk%2Fpull%2F1618 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=operator-framework%2Fjava-operator-sdk |
| Reload | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
| Reload | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
| Reload | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
| Please reload this page | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
|
operator-framework
| https://github.com/operator-framework |
| java-operator-sdk | https://github.com/operator-framework/java-operator-sdk |
|
Notifications
| https://github.com/login?return_to=%2Foperator-framework%2Fjava-operator-sdk |
|
Fork
240
| https://github.com/login?return_to=%2Foperator-framework%2Fjava-operator-sdk |
|
Star
933
| https://github.com/login?return_to=%2Foperator-framework%2Fjava-operator-sdk |
|
Code
| https://github.com/operator-framework/java-operator-sdk |
|
Issues
69
| https://github.com/operator-framework/java-operator-sdk/issues |
|
Pull requests
16
| https://github.com/operator-framework/java-operator-sdk/pulls |
|
Discussions
| https://github.com/operator-framework/java-operator-sdk/discussions |
|
Actions
| https://github.com/operator-framework/java-operator-sdk/actions |
|
Projects
| https://github.com/operator-framework/java-operator-sdk/projects |
|
Security and quality
0
| https://github.com/operator-framework/java-operator-sdk/security |
|
Insights
| https://github.com/operator-framework/java-operator-sdk/pulse |
|
Code
| https://github.com/operator-framework/java-operator-sdk |
|
Issues
| https://github.com/operator-framework/java-operator-sdk/issues |
|
Pull requests
| https://github.com/operator-framework/java-operator-sdk/pulls |
|
Discussions
| https://github.com/operator-framework/java-operator-sdk/discussions |
|
Actions
| https://github.com/operator-framework/java-operator-sdk/actions |
|
Projects
| https://github.com/operator-framework/java-operator-sdk/projects |
|
Security and quality
| https://github.com/operator-framework/java-operator-sdk/security |
|
Insights
| https://github.com/operator-framework/java-operator-sdk/pulse |
| csviri | https://github.com/csviri |
| main | https://github.com/operator-framework/java-operator-sdk/tree/main |
| leader-stop-bug-alternative | https://github.com/operator-framework/java-operator-sdk/tree/leader-stop-bug-alternative |
| Conversation | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
| Commits8 (8) | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits |
| Checks | https://github.com/operator-framework/java-operator-sdk/pull/1618/checks |
| Files changed | https://github.com/operator-framework/java-operator-sdk/pull/1618/files |
| fix: leader election stop deadlock | https://github.com/operator-framework/java-operator-sdk/pull/1618#top |
| csviri | https://github.com/csviri |
| main | https://github.com/operator-framework/java-operator-sdk/tree/main |
| leader-stop-bug-alternative | https://github.com/operator-framework/java-operator-sdk/tree/leader-stop-bug-alternative |
|
| https://github.com/csviri |
| csviri | https://github.com/csviri |
| Nov 22, 2022 | https://github.com/operator-framework/java-operator-sdk/pull/1618#issue-1459816438 |
| Please reload this page | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
| #1615 | https://github.com/operator-framework/java-operator-sdk/pull/1615 |
| Please reload this page | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
| https://github.com/csviri |
| csviri | https://github.com/csviri |
| Nov 22, 2022 | https://github.com/operator-framework/java-operator-sdk/pull/1618#event-7867583122 |
| https://github.com/csviri |
| csviri | https://github.com/csviri |
| metacosm | https://github.com/metacosm |
| November 22, 2022 12:53 | https://github.com/operator-framework/java-operator-sdk/pull/1618#event-7867590055 |
| csviri | https://github.com/csviri |
| November 23, 2022 13:11 | https://github.com/operator-framework/java-operator-sdk/pull/1618#commits-pushed-c0b043c |
|
| https://github.com/csviri |
| fix: leader election stop deadlock | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/c0b043cbe24a10b2c8927e94838eb9f393ff834a |
| c0b043c | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/c0b043cbe24a10b2c8927e94838eb9f393ff834a |
|
| https://github.com/csviri |
| cleanup | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/c68282a7f8589456ac58a33cba470f874e57cbdb |
| c68282a | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/c68282a7f8589456ac58a33cba470f874e57cbdb |
|
| https://github.com/csviri |
| fix: leader election stop deadlock | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/785422b8309bbb1fdcc61e89425ce33f0db2d488 |
| 785422b | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/785422b8309bbb1fdcc61e89425ce33f0db2d488 |
|
| https://github.com/csviri |
| format | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/c0d3e15917e569de6a4c17e89ddaaf8c3de9ee07 |
| c0d3e15 | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/c0d3e15917e569de6a4c17e89ddaaf8c3de9ee07 |
| https://github.com/csviri |
| csviri | https://github.com/csviri |
| force-pushed | https://github.com/operator-framework/java-operator-sdk/compare/ad0f91cd106bc623c486fb39a8443256a8397c1b..c0d3e15917e569de6a4c17e89ddaaf8c3de9ee07 |
| ad0f91c | https://github.com/operator-framework/java-operator-sdk/commit/ad0f91cd106bc623c486fb39a8443256a8397c1b |
| c0d3e15 | https://github.com/operator-framework/java-operator-sdk/commit/c0d3e15917e569de6a4c17e89ddaaf8c3de9ee07 |
|
Compare
| https://github.com/operator-framework/java-operator-sdk/compare/ad0f91cd106bc623c486fb39a8443256a8397c1b..c0d3e15917e569de6a4c17e89ddaaf8c3de9ee07 |
| November 23, 2022 12:11 | https://github.com/operator-framework/java-operator-sdk/pull/1618#event-7876605971 |
| csviri | https://github.com/csviri |
| November 23, 2022 13:18 | https://github.com/operator-framework/java-operator-sdk/pull/1618#commits-pushed-cf196f5 |
|
| https://github.com/csviri |
| fix issue | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/cf196f5dc94fb5302618cbc4086fb662e13564a7 |
| cf196f5 | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/cf196f5dc94fb5302618cbc4086fb662e13564a7 |
|
| https://github.com/csviri |
| format | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/6639cdd8723476d1a6b790f3b2a0e8e06f82bf0c |
| 6639cdd | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/6639cdd8723476d1a6b790f3b2a0e8e06f82bf0c |
|
| https://github.com/csviri |
| imports | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/25ba08c74fc3b5bfabd384fb09df612e8ffa3e2c |
| 25ba08c | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/25ba08c74fc3b5bfabd384fb09df612e8ffa3e2c |
|
| https://github.com/csviri |
| format | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/22e6f2dd04a6a2e9df35b7f76a6406ba1e9ee2e9 |
| 22e6f2d | https://github.com/operator-framework/java-operator-sdk/pull/1618/commits/22e6f2dd04a6a2e9df35b7f76a6406ba1e9ee2e9 |
| https://github.com/apps/sonarqubecloud |
| sonarqubecloud | https://github.com/apps/sonarqubecloud |
| Nov 23, 2022 | https://github.com/operator-framework/java-operator-sdk/pull/1618#issuecomment-1325002920 |
| https://sonarcloud.io/dashboard?id=java-operator-sdk_java-operator-sdk&pullRequest=1618 |
| https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=BUG |
| https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=BUG |
| 0 Bugs | https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=BUG |
| https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=VULNERABILITY |
| https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=VULNERABILITY |
| 0 Vulnerabilities | https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=VULNERABILITY |
| https://sonarcloud.io/project/security_hotspots?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=SECURITY_HOTSPOT |
| https://sonarcloud.io/project/security_hotspots?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=SECURITY_HOTSPOT |
| 0 Security Hotspots | https://sonarcloud.io/project/security_hotspots?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=SECURITY_HOTSPOT |
| https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=CODE_SMELL |
| https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=CODE_SMELL |
| 0 Code Smells | https://sonarcloud.io/project/issues?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&resolved=false&types=CODE_SMELL |
| https://sonarcloud.io/component_measures?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&metric=new_coverage&view=list |
| 0.0% Coverage | https://sonarcloud.io/component_measures?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&metric=new_coverage&view=list |
| https://sonarcloud.io/component_measures?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&metric=new_duplicated_lines_density&view=list |
| 0.0% Duplication | https://sonarcloud.io/component_measures?id=java-operator-sdk_java-operator-sdk&pullRequest=1618&metric=new_duplicated_lines_density&view=list |
| Please reload this page | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
| https://github.com/csviri |
| csviri | https://github.com/csviri |
| Nov 23, 2022 | https://github.com/operator-framework/java-operator-sdk/pull/1618#event-7877140510 |
|
LeaderElectionManager#stopLeading maybe deadlock with Operator#installShutdownHook
#1614
| https://github.com/operator-framework/java-operator-sdk/issues/1614 |
| https://github.com/metacosm |
| metacosm | https://github.com/metacosm |
|
Nov 23, 2022
| https://github.com/operator-framework/java-operator-sdk/pull/1618#pullrequestreview-1191999633 |
|
View reviewed changes
| https://github.com/operator-framework/java-operator-sdk/pull/1618/files/22e6f2dd04a6a2e9df35b7f76a6406ba1e9ee2e9 |
| https://github.com/csviri |
| csviri | https://github.com/csviri |
| e067f65 | https://github.com/operator-framework/java-operator-sdk/commit/e067f65bcf712efea4f94b0985bfdbd716eb2afc |
| Nov 24, 2022 | https://github.com/operator-framework/java-operator-sdk/pull/1618#event-7883391798 |
| https://github.com/csviri |
| csviri | https://github.com/csviri |
| November 24, 2022 07:54 | https://github.com/operator-framework/java-operator-sdk/pull/1618#event-7883391896 |
| https://github.com/metacosm |
| metacosm | https://github.com/metacosm |
|
May 27, 2026
| https://github.com/operator-framework/java-operator-sdk/pull/1618#ref-issue-4517052638 |
|
Operator#installShutdownHook silently skips installation when leader election is enabled
#3376
| https://github.com/operator-framework/java-operator-sdk/issues/3376 |
| https://github.com/Dennis-Mircea |
| Dennis-Mircea | https://github.com/Dennis-Mircea |
|
May 27, 2026
| https://github.com/operator-framework/java-operator-sdk/pull/1618#ref-pullrequest-4533285733 |
|
fix: shutdown hook deadlock under leader election and deprecate Operator#installShutdownHook(Duration)
#3383
| https://github.com/operator-framework/java-operator-sdk/pull/3383 |
| https://github.co/hiddenchars |
| https://github.com/operator-framework/java-operator-sdk/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foperator-framework%2Fjava-operator-sdk%2Fpull%2F1618 |
|
| https://github.com/metacosm |
|
metacosm
| https://github.com/metacosm |
|
| https://github.com/operator-framework/java-operator-sdk/pull/1618/files/22e6f2dd04a6a2e9df35b7f76a6406ba1e9ee2e9 |
|
| https://github.com/csviri |
|
csviri
| https://github.com/csviri |
|
LeaderElectionManager#stopLeading maybe deadlock with Operator#installShutdownHook
| https://github.com/operator-framework/java-operator-sdk/issues/1614 |
| Please reload this page | https://github.com/operator-framework/java-operator-sdk/pull/1618 |
|
| https://github.com/csviri |
|
| https://github.com/metacosm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |