René's URL Explorer Experiment


Title: Separate model view from view settings for more reliable reload by kkiesling · Pull Request #99 · openmc-dev/plotter · GitHub

Open Graph Title: Separate model view from view settings for more reliable reload by kkiesling · Pull Request #99 · openmc-dev/plotter

X Title: Separate model view from view settings for more reliable reload by kkiesling · Pull Request #99 · openmc-dev/plotter

Description: Native plotting GUI for model design and verification - Separate model view from view settings for more reliable reload by kkiesling · Pull Request #99 · openmc-dev/plotter

Open Graph Description: I am making this a draft because I think it needs work, but it could use another set of eyes. I think this is a bit clunky the way I have it still. The point of this change is to separate the viewe...

X Description: I am making this a draft because I think it needs work, but it could use another set of eyes. I think this is a bit clunky the way I have it still. The point of this change is to separate the viewe...

Opengraph URL: https://github.com/openmc-dev/plotter/pull/99

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8d853128-0336-c5c0-2e4d-5851ff3ab392
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAA2:E2378:6A047B9:94731B8:6A4FBF40
html-safe-nonceeeea79e9b94e663c702e6c78ccac085362b84a9728c1400dd9fa505cac6125ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUEyOkUyMzc4OjZBMDQ3Qjk6OTQ3MzFCODo2QTRGQkY0MCIsInZpc2l0b3JfaWQiOiIyOTg2Mjg3NTE5OTkyMTAyNzIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac55b8784861764db1d0d434cf09aab2cfd83859f9d6daa426f0bd66c543257535
hovercard-subject-tagpull_request:964542251
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/openmc-dev/plotter/99/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/61895d3957bca3e23f5a64837232d05845a97ed15f21744408125dfb9468a4fc/openmc-dev/plotter/pull/99
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/61895d3957bca3e23f5a64837232d05845a97ed15f21744408125dfb9468a4fc/openmc-dev/plotter/pull/99
og:image:altI am making this a draft because I think it needs work, but it could use another set of eyes. I think this is a bit clunky the way I have it still. The point of this change is to separate the viewe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekkiesling
hostnamegithub.com
expected-hostnamegithub.com
None7d8f8209b188a80e19a6957836ab9229715797be5db1a04163963c674ccc33f6
turbo-cache-controlno-cache
go-importgithub.com/openmc-dev/plotter git https://github.com/openmc-dev/plotter.git
octolytics-dimension-user_id42039615
octolytics-dimension-user_loginopenmc-dev
octolytics-dimension-repository_id176784178
octolytics-dimension-repository_nwoopenmc-dev/plotter
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id176784178
octolytics-dimension-repository_network_root_nwoopenmc-dev/plotter
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseea848e83cf3bf3613dd7b13d52965a684fd23ec5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openmc-dev/plotter/pull/99#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenmc-dev%2Fplotter%2Fpull%2F99
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenmc-dev%2Fplotter%2Fpull%2F99
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=openmc-dev%2Fplotter
Reloadhttps://github.com/openmc-dev/plotter/pull/99
Reloadhttps://github.com/openmc-dev/plotter/pull/99
Reloadhttps://github.com/openmc-dev/plotter/pull/99
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc-dev https://github.com/openmc-dev
plotterhttps://github.com/openmc-dev/plotter
Notifications https://github.com/login?return_to=%2Fopenmc-dev%2Fplotter
Fork 25 https://github.com/login?return_to=%2Fopenmc-dev%2Fplotter
Star 73 https://github.com/login?return_to=%2Fopenmc-dev%2Fplotter
Code https://github.com/openmc-dev/plotter
Issues 26 https://github.com/openmc-dev/plotter/issues
Pull requests 4 https://github.com/openmc-dev/plotter/pulls
Actions https://github.com/openmc-dev/plotter/actions
Projects https://github.com/openmc-dev/plotter/projects
Security and quality 0 https://github.com/openmc-dev/plotter/security
Insights https://github.com/openmc-dev/plotter/pulse
Code https://github.com/openmc-dev/plotter
Issues https://github.com/openmc-dev/plotter/issues
Pull requests https://github.com/openmc-dev/plotter/pulls
Actions https://github.com/openmc-dev/plotter/actions
Projects https://github.com/openmc-dev/plotter/projects
Security and quality https://github.com/openmc-dev/plotter/security
Insights https://github.com/openmc-dev/plotter/pulse
pshriwisehttps://github.com/pshriwise
openmc-dev:develophttps://github.com/openmc-dev/plotter/tree/develop
kkiesling:separate_model_viewhttps://github.com/kkiesling/plotter/tree/separate_model_view
Conversationhttps://github.com/openmc-dev/plotter/pull/99
Commits32 (32)https://github.com/openmc-dev/plotter/pull/99/commits
Checkshttps://github.com/openmc-dev/plotter/pull/99/checks
Files changedhttps://github.com/openmc-dev/plotter/pull/99/files
Separate model view from view settings for more reliable reloadhttps://github.com/openmc-dev/plotter/pull/99#top
pshriwisehttps://github.com/pshriwise
openmc-dev:develophttps://github.com/openmc-dev/plotter/tree/develop
kkiesling:separate_model_viewhttps://github.com/kkiesling/plotter/tree/separate_model_view
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 10, 2022https://github.com/openmc-dev/plotter/pull/99#issue-1268007734
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
#96https://github.com/openmc-dev/plotter/issues/96
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 10, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1003303613
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
June 10, 2022 20:41https://github.com/openmc-dev/plotter/pull/99#event-6788705986
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 10, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1003305412
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
June 16, 2022 18:09https://github.com/openmc-dev/plotter/pull/99#event-6823105624
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 16, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1157987464
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/paulromano
paulromanohttps://github.com/paulromano
Jun 21, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1014177024
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files
paulromanohttps://github.com/paulromano
https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1014177024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/main_window.pyhttps://github.com/openmc-dev/plotter/pull/99/files#diff-afa45b27414a1d5ed1cb3d2c3c4701a9d75da87929f5a1582fa163fde5075dfd
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
force-pushedhttps://github.com/openmc-dev/plotter/compare/fc74252d3c698f93ad762426272ffc141e25aad3..28ac7a177a8e2a2c08d15c61bab195aabf174009
fc74252https://github.com/openmc-dev/plotter/commit/fc74252d3c698f93ad762426272ffc141e25aad3
28ac7a1https://github.com/openmc-dev/plotter/commit/28ac7a177a8e2a2c08d15c61bab195aabf174009
Compare https://github.com/openmc-dev/plotter/compare/fc74252d3c698f93ad762426272ffc141e25aad3..28ac7a177a8e2a2c08d15c61bab195aabf174009
June 22, 2022 15:30https://github.com/openmc-dev/plotter/pull/99#event-6857564903
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 22, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1163610752
This commithttps://github.com/openmc-dev/plotter/pull/99/commits/43ddac109fd4fc2f508f83463bd1ef4a9d738923
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 23, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1164884546
@paulromanohttps://github.com/paulromano
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 23, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1017664686
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 23, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1017678963
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jun 23, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1164899133
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
July 7, 2022 12:40https://github.com/openmc-dev/plotter/pull/99#commits-pushed-e42ecd9
https://github.com/kkiesling
rough draft of only restoring view settings, not model settings - thi…https://github.com/openmc-dev/plotter/pull/99/commits/e42ecd9428ed0b1b8e41e7c4cbe69b0176c02ec4
e42ecd9https://github.com/openmc-dev/plotter/pull/99/commits/e42ecd9428ed0b1b8e41e7c4cbe69b0176c02ec4
https://github.com/kkiesling
remove commented lines and functions that are no longer neededhttps://github.com/openmc-dev/plotter/pull/99/commits/a2535996b225366941b1618db6db006cd3a5dea3
a253599https://github.com/openmc-dev/plotter/pull/99/commits/a2535996b225366941b1618db6db006cd3a5dea3
https://github.com/kkiesling
remove unnecessary importhttps://github.com/openmc-dev/plotter/pull/99/commits/0c6d89fa2569cb1d88145cc37c92fe9021305476
0c6d89fhttps://github.com/openmc-dev/plotter/pull/99/commits/0c6d89fa2569cb1d88145cc37c92fe9021305476
https://github.com/kkiesling
https://github.com/paulromano
remove missed print statementhttps://github.com/openmc-dev/plotter/pull/99/commits/7ce9e4b0a2b66af773552a7327955cf1e4d497ad
7ce9e4bhttps://github.com/openmc-dev/plotter/pull/99/commits/7ce9e4b0a2b66af773552a7327955cf1e4d497ad
https://github.com/kkiesling
more streamlined to use composition over inheritancehttps://github.com/openmc-dev/plotter/pull/99/commits/5ee873b27ab76eec28e9ef6b614465d9c5e6d25b
5ee873bhttps://github.com/openmc-dev/plotter/pull/99/commits/5ee873b27ab76eec28e9ef6b614465d9c5e6d25b
https://github.com/kkiesling
trying to asses view equality and populating idshttps://github.com/openmc-dev/plotter/pull/99/commits/1b187f79831c72c313edaa5c641affb89ba1746a
1b187f7https://github.com/openmc-dev/plotter/pull/99/commits/1b187f79831c72c313edaa5c641affb89ba1746a
https://github.com/kkiesling
trying to separate just the view parameters from the rest of view ind…https://github.com/openmc-dev/plotter/pull/99/commits/748baf8923b8801d2a419d35f734b8d39130bebf
748baf8https://github.com/openmc-dev/plotter/pull/99/commits/748baf8923b8801d2a419d35f734b8d39130bebf
https://github.com/kkiesling
separate out only the _PlotBase parameters and check thosehttps://github.com/openmc-dev/plotter/pull/99/commits/b130f620f385a03d13b4e78233129a9b91bc1665
b130f62https://github.com/openmc-dev/plotter/pull/99/commits/b130f620f385a03d13b4e78233129a9b91bc1665
https://github.com/kkiesling
only store necessary info for reload in pickle filehttps://github.com/openmc-dev/plotter/pull/99/commits/95ef00e98cff423c82339407019ec1be649ef4b4
95ef00ehttps://github.com/openmc-dev/plotter/pull/99/commits/95ef00e98cff423c82339407019ec1be649ef4b4
https://github.com/kkiesling
cleaned up docstringshttps://github.com/openmc-dev/plotter/pull/99/commits/4d371be9b5908d9289cfd9204edb269521e6d835
4d371behttps://github.com/openmc-dev/plotter/pull/99/commits/4d371be9b5908d9289cfd9204edb269521e6d835
https://github.com/kkiesling
make view params attribute on plotview to simplifyhttps://github.com/openmc-dev/plotter/pull/99/commits/e9e92a0736a7a3d69c32426ae7a2c9064970aef6
e9e92a0https://github.com/openmc-dev/plotter/pull/99/commits/e9e92a0736a7a3d69c32426ae7a2c9064970aef6
https://github.com/kkiesling
remove debugging print statementshttps://github.com/openmc-dev/plotter/pull/99/commits/3e996c9d62f3486dddc95e8d09e0660697b85df9
3e996c9https://github.com/openmc-dev/plotter/pull/99/commits/3e996c9d62f3486dddc95e8d09e0660697b85df9
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
force-pushedhttps://github.com/openmc-dev/plotter/compare/d3423729e062249af26ca02ef01d8a2a9b96e0b5..3e996c9d62f3486dddc95e8d09e0660697b85df9
d342372https://github.com/openmc-dev/plotter/commit/d3423729e062249af26ca02ef01d8a2a9b96e0b5
3e996c9https://github.com/openmc-dev/plotter/commit/3e996c9d62f3486dddc95e8d09e0660697b85df9
Compare https://github.com/openmc-dev/plotter/compare/d3423729e062249af26ca02ef01d8a2a9b96e0b5..3e996c9d62f3486dddc95e8d09e0660697b85df9
July 7, 2022 17:41https://github.com/openmc-dev/plotter/pull/99#event-6953996406
kkieslinghttps://github.com/kkiesling
July 7, 2022 13:55https://github.com/openmc-dev/plotter/pull/99#commits-pushed-eb34f8b
https://github.com/kkiesling
need to copy view params from previous viewhttps://github.com/openmc-dev/plotter/pull/99/commits/eb34f8b1d5ee5f43a2e97a33b8606f9597ccb490
eb34f8bhttps://github.com/openmc-dev/plotter/pull/99/commits/eb34f8b1d5ee5f43a2e97a33b8606f9597ccb490
https://github.com/kkiesling
updated docstrings for new classeshttps://github.com/openmc-dev/plotter/pull/99/commits/ac39180d32e98685740880dabcd013c6b5b16a63
ac39180https://github.com/openmc-dev/plotter/pull/99/commits/ac39180d32e98685740880dabcd013c6b5b16a63
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jul 7, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1178088493
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/paulromano
paulromanohttps://github.com/paulromano
Jul 7, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1032071419
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files/ac39180d32e98685740880dabcd013c6b5b16a63
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/ac39180d32e98685740880dabcd013c6b5b16a63#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/ac39180d32e98685740880dabcd013c6b5b16a63#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/ac39180d32e98685740880dabcd013c6b5b16a63#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/ac39180d32e98685740880dabcd013c6b5b16a63#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/ac39180d32e98685740880dabcd013c6b5b16a63#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
https://github.com/paulromano
Apply suggestions from code reviewhttps://github.com/openmc-dev/plotter/pull/99/commits/0ff3ed4848a2356ca1753bfd6b9fa696e13b810d
0ff3ed4https://github.com/openmc-dev/plotter/pull/99/commits/0ff3ed4848a2356ca1753bfd6b9fa696e13b810d
kkieslinghttps://github.com/kkiesling
July 8, 2022 10:13https://github.com/openmc-dev/plotter/pull/99#commits-pushed-ed014f5
https://github.com/kkiesling
issue warning and ignore plot settings if load failshttps://github.com/openmc-dev/plotter/pull/99/commits/ed014f51a1eb422d7357b306be62fec93cb71b4b
ed014f5https://github.com/openmc-dev/plotter/pull/99/commits/ed014f51a1eb422d7357b306be62fec93cb71b4b
https://github.com/kkiesling
typohttps://github.com/openmc-dev/plotter/pull/99/commits/81b41bbe2dc0a16c7ce72a9bf78f7b094e1af8b7
81b41bbhttps://github.com/openmc-dev/plotter/pull/99/commits/81b41bbe2dc0a16c7ce72a9bf78f7b094e1af8b7
https://github.com/kkiesling
remove mistaken importshttps://github.com/openmc-dev/plotter/pull/99/commits/8051d2faca90410b3942b39ebe9bc0d625f71ef3
8051d2fhttps://github.com/openmc-dev/plotter/pull/99/commits/8051d2faca90410b3942b39ebe9bc0d625f71ef3
https://github.com/kkiesling
ids_map and prop_map don't need to be privatehttps://github.com/openmc-dev/plotter/pull/99/commits/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b
3ab3f4bhttps://github.com/openmc-dev/plotter/pull/99/commits/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b
https://github.com/paulromano
paulromanohttps://github.com/paulromano
Jul 9, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1033479005
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/main_window.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-afa45b27414a1d5ed1cb3d2c3c4701a9d75da87929f5a1582fa163fde5075dfd
paulromanohttps://github.com/paulromano
Jul 9, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r917223311
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
Jul 11, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r918006576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
Jul 11, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r918141007
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/pshriwise
pshriwisehttps://github.com/pshriwise
Jul 9, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1033572905
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b
pshriwisehttps://github.com/pshriwise
https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1033572905
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@kkieslinghttps://github.com/kkiesling
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
pshriwisehttps://github.com/pshriwise
Jul 9, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r917313754
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
Jul 11, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r918084128
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
pshriwisehttps://github.com/pshriwise
Jul 9, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r917314236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
Jul 11, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r918200316
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/3ab3f4be0cdfde96dd7c1de47aefe10b86f5456b#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
pshriwisehttps://github.com/pshriwise
Jul 9, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r917315636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
Jul 11, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r918008734
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
July 11, 2022 09:26https://github.com/openmc-dev/plotter/pull/99#commits-pushed-7e3ecd3
https://github.com/kkiesling
https://github.com/paulromano
https://github.com/pshriwise
wording changeshttps://github.com/openmc-dev/plotter/pull/99/commits/7e3ecd3f21e28c7adf7858b3bb742bf5373fd766
7e3ecd3https://github.com/openmc-dev/plotter/pull/99/commits/7e3ecd3f21e28c7adf7858b3bb742bf5373fd766
https://github.com/kkiesling
https://github.com/paulromano
need to add view_params to list of attributeshttps://github.com/openmc-dev/plotter/pull/99/commits/ca2eab5759edd93ce4a1edcc472eaa4812249cf1
ca2eab5https://github.com/openmc-dev/plotter/pull/99/commits/ca2eab5759edd93ce4a1edcc472eaa4812249cf1
https://github.com/kkiesling
increment plotmodel versionhttps://github.com/openmc-dev/plotter/pull/99/commits/6ad6cde1e4070b6cde957363bb360dccb9bda28c
6ad6cdehttps://github.com/openmc-dev/plotter/pull/99/commits/6ad6cde1e4070b6cde957363bb360dccb9bda28c
https://github.com/kkiesling
simplify try/except statementhttps://github.com/openmc-dev/plotter/pull/99/commits/08a9a382a7c8e19f94cc1829921a60745d501ee1
08a9a38https://github.com/openmc-dev/plotter/pull/99/commits/08a9a382a7c8e19f94cc1829921a60745d501ee1
https://github.com/kkiesling
use_settings_pkl in docstringhttps://github.com/openmc-dev/plotter/pull/99/commits/635fbf9a86d380079574fba37c04afcbabdcafa5
635fbf9https://github.com/openmc-dev/plotter/pull/99/commits/635fbf9a86d380079574fba37c04afcbabdcafa5
https://github.com/kkiesling
store full currentView so that view_ind and view_params are both savedhttps://github.com/openmc-dev/plotter/pull/99/commits/9990c726dc966c39e393be453a2284093da9c3af
9990c72https://github.com/openmc-dev/plotter/pull/99/commits/9990c726dc966c39e393be453a2284093da9c3af
https://github.com/kkiesling
list of attribures as class attributehttps://github.com/openmc-dev/plotter/pull/99/commits/6a5f909d7fdf94173d38ce4f3fed2656de77b13a
6a5f909https://github.com/openmc-dev/plotter/pull/99/commits/6a5f909d7fdf94173d38ce4f3fed2656de77b13a
https://github.com/kkiesling
restore domain properties if file hashes are unchanged as wellhttps://github.com/openmc-dev/plotter/pull/99/commits/05743d80bf00d5f2636879909985430d31d62c89
05743d8https://github.com/openmc-dev/plotter/pull/99/commits/05743d80bf00d5f2636879909985430d31d62c89
https://github.com/kkiesling
prop_map and properties attributes were redundanthttps://github.com/openmc-dev/plotter/pull/99/commits/56e12dd9b02e575664ff68bd1bc1aef25314a987
56e12ddhttps://github.com/openmc-dev/plotter/pull/99/commits/56e12dd9b02e575664ff68bd1bc1aef25314a987
https://github.com/kkiesling
adopt_plotbase must be in PlotView to be able to set paramshttps://github.com/openmc-dev/plotter/pull/99/commits/90bf43501d864c7275100b92dac722e9f7d8bb8f
90bf435https://github.com/openmc-dev/plotter/pull/99/commits/90bf43501d864c7275100b92dac722e9f7d8bb8f
https://github.com/kkiesling
make cell_ids, instances, and mat_ids propertieshttps://github.com/openmc-dev/plotter/pull/99/commits/882540558931d9c4eab98d559eaac77e9959a925
8825405https://github.com/openmc-dev/plotter/pull/99/commits/882540558931d9c4eab98d559eaac77e9959a925
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jul 11, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1180694475
@pshriwisehttps://github.com/pshriwise
@paulromanohttps://github.com/paulromano
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
make initial view the currentview and always create a default viewhttps://github.com/openmc-dev/plotter/pull/99/commits/ebe54604a8ab0c9ca1c0f43f636b99c992ba39d0
ebe5460https://github.com/openmc-dev/plotter/pull/99/commits/ebe54604a8ab0c9ca1c0f43f636b99c992ba39d0
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jul 13, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1037909448
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files/882540558931d9c4eab98d559eaac77e9959a925
openmc_plotter/plotmodel.pyhttps://github.com/openmc-dev/plotter/pull/99/files/882540558931d9c4eab98d559eaac77e9959a925#diff-fb88459f7c5a855933ac8241cb6fa5c3da93c4be09ad74a78914f7ad20700749
kkieslinghttps://github.com/kkiesling
Jul 13, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r920461128
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pshriwisehttps://github.com/pshriwise
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
pshriwisehttps://github.com/pshriwise
Jul 13, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r920579931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
kkieslinghttps://github.com/kkiesling
Jul 14, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r921249549
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/kkiesling/plotter/blob/separate_model_view/openmc_plotter/main_window.py#L327
herehttps://github.com/kkiesling/plotter/blob/separate_model_view/openmc_plotter/main_window.py#L738
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
pshriwisehttps://github.com/pshriwise
Jul 14, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r921569896
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Model is loaded when initializing MainWindowhttps://github.com/kkiesling/plotter/blob/9ae7a7620b14625f1537b9dfc130b09097b02061/openmc_plotter/main_window.py#L58
PlotIndependent.masking is set to True for the initial current and active view.https://github.com/kkiesling/plotter/blob/9ae7a7620b14625f1537b9dfc130b09097b02061/openmc_plotter/plotmodel.py#L862
The GUI continues loading in MainWindow.loadGui and MainWindow.updateEditMenu is calledhttps://github.com/kkiesling/plotter/blob/9ae7a7620b14625f1537b9dfc130b09097b02061/openmc_plotter/main_window.py#L99
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
pshriwisehttps://github.com/pshriwise
Jul 18, 2022https://github.com/openmc-dev/plotter/pull/99#discussion_r922939678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
compare active and current views before updating current view to chec…https://github.com/openmc-dev/plotter/pull/99/commits/9ae7a7620b14625f1537b9dfc130b09097b02061
9ae7a76https://github.com/openmc-dev/plotter/pull/99/commits/9ae7a7620b14625f1537b9dfc130b09097b02061
https://github.com/kkiesling
kkieslinghttps://github.com/kkiesling
Jul 13, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1183680387
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/paulromano
paulromanohttps://github.com/paulromano
Jul 13, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1038010961
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files/9ae7a7620b14625f1537b9dfc130b09097b02061
https://github.com/paulromano
paulromanohttps://github.com/paulromano
Jul 13, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1183704934
@kkieslinghttps://github.com/kkiesling
@pshriwisehttps://github.com/pshriwise
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/pshriwise
pshriwisehttps://github.com/pshriwise
Jul 13, 2022https://github.com/openmc-dev/plotter/pull/99#issuecomment-1183769106
@kkieslinghttps://github.com/kkiesling
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/pshriwise
pshriwisehttps://github.com/pshriwise
Jul 18, 2022 https://github.com/openmc-dev/plotter/pull/99#ref-issue-1307328772
Previous view present for first-time load #101 https://github.com/openmc-dev/plotter/issues/101
https://github.com/pshriwise
pshriwisehttps://github.com/pshriwise
Jul 18, 2022 https://github.com/openmc-dev/plotter/pull/99#pullrequestreview-1041235607
View reviewed changes https://github.com/openmc-dev/plotter/pull/99/files/9ae7a7620b14625f1537b9dfc130b09097b02061
https://github.com/pshriwise
pshriwisehttps://github.com/pshriwise
4f353cchttps://github.com/openmc-dev/plotter/commit/4f353ccee8645caf04fb6c5d71cd6136183d50d5
Jul 18, 2022https://github.com/openmc-dev/plotter/pull/99#event-7008510690
https://github.co/hiddenchars
https://github.com/openmc-dev/plotter/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenmc-dev%2Fplotter%2Fpull%2F99
https://github.com/paulromano
paulromano https://github.com/paulromano
https://github.com/openmc-dev/plotter/pull/99/files/9ae7a7620b14625f1537b9dfc130b09097b02061
https://github.com/pshriwise
pshriwise https://github.com/pshriwise
https://github.com/openmc-dev/plotter/pull/99/files/9ae7a7620b14625f1537b9dfc130b09097b02061
separate model settings from view settings https://github.com/openmc-dev/plotter/issues/96
Please reload this pagehttps://github.com/openmc-dev/plotter/pull/99
https://github.com/kkiesling
https://github.com/paulromano
https://github.com/pshriwise
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.