René's URL Explorer Experiment


Title: Measure the whole type of a cast before inlining a chain onto it by abashev · Pull Request #78 · openjavaformat/open-java-format · GitHub

Open Graph Title: Measure the whole type of a cast before inlining a chain onto it by abashev · Pull Request #78 · openjavaformat/open-java-format

X Title: Measure the whole type of a cast before inlining a chain onto it by abashev · Pull Request #78 · openjavaformat/open-java-format

Description: Closes #60. The bug In sun.rmi.transport.tcp.TCPTransport the cast (PrivilegedAction) came out cut between < and String, with the lambda it applies to on a third line, while the call around it stayed on one line: static final Log tcpLog = Log.getLog( "sun.rmi.transport.tcp", "tcp", LogStream.parseLevel(AccessController.doPrivileged((PrivilegedAction< String>) () -> System.getProperty("sun.rmi.transport.tcp.logLevel")))); Why The arguments of getLog are inlined when a prefix of the last one fits, and CountWidthUntilBreakVisitor measures that prefix up to the first break inside the last level. visitTypeCast declares its level ACCEPT_INLINE_CHAIN, which means that first break is the one before the operand. The first break was the one visitParameterizedType emits after <, so the prefix ended at (PrivilegedAction<, fit, and the type then had to take that break because String>) did not fit behind it. A wildcard bound (? extends List), an intersection type (Runnable & Serializable) and an annotated type (@Nullable String) offer breaks of their own in the same place and split the same way. The fix The cast's level gets PartialInlineability.IF_FIRST_LEVEL_FITS, what visitDotWithPrefix uses for the same purpose: the visitor counts the whole first inner level, which is the rest of the type up to the break before the operand, when it fits. A chain is inlined onto a cast only if the type fits behind it. Here it does not, the chain is not inlined, and the arguments break one per line, as they do today when the type is not parameterized: static final Log tcpLog = Log.getLog( "sun.rmi.transport.tcp", "tcp", LogStream.parseLevel(AccessController.doPrivileged( (PrivilegedAction) () -> System.getProperty("sun.rmi.transport.tcp.logLevel")))); The type stays breakable for a cast that does not fit on a line at all: laying the type out without breaks, the first option in #60, gave the same result here but turned the 231-character cast of the golden C into a 254-column line, so it was dropped. Checked The golden ojf-issue-60-cast-type-in-inline-chain holds the statement above, the same cast one call shallower (which fit and does not change), and a method reference, two type arguments, a wildcard bound, a qualified name, an intersection type and an annotated type in the cast. It fails on main and passes with the change, and its output is stable on a second run. ./gradlew :open-java-format:test on JDK 21: 1545 tests, all green, the goldens C and B23749160 among them. Of the 15,747 files of the JDK 21 sources, that one statement in TCPTransport is the only one that formats differently, as #60 predicted; the 203 lambdas and 17 method references cast to a generic type elsewhere in the JDK are unchanged. Version A bug fix that changes the output of one shape, which the README allows in 2.x. The Migrate page on the website lists such fixes and should get a line for this one with the release that carries it.

Open Graph Description: Closes #60. The bug In sun.rmi.transport.tcp.TCPTransport the cast (PrivilegedAction<String>) came out cut between < and String, with the lambda it applies to on a third line, while the ca...

X Description: Closes #60. The bug In sun.rmi.transport.tcp.TCPTransport the cast (PrivilegedAction&lt;String&gt;) came out cut between &lt; and String, with the lambda it applies to on a third line, ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/78

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e12bde57-e3ee-4f75-49f1-22ecbf84945c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8580:23FBEE:5DA094:7C04DE:6AFBC680
html-safe-nonce78b2fc5d9ffa71721d3d7aa30dcb2d9886eb9a1b3d694dcc8566a20b20624f64
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTgwOjIzRkJFRTo1REEwOTQ6N0MwNERFOjZBRkJDNjgwIiwidmlzaXRvcl9pZCI6IjE4MzgyMTY2MDExMzY3NzY4MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb63018d205d504028f55574f81d19e29f682ddeea2eeb9a87d40435d30c1702f
hovercard-subject-tagpull_request:4636297715
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/78/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altCloses #60. The bug In sun.rmi.transport.tcp.TCPTransport the cast (PrivilegedAction<String>) came out cut between < and String, with the lambda it applies to on a third line, while the ca...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/78/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F78%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F78%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/78/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/78/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/78/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
cast-type-without-breakshttps://github.com/openjavaformat/open-java-format/tree/cast-type-without-breaks
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/78
Commits 2 https://github.com/openjavaformat/open-java-format/pull/78/commits
Checks 15 https://github.com/openjavaformat/open-java-format/pull/78/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/78/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/78/files
Measure the whole type of a cast before inlining a chain onto it https://github.com/openjavaformat/open-java-format/pull/78/files#top
Show all changes 2 commits https://github.com/openjavaformat/open-java-format/pull/78/files
b58f5c6 Measure the whole type of a cast before inlining a chain onto it abashev Sep 25, 2026 https://github.com/openjavaformat/open-java-format/pull/78/commits/b58f5c6865a3849b98191b971c85c65d9e9f3d38
d564203 Give the cast golden an input that has to be laid out afresh abashev Sep 25, 2026 https://github.com/openjavaformat/open-java-format/pull/78/commits/d564203602963c0a625747c454f817fcefb5565b
Clear filters https://github.com/openjavaformat/open-java-format/pull/78/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/78/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/78/files
JavaInputAstVisitor.java https://github.com/openjavaformat/open-java-format/pull/78/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
ojf-issue-60-cast-type-in-inline-chain.input https://github.com/openjavaformat/open-java-format/pull/78/files#diff-327ece9924daf373661574f82a8b1f3acb9fa69553ca8594341e98caa0e87b61
ojf-issue-60-cast-type-in-inline-chain.output https://github.com/openjavaformat/open-java-format/pull/78/files#diff-e3b4774c5cd04d1a3fd883a22300cbaafff01dae5ee623726023bea00665e4ee
open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.javahttps://github.com/openjavaformat/open-java-format/pull/78/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
View file https://github.com/openjavaformat/open-java-format/blob/d564203602963c0a625747c454f817fcefb5565b/open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/78/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/78/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
https://github.com/openjavaformat/open-java-format/pull/78/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
...ources/com/palantir/javaformat/java/testdata/ojf-issue-60-cast-type-in-inline-chain.inputhttps://github.com/openjavaformat/open-java-format/pull/78/files#diff-327ece9924daf373661574f82a8b1f3acb9fa69553ca8594341e98caa0e87b61
View file https://github.com/openjavaformat/open-java-format/blob/d564203602963c0a625747c454f817fcefb5565b/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-60-cast-type-in-inline-chain.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/78/{{ revealButtonHref }}
...urces/com/palantir/javaformat/java/testdata/ojf-issue-60-cast-type-in-inline-chain.outputhttps://github.com/openjavaformat/open-java-format/pull/78/files#diff-e3b4774c5cd04d1a3fd883a22300cbaafff01dae5ee623726023bea00665e4ee
View file https://github.com/openjavaformat/open-java-format/blob/d564203602963c0a625747c454f817fcefb5565b/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-60-cast-type-in-inline-chain.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/78/{{ revealButtonHref }}
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/78/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.