René's URL Explorer Experiment


Title: Report the column of a syntax error where javac puts it by abashev · Pull Request #72 · openjavaformat/open-java-format · GitHub

Open Graph Title: Report the column of a syntax error where javac puts it by abashev · Pull Request #72 · openjavaformat/open-java-format

X Title: Report the column of a syntax error where javac puts it by abashev · Pull Request #72 · openjavaformat/open-java-format

Description: Brings over google/google-java-format#1167, a fix from google-java-format 1.24. The bug For class Foo { void f() { g() } } the formatter reported A.java:2:6: error: ';' expected, while javac's caret for the same file stands under column 5. FormatterDiagnostic.toString added one to the column on the way out, on the assumption that it held a 0-based value; but the columns come from javac's line map and diagnostics, which are 1-based already. The comment saying otherwise dates from the time the formatter ran on ecj. From upstream, with the author kept google/google-java-format#1167 by Liam Miller-Cushon, commit authored by them: the column is printed as it is, and FormatterDiagnostic.column() is documented as 1-based, which is what it always returned, so the SPI's behaviour does not change. The eleven expectations in DiagnosticTest and MainTest move one column to the left, as upstream's did. Upstream also fixed the caret line of its "problem line as context" output, which this project does not print. Checked javac's own caret for the two inputs of DiagnosticTest stands at columns 5 and 4, the values the tests now expect. ./gradlew :open-java-format:test on JDK 21: 1497 tests, all green. Formatting is untouched: the JDK corpus check does not apply to an error message.

Open Graph Description: Brings over google/google-java-format#1167, a fix from google-java-format 1.24. The bug For class Foo { void f() { g() } } the formatter reported A.java:2:6: error: ';' expected, while jav...

X Description: Brings over google/google-java-format#1167, a fix from google-java-format 1.24. The bug For class Foo { void f() { g() } } the formatter reported A.java:2:6: error: ';' expected, w...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/72

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cf551a06-105f-460d-05b6-7f5201169e63
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB9C:3222F:6D5FF3:961A64:6AFBC7A9
html-safe-nonce87c39388f1e3607f85d065bd89f0089ff5ba9f13bede443deb2e0094e44ef396
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjlDOjMyMjJGOjZENUZGMzo5NjFBNjQ6NkFGQkM3QTkiLCJ2aXNpdG9yX2lkIjoiNDE2MTEzODg5MTQwMDM5ODc2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac868a93dd4593e3bfc5fd72636407891eff4493074ac4b51d18bfd9cbde403cb0
hovercard-subject-tagpull_request:4630552134
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/72/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altBrings over google/google-java-format#1167, a fix from google-java-format 1.24. The bug For class Foo { void f() { g() } } the formatter reported A.java:2:6: error: ';' expected, while jav...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/72/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F72%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F72%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/72/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/72/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/72/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
diagnostic-columnhttps://github.com/openjavaformat/open-java-format/tree/diagnostic-column
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/72
Commits 1 https://github.com/openjavaformat/open-java-format/pull/72/commits
Checks 15 https://github.com/openjavaformat/open-java-format/pull/72/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/72/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/72/files
Report the column of a syntax error where javac puts it https://github.com/openjavaformat/open-java-format/pull/72/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/72/files
da047d7 Report the column of a syntax error where javac puts it cushon Sep 24, 2026 https://github.com/openjavaformat/open-java-format/pull/72/commits/da047d7793b4e621e013a1f027821adb3b4b7405
Clear filters https://github.com/openjavaformat/open-java-format/pull/72/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/72/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/72/files
FormatterDiagnostic.java https://github.com/openjavaformat/open-java-format/pull/72/files#diff-9f1af53ab9d47ae7b21bc14b942cab8846f1e8bd2c090e051f0f81ef3703bf1c
DiagnosticTest.java https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
MainTest.java https://github.com/openjavaformat/open-java-format/pull/72/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
open-java-format-spi/src/main/java/com/palantir/javaformat/java/FormatterDiagnostic.javahttps://github.com/openjavaformat/open-java-format/pull/72/files#diff-9f1af53ab9d47ae7b21bc14b942cab8846f1e8bd2c090e051f0f81ef3703bf1c
View file https://github.com/openjavaformat/open-java-format/blob/da047d7793b4e621e013a1f027821adb3b4b7405/open-java-format-spi/src/main/java/com/palantir/javaformat/java/FormatterDiagnostic.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/72/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-9f1af53ab9d47ae7b21bc14b942cab8846f1e8bd2c090e051f0f81ef3703bf1c
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-9f1af53ab9d47ae7b21bc14b942cab8846f1e8bd2c090e051f0f81ef3703bf1c
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-9f1af53ab9d47ae7b21bc14b942cab8846f1e8bd2c090e051f0f81ef3703bf1c
open-java-format/src/test/java/com/palantir/javaformat/java/DiagnosticTest.javahttps://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
View file https://github.com/openjavaformat/open-java-format/blob/da047d7793b4e621e013a1f027821adb3b4b7405/open-java-format/src/test/java/com/palantir/javaformat/java/DiagnosticTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/72/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-258c4bb3e9b32c9c0985909561655feaa963c22c4f315f8fab4aee34d341adba
open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.javahttps://github.com/openjavaformat/open-java-format/pull/72/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
View file https://github.com/openjavaformat/open-java-format/blob/da047d7793b4e621e013a1f027821adb3b4b7405/open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/72/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/72/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/72/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.