René's URL Explorer Experiment


Title: Accept an annotated C-style array dimension on a parameter by abashev · Pull Request #65 · openjavaformat/open-java-format · GitHub

Open Graph Title: Accept an annotated C-style array dimension on a parameter by abashev · Pull Request #65 · openjavaformat/open-java-format

X Title: Accept an annotated C-style array dimension on a parameter by abashev · Pull Request #65 · openjavaformat/open-java-format

Description: Brings over the fix for google/google-java-format#374, commit google/google-java-format@ed40e472 from google-java-format 1.8. The bug A method parameter declared as int a @Anno [] crashed the formatter with a VerifyException from visitAnnotatedArrayType. The parameter's type was printed as a whole, dimensions included, before the name, and the annotated dimension that belongs after the name had nowhere to go. Fields and locals were fine, because their path already splits the dimensions off the type; parameters, try-with-resources and catch parameters go through visitToDeclare, which did not. From upstream, with the author kept google/google-java-format@ed40e472 by cushon (Liam Miller-Cushon), commit authored by them. visitToDeclare now extracts the dimensions the same way the other declaration paths do and hands them to declareOne, which already knew what to do with them. It comes with the null check that google/google-java-format#463 (google/google-java-format@e19b7637) added next to it: a var declaration or an untyped lambda parameter has no type tree to split. Without it, the port failed the Var golden and 83 JDK files. The upstream golden I374 comes with it, with the expected output in this project's style. Checked The golden crashes on main and passes with the change. int @A [] a @B [], var, for (var x : xs) and untyped lambda parameters still format as before. ./gradlew :open-java-format:test on JDK 21: 1501 tests, all green. The 15,747 files of the JDK 21 sources format exactly as before.

Open Graph Description: Brings over the fix for google/google-java-format#374, commit google/google-java-format@ed40e472 from google-java-format 1.8. The bug A method parameter declared as int a @Anno [] crashed the forma...

X Description: Brings over the fix for google/google-java-format#374, commit google/google-java-format@ed40e472 from google-java-format 1.8. The bug A method parameter declared as int a @Anno [] crashed the forma...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/65

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:efd2bac7-e814-d8c6-98f2-b8b59e47220b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEDE:2C9856:6EBEE:98F98:6AFBC765
html-safe-nonce5aa1fa84bf38e9547c9233029c045cf873ea0141bbd881d3c782ccba0ac2f397
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRURFOjJDOTg1Njo2RUJFRTo5OEY5ODo2QUZCQzc2NSIsInZpc2l0b3JfaWQiOiIyNTQ2OTk1MDczODA3Nzk2MDY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc7047297ffd075a3e7421418ab0905c6d1da4efccced55f598b8fe0dc24cbd2a
hovercard-subject-tagpull_request:4630383503
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/65/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altBrings over the fix for google/google-java-format#374, commit google/google-java-format@ed40e472 from google-java-format 1.8. The bug A method parameter declared as int a @Anno [] crashed the forma...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/65/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F65%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F65%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/65/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/65/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/65/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
parameter-array-dims-annotationhttps://github.com/openjavaformat/open-java-format/tree/parameter-array-dims-annotation
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/65
Commits 1 https://github.com/openjavaformat/open-java-format/pull/65/commits
Checks 15 https://github.com/openjavaformat/open-java-format/pull/65/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/65/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/65/files
Accept an annotated C-style array dimension on a parameter https://github.com/openjavaformat/open-java-format/pull/65/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/65/files
4ed1716 Accept an annotated C-style array dimension on a parameter cushon Sep 24, 2026 https://github.com/openjavaformat/open-java-format/pull/65/commits/4ed1716e03a64198f1cf23fd64bf6a4e3990aeeb
Clear filters https://github.com/openjavaformat/open-java-format/pull/65/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/65/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/65/files
JavaInputAstVisitor.java https://github.com/openjavaformat/open-java-format/pull/65/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
I374.input https://github.com/openjavaformat/open-java-format/pull/65/files#diff-8612090abe8e6c78ec1021f8a1f402022a25b4eafe7578f56ab26c22c7bcf662
I374.output https://github.com/openjavaformat/open-java-format/pull/65/files#diff-8e8b73098e4c52853c456dc0c39b42bf129e751abf3c7b91ae3ad4644ae33f3f
open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.javahttps://github.com/openjavaformat/open-java-format/pull/65/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
View file https://github.com/openjavaformat/open-java-format/blob/4ed1716e03a64198f1cf23fd64bf6a4e3990aeeb/open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/65/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/65/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
https://github.com/openjavaformat/open-java-format/pull/65/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I374.inputhttps://github.com/openjavaformat/open-java-format/pull/65/files#diff-8612090abe8e6c78ec1021f8a1f402022a25b4eafe7578f56ab26c22c7bcf662
View file https://github.com/openjavaformat/open-java-format/blob/4ed1716e03a64198f1cf23fd64bf6a4e3990aeeb/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I374.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/65/{{ revealButtonHref }}
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I374.outputhttps://github.com/openjavaformat/open-java-format/pull/65/files#diff-8e8b73098e4c52853c456dc0c39b42bf129e751abf3c7b91ae3ad4644ae33f3f
View file https://github.com/openjavaformat/open-java-format/blob/4ed1716e03a64198f1cf23fd64bf6a4e3990aeeb/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I374.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/65/{{ revealButtonHref }}
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/65/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.