René's URL Explorer Experiment


Title: Read quoted arguments from parameter files, and refuse a file that includes itself by abashev · Pull Request #49 · openjavaformat/open-java-format · GitHub

Open Graph Title: Read quoted arguments from parameter files, and refuse a file that includes itself by abashev · Pull Request #49 · openjavaformat/open-java-format

X Title: Read quoted arguments from parameter files, and refuse a file that includes itself by abashev · Pull Request #49 · openjavaformat/open-java-format

Description: Part of #40, split out of #45. Upstream report: google/google-java-format#421. From upstream, with the author kept google/google-java-format#931 by Karlheinz Friedberger (open upstream), its three commits squashed into one: an argument in an @argfile may be quoted with double or single quotes and then keeps its whitespace, so a path with a space in it is one path. Before, it became several arguments, each reported as "Skipping non-Java file", and the run still exited 0; an unclosed quote runs to the end of the file; escaped quotes are not handled, as upstream; a parameter file that includes itself is reported as "parameter file was included recursively" instead of overflowing the stack. The one change for argfiles that worked before: a path that contains a ' or " is now read as a quoted string. How it reads a file ARG_MATCHER finds one token at a time: a string in double quotes (group 1), a string in single quotes (group 2), or a run of characters without whitespace or quotes (group 3). The quotes are not part of the value. paramFilesStack holds the argfiles being read right now; a file already on it is an error, and a file included twice one after the other is still fine. The odd strings in paramsFileWithQuotesAndWhitespaces are edge cases, with +w marking an argument that contains whitespace: "'M' +w" keeps its single quotes, '"P" +w' keeps its double quotes, 'K +w is an unclosed quote at the end of a file, and "@@O +w is an escaped @ inside an unclosed quote. Checked The quoting and recursion cases from google/google-java-format#931 fail without the change. The nesting case passes either way and guards what already worked. ./gradlew :open-java-format:test on JDK 21: 1450 tests, all green. The jar formats the 15,747 files of the JDK 21 sources from one argfile, byte for byte as before. By hand: a quoted path with spaces in an argfile formats that file, and a self-including argfile prints the new error.

Open Graph Description: Part of #40, split out of #45. Upstream report: google/google-java-format#421. From upstream, with the author kept google/google-java-format#931 by Karlheinz Friedberger (open upstream), its three ...

X Description: Part of #40, split out of #45. Upstream report: google/google-java-format#421. From upstream, with the author kept google/google-java-format#931 by Karlheinz Friedberger (open upstream), its three ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/49

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2bce72b6-4269-388e-19bc-19149cef2fc6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB83E:211114:402B6A:569B87:6AFBB79C
html-safe-nonce62dcf1e020b386abea9e359d04d906f350233e17350bff3286019087e03adcf4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODNFOjIxMTExNDo0MDJCNkE6NTY5Qjg3OjZBRkJCNzlDIiwidmlzaXRvcl9pZCI6IjQ5Nzg1ODM0NjgzMzkwODMxNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9dbcab144a8b4334c1e0f6223c91250250e8e492ac71b37d0d0189096a5824c1
hovercard-subject-tagpull_request:4611615550
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/49/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altPart of #40, split out of #45. Upstream report: google/google-java-format#421. From upstream, with the author kept google/google-java-format#931 by Karlheinz Friedberger (open upstream), its three ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/49/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F49%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F49%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/49/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/49/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/49/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
argfile-quoteshttps://github.com/openjavaformat/open-java-format/tree/argfile-quotes
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/49
Commits 1 https://github.com/openjavaformat/open-java-format/pull/49/commits
Checks 14 https://github.com/openjavaformat/open-java-format/pull/49/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/49/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/49/files
Read quoted arguments from parameter files, and refuse a file that includes itself https://github.com/openjavaformat/open-java-format/pull/49/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/49/files
f5e6b12 Read quoted arguments from parameter files, and refuse a file that in… kfriedberger Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/49/commits/f5e6b12d7be9e72e654258d64d89ddf40e12fa15
Clear filters https://github.com/openjavaformat/open-java-format/pull/49/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/49/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/49/files
CommandLineOptionsParser.java https://github.com/openjavaformat/open-java-format/pull/49/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
CommandLineOptionsParserTest.java https://github.com/openjavaformat/open-java-format/pull/49/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
open-java-format/src/main/java/com/palantir/javaformat/java/CommandLineOptionsParser.javahttps://github.com/openjavaformat/open-java-format/pull/49/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
View file https://github.com/openjavaformat/open-java-format/blob/f5e6b12d7be9e72e654258d64d89ddf40e12fa15/open-java-format/src/main/java/com/palantir/javaformat/java/CommandLineOptionsParser.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/49/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
...-java-format/src/test/java/com/palantir/javaformat/java/CommandLineOptionsParserTest.javahttps://github.com/openjavaformat/open-java-format/pull/49/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
View file https://github.com/openjavaformat/open-java-format/blob/f5e6b12d7be9e72e654258d64d89ddf40e12fa15/open-java-format/src/test/java/com/palantir/javaformat/java/CommandLineOptionsParserTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/49/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
https://github.com/openjavaformat/open-java-format/pull/49/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/49/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.