René's URL Explorer Experiment


Title: Shut down the command line's thread pool when formatting is done by abashev · Pull Request #47 · openjavaformat/open-java-format · GitHub

Open Graph Title: Shut down the command line's thread pool when formatting is done by abashev · Pull Request #47 · openjavaformat/open-java-format

X Title: Shut down the command line's thread pool when formatting is done by abashev · Pull Request #47 · openjavaformat/open-java-format

Description: Part of #40, split out of #45. Upstream report: google/google-java-format#384. What changes Main.formatFiles created a fixed thread pool on every call and never shut it down. The command line did not notice, because the process exits, but a tool that runs Main in-process kept up to MAX_THREADS idle threads per call. The pool is now created in a try-with-resources. On Java 21 ExecutorService is AutoCloseable, and close() waits for the submitted tasks, which have all been waited for by then. The old body moved unchanged into an overload that takes the pool, so it is not re-indented in the diff. Checked MainTest.formatLeavesNoPoolThreadRunning runs format from a thread in a thread group of its own; the pool's threads join that group. Without the change it fails with "pool-1-thread-1 is still running". ./gradlew :open-java-format:test on JDK 21: 1448 tests, all green.

Open Graph Description: Part of #40, split out of #45. Upstream report: google/google-java-format#384. What changes Main.formatFiles created a fixed thread pool on every call and never shut it down. The command line did n...

X Description: Part of #40, split out of #45. Upstream report: google/google-java-format#384. What changes Main.formatFiles created a fixed thread pool on every call and never shut it down. The command line did n...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/47

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:03092738-a847-fcc5-7651-b321db98ef91
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA64:28E728:2BAA2E:39BFB7:6AFBB79D
html-safe-noncef4f65d58618c72f3e9bf799614ecfae9f455749411b8db53cc482894ec2f2b79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTY0OjI4RTcyODoyQkFBMkU6MzlCRkI3OjZBRkJCNzlEIiwidmlzaXRvcl9pZCI6IjgwNjc5ODQyNjkzMzIxNjY1NTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4f79fd57fff2967c04fbae9775032d6a115f246702bc8dab1e340f42da791805
hovercard-subject-tagpull_request:4611556424
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/47/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altPart of #40, split out of #45. Upstream report: google/google-java-format#384. What changes Main.formatFiles created a fixed thread pool on every call and never shut it down. The command line did n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/47/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F47%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F47%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/47/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/47/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/47/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
close-thread-poolhttps://github.com/openjavaformat/open-java-format/tree/close-thread-pool
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/47
Commits 1 https://github.com/openjavaformat/open-java-format/pull/47/commits
Checks 10 https://github.com/openjavaformat/open-java-format/pull/47/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/47/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/47/files
Shut down the command line's thread pool when formatting is done https://github.com/openjavaformat/open-java-format/pull/47/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/47/files
c10548d Shut down the command line's thread pool when formatting is done abashev Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/47/commits/c10548dd8f4830e75bf44a000defa577a006734c
Clear filters https://github.com/openjavaformat/open-java-format/pull/47/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/47/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/47/files
Main.java https://github.com/openjavaformat/open-java-format/pull/47/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
MainTest.java https://github.com/openjavaformat/open-java-format/pull/47/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
open-java-format/src/main/java/com/palantir/javaformat/java/Main.javahttps://github.com/openjavaformat/open-java-format/pull/47/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
View file https://github.com/openjavaformat/open-java-format/blob/c10548dd8f4830e75bf44a000defa577a006734c/open-java-format/src/main/java/com/palantir/javaformat/java/Main.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/47/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/47/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/47/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.javahttps://github.com/openjavaformat/open-java-format/pull/47/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
View file https://github.com/openjavaformat/open-java-format/blob/c10548dd8f4830e75bf44a000defa577a006734c/open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/47/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/47/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/47/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/47/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/47/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/47/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.