René's URL Explorer Experiment


Title: Bring over upstream #1784: run the string wrapping pass to a fixed point by abashev · Pull Request #46 · openjavaformat/open-java-format · GitHub

Open Graph Title: Bring over upstream #1784: run the string wrapping pass to a fixed point by abashev · Pull Request #46 · openjavaformat/open-java-format

X Title: Bring over upstream #1784: run the string wrapping pass to a fixed point by abashev · Pull Request #46 · openjavaformat/open-java-format

Description: Closes #34. Brings over palantir#1784, which fixes palantir#1343. From upstream, with the author kept palantir#1784 by Zayan Khan, commit authored by them, keeping upstream's Co-authored-by trailer. StringWrapper derives a text block's indentation from the layout around it, and the same pass can move that layout, so one round is not always a fixed point. wrap now repeats the pass while it keeps changing the source, up to MAX_ROUNDS = 5. Paths moved from palantir-java-format/ to open-java-format/; the changelog entry is left out. The upstream golden palantir-issue-1343-text-block-indent-stable comes with it. Added here Two goldens for text blocks that settled only on a second run: a method argument with more arguments after it (the input from google/google-java-format#805), and a text block in each branch of a ternary (the input from google/google-java-format#1378). Checked All three goldens fail without the change and pass with it. ./gradlew :open-java-format:test on JDK 21: 1429 tests, all green. JDK 21 sources, 15,747 files: one formats differently, java/lang/Module.java, with a text block argument like the first new golden. The old code moved it again on a second run; the new first run gives exactly the old second run's result and is stable. Formatting the sources takes no longer (30–34 s before, 32–33 s after, within noise). The other 429 JDK files that change on a second run still do; this pass is not what moves them. 304 of them are the blank lines that #43 fixes. The rest change elsewhere, for example string concatenations that the main formatting pass lays out again. Version The output changes only for files that were never stable: on a file that is already a fixed point, one round is the same as before. #34 asks to show that on a corpus before it ships; the numbers above are that run.

Open Graph Description: Closes #34. Brings over palantir#1784, which fixes palantir#1343. From upstream, with the author kept palantir#1784 by Zayan Khan, commit authored by them, keeping upstream's Co-authored-by tr...

X Description: Closes #34. Brings over palantir#1784, which fixes palantir#1343. From upstream, with the author kept palantir#1784 by Zayan Khan, commit authored by them, keeping upstream's Co-authored-b...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/46

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9405b33-c2d1-dc9b-29f6-d1c6ba534bc6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB152:3E5885:2C54F4:3A854D:6AFBB79B
html-safe-nonce44c2074b07e40306518f00a9c998fff182fbb60020e26c80b254734c52860fbe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTUyOjNFNTg4NToyQzU0RjQ6M0E4NTREOjZBRkJCNzlCIiwidmlzaXRvcl9pZCI6IjM0NjAzNjY4MDA0MDk4MzU0MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac339659e5949cfded46a1797ff05eef207eec85d9a2c916d1cb6681d26c9b756d
hovercard-subject-tagpull_request:4611130063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/46/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altCloses #34. Brings over palantir#1784, which fixes palantir#1343. From upstream, with the author kept palantir#1784 by Zayan Khan, commit authored by them, keeping upstream's Co-authored-by tr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/46/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F46%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F46%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/46/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/46/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/46/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
upstream-pr-1784https://github.com/openjavaformat/open-java-format/tree/upstream-pr-1784
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/46
Commits 2 https://github.com/openjavaformat/open-java-format/pull/46/commits
Checks 10 https://github.com/openjavaformat/open-java-format/pull/46/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/46/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/46/files
Bring over upstream #1784: run the string wrapping pass to a fixed point https://github.com/openjavaformat/open-java-format/pull/46/files#top
Show all changes 2 commits https://github.com/openjavaformat/open-java-format/pull/46/files
e2c90fd Run the string wrapping pass to a fixed point ZayanKhan-12 Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/46/commits/e2c90fdcf5d90834f541a1b36791747d58ce13e3
95c738a Cover two more text blocks that settled only on a second run abashev Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/46/commits/95c738acea2f1375f287dc8f7a3fb95d24a7317e
Clear filters https://github.com/openjavaformat/open-java-format/pull/46/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/46/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/46/files
StringWrapper.java https://github.com/openjavaformat/open-java-format/pull/46/files#diff-e1a3ba2697d8a173c2a21309f93db0dd44e1d34a557cb37877fdafae42b26cd6
ojf-issue-34-text-block-argument.input https://github.com/openjavaformat/open-java-format/pull/46/files#diff-57b86555d8a3351af52e68f138de15a7faedd128954c018fb07079235bf369b1
ojf-issue-34-text-block-argument.output https://github.com/openjavaformat/open-java-format/pull/46/files#diff-a46d9c4a4f3f371779aa39f9e718b6ce918bb27bd8560900112e38a3b7a6ef7a
ojf-issue-34-text-block-ternary.input https://github.com/openjavaformat/open-java-format/pull/46/files#diff-93939eba123d651ec33db995213dcaea61cf50d391353815daadf264232154c4
ojf-issue-34-text-block-ternary.output https://github.com/openjavaformat/open-java-format/pull/46/files#diff-5d18bf07deca42976dbca4a04603d7c84d4d0ea813ed51777287909756c97694
palantir-issue-1343-text-block-indent-stable.input https://github.com/openjavaformat/open-java-format/pull/46/files#diff-6497afd494c2f0efb52ddcccc530fd14df56a9394684caa7b4e4bef130cb49e9
palantir-issue-1343-text-block-indent-stable.output https://github.com/openjavaformat/open-java-format/pull/46/files#diff-63cfa1caae8890fee0959ee2cb38c245109710633015c09af41989bbcb2bcc8b
open-java-format/src/main/java/com/palantir/javaformat/java/StringWrapper.javahttps://github.com/openjavaformat/open-java-format/pull/46/files#diff-e1a3ba2697d8a173c2a21309f93db0dd44e1d34a557cb37877fdafae42b26cd6
View file https://github.com/openjavaformat/open-java-format/blob/95c738acea2f1375f287dc8f7a3fb95d24a7317e/open-java-format/src/main/java/com/palantir/javaformat/java/StringWrapper.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/46/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/46/files#diff-e1a3ba2697d8a173c2a21309f93db0dd44e1d34a557cb37877fdafae42b26cd6
https://github.com/openjavaformat/open-java-format/pull/46/files#diff-e1a3ba2697d8a173c2a21309f93db0dd44e1d34a557cb37877fdafae42b26cd6
...st/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-argument.inputhttps://github.com/openjavaformat/open-java-format/pull/46/files#diff-57b86555d8a3351af52e68f138de15a7faedd128954c018fb07079235bf369b1
View file https://github.com/openjavaformat/open-java-format/blob/95c738acea2f1375f287dc8f7a3fb95d24a7317e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-argument.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/46/{{ revealButtonHref }}
...t/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-argument.outputhttps://github.com/openjavaformat/open-java-format/pull/46/files#diff-a46d9c4a4f3f371779aa39f9e718b6ce918bb27bd8560900112e38a3b7a6ef7a
View file https://github.com/openjavaformat/open-java-format/blob/95c738acea2f1375f287dc8f7a3fb95d24a7317e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-argument.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/46/{{ revealButtonHref }}
...est/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-ternary.inputhttps://github.com/openjavaformat/open-java-format/pull/46/files#diff-93939eba123d651ec33db995213dcaea61cf50d391353815daadf264232154c4
View file https://github.com/openjavaformat/open-java-format/blob/95c738acea2f1375f287dc8f7a3fb95d24a7317e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-ternary.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/46/{{ revealButtonHref }}
...st/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-ternary.outputhttps://github.com/openjavaformat/open-java-format/pull/46/files#diff-5d18bf07deca42976dbca4a04603d7c84d4d0ea813ed51777287909756c97694
View file https://github.com/openjavaformat/open-java-format/blob/95c738acea2f1375f287dc8f7a3fb95d24a7317e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-34-text-block-ternary.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/46/{{ revealButtonHref }}
.../com/palantir/javaformat/java/testdata/palantir-issue-1343-text-block-indent-stable.inputhttps://github.com/openjavaformat/open-java-format/pull/46/files#diff-6497afd494c2f0efb52ddcccc530fd14df56a9394684caa7b4e4bef130cb49e9
View file https://github.com/openjavaformat/open-java-format/blob/95c738acea2f1375f287dc8f7a3fb95d24a7317e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/palantir-issue-1343-text-block-indent-stable.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/46/{{ revealButtonHref }}
...com/palantir/javaformat/java/testdata/palantir-issue-1343-text-block-indent-stable.outputhttps://github.com/openjavaformat/open-java-format/pull/46/files#diff-63cfa1caae8890fee0959ee2cb38c245109710633015c09af41989bbcb2bcc8b
View file https://github.com/openjavaformat/open-java-format/blob/95c738acea2f1375f287dc8f7a3fb95d24a7317e/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/palantir-issue-1343-text-block-indent-stable.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/46/{{ revealButtonHref }}
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/46/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.