René's URL Explorer Experiment


Title: Command line: quoted argfile paths, a closed thread pool, and the right flag in the --dry-run error by abashev · Pull Request #45 · openjavaformat/open-java-format · GitHub

Open Graph Title: Command line: quoted argfile paths, a closed thread pool, and the right flag in the --dry-run error by abashev · Pull Request #45 · openjavaformat/open-java-format

X Title: Command line: quoted argfile paths, a closed thread pool, and the right flag in the --dry-run error by abashev · Pull Request #45 · openjavaformat/open-java-format

Description: Closes #40. Upstream reports: google/google-java-format#421, google/google-java-format#384, google/google-java-format#1094. Three command-line fixes, one commit each. Two are ported from open upstream PRs and keep their authors. From upstream, with the authors kept google/google-java-format#931 by Karlheinz Friedberger, its three commits squashed into one. An argument in an @argfile may be quoted with double or single quotes and then keeps its whitespace, so a path with a space in it is one path. Before, it became several arguments, each "Skipping non-Java file", and the run exited 0. A parameter file that includes itself is now reported as "parameter file was included recursively" instead of overflowing the stack. Escaped quotes are not handled, as upstream. google/google-java-format#1451 by rootkiller6788. The error for --dry-run with in-place formatting names --replace; before, it named --in-place, which does not exist. Added here The thread pool is closed when Main.formatFiles returns. The command line did not notice the leak, because it exits, but a tool that runs Main in-process kept up to MAX_THREADS idle threads per call. On Java 21 ExecutorService is AutoCloseable, and close() waits for the submitted tasks, which have all been waited for by then. Checked Test first for each part: the quoting and recursion cases from palantir#931 fail without the parser change (the nesting case passes either way and guards what already worked); MainTest.formatLeavesNoPoolThreadRunning fails with "pool-1-thread-1 is still running"; CommandLineFlagsTest.inPlaceDryRun fails on the old message. ./gradlew :open-java-format:test on JDK 21: 1421 tests, all green. The jar formats the 15,747 files of the JDK 21 sources from one argfile, byte for byte as before. By hand: a quoted path with spaces in an argfile formats that file, a self-including argfile prints the new error, and --dry-run --replace names --replace.

Open Graph Description: Closes #40. Upstream reports: google/google-java-format#421, google/google-java-format#384, google/google-java-format#1094. Three command-line fixes, one commit each. Two are ported from open upstr...

X Description: Closes #40. Upstream reports: google/google-java-format#421, google/google-java-format#384, google/google-java-format#1094. Three command-line fixes, one commit each. Two are ported from open upstr...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/45

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:53836f39-857d-6e82-d17f-b18275cd44ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA12:337AE8:170718:1E993A:6AFBB1EA
html-safe-nonce7e880734637c46c8284d58158d698ab814406710c38649c0e9ae78d5167b92ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTEyOjMzN0FFODoxNzA3MTg6MUU5OTNBOjZBRkJCMUVBIiwidmlzaXRvcl9pZCI6IjUyMjgzNDAxNTAyMjM0ODMzNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7e7b2b1130bdc771318819cc8c76b4e031b88d51c76bcf9960886b4f699875e5
hovercard-subject-tagpull_request:4611072615
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/45/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altCloses #40. Upstream reports: google/google-java-format#421, google/google-java-format#384, google/google-java-format#1094. Three command-line fixes, one commit each. Two are ported from open upstr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/45/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F45%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F45%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/45/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/45/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/45/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
cli-argfile-pool-dry-runhttps://github.com/openjavaformat/open-java-format/tree/cli-argfile-pool-dry-run
Conversation 2 https://github.com/openjavaformat/open-java-format/pull/45
Commits 3 https://github.com/openjavaformat/open-java-format/pull/45/commits
Checks 10 https://github.com/openjavaformat/open-java-format/pull/45/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/45/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/45/files
Command line: quoted argfile paths, a closed thread pool, and the right flag in the --dry-run error https://github.com/openjavaformat/open-java-format/pull/45/files#top
Show all changes 3 commits https://github.com/openjavaformat/open-java-format/pull/45/files
e9fcd01 Read quoted arguments from parameter files, and refuse a file that in… kfriedberger Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/45/commits/e9fcd0145e05a100cae41f50fb5362f5410181d4
cee2533 Shut down the command line's thread pool when formatting is done abashev Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/45/commits/cee25339477d5ef96d813c6487617c5070a35def
fe8966d Name --replace in the error for --dry-run with in-place formatting rootkiller6788 Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/45/commits/fe8966da6c878bf4bbb2ddf583b22654f3a2fe4e
Clear filters https://github.com/openjavaformat/open-java-format/pull/45/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/45/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/45/files
CommandLineOptionsParser.java https://github.com/openjavaformat/open-java-format/pull/45/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
Main.java https://github.com/openjavaformat/open-java-format/pull/45/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
CommandLineFlagsTest.java https://github.com/openjavaformat/open-java-format/pull/45/files#diff-e8fb02df71242d649bc630cef8a13360dfa0228abc22224729d6120a464d42f4
CommandLineOptionsParserTest.java https://github.com/openjavaformat/open-java-format/pull/45/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
MainTest.java https://github.com/openjavaformat/open-java-format/pull/45/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
open-java-format/src/main/java/com/palantir/javaformat/java/CommandLineOptionsParser.javahttps://github.com/openjavaformat/open-java-format/pull/45/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
View file https://github.com/openjavaformat/open-java-format/blob/fe8966da6c878bf4bbb2ddf583b22654f3a2fe4e/open-java-format/src/main/java/com/palantir/javaformat/java/CommandLineOptionsParser.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/45/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-c3171a74d6665751289846dcdbb92ae52c91172f36657c5a9e56bf67617643e0
open-java-format/src/main/java/com/palantir/javaformat/java/Main.javahttps://github.com/openjavaformat/open-java-format/pull/45/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
View file https://github.com/openjavaformat/open-java-format/blob/fe8966da6c878bf4bbb2ddf583b22654f3a2fe4e/open-java-format/src/main/java/com/palantir/javaformat/java/Main.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/45/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
open-java-format/src/test/java/com/palantir/javaformat/java/CommandLineFlagsTest.javahttps://github.com/openjavaformat/open-java-format/pull/45/files#diff-e8fb02df71242d649bc630cef8a13360dfa0228abc22224729d6120a464d42f4
View file https://github.com/openjavaformat/open-java-format/blob/fe8966da6c878bf4bbb2ddf583b22654f3a2fe4e/open-java-format/src/test/java/com/palantir/javaformat/java/CommandLineFlagsTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/45/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-e8fb02df71242d649bc630cef8a13360dfa0228abc22224729d6120a464d42f4
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-e8fb02df71242d649bc630cef8a13360dfa0228abc22224729d6120a464d42f4
...-java-format/src/test/java/com/palantir/javaformat/java/CommandLineOptionsParserTest.javahttps://github.com/openjavaformat/open-java-format/pull/45/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
View file https://github.com/openjavaformat/open-java-format/blob/fe8966da6c878bf4bbb2ddf583b22654f3a2fe4e/open-java-format/src/test/java/com/palantir/javaformat/java/CommandLineOptionsParserTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/45/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-a0c22db1dbb3ea20283dd2378696c61c8ede445220d24c7d723dda58a5025161
open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.javahttps://github.com/openjavaformat/open-java-format/pull/45/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
View file https://github.com/openjavaformat/open-java-format/blob/fe8966da6c878bf4bbb2ddf583b22654f3a2fe4e/open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/45/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/45/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/45/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.